From: Mira Limbeck <m.limbeck@proxmox.com>
Date: Mon, 26 Aug 2019 12:55:25 +0000 (+0200)
Subject: fix use of uninitialized value
X-Git-Url: https://git.proxmox.com/?p=pve-firewall.git;a=commitdiff_plain;h=13d39f198ad142a013077f4b3cc436257f7a1a11

fix use of uninitialized value

$param->{rename} was not checked for definedness even though it is
optional. This lead to a 'use of uninitialized value' when just updating
the cidr.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
---

diff --git a/src/PVE/API2/Firewall/Aliases.pm b/src/PVE/API2/Firewall/Aliases.pm
index 6f421fb..b81dc9d 100644
--- a/src/PVE/API2/Firewall/Aliases.pm
+++ b/src/PVE/API2/Firewall/Aliases.pm
@@ -230,7 +230,8 @@ sub register_update_alias {
 
 	    $aliases->{$name} = $data;
 
-	    my $rename = lc($param->{rename});
+	    my $rename = $param->{rename};
+	    $rename = lc($rename) if $rename;
 
 	    if ($rename && ($name ne $rename)) {
 		raise_param_exc({ name => "alias '$param->{rename}' already exists" })