From: Alwin Antreich <a.antreich@proxmox.com>
Date: Wed, 13 Feb 2019 11:27:58 +0000 (+0100)
Subject: Fix unitialized value $mark in bitwise operation
X-Git-Url: https://git.proxmox.com/?p=pve-firewall.git;a=commitdiff_plain;h=45c8eeb8bdb814d2bc9cf644de28f9f022799813

Fix unitialized value $mark in bitwise operation

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
---

diff --git a/src/PVE/FirewallSimulator.pm b/src/PVE/FirewallSimulator.pm
index b01e45b..188c38f 100644
--- a/src/PVE/FirewallSimulator.pm
+++ b/src/PVE/FirewallSimulator.pm
@@ -21,7 +21,7 @@ eval {
     $have_lxc = 1;
 };
 
-my $mark;
+my $mark = 0;
 my $trace;
 my $debug = 0;
 
@@ -227,7 +227,7 @@ sub rule_match {
 
 	if ($rule =~ s@^-m mark --mark ($NUMBER_RE)(?:/($NUMBER_RE))?\s*@@) {
 	    my ($value, $mask) = PVE::Firewall::get_mark_values($1, $2);
-	    return undef if !defined($mark) || ($mark & $mask) != $value;
+	    return undef if ($mark & $mask) != $value;
 	    next;
 	}