From: Dietmar Maurer <dietmar@proxmox.com>
Date: Tue, 4 Mar 2014 08:27:26 +0000 (+0100)
Subject: use PVE::ProcFSTools::write_proc_entry instead of system("echo ...")
X-Git-Url: https://git.proxmox.com/?p=pve-firewall.git;a=commitdiff_plain;h=5f0a912c4f27d3ebd743920a029c7f6cad2fdd64

use PVE::ProcFSTools::write_proc_entry instead of system("echo ...")
---

diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index 5e73d2b..3a4f2f4 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -4,6 +4,7 @@ use warnings;
 use strict;
 use Data::Dumper;
 use Digest::SHA;
+use PVE::ProcFSTools;
 use PVE::Tools;
 use PVE::QemuServer;
 use File::Basename;
@@ -623,8 +624,8 @@ sub enable_bridge_firewall {
 
     return if $bridge_firewall_enabled; # only once
 
-    system("echo 1 > /proc/sys/net/bridge/bridge-nf-call-iptables");
-    system("echo 1 > /proc/sys/net/bridge/bridge-nf-call-ip6tables");
+    PVE::ProcFSTools::write_proc_entry("/proc/sys/net/bridge/bridge-nf-call-iptables", "1");
+    PVE::ProcFSTools::write_proc_entry("/proc/sys/net/bridge/bridge-nf-call-ip6tables", "1");
 
     $bridge_firewall_enabled = 1;
 }