From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Mon, 4 May 2020 12:13:02 +0000 (+0200)
Subject: icmp: allow to specify the echo-reply (0) type as integer
X-Git-Url: https://git.proxmox.com/?p=pve-firewall.git;a=commitdiff_plain;h=88614d7216ea46d765d8d157cdc14648f7b5b45b

icmp: allow to specify the echo-reply (0) type as integer

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index 28dbb19..a6157e3 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -2039,7 +2039,7 @@ sub ipt_rule_to_cmds {
 	    my $multisport = defined($rule->{sport}) && parse_port_name_number_or_range($rule->{sport}, 0);
 
 	    my $add_dport = sub {
-		return if !$rule->{dport};
+		return if !defined($rule->{dport});
 
 		if ($proto eq 'icmp') {
 		    # Note: we use dport to store --icmp-type
@@ -2062,6 +2062,7 @@ sub ipt_rule_to_cmds {
 		} elsif ($multidport) {
 		    push @match, "--match multiport", "--dports $rule->{dport}";
 		} else {
+		    return if !$rule->{dport};
 		    push @match, "--dport $rule->{dport}";
 		}
 	    };