From: Dietmar Maurer <dietmar@proxmox.com>
Date: Thu, 27 Feb 2014 11:54:11 +0000 (+0100)
Subject: use defined() to check fot undefined value
X-Git-Url: https://git.proxmox.com/?p=pve-firewall.git;a=commitdiff_plain;h=a104121732bddbd34a5870f4ad255be5fa5c0a49

use defined() to check fot undefined value
---

diff --git a/PVE/Firewall.pm b/PVE/Firewall.pm
index fde72fd..43b42a2 100644
--- a/PVE/Firewall.pm
+++ b/PVE/Firewall.pm
@@ -736,7 +736,7 @@ sub ruleset_generate_rule {
     if ($rule->{dport}) {
 	if ($rule->{proto} && $rule->{proto} eq 'icmp') {
 	    # Note: we use dport to store --icmp-type
-	    die "unknown icmp-type '$rule->{dport}'\n" if !$icmp_type_names->{$rule->{dport}};
+	    die "unknown icmp-type '$rule->{dport}'\n" if !defined($icmp_type_names->{$rule->{dport}});
 	    $cmd .= " -m icmp --icmp-type $rule->{dport}";
 	} else {
 	    if ($rule->{nbdport} && $rule->{nbdport} > 1) {