From: Dietmar Maurer <dietmar@proxmox.com>
Date: Thu, 3 Apr 2014 07:33:20 +0000 (+0200)
Subject: simplify check for iprange
X-Git-Url: https://git.proxmox.com/?p=pve-firewall.git;a=commitdiff_plain;h=ac8242cc956f3fd0e53ddd941ba5a3edf45bae33;ds=sidebyside

simplify check for iprange

We already parsed the address, so we can do a simpler check.
---

diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index 83a9921..226d1fc 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -952,7 +952,7 @@ sub ruleset_generate_cmdstr {
 	    die "no such ipset $2" if !$cluster_conf->{ipset}->{$2};
 	    push @cmd, "-m set --match-set PVEFW-$2 src";
 
-        } elsif ($source =~ m/^(\d+)\.(\d+).(\d+).(\d+)\-(\d+)\.(\d+).(\d+).(\d+)$/){
+        } elsif ($source =~ m/\-/){
 	    push @cmd, "-m iprange --src-range $source";
 
 	} else {