From: Dietmar Maurer <dietmar@proxmox.com>
Date: Tue, 15 Apr 2014 07:04:42 +0000 (+0200)
Subject: do not set persistent state if firewall is disabled
X-Git-Url: https://git.proxmox.com/?p=pve-firewall.git;a=commitdiff_plain;h=b22130d3fd198a3d5ad9113f87c4ae3cf68c0303

do not set persistent state if firewall is disabled

Else we have to manually restart the service after enable is set.
---

diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index ba0ddae..d5d4950 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -2882,11 +2882,7 @@ sub update {
 	die "Firewall is disabled - cannot start\n" if !$enable && $start;
 
 	if (!$enable) {
-	    if ($status ne 'stopped') {
-		print "trying to stop firewall (firewall is disabled)\n" if $verbose;
-		PVE::Firewall::remove_pvefw_chains();
-		PVE::Firewall::save_pvefw_status('stopped');
-	    }
+	    PVE::Firewall::remove_pvefw_chains();
 	    print "Firewall disabled\n" if $verbose;
 	    return;
 	}