From 45c8eeb8bdb814d2bc9cf644de28f9f022799813 Mon Sep 17 00:00:00 2001 From: Alwin Antreich Date: Wed, 13 Feb 2019 12:27:58 +0100 Subject: [PATCH] Fix unitialized value $mark in bitwise operation Signed-off-by: Alwin Antreich --- src/PVE/FirewallSimulator.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/FirewallSimulator.pm b/src/PVE/FirewallSimulator.pm index b01e45b..188c38f 100644 --- a/src/PVE/FirewallSimulator.pm +++ b/src/PVE/FirewallSimulator.pm @@ -21,7 +21,7 @@ eval { $have_lxc = 1; }; -my $mark; +my $mark = 0; my $trace; my $debug = 0; @@ -227,7 +227,7 @@ sub rule_match { if ($rule =~ s@^-m mark --mark ($NUMBER_RE)(?:/($NUMBER_RE))?\s*@@) { my ($value, $mask) = PVE::Firewall::get_mark_values($1, $2); - return undef if !defined($mark) || ($mark & $mask) != $value; + return undef if ($mark & $mask) != $value; next; } -- 2.39.2