From 006490cb2f0e6eed699f1f451e5beaf6b78ef52f Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Thu, 30 Oct 2014 13:35:55 +0100 Subject: [PATCH] $ipversion is interger, so use '!=' instead of string 'ne' --- src/PVE/Firewall.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 5c810f2..e99019e 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -816,7 +816,7 @@ sub parse_address_list { my $new_ipversion = Net::IP::ip_is_ipv6($ip->ip()) ? 6 : 4; die "detected mixed ipv4/ipv6 addresses in address list '$str'\n" - if defined($ipversion) && ($new_ipversion != $ipversion); + if $ipversion && ($new_ipversion != $ipversion); $ipversion = $new_ipversion; } @@ -1750,7 +1750,7 @@ sub ruleset_generate_vm_rules { foreach my $rule (@$rules) { next if $rule->{iface} && $rule->{iface} ne $netid; next if !$rule->{enable} || $rule->{errors}; - next if $rule->{ipversion} && $rule->{ipversion} ne $ipversion; + next if $rule->{ipversion} && ($rule->{ipversion} != $ipversion); if ($rule->{type} eq 'group') { ruleset_add_group_rule($ruleset, $cluster_conf, $chain, $rule, $direction, -- 2.39.2