From 5b1df9a0feb51097265cdd2baf5dffbd890d2a81 Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Tue, 4 Mar 2014 12:23:19 +0100 Subject: [PATCH 1/1] correctly init PVEFW-FORWARD chain We generate that chain by default, so the old code never triggered. --- src/PVE/Firewall.pm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index e0e7a67..51eaac6 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -823,11 +823,6 @@ sub ruleset_insertrule { sub generate_bridge_chains { my ($ruleset, $bridge) = @_; - if (!ruleset_chain_exist($ruleset, "PVEFW-FORWARD")){ - ruleset_create_chain($ruleset, "PVEFW-FORWARD"); - ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT"); - } - if (!ruleset_chain_exist($ruleset, "$bridge-FW")) { ruleset_create_chain($ruleset, "$bridge-FW"); ruleset_addrule($ruleset, "PVEFW-FORWARD", "-o $bridge -m physdev --physdev-is-bridged -j $bridge-FW"); @@ -1517,7 +1512,9 @@ sub compile { ruleset_create_chain($ruleset, "PVEFW-INPUT"); ruleset_create_chain($ruleset, "PVEFW-OUTPUT"); + ruleset_create_chain($ruleset, "PVEFW-FORWARD"); + ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT"); my $hostfw_options = {}; my $hostfw_conf; -- 2.39.2