From 6d2ab0175d9603e3ea8eb2a236a4e520d41703ca Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Wed, 5 Mar 2014 07:36:25 +0100 Subject: [PATCH] cleanup - avoid warning about undefined value --- src/PVE/Firewall.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 6434592..0e59a09 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -823,7 +823,7 @@ sub ruleset_insertrule { sub generate_bridge_chains { my ($ruleset, $hostfw_conf, $bridge) = @_; - my $options = $hostfw_conf->{options}; + my $options = $hostfw_conf->{options} || {}; # fixme: what log level should we use here? my $loglevel = get_option_log_level($options, "log_level_out"); @@ -1527,7 +1527,7 @@ sub compile { ruleset_addrule($ruleset, "PVEFW-FORWARD", "-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT"); my $hostfw_options = {}; - my $hostfw_conf; + my $hostfw_conf = {}; $filename = "/etc/pve/local/host.fw"; if (my $fh = IO::File->new($filename, O_RDONLY)) { @@ -1537,8 +1537,7 @@ sub compile { generate_std_chains($ruleset, $hostfw_options); - my $hostfw_enable = $hostfw_conf && - !(defined($hostfw_options->{enable}) && ($hostfw_options->{enable} == 0)); + my $hostfw_enable = !(defined($hostfw_options->{enable}) && ($hostfw_options->{enable} == 0)); enable_host_firewall($ruleset, $hostfw_conf, $groups_conf) if $hostfw_enable; -- 2.39.2