From 6e299ae385402df8019ecf34db56f05a0e9ffeae Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Mon, 7 Apr 2014 11:02:14 +0200 Subject: [PATCH 1/1] ipset: only save ip/network once We do not allow duplicate entries. --- src/PVE/Firewall.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 74bd8d9..5168093 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -2143,7 +2143,13 @@ my $format_ipset = sub { my $raw = ''; + my $nethash = {}; foreach my $entry (@$options) { + $nethash->{$entry->{cidr}} = $entry; + } + + foreach my $cidr (sort keys %$nethash) { + my $entry = $nethash->{$cidr}; my $line = $entry->{nomatch} ? '!' : ''; $line .= $entry->{cidr}; $line .= " # " . encode('utf8', $entry->{comment}) -- 2.39.2