From 78db58727163aec5fa554ed085be495ae9e744d4 Mon Sep 17 00:00:00 2001
From: Dietmar Maurer <dietmar@proxmox.com>
Date: Thu, 9 Aug 2012 11:19:49 +0200
Subject: [PATCH] add comments to generated rules file

---
 PVE/Firewall.pm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/PVE/Firewall.pm b/PVE/Firewall.pm
index c9f502a..b0cf92d 100644
--- a/PVE/Firewall.pm
+++ b/PVE/Firewall.pm
@@ -229,7 +229,11 @@ sub compile {
 
     $out = sprintf($rule_format, '#ACTION', 'SOURCE', 'DEST', 'PROTO', 'DPORT', 'SPORT');
     foreach my $vmid (sort keys %$rules) {
-	if (my $inrules = $rules->{$vmid}->{in}) {
+	my $inrules = $rules->{$vmid}->{in};
+	my $outrules = $rules->{$vmid}->{out};
+
+	if (scalar(@$inrules)) {
+	    $out .= "# IN to VM $vmid\n";
 	    foreach my $rule (@$inrules) {
 		foreach my $netid (keys %{$netinfo->{$vmid}}) {
 		    my $net = $netinfo->{$vmid}->{$netid};
@@ -239,7 +243,8 @@ sub compile {
 	    }
 	}
 
-	if (my $outrules = $rules->{$vmid}->{out}) {
+	if (scalar(@$outrules)) {
+	    $out .= "# OUT from VM $vmid\n";
 	    foreach my $rule (@$outrules) {
 		foreach my $netid (keys %{$netinfo->{$vmid}}) {
 		    my $net = $netinfo->{$vmid}->{$netid};
-- 
2.39.2