From 51088c75f2e794e33924c665a79fe486a021ca40 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Fri, 18 Oct 2019 17:15:46 +0200 Subject: [PATCH] refactor print_pending_delete slightly while this was much better than the old mess from parse_pending_delete it still was a bit much nested into one line. split that up a bit, add a render_key helper which does the clunky "add !" check and just call that one in the map {} Signed-off-by: Thomas Lamprecht --- PVE/AbstractConfig.pm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm index 16ba427..055bd74 100644 --- a/PVE/AbstractConfig.pm +++ b/PVE/AbstractConfig.pm @@ -92,7 +92,14 @@ sub parse_pending_delete { sub print_pending_delete { my ($class, $delete_hash) = @_; - join ",", map { ( $delete_hash->{$_}->{force} ? '!' : '' ) . $_ } keys %$delete_hash; + + my $render_key = sub { + my $key = shift; + $key = "!$key" if $delete_hash->{$key}->{force}; + return $key; + }; + + join (',', map { $render_key->($_) } keys %$delete_hash); } sub add_to_pending_delete { -- 2.39.2