ui: firewall: refactor privilege checks and prevent double click

[pve-manager.git] / www / manager6 / grid / FirewallAliases.js

diff --git a/www/manager6/grid/FirewallAliases.js b/www/manager6/grid/FirewallAliases.js
index b6f07334801b4338793c8131aeff0e33bfbaef2b..0fb6962eba4dde4150c94082ee59d06e92e736d7 100644 (file)
--- a/www/manager6/grid/FirewallAliases.js
+++ b/www/manager6/grid/FirewallAliases.js
@@ -105,6 +105,7 @@ Ext.define('PVE.FirewallAliases', {
        let sm = Ext.create('Ext.selection.RowModel', {});
 
        let caps = Ext.state.Manager.get('GuiCap');
+       let canEdit = !!caps.vms['VM.Config.Network'] || !!caps.dc['Sys.Modify'] || !!caps.nodes['Sys.Modify'];
 
        let reload = function() {
            let oldrec = sm.getSelection()[0];
@@ -120,7 +121,7 @@ Ext.define('PVE.FirewallAliases', {
 
        let run_editor = function() {
            let rec = me.getSelectionModel().getSelection()[0];
-           if (!rec) {
+           if (!rec || !canEdit) {
                return;
            }
            let win = Ext.create('PVE.FirewallAliasEdit', {
@@ -135,7 +136,7 @@ Ext.define('PVE.FirewallAliases', {
            text: gettext('Edit'),
            disabled: true,
            selModel: sm,
-           enableFn: rec => !!caps.vms['VM.Config.Network'] || !!caps.dc['Sys.Modify'] || !!caps.nodes['Sys.Modify'],
+           enableFn: rec => canEdit,
            handler: run_editor,
        });