From: Dominik Csapak <d.csapak@proxmox.com>
Date: Tue, 28 Feb 2017 11:06:45 +0000 (+0100)
Subject: use login instead of bash
X-Git-Url: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff_plain;h=e890b92d671b3b38ae06c32e7b22152450f64df3

use login instead of bash

since bash does not play well with utf8 encoded input,
eg. pressing ALTGR + M on an english intl keyboard layout int novnc
does not enter the mu symbol but makes bash think you pressed alt+5,
we should use login without authorization when logging in as root

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index f28a3ffd..c85c9f57 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -672,7 +672,7 @@ __PACKAGE__->register_method ({
 		$upgradecmd = PVE::Tools::shellquote($upgradecmd) if $remip;
 		$shcmd = [ '/bin/bash', '-c', $upgradecmd ];
 	    } else {
-		$shcmd = [ '/bin/bash', '-l' ];
+		$shcmd = [ '/bin/login', '-f', 'root' ];
 	    }
 	} else {
 	    $shcmd = [ '/bin/login' ];
@@ -829,7 +829,7 @@ __PACKAGE__->register_method ({
 		my $upgradecmd = "pveupgrade --shell";
 		$shcmd = [ '/bin/bash', '-c', $upgradecmd ];
 	    } else {
-		$shcmd = [ '/bin/bash', '-l' ];
+		$shcmd = [ '/bin/login', '-f', 'root' ];
 	    }
 	} else {
 	    $shcmd = [ '/bin/login' ];