]> git.proxmox.com Git - pve-qemu-kvm.git/commitdiff
Removing wrong CVE-2015-8619
authorWolfgang Bumiller <w.bumiller@proxmox.com>
Fri, 8 Jan 2016 09:21:53 +0000 (10:21 +0100)
committerDietmar Maurer <dietmar@proxmox.com>
Fri, 8 Jan 2016 11:43:00 +0000 (12:43 +0100)
It's not required and breaks 'sendkey' of combined keys such
as "ctrl-f1".

debian/patches/CVE-2015-8619-hmp-oob-write.patch [deleted file]
debian/patches/series

diff --git a/debian/patches/CVE-2015-8619-hmp-oob-write.patch b/debian/patches/CVE-2015-8619-hmp-oob-write.patch
deleted file mode 100644 (file)
index 1dd22d4..0000000
+++ /dev/null
@@ -1,34 +0,0 @@
-From b0363f4c0e91671064dd7ffece8a6923c8dcaf20 Mon Sep 17 00:00:00 2001
-From: Prasad J Pandit <pjp@fedoraproject.org>
-Date: Thu, 17 Dec 2015 17:47:15 +0530
-Subject: [PATCH] hmp: avoid redundant null termination of buffer
-
-When processing 'sendkey' command, hmp_sendkey routine null
-terminates the 'keyname_buf' array. This results in an OOB write
-issue, if 'keyname_len' was to fall outside of 'keyname_buf' array.
-Removed the redundant null termination, as pstrcpy routine already
-null terminates the target buffer.
-
-Reported-by: Ling Liu <liuling-it@360.cn>
-Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
----
-  hmp.c | 2 --
-  1 file changed, 2 deletions(-)
-
-diff --git a/hmp.c b/hmp.c
-index 2140605..e530c9c 100644
---- a/hmp.c
-+++ b/hmp.c
-@@ -1746,9 +1746,7 @@ void hmp_sendkey(Monitor *mon, const QDict *qdict)
-         /* Be compatible with old interface, convert user inputted "<" */
-         if (!strncmp(keyname_buf, "<", 1) && keyname_len == 1) {
-             pstrcpy(keyname_buf, sizeof(keyname_buf), "less");
--            keyname_len = 4;
-         }
--        keyname_buf[keyname_len] = 0;
-         keylist = g_malloc0(sizeof(*keylist));
-         keylist->value = g_malloc0(sizeof(*keylist->value));
--- 
-2.4.3
-===
index 6b978ca2900fa1d985631fbe4d99cb396515743a..87a00aba2ec40572937f91802fc6c0042329e9a1 100644 (file)
@@ -42,7 +42,6 @@ CVE-2015-7549-msix-pba-write-ro.patch
 CVE-2015-8558-ehci_make_idt_processing_more_robust.patch
 vmxnet3-host-memory-leakage.patch
 CVE-2015-8613-scsi-initialize-info-object.patch
-CVE-2015-8619-hmp-oob-write.patch
 CVE-2015-8666-acpi-fix-buffer-overrun-on-migration.patch
 CVE-2015-8701-net-rocker-off-by-one.patch
 CVE-2015-8743-ne2000-ioport-bounds-check.patch