From 1207620cf0d60129e549c36e812943e33e5ddf0f Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Mon, 23 Nov 2020 15:13:33 +0100 Subject: [PATCH] perlcritic: avoid conditional variable declaration Signed-off-by: Thomas Lamprecht --- PVE/Diskmanage.pm | 9 ++++++--- PVE/Storage.pm | 3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index 2552add..7a0f963 100644 --- a/PVE/Diskmanage.pm +++ b/PVE/Diskmanage.pm @@ -713,9 +713,12 @@ sub get_partnum { sub get_blockdev { my ($part_path) = @_; - my $dev = $1 if $part_path =~ m|^/dev/(.*)$|; - my $link = readlink "/sys/class/block/$dev"; - my $block_dev = $1 if $link =~ m|([^/]*)/$dev$|; + my ($dev, $block_dev); + if ($part_path =~ m|^/dev/(.*)$|) { + $dev = $1; + my $link = readlink "/sys/class/block/$dev"; + $block_dev = $1 if $link =~ m|([^/]*)/$dev$|; + } die "Can't parse parent device\n" if !defined($block_dev); die "No valid block device\n" if index($dev, $block_dev) == -1; diff --git a/PVE/Storage.pm b/PVE/Storage.pm index bd6e15e..13fea73 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -1411,7 +1411,8 @@ sub decompressor_info { die "ERROR: archive format not defined\n" if !defined($decompressor->{$format}); - my $decomp = $decompressor->{$format}->{$comp} if $comp; + my $decomp; + $decomp = $decompressor->{$format}->{$comp} if $comp; my $info = { format => $format, -- 2.39.2