fix unnecessary root check for unused disks

we needed root@pam rights to remove an unused disk
from a vm (instead of the correct Storage rights)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index aadfde5833e5ddd2698661dbc571d601bc9c5304..c0a72c0316c44f071ffb79d8890b22c066f664d3 100644 (file)
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -243,6 +243,7 @@ my $check_vm_modify_config_perm = sub {
        # disk checks need to be done somewhere else
        next if PVE::QemuServer::is_valid_drivename($opt);
        next if $opt eq 'cdrom';
+       next if $opt =~ m/^unused\d+$/;
 
        if ($cpuoptions->{$opt} || $opt =~ m/^numa\d+$/) {
            $rpcenv->check_vm_perm($authuser, $vmid, $pool, ['VM.Config.CPU']);

diff --git a/changelog.Debian b/changelog.Debian
index d6685751c4ea1dd521e954590c8c99a92254fe4a..a06c42139f6576c98c919c94a677242ef9a3db23 100644 (file)
--- a/changelog.Debian
+++ b/changelog.Debian
@@ -2,6 +2,8 @@ qemu-server (4.0-80) unstable; urgency=medium
 
   * split old style pipe open call
 
+  * fix unnecessary root check for unused disks
+
  -- Proxmox Support Team <support@proxmox.com>  Thu, 09 Jun 2016 18:13:03 +0200
 
 qemu-server (4.0-79) unstable; urgency=medium