]> git.proxmox.com Git - qemu-server.git/commitdiff
migrate: simplify replicated_volume loop
authorFabian Grünbichler <f.gruenbichler@proxmox.com>
Mon, 20 Apr 2020 09:24:05 +0000 (11:24 +0200)
committerFabian Grünbichler <f.gruenbichler@proxmox.com>
Mon, 20 Apr 2020 09:24:23 +0000 (11:24 +0200)
(no change compared to previous iteration except for readability)

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
PVE/QemuMigrate.pm

index b596a9271a019166721d7127f1b1290511a9e6a1..d90b709f2f0e63fc9c3874d2793547f143b55b4c 100644 (file)
@@ -710,12 +710,10 @@ sub phase2 {
     $input .= "nbd_protocol_version: $nbd_protocol_version\n";
 
     my $number_of_online_replicated_volumes = 0;
-    if ($self->{online_local_volumes}) {
-       foreach my $volid (keys %{$self->{replicated_volumes}}) {
-           next if !(grep { $volid eq $_ } @{$self->{online_local_volumes}});
-           $number_of_online_replicated_volumes++;
-           $input .= "replicated_volume: $volid\n";
-       }
+    foreach my $volid (@{$self->{online_local_volumes}}) {
+       next if !$self->{replicated_volumes}->{$volid};
+       $number_of_online_replicated_volumes++;
+       $input .= "replicated_volume: $volid\n";
     }
 
     my $target_replicated_volumes = {};