From: Dominik Csapak <d.csapak@proxmox.com>
Date: Thu, 28 Feb 2019 08:15:59 +0000 (+0100)
Subject: fix #2114: set correct link status on hotplug
X-Git-Url: https://git.proxmox.com/?p=qemu-server.git;a=commitdiff_plain;h=79046fd12e1ec906c8fce5aeee8bb9f142f4fc36

fix #2114: set correct link status on hotplug

we also need to set the link status if the whole device changed,
otherwise a change of macaddress allows a network connection even
if link_down is set to 1

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 6e56eda..5422296 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4140,7 +4140,10 @@ sub vm_deviceplug {
 
         my $netdevicefull = print_netdevice_full($vmid, $conf, $device, $deviceid, undef, $use_old_bios_files, $arch, $machine_type);
         qemu_deviceadd($vmid, $netdevicefull);
-        eval { qemu_deviceaddverify($vmid, $deviceid); };
+	eval {
+	    qemu_deviceaddverify($vmid, $deviceid);
+	    qemu_set_link_status($vmid, $deviceid, !$device->{link_down});
+	};
 	if (my $err = $@) {
 	    eval { qemu_netdevdel($vmid, $deviceid); };
 	    warn $@ if $@;