From: Dominik Csapak <d.csapak@proxmox.com>
Date: Mon, 17 Dec 2018 08:19:58 +0000 (+0100)
Subject: fix #2032: check that type is set before using
X-Git-Url: https://git.proxmox.com/?p=qemu-server.git;a=commitdiff_plain;h=86c9fafefc696a9c19b9ada00ea2793f6a0e4883

fix #2032: check that type is set before using

When not setting 'vga' we would get a warning:

Use of uninitialized value $type in string eq at
/usr/share/perl5/PVE/QemuServer.pm line 2026.

This patch changes the order of the conditions and checks if $type is set
before using it, so that we do not get the warning anymore.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 4a6a6ccc..38b511e9 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2023,7 +2023,7 @@ sub print_vga_device {
     my ($conf, $vga, $arch, $machine, $id, $qxlnum, $bridges) = @_;
 
     my $type = $vga_map->{$vga->{type}};
-    if ($type eq 'virtio-vga' && $arch eq 'aarch64') {
+    if ($arch eq 'aarch64' && defined($type) && $type eq 'virtio-vga') {
 	$type = 'virtio-gpu';
     }
     my $vgamem_mb = $vga->{memory};