qemu-server.git
17 hours agoremove unused variable master
Dominik Csapak [Mon, 15 Jul 2019 12:35:30 +0000 (14:35 +0200)]
remove unused variable

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
17 hours agofix #2275: die on invalid sendkey
Dominik Csapak [Mon, 15 Jul 2019 12:35:29 +0000 (14:35 +0200)]
fix #2275: die on invalid sendkey

sendkey does not return anything if it is succesful and the error otherwise

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
26 hours agoaudio dev: follouwp code cleanup and error handling
Thomas Lamprecht [Thu, 18 Jul 2019 07:08:59 +0000 (09:08 +0200)]
audio dev: follouwp code cleanup and error handling

die if we get some unknown value, which is either a bug (new dev type
added to enum but not here) or a user manual edit error, good to
ccatch both

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
26 hours agoaudio dev: add note that this is useful for SPICE
Thomas Lamprecht [Thu, 18 Jul 2019 07:08:40 +0000 (09:08 +0200)]
audio dev: add note that this is useful for SPICE

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
27 hours agoAdd audio device to HW permissions
Aaron Lauterer [Wed, 17 Jul 2019 13:59:01 +0000 (15:59 +0200)]
Add audio device to HW permissions

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
27 hours agoAdd PCI address for audio device
Aaron Lauterer [Wed, 17 Jul 2019 13:59:00 +0000 (15:59 +0200)]
Add PCI address for audio device

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
27 hours agoAdd audio device support
Aaron Lauterer [Wed, 17 Jul 2019 13:58:57 +0000 (15:58 +0200)]
Add audio device support

Until now audio devices had to be added manually with the `args` option
in the VMs config file. This adds a new config option to define an audio
device. It is called `audio0` with the extra `0` to be prepared should
we ever implement support for more than one audio device.

Supported devices are:

* ich9-intel-hda: Intel HD Audio Controller, emulates ICH9
* intel-hda: Intel HD Audio Controller, emulates ICH6
* AC97: useful for older OSs like Win XP

If any of the `intel-hda`s is selected two additional devices will be
created: hda-micro and hda-duplex. The `*intel-hda` controllers need at
least one of them as they emulate microphones and speakers (hda-micro)
or line in and out devices (hda-duplex).

Having both is deemed best practice to avoid problems if some software
needs one of the other kind of output/input ports.

I also cleaned up some old, commented out, code regarding audio devices.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
7 days agobump version to 6.0-5
Thomas Lamprecht [Thu, 11 Jul 2019 17:45:38 +0000 (19:45 +0200)]
bump version to 6.0-5

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
10 days agouse new pcie port hardware
Dominik Csapak [Mon, 8 Jul 2019 09:25:10 +0000 (11:25 +0200)]
use new pcie port hardware

with qemu 4.0 we can make use of the new pcie-root-ports with settings
for the width/speed which can resolve issues with some hardware combinations
when negioating link speed

so we add a new q35 cfg that we include with machine types >= 4.0
to preserve live migration of machines without passthrough but q35

for details about the link speeds see:

pcie: Enhanced link speed and width support
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg02827.html

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 weeks agoFix: rtcflags: ignore startdate 'now'
Alwin Antreich [Thu, 4 Jul 2019 09:00:58 +0000 (11:00 +0200)]
Fix: rtcflags: ignore startdate 'now'

If 'now' is passed to the startdate option, the kvm start fails with
below failure.
 kvm: invalid datetime format
 valid formats: '2006-06-17T16:01:21' or '2006-06-17'

With this patch, 'now' is ignored and not passed to the rtcflags (-rtc).

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2 weeks agobump version to 6.0-4
Thomas Lamprecht [Fri, 28 Jun 2019 18:36:39 +0000 (20:36 +0200)]
bump version to 6.0-4

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 weeks agocheck_local_storage_availability: only count each unavailable storage once
Thomas Lamprecht [Fri, 28 Jun 2019 15:23:44 +0000 (17:23 +0200)]
check_local_storage_availability: only count each unavailable storage once

and some general cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 weeks agomigrate: add size to volume attributes
Tim Marx [Fri, 28 Jun 2019 13:13:47 +0000 (15:13 +0200)]
migrate: add size to volume attributes

Signed-off-by: Tim Marx <t.marx@proxmox.com>
2 weeks agomigrate: handle storage not selected manually in storage config
Tim Marx [Fri, 28 Jun 2019 13:13:45 +0000 (15:13 +0200)]
migrate: handle storage not selected manually in storage config

e.g. local storage was considered not allowed for offline migration
even if it is available on all nodes, this should now be fixed as it
is now considered available on all nodes if a local storage isn't
restricted to a specific subset of the available nodes. The user is
responseable to make sure that the datacenter storage config reflects
the actual setup, so there is no additional check for local storages
which aren't available on all nodes if they are not explicitly marked
at datacenter level.

Signed-off-by: Tim Marx <t.marx@proxmox.com>
2 weeks agocloudinit: set iso-level in genisoimage call
Mira Limbeck [Thu, 27 Jun 2019 16:01:05 +0000 (18:01 +0200)]
cloudinit: set iso-level in genisoimage call

This is required for Windows to recognize the ISO and as a result the cloudinit
config. This is the minimum to get any config working at all for windows.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
3 weeks agoFix guest agent shutdown without timeout
Stefan Reiter [Tue, 25 Jun 2019 14:44:31 +0000 (16:44 +0200)]
Fix guest agent shutdown without timeout

Regression from change allowing timeouts to be set, now shutting down
also works without timeouts again (previously qmp failed because of
the unknown "timeout" parameter passed to it).

We always delete the timeout value from the arguments, regardless of
truthiness. "delete" returns the deleted element, deleting a
non-existant hash entry returns undef, which is fine after this point:

"deleting non-existent elements returns the undefined value in their
corresponding positions."
- https://perldoc.perl.org/functions/delete.html

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
3 weeks agobump version to 6.0-3
Thomas Lamprecht [Tue, 25 Jun 2019 12:34:27 +0000 (14:34 +0200)]
bump version to 6.0-3

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 weeks agoadd_hyperv_enlightenments: do not add hv_evmcs for now at all
Thomas Lamprecht [Tue, 25 Jun 2019 12:32:05 +0000 (14:32 +0200)]
add_hyperv_enlightenments: do not add hv_evmcs for now at all

as Windows VMs on hosts with AMD CPUs do not start at all with
that...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 weeks agobump version to 6.0-2
Thomas Lamprecht [Mon, 24 Jun 2019 15:50:01 +0000 (17:50 +0200)]
bump version to 6.0-2

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 weeks agofollowup: move hv_tlbflush under 3.1 machine feature guard
Thomas Lamprecht [Mon, 24 Jun 2019 15:23:42 +0000 (17:23 +0200)]
followup: move hv_tlbflush under 3.1 machine feature guard

while it really should not pose an issue for live migrations lets be
on the safe side and also add this only with 3.1 or later machines

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 weeks agofix #2083: Add hv_tlbflush, hv_ipi, hv_evmcs enlightenments
Stefan Reiter [Wed, 19 Jun 2019 08:23:20 +0000 (10:23 +0200)]
fix #2083: Add hv_tlbflush, hv_ipi, hv_evmcs enlightenments

Kernels 4.18+ (4.17+ for evmcs) support new Hyper-V enlightenments for
Windows KVM guests. QEMU supports these since 3.0 and 3.1 respectively.
tlbflush and ipi improve performance on overcommitted systems, evmcs
improves nested virtualization.

It's not entirely clear to me if Win7 already supports these, but since
it doesn't cause any performance penalties (and it works fine without
crashing, which makes sense either way, because Hyper-V enlightenments
are opt-in by the guest OS), enabling it regardless should be fine.
(As opposed to adding a new if branch for win8+)

Feature explanations to the best of my understanding:

hv_tlbflush allows the guest OS to trigger tlb shootdowns via a
hypercall. This allows CPUs to be identified via their vpindex (which
makes hv_vpindex a prerequisite to hv_tlbflush, but that is already
handled in our code). In overcommited configurations, where multiple
vCPUs reside on one pCPU, this increases performance of guest tlb
flushes, by only flushing each pCPU once. It also allows multiple tlb
flushes with only one vmexit.

hv_ipi allows sending inter-processor interrupts via vpindex, once again
making it a prerequisite. Benefits are pretty much as with tlbflush.

hv_evmcs is a VM control structure in L1 guest memory, allowing an L1 guest
to modify L2 VMCS and entering L2 without having the L0 host perform an
expensive VMCS update on trapping the nested vmenter.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
3 weeks agofix #2244: Allow timeout for guest-agent shutdown
Stefan Reiter [Mon, 24 Jun 2019 08:33:07 +0000 (10:33 +0200)]
fix #2244: Allow timeout for guest-agent shutdown

The "guest-shutdown" guest agent call is blocking for some reason, so if
it fails (e.g. agent not installed on guest) only the default timeout of
10 minutes (see QMPClient.pm, sub cmd) would apply.

With this change, if (and only if) a timeout is specified via CLI/API,
it is used instead. In case it is not specified, behaviour stays the
same (default 10 min timeout).

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
3 weeks agod/control: bump version dependency to libpve-common-perl
Thomas Lamprecht [Mon, 24 Jun 2019 15:20:05 +0000 (17:20 +0200)]
d/control: bump version dependency to libpve-common-perl

for the new wait_for_unit_removed helper

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 weeks agod/control: wrap and sort + remove duplicates
Thomas Lamprecht [Mon, 24 Jun 2019 15:19:19 +0000 (17:19 +0200)]
d/control: wrap and sort + remove duplicates

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 weeks agowait for vm scopes to be gone
Wolfgang Bumiller [Wed, 19 Jun 2019 07:21:22 +0000 (09:21 +0200)]
wait for vm scopes to be gone

This should help with the rare case where stop mode backups
fail to restart due to the $vmid.scope not being completely
gone when we want to restart. This queries systemd via dbus,
and if the scope is still there, awaits a UnitRemoved signal
for the scope from dbus.

For now with a 5 second timeout... (given that the processes
are already gone and it's really just waiting for systemd to
wake up, this should be plenty...)

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
4 weeks agoadd migration precondition api endpoint
Tim Marx [Fri, 14 Jun 2019 12:35:35 +0000 (14:35 +0200)]
add migration precondition api endpoint

Signed-off-by: Tim Marx <t.marx@proxmox.com>
4 weeks agobump version to 6.0-1
Thomas Lamprecht [Fri, 14 Jun 2019 18:59:24 +0000 (20:59 +0200)]
bump version to 6.0-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 weeks agod/control: bump qemu versioned dependency to 3.0.1-62
Thomas Lamprecht [Fri, 14 Jun 2019 18:55:28 +0000 (20:55 +0200)]
d/control: bump qemu versioned dependency to 3.0.1-62

to ensure we have the md-clear flag available

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 weeks agoSMBIOS: followup: allow now 512 characters for full format string
Thomas Lamprecht [Tue, 11 Jun 2019 15:39:20 +0000 (17:39 +0200)]
SMBIOS: followup: allow now 512 characters for full format string

to acutally allow to set the values requested by #2190 we need to
alter the limit a bit, as else the requested values cannot be save.

Just double it to 512, which should be really enough for this, else
go complain to your software vendor for needing such _hacks_ in the
first place..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 weeks agofix #2190: Base64 encode SMBIOS value strings in order to allow more characters
Christian Ebner [Tue, 11 Jun 2019 10:13:52 +0000 (12:13 +0200)]
fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

On some occasions e.g. license checking, the manufacturer string in the
SMBIOS settings edit has to allow characters such as whitespaces.
https://forum.proxmox.com/threads/proxmox-and-windows-rok-license-for-dell.53236/
In principle SMBIOS allows to pass any zero terminated string to the
corresponding fields in the structure type 1 (System Information).

By base64 encoding the values clashing of the config is avoided.

Relies on the corresponding patch to pve-manager to obtain base64 encoded values.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
5 weeks agofollowup: mention new md-clear flag also in description
Thomas Lamprecht [Thu, 6 Jun 2019 15:47:41 +0000 (17:47 +0200)]
followup: mention new md-clear flag also in description

that should really be autogenerated!

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 weeks agoadd md-clear cpu flag
Oguz Bektas [Mon, 3 Jun 2019 13:17:11 +0000 (15:17 +0200)]
add md-clear cpu flag

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
6 weeks agoadd qm command for cloudinit config dump
Mira Limbeck [Wed, 5 Jun 2019 09:09:43 +0000 (11:09 +0200)]
add qm command for cloudinit config dump

Adds the command 'qm cloudinit dump <vmid> <type>' where type is either
'user', 'network' or 'meta' as specified in the API.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
6 weeks agoadd new API for dumping cloudinit config
Mira Limbeck [Wed, 5 Jun 2019 09:09:42 +0000 (11:09 +0200)]
add new API for dumping cloudinit config

Adds the path '{vmid}/cloudinit/dump' and requires the parameter 'type'
that's either 'user', 'network' or 'meta'. Returns the generated config as
string.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
6 weeks agoadd function to dump cloudinit config
Mira Limbeck [Wed, 5 Jun 2019 09:09:41 +0000 (11:09 +0200)]
add function to dump cloudinit config

This adds a function to dump the generated cloudinit config. Only one
can be dumped at a time, either 'user', 'network' or 'meta'.

The logic to get user, network and metadata is copied from the other
path that also creates the ISO image to keep it simple and not
complicate the other code path further.

The hash generation for the metadata config is unified between nocloud
and configdrive2 formats. We need it a 3rd time with the new dump
functions so it makes sense to combine it and the metadata config
generation in a single function. The <format>_gen_metadata functions are
each used twice now.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
6 weeks agodrop vnc x509 param, deprecated in 2.5 removed in 4.0
Thomas Lamprecht [Thu, 6 Jun 2019 07:49:47 +0000 (09:49 +0200)]
drop vnc x509 param, deprecated in 2.5 removed in 4.0

while we have 3.0.1 for now, 4.x will come sooner or later so do this
now already..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
6 weeks agoapi/qemu: start: add helper for root-only param extraction
Thomas Lamprecht [Thu, 6 Jun 2019 07:43:43 +0000 (09:43 +0200)]
api/qemu: start: add helper for root-only param extraction

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
6 weeks agoapi/qemu: extra line cleanup
Thomas Lamprecht [Thu, 6 Jun 2019 07:41:52 +0000 (09:41 +0200)]
api/qemu: extra line cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
6 weeks agoFix #1999: cli: listsnapshot: handle multiple roots and mark orphaned as root
Rhonda D'Vine [Wed, 5 Jun 2019 13:30:48 +0000 (15:30 +0200)]
Fix #1999: cli: listsnapshot: handle multiple roots and mark orphaned as root

This commit addresses the following things:

* There can be multiple independent snapshot tree roots, display them
  all
* If a snapshot defines a parent that doesn't exist, it is now
  considered a snapshot root

There is a potential issue (which was also before and also affects the
GUI): circular snapshot trees.  That plays into the second mentioned
issue above.  If you manage to have a snapshot that defines a
non-existing root in the config, and then create a snapshot with that
exact name as a child of that snapshot, it would create a circular
dependency.  This would have to get addressed in the GUI too.

Signed-off-by: Rhonda D'Vine <rhonda@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
6 weeks agodrop references to un-maintained sheepdog plugin
Thomas Lamprecht [Tue, 4 Jun 2019 15:42:33 +0000 (17:42 +0200)]
drop references to un-maintained sheepdog plugin

we remove it from pve-storage as it's abandoned

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
6 weeks agorefactor do_snapshots_with_qemu a bit cleaner
Thomas Lamprecht [Tue, 4 Jun 2019 15:40:42 +0000 (17:40 +0200)]
refactor do_snapshots_with_qemu a bit cleaner

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
7 weeks agowhitespace cleanup
Tim Marx [Wed, 22 May 2019 13:25:34 +0000 (15:25 +0200)]
whitespace cleanup

Signed-off-by: Tim Marx <t.marx@proxmox.com>
7 weeks agocommon sources.list: move from stretch to buster
Thomas Lamprecht [Mon, 27 May 2019 11:58:01 +0000 (13:58 +0200)]
common sources.list: move from stretch to buster

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
7 weeks agovm_resume: correctly honor $nocheck
Fabian Grünbichler [Thu, 23 May 2019 19:22:22 +0000 (21:22 +0200)]
vm_resume: correctly honor $nocheck

for both vm_mon_cmd calls. under certain circumstances, the following
sequence of events can otherwise fail when live-migrating under load:

S...source node
T...target node

0: migration is complete, handover from S to T starts
1: S: logically move VM config file from S to T via rename()
2: S: rename returns, config file is (visibly) moved on S
3: S: trigger resume on T via mtunnel
4a: T: call vm_resume while config file move is not yet visible on T
4b: T: call vm_resume while config file move is already visible on T

4a instead of 4b means vm_mon_cmd will die in check_running unless
vm_mon_cmd_nocheck is used.

under heavy pmxcfs load and a slow cluster/corosync network, there can
be a few seconds of delay between 1 and 2, with a subsequent race ending in 4a
instead of 4b.

this issue was reported to occur on bulk migrations.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
8 weeks agod/changelog: correct distribution
Thomas Lamprecht [Wed, 22 May 2019 17:12:54 +0000 (19:12 +0200)]
d/changelog: correct distribution

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 weeks agobump version to 6.0-0+1
Thomas Lamprecht [Wed, 22 May 2019 17:06:26 +0000 (19:06 +0200)]
bump version to 6.0-0+1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 weeks agod/control: remove dependency to essential libc
Thomas Lamprecht [Wed, 22 May 2019 17:00:36 +0000 (19:00 +0200)]
d/control: remove dependency to essential libc

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 weeks agobump debian compat level to 11
Thomas Lamprecht [Wed, 22 May 2019 16:47:53 +0000 (18:47 +0200)]
bump debian compat level to 11

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 weeks agobuildsys: use dpkg-dev makefile helpers for pkg info
Thomas Lamprecht [Wed, 22 May 2019 16:47:23 +0000 (18:47 +0200)]
buildsys: use dpkg-dev makefile helpers for pkg info

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
8 weeks agotest: config2command: fallback to hardcoded version
Thomas Lamprecht [Wed, 22 May 2019 16:37:02 +0000 (18:37 +0200)]
test: config2command: fallback to hardcoded version

especially useful when bootstrapping, where  pve-qemu-kvm may not yet
be build

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofixup: delete cloudinit disk before restoring
Thomas Lamprecht [Fri, 17 May 2019 10:09:51 +0000 (12:09 +0200)]
fixup: delete cloudinit disk before restoring

cloudinit is just completely broken...
Until we rewrite this to a sane designe (i.e., never backup, mirror,
... any CI disk anywhere - the state is in the config and gets
created on start and deleted on stop anyway) do this..

Co-developed-by: Mira Limbek <m.limbek@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agoQemuServer: code cleanup
Thomas Lamprecht [Fri, 17 May 2019 08:53:50 +0000 (10:53 +0200)]
QemuServer: code cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofollouwp: set is_cloudinit in drive to avoid always rechecking
Thomas Lamprecht [Fri, 17 May 2019 08:53:30 +0000 (10:53 +0200)]
follouwp: set is_cloudinit in drive to avoid always rechecking

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agomap cloudinit disk to new vmid on restore
Mira Limbeck [Thu, 16 May 2019 12:07:01 +0000 (14:07 +0200)]
map cloudinit disk to new vmid on restore

Resolves the issue of restoring a VM that has a cloudinit drive
configured to a new VMID. The VMID of the disk name gets now remapped
correctly and in the process the cloudinit disk is created with the same size
as in PVE/API2/Qemu.pm create_disks and in PVE/QemuServer/Cloudinit
commit_cloudinit_disk as the same constant is used.

This is done by matching any line starting with either 'ide', 'sata' or
'scsi' and then check if it is a cloudinit drive. As cloudinit drives
are attached as cdrom, only those 3 are possible. For the cloudinit
check we use 'parse_drive' followed by 'drive_is_cloudinit' so no custom
regex is necessary.

'--targetstorage' is also taken into account on restore now for
cloudinit disks. If a target storage is specified the format is either
kept if possible, or changed to the default of that storage.

This should fix #1807 completely. The restore error was already resolved
with commit 7e8ab2a, but the vmid of the disk might not have matched the new
one.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
2 months agointroduce one global CLOUDINIT_DISK_SIZE constant
Mira Limbeck [Thu, 16 May 2019 12:07:00 +0000 (14:07 +0200)]
introduce one global CLOUDINIT_DISK_SIZE constant

The variable is used instead of the literal value so we have one single
place to change the actual value of every use.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
2 months agofixup: shorter/conciser comment
Thomas Lamprecht [Thu, 16 May 2019 14:28:53 +0000 (16:28 +0200)]
fixup: shorter/conciser comment

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofix clone_disk with formats other than raw/qcow2
Mira Limbeck [Thu, 16 May 2019 13:08:50 +0000 (15:08 +0200)]
fix clone_disk with formats other than raw/qcow2

with commit 64d1a6a it's now possible to specify a format other than raw
or qcow2 when creating VMs. This can lead to an error when cloning the
VMs and a cloudinit disk with a different format is attached (e.g.
vmdk).

We use QEMU_FORMAT_RE in drive_is_cloudinit and according to the
QEMU_FORMAT_RE we support 7 different formats.

With this change we add any format other than 'raw' as '.<format>' to the
name and no longer die on any other format. Cloudinit disks with invalid
format are not cloned as the drive is recognized as cdrom, not cloudinit.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
2 months agofollowup: fixup comment
Thomas Lamprecht [Wed, 15 May 2019 14:33:46 +0000 (16:33 +0200)]
followup: fixup comment

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofix existing cloudinit volume not available for file_size_info
Mira Limbeck [Wed, 15 May 2019 10:53:24 +0000 (12:53 +0200)]
fix existing cloudinit volume not available for file_size_info

file_size_info can't find the file if it is not available, e.g.,
RBD storage with KRBD or LVM where the volume was not yet activated,
returns then 0, which we interpret as the disk not existing, thus
call vdisk_alloc which errors as the disk, in fact, really already exists.

With this patch we call activate_volume before trying
file_size_info, so if the volume exists we get it available and else
we can really create it.
If the disk does not exist and is created with vdisk_alloc we still
require an additional call to activate_volume for the new disk.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofix #503: print correct offline time for stop mode backups
Thomas Lamprecht [Wed, 8 May 2019 17:32:37 +0000 (17:32 +0000)]
fix #503: print correct offline time for stop mode backups

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agod/control: add ${misc:Depends} to Depends list
Thomas Lamprecht [Mon, 13 May 2019 16:06:50 +0000 (16:06 +0000)]
d/control: add ${misc:Depends} to Depends list

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofixup: correct initial prefix
Thomas Lamprecht [Mon, 13 May 2019 06:05:51 +0000 (06:05 +0000)]
fixup: correct initial prefix

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agominor followup cleanups
Thomas Lamprecht [Mon, 13 May 2019 05:49:31 +0000 (05:49 +0000)]
minor followup cleanups

remove now out of date commen about 'our', left over from previous
revision

Pass firs $prefix directly to function and some other small stuff

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofix #1999: create a tree view for qm listsnapshot
Rhonda D'Vine [Fri, 10 May 2019 12:45:55 +0000 (14:45 +0200)]
fix #1999: create a tree view for qm listsnapshot

The look of the tree is based on the GUI variant, so that we have a
consistent output when run multiple times, too.

Signed-off-by: Rhonda D'Vine <rhonda@proxmox.com>
2 months agomigrate: log which local resource causes error
Tim Marx [Fri, 3 May 2019 12:22:39 +0000 (14:22 +0200)]
migrate: log which local resource causes error

Signed-off-by: Tim Marx <t.marx@proxmox.com>
2 months agowhitespace cleanup
Tim Marx [Fri, 3 May 2019 12:22:38 +0000 (14:22 +0200)]
whitespace cleanup

Signed-off-by: Tim Marx <t.marx@proxmox.com>
2 months agobump version to 5.0-51
Thomas Lamprecht [Tue, 30 Apr 2019 14:08:27 +0000 (14:08 +0000)]
bump version to 5.0-51

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agocloudinit: use detected format in volname parsing
Thomas Lamprecht [Tue, 30 Apr 2019 13:24:53 +0000 (13:24 +0000)]
cloudinit: use detected format in volname parsing

keep the ?, as format is raw if no file ending is there, which we
want to handle too.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofollowup: do not query size of image we just created
Thomas Lamprecht [Tue, 30 Apr 2019 13:09:21 +0000 (13:09 +0000)]
followup: do not query size of image we just created

we know the size, and even if a storage plugin pads this up (it
mustn't alloc something smaller, but something bigger can be OK) we
know that our 4MB is OK, and can only be used anyway to make this
compatible between storage plugins.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofollowup: make ISO exists check a bit stricter
Thomas Lamprecht [Tue, 30 Apr 2019 13:07:55 +0000 (13:07 +0000)]
followup: make ISO exists check a bit stricter

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofix #2173: use qemu-img to check cloudinit disk existence
Mira Limbeck [Tue, 30 Apr 2019 12:20:47 +0000 (14:20 +0200)]
fix #2173: use qemu-img to check cloudinit disk existence

use file_size_info to check for existence of cloudinit disk instead of
'-e'. It uses `qemu-img info` to get some file info, which can handle
rbd, and various other paths for volumes not exposed as normal file
or not mapped, yet.

this addresses a problem with rbd where the path returned available
is not checkable with '-e'.

Any size > 0 is interpreted as the image existing.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofix: #1075: Restore VM template to VM and try to convert to template.
Christian Ebner [Fri, 19 Apr 2019 10:06:07 +0000 (12:06 +0200)]
fix: #1075: Restore VM template to VM and try to convert to template.

The restore of a backup from a VM template will first restore the VM and then
convert the restored VM back into a template.
This automatically performes the steps of the current behaviour, where the user
has to manually convert the restored VM back to a template.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2 months agocreate ci disk: long line cleanup
Thomas Lamprecht [Wed, 24 Apr 2019 13:33:32 +0000 (13:33 +0000)]
create ci disk: long line cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 months agofollowup: keep raw as default for non-path based stores
Thomas Lamprecht [Wed, 24 Apr 2019 13:27:16 +0000 (13:27 +0000)]
followup: keep raw as default for non-path based stores

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agofix #1829: Cloudinit ignore format parameter
Wolfgang Link [Tue, 16 Apr 2019 07:58:22 +0000 (09:58 +0200)]
fix #1829: Cloudinit ignore format parameter

When a Cloudinit image is created, we allow choosing
the format as parameter.
So, the parameter should also be taken into account.

The default for Cloudinit will stay qcow2 on directory storages.

3 months agofollowup: expand check_vm_modify_config_perm comment
Thomas Lamprecht [Fri, 12 Apr 2019 14:19:45 +0000 (16:19 +0200)]
followup: expand check_vm_modify_config_perm comment

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agoallow non root users to add spice usb port
Dominik Csapak [Fri, 12 Apr 2019 14:08:37 +0000 (16:08 +0200)]
allow non root users to add spice usb port

using the same logic like serialX: socket
users need VM.Config.HWType for usbX: spice
but only root can add/remove real devices

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 months agomove check for serialX: socket
Dominik Csapak [Fri, 12 Apr 2019 14:08:36 +0000 (16:08 +0200)]
move check for serialX: socket

since we do not want the user to change a device which has a real
devices already set, we have to check it later when we have the config

so we do not have to give the params to vm_check_modify_config_perm anymore

also improve the regex to \d+

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 months agofix #1811: allow non root user to edit serialX: socket entries
Dominik Csapak [Thu, 11 Apr 2019 11:39:49 +0000 (13:39 +0200)]
fix #1811: allow non root user to edit serialX: socket entries

use VM.Config.HWType for 'socket' and root@pam for real serial devices

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 months agocode cleanup
Thomas Lamprecht [Fri, 5 Apr 2019 15:37:18 +0000 (17:37 +0200)]
code cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agofix creating clone if target storage is same as source storage
Alwin Antreich [Fri, 5 Apr 2019 12:35:45 +0000 (14:35 +0200)]
fix creating clone if target storage is same as source storage

the clone API calls (target) 'storage' parameter is optional as we
simply use the source storage in this case, but we did not handle
this case when we added the bandwidth_limit abillity, address that.

This patch only pushes the storage parameter into the storage_list array
if it is defined.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agobump version to 5.0-50
Thomas Lamprecht [Thu, 4 Apr 2019 14:22:39 +0000 (16:22 +0200)]
bump version to 5.0-50

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agofollowup: remove unused variable and add spave between value and unit
Thomas Lamprecht [Tue, 2 Apr 2019 12:33:10 +0000 (14:33 +0200)]
followup: remove unused variable and add spave between value and unit

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agofollowup: reword bwlimit default wording
Thomas Lamprecht [Tue, 2 Apr 2019 08:37:40 +0000 (10:37 +0200)]
followup: reword bwlimit default wording

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agobwlimit: add parameter to API2 calls
Stoiko Ivanov [Mon, 1 Apr 2019 09:31:05 +0000 (11:31 +0200)]
bwlimit: add parameter to API2 calls

for migrate_vm, clone_vm and move_vm_disk and extract it. The 'migrate_vm' call
passes it to PVE::QemuMigrate->migrate for handling.

Additionally the bwlimit option's description of the 'create_vm' call gets
consistent capitalization of I/O.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
3 months agobwlimit: add parameter to QemuServer::clone_disk
Stoiko Ivanov [Mon, 1 Apr 2019 09:31:04 +0000 (11:31 +0200)]
bwlimit: add parameter to QemuServer::clone_disk

and pass it to qemu_drive_mirror (used for online disks).

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
3 months agobwlimit: add parameter for QemuMigrate::phase2
Stoiko Ivanov [Mon, 1 Apr 2019 09:31:02 +0000 (11:31 +0200)]
bwlimit: add parameter for QemuMigrate::phase2

used for online local disks via qemu_drive_mirror

Add TODO comment for offline disks, as clone_disk calls `qemu-img
convert`, which does not have a bandwidth limit parameter.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
3 months agobwlimit: add parameter to QemuMigrate::sync_disks
Stoiko Ivanov [Mon, 1 Apr 2019 09:31:00 +0000 (11:31 +0200)]
bwlimit: add parameter to QemuMigrate::sync_disks

used for offline migration of local volumes

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
3 months agobwlimit: add parameter to qemu_drive_mirror
Stoiko Ivanov [Mon, 1 Apr 2019 09:30:59 +0000 (11:30 +0200)]
bwlimit: add parameter to qemu_drive_mirror

used for online drive migrations, move_disk and clone calls.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
3 months agobwlimit: honor bwlimit for migrate qmp call
Stoiko Ivanov [Mon, 1 Apr 2019 09:30:58 +0000 (11:30 +0200)]
bwlimit: honor bwlimit for migrate qmp call

The 'migrate_speed' can be set in the VM config. Additionally the 'migrate'
bwlimit from datacenter.cfg (storage-specific limits play no role for
memory+state migration) or the parameter provided to the API call can restrict
the speed. Take the lower of the two.

This patch also refactors the setting of migrate_speed and comments for clarity.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
3 months agochange task name for suspend with and without disk
Dominik Csapak [Fri, 29 Mar 2019 09:44:31 +0000 (10:44 +0100)]
change task name for suspend with and without disk

so that we can differentiate in the gui

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
3 months agodrive mirror: cleanup exception handling code a bit
Thomas Lamprecht [Sat, 30 Mar 2019 08:36:30 +0000 (09:36 +0100)]
drive mirror: cleanup exception handling code a bit

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agofix #2100: ignore cloudinit drive on offline migration
Mira Limbeck [Fri, 29 Mar 2019 15:32:04 +0000 (16:32 +0100)]
fix #2100: ignore cloudinit drive on offline migration

disk is not copied to the target node but still deleted on cleanup
(phase3_cleanup).

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
3 months agocloudinit: create disk if it does not exist on start
Mira Limbeck [Fri, 29 Mar 2019 15:32:03 +0000 (16:32 +0100)]
cloudinit: create disk if it does not exist on start

create a fixed size cloudinit disk if it is referenced in config and
does not exist. the size of the disk created when first added to the
config is reduced to 4MiB to match the one created in
commit_cloudinit_disk.
maximum file size per snippet file (network, user, meta) is increased to 1MiB.
preparation for offline migration without the cloudinit disk (that is
always regenerated on start).

also fixes #1807, although a further patch is required to change the
vmid on restore

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
3 months agopartially revert 4efb58a - unquote configdrive2 ips
Mira Limbeck [Mon, 25 Mar 2019 11:34:44 +0000 (12:34 +0100)]
partially revert 4efb58a - unquote configdrive2 ips

configdrive2 uses /etc/network/interfaces style config instead of the
official yaml one. this does not allow quoting of the ip addresses.

Tested with Windows Server 2016.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
3 months agobump version to 5.0-49
Thomas Lamprecht [Thu, 21 Mar 2019 11:56:02 +0000 (12:56 +0100)]
bump version to 5.0-49

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agoremove registering 'pve-snapshot-name', now in common
Thomas Lamprecht [Thu, 21 Mar 2019 11:53:45 +0000 (12:53 +0100)]
remove registering 'pve-snapshot-name', now in common

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agofollowup: which lock
Thomas Lamprecht [Thu, 21 Mar 2019 11:53:17 +0000 (12:53 +0100)]
followup: which lock

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 months agoadd lock to vm status
Dominik Csapak [Wed, 20 Mar 2019 10:29:01 +0000 (11:29 +0100)]
add lock to vm status

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 months agobump version to 5.0-48
Thomas Lamprecht [Tue, 19 Mar 2019 12:26:20 +0000 (13:26 +0100)]
bump version to 5.0-48

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>