From 1a0c2f032cc2f8fa6a314c12bd03ecc51654c7ad Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Wed, 19 Sep 2018 13:31:19 +0200 Subject: [PATCH] restore vm: vmgenid: small code cleanup do not use $1 do write out config, if code gets added this may easily get overwritten, as vmgenid is a fixed key just hardcode it. also move the comment to where it actually belongs Signed-off-by: Thomas Lamprecht --- PVE/QemuServer.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 6785b02..c0c63d8 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5565,13 +5565,13 @@ sub restore_update_config_line { } else { print $outfd $line; } - } elsif (($line =~ m/^(vmgenid: )(.*)/)) { - # always generate a new vmgenid + } elsif (($line =~ m/^vmgenid: (.*)/)) { my $vmgenid = $2; if ($vmgenid ne '0') { + # always generate a new vmgenid if there was a valid one setup $vmgenid = generate_uuid(); } - print $outfd $1.$vmgenid."\n"; + print $outfd "vmgenid: $vmgenid\n"; } elsif (($line =~ m/^(smbios1: )(.*)/) && $unique) { my ($uuid, $uuid_str); UUID::generate($uuid); -- 2.39.2