From 48caa553aba68432f43aca58276de2abeb29a236 Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Thu, 23 Apr 2020 12:46:49 +0200 Subject: [PATCH] importovf: die with error when disk file is missing Also add missing '\n' at the end of error messages Signed-off-by: Dominik Csapak --- PVE/QemuServer/OVF.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer/OVF.pm b/PVE/QemuServer/OVF.pm index 536e0eb..dbcc361 100644 --- a/PVE/QemuServer/OVF.pm +++ b/PVE/QemuServer/OVF.pm @@ -213,12 +213,16 @@ ovf:Item[rasd:InstanceID='%s']/rasd:ResourceType", $controller_id); my $ovf_dir = realpath(dirname(File::Spec->rel2abs($ovf))); my $backing_file_path = realpath(join ('/', $ovf_dir, $filepath)); if ($backing_file_path !~ /^\Q${ovf_dir}\E/) { - die "error parsing $filepath, are you using a symlink ?"; + die "error parsing $filepath, are you using a symlink ?\n"; + } + + if (!-e $backing_file_path) { + die "error parsing $filepath, file seems not to exist at $backing_file_path\n"; } my $virtual_size; if ( !($virtual_size = PVE::Storage::file_size_info($backing_file_path)) ) { - die "error parsing $backing_file_path, size seems to be $virtual_size"; + die "error parsing $backing_file_path, size seems to be $virtual_size\n"; } $pve_disk = { -- 2.39.2