From 49a5a0d84b626bef92ed4f1f519d5b1b9d59a64e Mon Sep 17 00:00:00 2001 From: Fabian Ebner Date: Wed, 8 Apr 2020 11:25:11 +0200 Subject: [PATCH] sync_disks: be more verbose if storage_migrate fails If storage_migrate dies, the error message might not include the volume ID or the target storage ID, but those might be good to know. Signed-off-by: Fabian Ebner --- PVE/QemuMigrate.pm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index a048fcb..5ed953a 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -557,8 +557,13 @@ sub sync_disks { 'allow_rename' => !$local_volumes->{$volid}->{is_vmstate}, }; - my $new_volid = PVE::Storage::storage_migrate($storecfg, $volid, $self->{ssh_info}, - $targetsid, $storage_migrate_opts); + my $new_volid = eval { + PVE::Storage::storage_migrate($storecfg, $volid, $self->{ssh_info}, + $targetsid, $storage_migrate_opts); + }; + if (my $err = $@) { + die "storage migration for '$volid' to storage '$targetsid' failed - $err\n"; + } $self->{volume_map}->{$volid} = $new_volid; $self->log('info', "volume '$volid' is '$new_volid' on the target\n"); -- 2.39.2