From 90ff65b63a001e81fc68ce99bc3b0dd53ed04b47 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fabian=20Gr=C3=BCnbichler?= Date: Mon, 20 Apr 2020 11:24:05 +0200 Subject: [PATCH] migrate: simplify replicated_volume loop MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit (no change compared to previous iteration except for readability) Signed-off-by: Fabian Grünbichler --- PVE/QemuMigrate.pm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index b596a92..d90b709 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -710,12 +710,10 @@ sub phase2 { $input .= "nbd_protocol_version: $nbd_protocol_version\n"; my $number_of_online_replicated_volumes = 0; - if ($self->{online_local_volumes}) { - foreach my $volid (keys %{$self->{replicated_volumes}}) { - next if !(grep { $volid eq $_ } @{$self->{online_local_volumes}}); - $number_of_online_replicated_volumes++; - $input .= "replicated_volume: $volid\n"; - } + foreach my $volid (@{$self->{online_local_volumes}}) { + next if !$self->{replicated_volumes}->{$volid}; + $number_of_online_replicated_volumes++; + $input .= "replicated_volume: $volid\n"; } my $target_replicated_volumes = {}; -- 2.39.2