From b57d4863e2165aab83d94b8c897379900bc9d07e Mon Sep 17 00:00:00 2001 From: Stefan Reiter Date: Wed, 6 May 2020 14:17:52 +0200 Subject: [PATCH] cfg2cmd: fix uninitialized value warning on OVMF w/o efidisk It's possible to have a VM with OVMF but without an efidisk, so don't call parse_drive on a potential undef value. Partial revert of 818c3b8d91 ("cfg2cmd: ovmf: code cleanup") Signed-off-by: Stefan Reiter --- PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index cb96b71..0785fd2 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3084,7 +3084,8 @@ sub config_to_command { die "uefi base image '$ovmf_code' not found\n" if ! -f $ovmf_code; my ($path, $format); - if (my $d = parse_drive('efidisk0', $conf->{efidisk0})) { + if (my $efidisk = $conf->{efidisk0}) { + my $d = parse_drive('efidisk0', $efidisk); my ($storeid, $volname) = PVE::Storage::parse_volume_id($d->{file}, 1); $format = $d->{format}; if ($storeid) { -- 2.39.2