From c351659d873a25d287d01fc65060b146414cceb1 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Sat, 11 Nov 2023 15:09:42 +0100 Subject: [PATCH] add some comments for legacy 2MB OVMF image builds Signed-off-by: Thomas Lamprecht --- PVE/QemuServer.pm | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index dbcd568..9811eba 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -86,6 +86,9 @@ my $OVMF = { "$EDK2_FW_BASE/OVMF_CODE_4M.secboot.fd", "$EDK2_FW_BASE/OVMF_VARS_4M.ms.fd", ], + # FIXME: These are legacy 2MB-sized images that modern OVMF doesn't supports to build + # anymore. how can we deperacate this sanely without breaking existing instances, or using + # older backups and snapshot? default => [ "$EDK2_FW_BASE/OVMF_CODE.fd", "$EDK2_FW_BASE/OVMF_VARS.fd", @@ -3343,9 +3346,13 @@ sub get_ovmf_files($$$) { or die "no OVMF images known for architecture '$arch'\n"; my $type = 'default'; - if ($arch ne "aarch64" && defined($efidisk->{efitype}) && $efidisk->{efitype} eq '4m') { - $type = $smm ? "4m" : "4m-no-smm"; - $type .= '-ms' if $efidisk->{'pre-enrolled-keys'}; + if ($arch eq 'x86_64') { + if (defined($efidisk->{efitype}) && $efidisk->{efitype} eq '4m') { + $type = $smm ? "4m" : "4m-no-smm"; + $type .= '-ms' if $efidisk->{'pre-enrolled-keys'}; + } else { + # TODO: log_warn about use of legacy images for x86_64 with Promxox VE 9 + } } my ($ovmf_code, $ovmf_vars) = $types->{$type}->@*; -- 2.39.2