]> git.proxmox.com Git - qemu.git/commitdiff
rng-egd: offset the point when repeatedly read from the buffer
authorAmos Kong <akong@redhat.com>
Thu, 21 Nov 2013 08:42:51 +0000 (16:42 +0800)
committerAnthony Liguori <aliguori@amazon.com>
Thu, 21 Nov 2013 15:55:37 +0000 (07:55 -0800)
The buffer content might be read out more than once, currently
we just repeatedly read the first data block, buffer offset is
missing.

Cc: qemu-stable@nongnu.org
Signed-off-by: Amos Kong <akong@redhat.com>
Message-id: 1385023371-8198-3-git-send-email-akong@redhat.com
Signed-off-by: Anthony Liguori <aliguori@amazon.com>
backends/rng-egd.c

index 6f56f9e4e44ada82992f02a7f6be3b85c718076a..25bb3b453bae50be39d7d69448da94dcaed2f0bf 100644 (file)
@@ -91,12 +91,14 @@ static int rng_egd_chr_can_read(void *opaque)
 static void rng_egd_chr_read(void *opaque, const uint8_t *buf, int size)
 {
     RngEgd *s = RNG_EGD(opaque);
+    size_t buf_offset = 0;
 
     while (size > 0 && s->requests) {
         RngRequest *req = s->requests->data;
         int len = MIN(size, req->size - req->offset);
 
-        memcpy(req->data + req->offset, buf, len);
+        memcpy(req->data + req->offset, buf + buf_offset, len);
+        buf_offset += len;
         req->offset += len;
         size -= len;