From: Vlad Yasevich <vyasevic@redhat.com>
Date: Fri, 15 Nov 2013 17:09:47 +0000 (-0500)
Subject: qom: Fix memory leak in object_property_set_link()
X-Git-Tag: v1.7.0-rc1~18^2
X-Git-Url: https://git.proxmox.com/?p=qemu.git;a=commitdiff_plain;h=2d3aa28cc2cf382aa04cd577e0be542175eea9bd

qom: Fix memory leak in object_property_set_link()

Save the result of the call to object_get_canonical_path()
so we can free it.

Cc: qemu-stable@nongnu.org
Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
Reviewed-by: Amos Kong <akong@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---

diff --git a/qom/object.c b/qom/object.c
index b617f265e..fc19cf676 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -838,8 +838,9 @@ char *object_property_get_str(Object *obj, const char *name,
 void object_property_set_link(Object *obj, Object *value,
                               const char *name, Error **errp)
 {
-    object_property_set_str(obj, object_get_canonical_path(value),
-                            name, errp);
+    gchar *path = object_get_canonical_path(value);
+    object_property_set_str(obj, path, name, errp);
+    g_free(path);
 }
 
 Object *object_property_get_link(Object *obj, const char *name,