]> git.proxmox.com Git - rustc.git/blame - CONTRIBUTING.md
New upstream version 1.30.0+dfsg1
[rustc.git] / CONTRIBUTING.md
CommitLineData
85aaf69f 1# Contributing to Rust
ea8adc8c 2[contributing-to-rust]: #contributing-to-rust
1a4d82fc 3
85aaf69f
SL
4Thank you for your interest in contributing to Rust! There are many ways to
5contribute, and we appreciate all of them. This document is a bit long, so here's
6links to the major sections:
1a4d82fc 7
85aaf69f
SL
8* [Feature Requests](#feature-requests)
9* [Bug Reports](#bug-reports)
7453a54e 10* [The Build System](#the-build-system)
85aaf69f
SL
11* [Pull Requests](#pull-requests)
12* [Writing Documentation](#writing-documentation)
13* [Issue Triage](#issue-triage)
14* [Out-of-tree Contributions](#out-of-tree-contributions)
e9174d1e 15* [Helpful Links and Information](#helpful-links-and-information)
1a4d82fc 16
85aaf69f
SL
17If you have questions, please make a post on [internals.rust-lang.org][internals] or
18hop on [#rust-internals][pound-rust-internals].
1a4d82fc 19
c34b1796 20As a reminder, all contributors are expected to follow our [Code of Conduct][coc].
1a4d82fc 21
ea8adc8c 22[pound-rust-internals]: https://chat.mibbit.com/?server=irc.mozilla.org&channel=%23rust-internals
e9174d1e
SL
23[internals]: https://internals.rust-lang.org
24[coc]: https://www.rust-lang.org/conduct.html
1a4d82fc 25
85aaf69f 26## Feature Requests
ea8adc8c 27[feature-requests]: #feature-requests
1a4d82fc 28
0531ce1d
XL
29To request a change to the way the Rust language works, please head over
30to the [RFCs repository](https://github.com/rust-lang/rfcs) and view the
31[README](https://github.com/rust-lang/rfcs/blob/master/README.md)
32for instructions.
1a4d82fc 33
85aaf69f 34## Bug Reports
ea8adc8c 35[bug-reports]: #bug-reports
1a4d82fc 36
85aaf69f
SL
37While bugs are unfortunate, they're a reality in software. We can't fix what we
38don't know about, so please report liberally. If you're not sure if something
39is a bug or not, feel free to file a bug anyway.
1a4d82fc 40
92a42be0
SL
41**If you believe reporting your bug publicly represents a security risk to Rust users,
42please follow our [instructions for reporting security vulnerabilities](https://www.rust-lang.org/security.html)**.
43
85aaf69f
SL
44If you have the chance, before reporting a bug, please [search existing
45issues](https://github.com/rust-lang/rust/search?q=&type=Issues&utf8=%E2%9C%93),
46as it's possible that someone else has already reported your error. This doesn't
47always work, and sometimes it's hard to know what to search for, so consider this
48extra credit. We won't mind if you accidentally file a duplicate report.
1a4d82fc 49
83c7162d 50Similarly, to help others who encountered the bug find your issue,
94b46f34 51consider filing an issue with a descriptive title, which contains information that might be unique to it.
83c7162d
XL
52This can be the language or compiler feature used, the conditions that trigger the bug,
53or part of the error message if there is any.
54An example could be: **"impossible case reached" on lifetime inference for impl Trait in return position**.
55
85aaf69f
SL
56Opening an issue is as easy as following [this
57link](https://github.com/rust-lang/rust/issues/new) and filling out the fields.
58Here's a template that you can use to file a bug, though it's not necessary to
59use it exactly:
1a4d82fc 60
85aaf69f
SL
61 <short summary of the bug>
62
63 I tried this code:
64
65 <code sample that causes the bug>
66
67 I expected to see this happen: <explanation>
68
69 Instead, this happened: <explanation>
70
71 ## Meta
72
73 `rustc --version --verbose`:
74
75 Backtrace:
76
77All three components are important: what you did, what you expected, what
78happened instead. Please include the output of `rustc --version --verbose`,
79which includes important information about what platform you're on, what
80version of Rust you're using, etc.
81
82Sometimes, a backtrace is helpful, and so including that is nice. To get
54a0048b
SL
83a backtrace, set the `RUST_BACKTRACE` environment variable to a value
84other than `0`. The easiest way
85aaf69f
SL
85to do this is to invoke `rustc` like this:
86
87```bash
88$ RUST_BACKTRACE=1 rustc ...
1a4d82fc
JJ
89```
90
7453a54e 91## The Build System
ea8adc8c 92[the-build-system]: #the-build-system
7453a54e
SL
93
94Rust's build system allows you to bootstrap the compiler, run tests &
95benchmarks, generate documentation, install a fresh build of Rust, and more.
96It's your best friend when working on Rust, allowing you to compile & test
97your contributions before submission.
98
476ff2be
SL
99The build system lives in [the `src/bootstrap` directory][bootstrap] in the
100project root. Our build system is itself written in Rust and is based on Cargo
101to actually build all the compiler's crates. If you have questions on the build
102system internals, try asking in [`#rust-internals`][pound-rust-internals].
7453a54e 103
476ff2be
SL
104[bootstrap]: https://github.com/rust-lang/rust/tree/master/src/bootstrap/
105
7453a54e 106### Configuration
ea8adc8c 107[configuration]: #configuration
7453a54e
SL
108
109Before you can start building the compiler you need to configure the build for
110your system. In most cases, that will just mean using the defaults provided
8bb4bdeb 111for Rust.
7453a54e 112
3b2f2976 113To change configuration, you must copy the file `config.toml.example`
8bb4bdeb
XL
114to `config.toml` in the directory from which you will be running the build, and
115change the settings provided.
116
117There are large number of options provided in this config file that will alter the
118configuration used in the build process. Some options to note:
7453a54e 119
8bb4bdeb 120#### `[llvm]`:
ff7c6d11 121- `assertions = true` = This enables LLVM assertions, which makes LLVM misuse cause an assertion failure instead of weird misbehavior. This also slows down the compiler's runtime by ~20%.
8bb4bdeb 122- `ccache = true` - Use ccache when building llvm
7453a54e 123
8bb4bdeb
XL
124#### `[build]`:
125- `compiler-docs = true` - Build compiler documentation
7453a54e 126
8bb4bdeb 127#### `[rust]`:
ff7c6d11
XL
128- `debuginfo = true` - Build a compiler with debuginfo. Makes building rustc slower, but then you can use a debugger to debug `rustc`.
129- `debuginfo-lines = true` - An alternative to `debuginfo = true` that doesn't let you use a debugger, but doesn't make building rustc slower and still gives you line numbers in backtraces.
83c7162d 130- `debuginfo-tools = true` - Build the extended tools with debuginfo.
ff7c6d11
XL
131- `debug-assertions = true` - Makes the log output of `debug!` work.
132- `optimize = false` - Disable optimizations to speed up compilation of stage1 rust, but makes the stage1 compiler x100 slower.
8bb4bdeb
XL
133
134For more options, the `config.toml` file contains commented out defaults, with
135descriptions of what each option will do.
136
137Note: Previously the `./configure` script was used to configure this
138project. It can still be used, but it's recommended to use a `config.toml`
139file. If you still have a `config.mk` file in your directory - from
140`./configure` - you may need to delete it for `config.toml` to work.
7453a54e 141
476ff2be 142### Building
ea8adc8c
XL
143[building]: #building
144
94b46f34 145A default configuration requires around 3.5 GB of disk space, whereas building a debug configuration may require more than 30 GB.
83c7162d 146
ea8adc8c
XL
147Dependencies
148- [build dependencies](README.md#building-from-source)
149- `gdb` 6.2.0 minimum, 7.1 or later recommended for test builds
476ff2be 150
8bb4bdeb
XL
151The build system uses the `x.py` script to control the build process. This script
152is used to build, test, and document various parts of the compiler. You can
153execute it as:
476ff2be
SL
154
155```sh
156python x.py build
157```
158
159On some systems you can also use the shorter version:
160
161```sh
162./x.py build
163```
164
165To learn more about the driver and top-level targets, you can execute:
166
167```sh
168python x.py --help
169```
170
171The general format for the driver script is:
172
173```sh
174python x.py <command> [<directory>]
175```
176
177Some example commands are `build`, `test`, and `doc`. These will build, test,
178and document the specified directory. The second argument, `<directory>`, is
179optional and defaults to working over the entire compiler. If specified,
180however, only that specific directory will be built. For example:
181
182```sh
183# build the entire compiler
184python x.py build
185
186# build all documentation
187python x.py doc
188
189# run all test suites
190python x.py test
191
192# build only the standard library
193python x.py build src/libstd
194
195# test only one particular test suite
196python x.py test src/test/rustdoc
197
198# build only the stage0 libcore library
199python x.py build src/libcore --stage 0
200```
201
7cac9316 202You can explore the build system through the various `--help` pages for each
476ff2be
SL
203subcommand. For example to learn more about a command you can run:
204
205```
206python x.py build --help
207```
208
209To learn about all possible rules you can execute, run:
210
211```
212python x.py build --help --verbose
213```
214
8bb4bdeb
XL
215Note: Previously `./configure` and `make` were used to build this project.
216They are still available, but `x.py` is the recommended build system.
217
476ff2be 218### Useful commands
ea8adc8c 219[useful-commands]: #useful-commands
476ff2be
SL
220
221Some common invocations of `x.py` are:
222
223- `x.py build --help` - show the help message and explain the subcommand
224- `x.py build src/libtest --stage 1` - build up to (and including) the first
225 stage. For most cases we don't need to build the stage2 compiler, so we can
226 save time by not building it. The stage1 compiler is a fully functioning
227 compiler and (probably) will be enough to determine if your change works as
228 expected.
229- `x.py build src/rustc --stage 1` - This will build just rustc, without libstd.
230 This is the fastest way to recompile after you changed only rustc source code.
231 Note however that the resulting rustc binary won't have a stdlib to link
232 against by default. You can build libstd once with `x.py build src/libstd`,
8bb4bdeb 233 but it is only guaranteed to work if recompiled, so if there are any issues
476ff2be
SL
234 recompile it.
235- `x.py test` - build the full compiler & run all tests (takes a while). This
7453a54e
SL
236 is what gets run by the continuous integration system against your pull
237 request. You should run this before submitting to make sure your tests pass
238 & everything builds in the correct manner.
476ff2be
SL
239- `x.py test src/libstd --stage 1` - test the standard library without
240 recompiling stage 2.
241- `x.py test src/test/run-pass --test-args TESTNAME` - Run a matching set of
242 tests.
54a0048b
SL
243 - `TESTNAME` should be a substring of the tests to match against e.g. it could
244 be the fully qualified test name, or just a part of it.
7453a54e
SL
245 `TESTNAME=collections::hash::map::test_map::test_capacity_not_less_than_len`
246 or `TESTNAME=test_capacity_not_less_than_len`.
476ff2be
SL
247- `x.py test src/test/run-pass --stage 1 --test-args <substring-of-test-name>` -
248 Run a single rpass test with the stage1 compiler (this will be quicker than
249 running the command above as we only build the stage1 compiler, not the entire
250 thing). You can also leave off the directory argument to run all stage1 test
251 types.
252- `x.py test src/libcore --stage 1` - Run stage1 tests in `libcore`.
253- `x.py test src/tools/tidy` - Check that the source code is in compliance with
254 Rust's style guidelines. There is no official document describing Rust's full
255 guidelines as of yet, but basic rules like 4 spaces for indentation and no
256 more than 99 characters in a single line should be kept in mind when writing
257 code.
ea8adc8c
XL
258
259### Using your local build
260[using-local-build]: #using-local-build
261
262If you use Rustup to manage your rust install, it has a feature called ["custom
263toolchains"][toolchain-link] that you can use to access your newly-built compiler
264without having to install it to your system or user PATH. If you've run `python
265x.py build`, then you can add your custom rustc to a new toolchain like this:
266
267[toolchain-link]: https://github.com/rust-lang-nursery/rustup.rs#working-with-custom-toolchains-and-local-builds
268
269```
270rustup toolchain link <name> build/<host-triple>/stage2
271```
272
273Where `<host-triple>` is the build triple for the host (the triple of your
274computer, by default), and `<name>` is the name for your custom toolchain. (If you
275added `--stage 1` to your build command, the compiler will be in the `stage1`
276folder instead.) You'll only need to do this once - it will automatically point
277to the latest build you've done.
278
279Once this is set up, you can use your custom toolchain just like any other. For
280example, if you've named your toolchain `local`, running `cargo +local build` will
281compile a project with your custom rustc, setting `rustup override set local` will
282override the toolchain for your current directory, and `cargo +local doc` will use
283your custom rustc and rustdoc to generate docs. (If you do this with a `--stage 1`
284build, you'll need to build rustdoc specially, since it's not normally built in
285stage 1. `python x.py build --stage 1 src/libstd src/tools/rustdoc` will build
286rustdoc and libstd, which will allow rustdoc to be run with that toolchain.)
7453a54e 287
ff7c6d11
XL
288### Out-of-tree builds
289[out-of-tree-builds]: #out-of-tree-builds
290
291Rust's `x.py` script fully supports out-of-tree builds - it looks for
292the Rust source code from the directory `x.py` was found in, but it
293reads the `config.toml` configuration file from the directory it's
294run in, and places all build artifacts within a subdirectory named `build`.
295
296This means that if you want to do an out-of-tree build, you can just do it:
297```
298$ cd my/build/dir
299$ cp ~/my-config.toml config.toml # Or fill in config.toml otherwise
300$ path/to/rust/x.py build
301...
302$ # This will use the Rust source code in `path/to/rust`, but build
303$ # artifacts will now be in ./build
304```
305
306It's absolutely fine to have multiple build directories with different
307`config.toml` configurations using the same code.
308
85aaf69f 309## Pull Requests
ea8adc8c 310[pull-requests]: #pull-requests
1a4d82fc 311
85aaf69f 312Pull requests are the primary mechanism we use to change Rust. GitHub itself
2c00a5a8 313has some [great documentation][about-pull-requests] on using the Pull Request feature.
3b2f2976
XL
314We use the "fork and pull" model [described here][development-models], where
315contributors push changes to their personal fork and create pull requests to
316bring those changes into the source repository.
1a4d82fc 317
2c00a5a8 318[about-pull-requests]: https://help.github.com/articles/about-pull-requests/
3b2f2976 319[development-models]: https://help.github.com/articles/about-collaborative-development-models/
85aaf69f
SL
320
321Please make pull requests against the `master` branch.
322
8bb4bdeb
XL
323Compiling all of `./x.py test` can take a while. When testing your pull request,
324consider using one of the more specialized `./x.py` targets to cut down on the
c1a9b12d
SL
325amount of time you have to wait. You need to have built the compiler at least
326once before running these will work, but that’s only one full build rather than
327one each time.
328
476ff2be 329 $ python x.py test --stage 1
c1a9b12d
SL
330
331is one such example, which builds just `rustc`, and then runs the tests. If
332you’re adding something to the standard library, try
333
476ff2be 334 $ python x.py test src/libstd --stage 1
c1a9b12d 335
9e0c209e
SL
336Please make sure your pull request is in compliance with Rust's style
337guidelines by running
338
476ff2be 339 $ python x.py test src/tools/tidy
9e0c209e
SL
340
341Make this check before every pull request (and every new commit in a pull
342request) ; you can add [git hooks](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks)
343before every push to make sure you never forget to make this check.
344
85aaf69f 345All pull requests are reviewed by another person. We have a bot,
62682a34
SL
346@rust-highfive, that will automatically assign a random person to review your
347request.
85aaf69f
SL
348
349If you want to request that a specific person reviews your pull request,
350you can add an `r?` to the message. For example, Steve usually reviews
351documentation changes. So if you were to make a documentation change, add
352
353 r? @steveklabnik
354
355to the end of the message, and @rust-highfive will assign @steveklabnik instead
356of a random person. This is entirely optional.
357
358After someone has reviewed your pull request, they will leave an annotation
359on the pull request with an `r+`. It will look something like this:
360
361 @bors: r+ 38fe8d2
362
363This tells @bors, our lovable integration bot, that your pull request has
364been approved. The PR then enters the [merge queue][merge-queue], where @bors
365will run all the tests on every platform we support. If it all works out,
366@bors will merge your code into `master` and close the pull request.
367
3b2f2976 368[merge-queue]: https://buildbot2.rust-lang.org/homu/queue/rust
85aaf69f 369
c1a9b12d 370Speaking of tests, Rust has a comprehensive test suite. More information about
b7449926 371it can be found [here][rctd].
c1a9b12d 372
ea8adc8c
XL
373### External Dependencies
374[external-dependencies]: #external-dependencies
375
376Currently building Rust will also build the following external projects:
377
378* [clippy](https://github.com/rust-lang-nursery/rust-clippy)
379* [miri](https://github.com/solson/miri)
ff7c6d11
XL
380* [rustfmt](https://github.com/rust-lang-nursery/rustfmt)
381* [rls](https://github.com/rust-lang-nursery/rls/)
ea8adc8c 382
ff7c6d11
XL
383We allow breakage of these tools in the nightly channel. Maintainers of these
384projects will be notified of the breakages and should fix them as soon as
385possible.
ea8adc8c 386
ff7c6d11 387After the external is fixed, one could add the changes with
ea8adc8c 388
ff7c6d11 389```sh
ea8adc8c
XL
390git add path/to/submodule
391```
392
393outside the submodule.
394
ff7c6d11 395In order to prepare your tool-fixing PR, you can run the build locally by doing
abe05a73
XL
396`./x.py build src/tools/TOOL`. If you will be editing the sources
397there, you may wish to set `submodules = false` in the `config.toml`
398to prevent `x.py` from resetting to the original branch.
399
ff7c6d11
XL
400Breakage is not allowed in the beta and stable channels, and must be addressed
401before the PR is merged.
402
abe05a73
XL
403#### Breaking Tools Built With The Compiler
404[breaking-tools-built-with-the-compiler]: #breaking-tools-built-with-the-compiler
405
406Rust's build system builds a number of tools that make use of the
b7449926
XL
407internals of the compiler. This includes
408[Clippy](https://github.com/rust-lang-nursery/rust-clippy),
abe05a73
XL
409[RLS](https://github.com/rust-lang-nursery/rls) and
410[rustfmt](https://github.com/rust-lang-nursery/rustfmt). If these tools
411break because of your changes, you may run into a sort of "chicken and egg"
412problem. These tools rely on the latest compiler to be built so you can't update
413them to reflect your changes to the compiler until those changes are merged into
414the compiler. At the same time, you can't get your changes merged into the compiler
415because the rust-lang/rust build won't pass until those tools build and pass their
416tests.
417
418That means that, in the default state, you can't update the compiler without first
419fixing rustfmt, rls and the other tools that the compiler builds.
420
ff7c6d11
XL
421Luckily, a feature was [added to Rust's build](https://github.com/rust-lang/rust/issues/45861)
422to make all of this easy to handle. The idea is that we allow these tools to be "broken",
abe05a73
XL
423so that the rust-lang/rust build passes without trying to build them, then land the change
424in the compiler, wait for a nightly, and go update the tools that you broke. Once you're done
ff7c6d11
XL
425and the tools are working again, you go back in the compiler and update the tools
426so they can be distributed again.
abe05a73
XL
427
428This should avoid a bunch of synchronization dances and is also much easier on contributors as
429there's no need to block on rls/rustfmt/other tools changes going upstream.
430
431Here are those same steps in detail:
432
4331. (optional) First, if it doesn't exist already, create a `config.toml` by copying
434 `config.toml.example` in the root directory of the Rust repository.
435 Set `submodules = false` in the `[build]` section. This will prevent `x.py`
436 from resetting to the original branch after you make your changes. If you
437 need to [update any submodules to their latest versions][updating-submodules],
438 see the section of this file about that for more information.
4392. (optional) Run `./x.py test src/tools/rustfmt` (substituting the submodule
440 that broke for `rustfmt`). Fix any errors in the submodule (and possibly others).
4413. (optional) Make commits for your changes and send them to upstream repositories as a PR.
4424. (optional) Maintainers of these submodules will **not** merge the PR. The PR can't be
443 merged because CI will be broken. You'll want to write a message on the PR referencing
444 your change, and how the PR should be merged once your change makes it into a nightly.
ff7c6d11
XL
4455. Wait for your PR to merge.
4466. Wait for a nightly
4477. (optional) Help land your PR on the upstream repository now that your changes are in nightly.
4488. (optional) Send a PR to rust-lang/rust updating the submodule.
abe05a73
XL
449
450#### Updating submodules
451[updating-submodules]: #updating-submodules
452
453These instructions are specific to updating `rustfmt`, however they may apply
454to the other submodules as well. Please help by improving these instructions
ff7c6d11 455if you find any discrepancies or special cases that need to be addressed.
abe05a73
XL
456
457To update the `rustfmt` submodule, start by running the appropriate
458[`git submodule` command](https://git-scm.com/book/en/v2/Git-Tools-Submodules).
459For example, to update to the latest commit on the remote master branch,
460you may want to run:
461```
462git submodule update --remote src/tools/rustfmt
463```
464If you run `./x.py build` now, and you are lucky, it may just work. If you see
465an error message about patches that did not resolve to any crates, you will need
466to complete a few more steps which are outlined with their rationale below.
467
468*(This error may change in the future to include more information.)*
469```
470error: failed to resolve patches for `https://github.com/rust-lang-nursery/rustfmt`
471
472Caused by:
473 patch for `rustfmt-nightly` in `https://github.com/rust-lang-nursery/rustfmt` did not resolve to any crates
474failed to run: ~/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path ~/rust/src/bootstrap/Cargo.toml
475```
476
477If you haven't used the `[patch]`
478section of `Cargo.toml` before, there is [some relevant documentation about it
479in the cargo docs](http://doc.crates.io/manifest.html#the-patch-section). In
ff7c6d11 480addition to that, you should read the
abe05a73
XL
481[Overriding dependencies](http://doc.crates.io/specifying-dependencies.html#overriding-dependencies)
482section of the documentation as well.
483
484Specifically, the following [section in Overriding dependencies](http://doc.crates.io/specifying-dependencies.html#testing-a-bugfix) reveals what the problem is:
485
486> Next up we need to ensure that our lock file is updated to use this new version of uuid so our project uses the locally checked out copy instead of one from crates.io. The way [patch] works is that it'll load the dependency at ../path/to/uuid and then whenever crates.io is queried for versions of uuid it'll also return the local version.
ff7c6d11 487>
abe05a73
XL
488> This means that the version number of the local checkout is significant and will affect whether the patch is used. Our manifest declared uuid = "1.0" which means we'll only resolve to >= 1.0.0, < 2.0.0, and Cargo's greedy resolution algorithm also means that we'll resolve to the maximum version within that range. Typically this doesn't matter as the version of the git repository will already be greater or match the maximum version published on crates.io, but it's important to keep this in mind!
489
490This says that when we updated the submodule, the version number in our
491`src/tools/rustfmt/Cargo.toml` changed. The new version is different from
492the version in `Cargo.lock`, so the build can no longer continue.
493
494To resolve this, we need to update `Cargo.lock`. Luckily, cargo provides a
495command to do this easily.
496
497First, go into the `src/` directory since that is where `Cargo.toml` is in
498the rust repository. Then run, `cargo update -p rustfmt-nightly` to solve
499the problem.
500
501```
502$ cd src
503$ cargo update -p rustfmt-nightly
504```
505
506This should change the version listed in `src/Cargo.lock` to the new version you updated
507the submodule to. Running `./x.py build` should work now.
ea8adc8c 508
85aaf69f 509## Writing Documentation
ea8adc8c 510[writing-documentation]: #writing-documentation
85aaf69f
SL
511
512Documentation improvements are very welcome. The source of `doc.rust-lang.org`
513is located in `src/doc` in the tree, and standard API documentation is generated
514from the source code itself.
515
c1a9b12d
SL
516Documentation pull requests function in the same way as other pull requests,
517though you may see a slightly different form of `r+`:
85aaf69f
SL
518
519 @bors: r+ 38fe8d2 rollup
520
521That additional `rollup` tells @bors that this change is eligible for a 'rollup'.
522To save @bors some work, and to get small changes through more quickly, when
523@bors attempts to merge a commit that's rollup-eligible, it will also merge
524the other rollup-eligible patches too, and they'll get tested and merged at
525the same time.
526
cc61c64b 527To find documentation-related issues, sort by the [T-doc label][tdoc].
62682a34 528
cc61c64b
XL
529[tdoc]: https://github.com/rust-lang/rust/issues?q=is%3Aopen%20is%3Aissue%20label%3AT-doc
530
531You can find documentation style guidelines in [RFC 1574][rfc1574].
532
533[rfc1574]: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md#appendix-a-full-conventions-text
62682a34 534
8bb4bdeb 535In many cases, you don't need a full `./x.py doc`. You can use `rustdoc` directly
b039eaaf
SL
536to check small fixes. For example, `rustdoc src/doc/reference.md` will render
537reference to `doc/reference.html`. The CSS might be messed up, but you can
9e0c209e 538verify that the HTML is right.
b039eaaf 539
85aaf69f 540## Issue Triage
ea8adc8c 541[issue-triage]: #issue-triage
85aaf69f
SL
542
543Sometimes, an issue will stay open, even though the bug has been fixed. And
544sometimes, the original bug may go stale because something has changed in the
545meantime.
546
547It can be helpful to go through older bug reports and make sure that they are
548still valid. Load up an older issue, double check that it's still true, and
62682a34
SL
549leave a comment letting us know if it is or is not. The [least recently
550updated sort][lru] is good for finding issues like this.
551
552Contributors with sufficient permissions on the Rust repo can help by adding
553labels to triage issues:
554
555* Yellow, **A**-prefixed labels state which **area** of the project an issue
b039eaaf 556 relates to.
62682a34 557
9cc50fc6 558* Magenta, **B**-prefixed labels identify bugs which are **blockers**.
62682a34 559
ea8adc8c
XL
560* Dark blue, **beta-** labels track changes which need to be backported into
561 the beta branches.
562
563* Light purple, **C**-prefixed labels represent the **category** of an issue.
564
62682a34
SL
565* Green, **E**-prefixed labels explain the level of **experience** necessary
566 to fix the issue.
567
ea8adc8c
XL
568* The dark blue **final-comment-period** label marks bugs that are using the
569 RFC signoff functionality of [rfcbot][rfcbot] and are currenty in the final
570 comment period.
571
62682a34
SL
572* Red, **I**-prefixed labels indicate the **importance** of the issue. The
573 [I-nominated][inom] label indicates that an issue has been nominated for
b039eaaf 574 prioritizing at the next triage meeting.
62682a34 575
ea8adc8c
XL
576* The purple **metabug** label marks lists of bugs collected by other
577 categories.
578
579* Purple gray, **O**-prefixed labels are the **operating system** or platform
580 that this issue is specific to.
581
62682a34
SL
582* Orange, **P**-prefixed labels indicate a bug's **priority**. These labels
583 are only assigned during triage meetings, and replace the [I-nominated][inom]
b039eaaf 584 label.
62682a34 585
ea8adc8c
XL
586* The gray **proposed-final-comment-period** label marks bugs that are using
587 the RFC signoff functionality of [rfcbot][rfcbot] and are currently awaiting
588 signoff of all team members in order to enter the final comment period.
62682a34 589
ea8adc8c
XL
590* Pink, **regression**-prefixed labels track regressions from stable to the
591 release channels.
b039eaaf 592
ea8adc8c
XL
593* The light orange **relnotes** label marks issues that should be documented in
594 the release notes of the next release.
595
596* Gray, **S**-prefixed labels are used for tracking the **status** of pull
597 requests.
598
599* Blue, **T**-prefixed bugs denote which **team** the issue belongs to.
62682a34 600
b039eaaf 601If you're looking for somewhere to start, check out the [E-easy][eeasy] tag.
85aaf69f 602
62682a34
SL
603[inom]: https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AI-nominated
604[eeasy]: https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AE-easy
85aaf69f 605[lru]: https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-asc
0531ce1d 606[rfcbot]: https://github.com/anp/rfcbot-rs/
85aaf69f
SL
607
608## Out-of-tree Contributions
ea8adc8c 609[out-of-tree-contributions]: #out-of-tree-contributions
85aaf69f
SL
610
611There are a number of other ways to contribute to Rust that don't deal with
612this repository.
613
614Answer questions in [#rust][pound-rust], or on [users.rust-lang.org][users],
615or on [StackOverflow][so].
616
617Participate in the [RFC process](https://github.com/rust-lang/rfcs).
618
619Find a [requested community library][community-library], build it, and publish
620it to [Crates.io](http://crates.io). Easier said than done, but very, very
621valuable!
1a4d82fc 622
85aaf69f 623[pound-rust]: http://chat.mibbit.com/?server=irc.mozilla.org&channel=%23rust
e9174d1e 624[users]: https://users.rust-lang.org/
85aaf69f
SL
625[so]: http://stackoverflow.com/questions/tagged/rust
626[community-library]: https://github.com/rust-lang/rfcs/labels/A-community-library
e9174d1e
SL
627
628## Helpful Links and Information
ea8adc8c 629[helpful-info]: #helpful-info
e9174d1e
SL
630
631For people new to Rust, and just starting to contribute, or even for
632more seasoned developers, some useful places to look for information
633are:
634
0531ce1d 635* The [rustc guide] contains information about how various parts of the compiler work
ea8adc8c 636* [Rust Forge][rustforge] contains additional documentation, including write-ups of how to achieve common tasks
e9174d1e
SL
637* The [Rust Internals forum][rif], a place to ask questions and
638 discuss Rust's internals
639* The [generated documentation for rust's compiler][gdfrustc]
b039eaaf 640* The [rust reference][rr], even though it doesn't specifically talk about Rust's internals, it's a great resource nonetheless
e9174d1e
SL
641* Although out of date, [Tom Lee's great blog article][tlgba] is very helpful
642* [rustaceans.org][ro] is helpful, but mostly dedicated to IRC
643* The [Rust Compiler Testing Docs][rctd]
b039eaaf
SL
644* For @bors, [this cheat sheet][cheatsheet] is helpful (Remember to replace `@homu` with `@bors` in the commands that you use.)
645* **Google!** ([search only in Rust Documentation][gsearchdocs] to find types, traits, etc. quickly)
e9174d1e
SL
646* Don't be afraid to ask! The Rust community is friendly and helpful.
647
0531ce1d 648[rustc guide]: https://rust-lang-nursery.github.io/rustc-guide/about-this-guide.html
e9174d1e 649[gdfrustc]: http://manishearth.github.io/rust-internals-docs/rustc/
9cc50fc6 650[gsearchdocs]: https://www.google.com/search?q=site:doc.rust-lang.org+your+query+here
e9174d1e
SL
651[rif]: http://internals.rust-lang.org
652[rr]: https://doc.rust-lang.org/book/README.html
ea8adc8c 653[rustforge]: https://forge.rust-lang.org/
a7813a04 654[tlgba]: http://tomlee.co/2014/04/a-more-detailed-tour-of-the-rust-compiler/
e9174d1e 655[ro]: http://www.rustaceans.org/
b7449926 656[rctd]: https://rust-lang-nursery.github.io/rustc-guide/tests/intro.html
3b2f2976 657[cheatsheet]: https://buildbot2.rust-lang.org/homu/