]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/blame - Documentation/stable_kernel_rules.txt
Documentation/kernel-docs.txt: convert it to ReST markup
[mirror_ubuntu-zesty-kernel.git] / Documentation / stable_kernel_rules.txt
CommitLineData
5fe270a4
MCC
1Everything you ever wanted to know about Linux -stable releases
2===============================================================
fc185d95 3
e48e9909
JJ
4Rules on what kind of patches are accepted, and which ones are not, into the
5"-stable" tree:
fc185d95
GKH
6
7 - It must be obviously correct and tested.
84eb8d06 8 - It cannot be bigger than 100 lines, with context.
fc185d95
GKH
9 - It must fix only one thing.
10 - It must fix a real bug that bothers people (not a, "This could be a
e48e9909 11 problem..." type thing).
fc185d95
GKH
12 - It must fix a problem that causes a build error (but not for things
13 marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
e48e9909
JJ
14 security issue, or some "oh, that's not good" issue. In short, something
15 critical.
8191e0d9
MG
16 - Serious issues as reported by a user of a distribution kernel may also
17 be considered if they fix a notable performance or interactivity issue.
18 As these fixes are not as obvious and have a higher risk of a subtle
19 regression they should only be submitted by a distribution kernel
20 maintainer and include an addendum linking to a bugzilla entry if it
21 exists and additional information on the user-visible impact.
79cd80a1 22 - New device IDs and quirks are also accepted.
e48e9909
JJ
23 - No "theoretical race condition" issues, unless an explanation of how the
24 race can be exploited is also provided.
84eb8d06 25 - It cannot contain any "trivial" fixes in it (spelling changes,
e48e9909 26 whitespace cleanups, etc).
e48e9909 27 - It must follow the Documentation/SubmittingPatches rules.
959fb1c5 28 - It or an equivalent fix must already exist in Linus' tree (upstream).
fc185d95
GKH
29
30
5fe270a4
MCC
31Procedure for submitting patches to the -stable tree
32----------------------------------------------------
fc185d95 33
b76fc285
DC
34 - If the patch covers files in net/ or drivers/net please follow netdev stable
35 submission guidelines as described in
36 Documentation/networking/netdev-FAQ.txt
5de61e7a
BN
37 - Security patches should not be handled (solely) by the -stable review
38 process but should follow the procedures in Documentation/SecurityBugs.
39
5fe270a4
MCC
40For all other submissions, choose one of the following procedures
41-----------------------------------------------------------------
5de61e7a 42
5fe270a4
MCC
43.. _option_1:
44
45Option 1
46********
47
48To have the patch automatically included in the stable tree, add the tag
49
50.. code-block:: none
5de61e7a 51
5fa22429 52 Cc: stable@vger.kernel.org
5de61e7a 53
5fe270a4
MCC
54in the sign-off area. Once the patch is merged it will be applied to
55the stable tree without anything else needing to be done by the author
56or subsystem maintainer.
57
58.. _option_2:
5de61e7a 59
5fe270a4
MCC
60Option 2
61********
5de61e7a 62
5fe270a4
MCC
63After the patch has been merged to Linus' tree, send an email to
64stable@vger.kernel.org containing the subject of the patch, the commit ID,
65why you think it should be applied, and what kernel version you wish it to
66be applied to.
5de61e7a 67
5fe270a4 68.. _option_3:
5de61e7a 69
5fe270a4
MCC
70Option 3
71********
bde1b294 72
5fe270a4
MCC
73Send the patch, after verifying that it follows the above rules, to
74stable@vger.kernel.org. You must note the upstream commit ID in the
75changelog of your submission, as well as the kernel version you wish
76it to be applied to.
77
78:ref:`option_1` is **strongly** preferred, is the easiest and most common.
79:ref:`option_2` and :ref:`option_3` are more useful if the patch isn't deemed
80worthy at the time it is applied to a public git tree (for instance, because
81it deserves more regression testing first). :ref:`option_3` is especially
82useful if the patch needs some special handling to apply to an older kernel
83(e.g., if API's have changed in the meantime).
84
85Note that for :ref:`option_3`, if the patch deviates from the original
86upstream patch (for example because it had to be backported) this must be very
87clearly documented and justified in the patch description.
bde1b294
CD
88
89The upstream commit ID must be specified with a separate line above the commit
90text, like this:
91
5fe270a4
MCC
92.. code-block:: none
93
bde1b294 94 commit <sha1> upstream.
5de61e7a
BN
95
96Additionally, some patches submitted via Option 1 may have additional patch
97prerequisites which can be cherry-picked. This can be specified in the following
98format in the sign-off area:
8e9b9362 99
5fe270a4
MCC
100.. code-block:: none
101
2584f521
PG
102 Cc: <stable@vger.kernel.org> # 3.3.x: a1f84a3: sched: Check for idle
103 Cc: <stable@vger.kernel.org> # 3.3.x: 1b9508f: sched: Rate-limit newidle
104 Cc: <stable@vger.kernel.org> # 3.3.x: fd21073: sched: Fix affinity logic
105 Cc: <stable@vger.kernel.org> # 3.3.x
5fe270a4
MCC
106 Signed-off-by: Ingo Molnar <mingo@elte.hu>
107
108The tag sequence has the meaning of:
109
110.. code-block:: none
8e9b9362 111
8e9b9362
SAS
112 git cherry-pick a1f84a3
113 git cherry-pick 1b9508f
114 git cherry-pick fd21073
115 git cherry-pick <this commit>
116
fdc81b79
DD
117Also, some patches may have kernel version prerequisites. This can be
118specified in the following format in the sign-off area:
119
5fe270a4
MCC
120.. code-block:: none
121
f902493a 122 Cc: <stable@vger.kernel.org> # 3.3.x-
fdc81b79 123
5fe270a4
MCC
124The tag has the meaning of:
125
126.. code-block:: none
127
fdc81b79
DD
128 git cherry-pick <this commit>
129
5fe270a4 130For each "-stable" tree starting with the specified version.
fdc81b79 131
5de61e7a
BN
132Following the submission:
133
e48e9909
JJ
134 - The sender will receive an ACK when the patch has been accepted into the
135 queue, or a NAK if the patch is rejected. This response might take a few
136 days, according to the developer's schedules.
137 - If accepted, the patch will be added to the -stable queue, for review by
46cdf871 138 other developers and by the relevant subsystem maintainer.
fc185d95
GKH
139
140
5fe270a4
MCC
141Review cycle
142------------
fc185d95 143
e48e9909
JJ
144 - When the -stable maintainers decide for a review cycle, the patches will be
145 sent to the review committee, and the maintainer of the affected area of
146 the patch (unless the submitter is the maintainer of the area) and CC: to
147 the linux-kernel mailing list.
148 - The review committee has 48 hours in which to ACK or NAK the patch.
fc185d95 149 - If the patch is rejected by a member of the committee, or linux-kernel
e48e9909
JJ
150 members object to the patch, bringing up issues that the maintainers and
151 members did not realize, the patch will be dropped from the queue.
152 - At the end of the review cycle, the ACKed patches will be added to the
153 latest -stable release, and a new -stable release will happen.
154 - Security patches will be accepted into the -stable tree directly from the
155 security kernel team, and not go through the normal review cycle.
fc185d95
GKH
156 Contact the kernel security team for more details on this procedure.
157
5fe270a4
MCC
158Trees
159-----
2584f521
PG
160
161 - The queues of patches, for both completed versions and in progress
162 versions can be found at:
5fe270a4 163
2584f521 164 http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git
5fe270a4 165
2584f521
PG
166 - The finalized and tagged releases of all stable kernels can be found
167 in separate branches per version at:
5fe270a4 168
2584f521
PG
169 http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git
170
fc185d95 171
5fe270a4
MCC
172Review committee
173----------------
fc185d95 174
e48e9909
JJ
175 - This is made up of a number of kernel developers who have volunteered for
176 this task, and a few that haven't.