]> git.proxmox.com Git - mirror_frr.git/blame - bgpd/bgp_io.c
Revert "lib: add ringbuf socket read function"
[mirror_frr.git] / bgpd / bgp_io.c
CommitLineData
958b450c 1/* BGP I/O.
51abb4b4 2 * Implements packet I/O in a pthread.
958b450c 3 * Copyright (C) 2017 Cumulus Networks
51abb4b4 4 * Quentin Young
958b450c
QY
5 *
6 * This program is free software; you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License as published by
8 * the Free Software Foundation; either version 2 of the License, or
9 * (at your option) any later version.
10 *
11 * This program is distributed in the hope that it will be useful, but
12 * WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * General Public License for more details.
15 *
16 * You should have received a copy of the GNU General Public License
17 * along with this program; see the file COPYING; if not, write to the
18 * Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
19 * MA 02110-1301 USA
56257a44
QY
20 */
21
95158b0c 22/* clang-format off */
42cf651e 23#include <zebra.h>
95158b0c 24#include <pthread.h> // for pthread_mutex_unlock, pthread_mutex_lock
093279cd 25#include <sys/uio.h> // for writev
56257a44 26
1ac267a2 27#include "frr_pthread.h"
95158b0c
QY
28#include "linklist.h" // for list_delete, list_delete_all_node, lis...
29#include "log.h" // for zlog_debug, safe_strerror, zlog_err
30#include "memory.h" // for MTYPE_TMP, XCALLOC, XFREE
31#include "network.h" // for ERRNO_IO_RETRY
32#include "stream.h" // for stream_get_endp, stream_getw_from, str...
74ffbfe6 33#include "ringbuf.h" // for ringbuf_remain, ringbuf_peek, ringbuf_...
50478845 34#include "thread.h" // for THREAD_OFF, THREAD_ARG, thread...
95158b0c 35#include "zassert.h" // for assert
56257a44 36
42cf651e 37#include "bgpd/bgp_io.h"
95158b0c 38#include "bgpd/bgp_debug.h" // for bgp_debug_neighbor_events, bgp_type_str
14454c9f 39#include "bgpd/bgp_errors.h" // for expanded error reference information
95158b0c
QY
40#include "bgpd/bgp_fsm.h" // for BGP_EVENT_ADD, bgp_event
41#include "bgpd/bgp_packet.h" // for bgp_notify_send_with_data, bgp_notify...
c7bb4f00 42#include "bgpd/bgp_trace.h" // for frrtraces
95158b0c
QY
43#include "bgpd/bgpd.h" // for peer, BGP_MARKER_SIZE, bgp_master, bm
44/* clang-format on */
56257a44 45
424ab01d
QY
46/* forward declarations */
47static uint16_t bgp_write(struct peer *);
6af96fa3 48static uint16_t bgp_read(struct peer *peer, int *code_p);
424ab01d
QY
49static int bgp_process_writes(struct thread *);
50static int bgp_process_reads(struct thread *);
51static bool validate_header(struct peer *);
56257a44 52
424ab01d 53/* generic i/o status codes */
95158b0c
QY
54#define BGP_IO_TRANS_ERR (1 << 0) // EAGAIN or similar occurred
55#define BGP_IO_FATAL_ERR (1 << 1) // some kind of fatal TCP error
56257a44 56
a715eab3 57/* Thread external API ----------------------------------------------------- */
56257a44 58
424ab01d 59void bgp_writes_on(struct peer *peer)
56257a44 60{
1ac267a2 61 struct frr_pthread *fpt = bgp_pth_io;
a715eab3 62 assert(fpt->running);
f09a656d 63
424ab01d
QY
64 assert(peer->status != Deleted);
65 assert(peer->obuf);
66 assert(peer->ibuf);
67 assert(peer->ibuf_work);
387f984e
QY
68 assert(!peer->t_connect_check_r);
69 assert(!peer->t_connect_check_w);
424ab01d 70 assert(peer->fd);
56257a44 71
b750b0ba
QY
72 thread_add_write(fpt->master, bgp_process_writes, peer, peer->fd,
73 &peer->t_write);
74 SET_FLAG(peer->thread_flags, PEER_THREAD_WRITES_ON);
424ab01d 75}
56257a44 76
424ab01d
QY
77void bgp_writes_off(struct peer *peer)
78{
1ac267a2 79 struct frr_pthread *fpt = bgp_pth_io;
a715eab3 80 assert(fpt->running);
151044ce 81
b750b0ba
QY
82 thread_cancel_async(fpt->master, &peer->t_write, NULL);
83 THREAD_OFF(peer->t_generate_updgrp_packets);
56257a44 84
b750b0ba 85 UNSET_FLAG(peer->thread_flags, PEER_THREAD_WRITES_ON);
56257a44
QY
86}
87
424ab01d 88void bgp_reads_on(struct peer *peer)
56257a44 89{
1ac267a2 90 struct frr_pthread *fpt = bgp_pth_io;
a715eab3 91 assert(fpt->running);
f09a656d 92
424ab01d
QY
93 assert(peer->status != Deleted);
94 assert(peer->ibuf);
95 assert(peer->fd);
96 assert(peer->ibuf_work);
424ab01d 97 assert(peer->obuf);
387f984e
QY
98 assert(!peer->t_connect_check_r);
99 assert(!peer->t_connect_check_w);
424ab01d
QY
100 assert(peer->fd);
101
b750b0ba
QY
102 thread_add_read(fpt->master, bgp_process_reads, peer, peer->fd,
103 &peer->t_read);
104
105 SET_FLAG(peer->thread_flags, PEER_THREAD_READS_ON);
56257a44
QY
106}
107
424ab01d 108void bgp_reads_off(struct peer *peer)
56257a44 109{
1ac267a2 110 struct frr_pthread *fpt = bgp_pth_io;
a715eab3 111 assert(fpt->running);
151044ce 112
b750b0ba
QY
113 thread_cancel_async(fpt->master, &peer->t_read, NULL);
114 THREAD_OFF(peer->t_process_packet);
56257a44 115
b750b0ba 116 UNSET_FLAG(peer->thread_flags, PEER_THREAD_READS_ON);
56257a44
QY
117}
118
a715eab3 119/* Thread internal functions ----------------------------------------------- */
51abb4b4 120
a715eab3 121/*
51abb4b4 122 * Called from I/O pthread when a file descriptor has become ready for writing.
424ab01d
QY
123 */
124static int bgp_process_writes(struct thread *thread)
56257a44 125{
424ab01d
QY
126 static struct peer *peer;
127 peer = THREAD_ARG(thread);
128 uint16_t status;
b750b0ba 129 bool reschedule;
bbac44ac 130 bool fatal = false;
424ab01d
QY
131
132 if (peer->fd < 0)
133 return -1;
134
1ac267a2 135 struct frr_pthread *fpt = bgp_pth_io;
424ab01d 136
00dffa8c 137 frr_with_mutex(&peer->io_mtx) {
424ab01d
QY
138 status = bgp_write(peer);
139 reschedule = (stream_fifo_head(peer->obuf) != NULL);
140 }
56257a44 141
a715eab3
QY
142 /* no problem */
143 if (CHECK_FLAG(status, BGP_IO_TRANS_ERR)) {
56257a44 144 }
56257a44 145
a715eab3 146 /* problem */
bbac44ac 147 if (CHECK_FLAG(status, BGP_IO_FATAL_ERR)) {
a715eab3 148 reschedule = false;
bbac44ac
QY
149 fatal = true;
150 }
424ab01d 151
a77e2f4b
S
152 /* If suppress fib pending is enabled, route is advertised to peers when
153 * the status is received from the FIB. The delay is added
154 * to update group packet generate which will allow more routes to be
155 * sent in the update message
156 */
424ab01d
QY
157 if (reschedule) {
158 thread_add_write(fpt->master, bgp_process_writes, peer,
159 peer->fd, &peer->t_write);
b785b7ad 160 } else if (!fatal) {
a77e2f4b
S
161 BGP_UPDATE_GROUP_TIMER_ON(&peer->t_generate_updgrp_packets,
162 bgp_generate_updgrp_packets);
424ab01d
QY
163 }
164
165 return 0;
56257a44
QY
166}
167
a715eab3 168/*
51abb4b4
QY
169 * Called from I/O pthread when a file descriptor has become ready for reading,
170 * or has hung up.
9eb217ff
QY
171 *
172 * We read as much data as possible, process as many packets as we can and
173 * place them on peer->ibuf for secondary processing by the main thread.
56257a44 174 */
424ab01d 175static int bgp_process_reads(struct thread *thread)
56257a44 176{
e11eeb8c
QY
177 /* clang-format off */
178 static struct peer *peer; // peer to read from
179 uint16_t status; // bgp_read status code
180 bool more = true; // whether we got more data
181 bool fatal = false; // whether fatal error occurred
182 bool added_pkt = false; // whether we pushed onto ->ibuf
b8cfb2cd 183 int code = 0; // FSM code if error occurred
e11eeb8c 184 /* clang-format on */
9eb217ff 185
424ab01d 186 peer = THREAD_ARG(thread);
424ab01d 187
97b4a0ec 188 if (peer->fd < 0 || bm->terminating)
424ab01d
QY
189 return -1;
190
1ac267a2 191 struct frr_pthread *fpt = bgp_pth_io;
424ab01d 192
00dffa8c 193 frr_with_mutex(&peer->io_mtx) {
6af96fa3 194 status = bgp_read(peer, &code);
424ab01d 195 }
424ab01d 196
9eb217ff
QY
197 /* error checking phase */
198 if (CHECK_FLAG(status, BGP_IO_TRANS_ERR)) {
199 /* no problem; just don't process packets */
200 more = false;
201 }
424ab01d 202
9eb217ff
QY
203 if (CHECK_FLAG(status, BGP_IO_FATAL_ERR)) {
204 /* problem; tear down session */
205 more = false;
206 fatal = true;
6af96fa3
MS
207
208 /* Handle the error in the main pthread, include the
209 * specific state change from 'bgp_read'.
210 */
211 thread_add_event(bm->master, bgp_packet_process_error,
212 peer, code, NULL);
56257a44 213 }
56257a44 214
9eb217ff
QY
215 while (more) {
216 /* static buffer for transferring packets */
9eb217ff 217 /* shorter alias to peer's input buffer */
74ffbfe6 218 struct ringbuf *ibw = peer->ibuf_work;
9eb217ff 219 /* packet size as given by header */
74ffbfe6 220 uint16_t pktsize = 0;
9eb217ff
QY
221
222 /* check that we have enough data for a header */
74ffbfe6 223 if (ringbuf_remain(ibw) < BGP_HEADER_SIZE)
9eb217ff 224 break;
424ab01d 225
a2b6e694 226 /* check that header is valid */
227 if (!validate_header(peer)) {
9eb217ff
QY
228 fatal = true;
229 break;
424ab01d 230 }
424ab01d 231
9eb217ff 232 /* header is valid; retrieve packet size */
74ffbfe6
QY
233 ringbuf_peek(ibw, BGP_MARKER_SIZE, &pktsize, sizeof(pktsize));
234
235 pktsize = ntohs(pktsize);
424ab01d 236
9eb217ff 237 /* if this fails we are seriously screwed */
ef56aee4 238 assert(pktsize <= peer->max_packet_size);
9eb217ff 239
a715eab3
QY
240 /*
241 * If we have that much data, chuck it into its own
242 * stream and append to input queue for processing.
243 */
74ffbfe6 244 if (ringbuf_remain(ibw) >= pktsize) {
9eb217ff 245 struct stream *pkt = stream_new(pktsize);
6af96fa3 246
7c9d82cd
S
247 assert(STREAM_WRITEABLE(pkt) == pktsize);
248 assert(ringbuf_get(ibw, pkt->data, pktsize) == pktsize);
249 stream_set_endp(pkt, pktsize);
9eb217ff 250
0c3436aa 251 frrtrace(2, frr_bgp, packet_read, peer, pkt);
00dffa8c 252 frr_with_mutex(&peer->io_mtx) {
9eb217ff
QY
253 stream_fifo_push(peer->ibuf, pkt);
254 }
9eb217ff
QY
255
256 added_pkt = true;
257 } else
258 break;
259 }
260
9eb217ff
QY
261 /* handle invalid header */
262 if (fatal) {
9eb217ff 263 /* wipe buffer just in case someone screwed up */
74ffbfe6 264 ringbuf_wipe(peer->ibuf_work);
9eb217ff 265 } else {
ef56aee4 266 assert(ringbuf_space(peer->ibuf_work) >= peer->max_packet_size);
421a7dfc 267
424ab01d
QY
268 thread_add_read(fpt->master, bgp_process_reads, peer, peer->fd,
269 &peer->t_read);
9eb217ff 270 if (added_pkt)
e0d550df
MS
271 thread_add_event(bm->master, bgp_process_packet,
272 peer, 0, &peer->t_process_packet);
9eb217ff 273 }
424ab01d
QY
274
275 return 0;
56257a44
QY
276}
277
a715eab3 278/*
56257a44
QY
279 * Flush peer output buffer.
280 *
281 * This function pops packets off of peer->obuf and writes them to peer->fd.
282 * The amount of packets written is equal to the minimum of peer->wpkt_quanta
424ab01d 283 * and the number of packets on the output buffer, unless an error occurs.
56257a44
QY
284 *
285 * If write() returns an error, the appropriate FSM event is generated.
286 *
287 * The return value is equal to the number of packets written
288 * (which may be zero).
289 */
424ab01d 290static uint16_t bgp_write(struct peer *peer)
56257a44 291{
d7c0a89a 292 uint8_t type;
56257a44 293 struct stream *s;
56257a44 294 int update_last_write = 0;
093279cd 295 unsigned int count;
eb2277cf 296 uint32_t uo = 0;
424ab01d 297 uint16_t status = 0;
555e09d4 298 uint32_t wpkt_quanta_old;
56257a44 299
093279cd
QY
300 int writenum = 0;
301 int num;
302 unsigned int iovsz;
303 unsigned int strmsz;
304 unsigned int total_written;
305
996c9314
LB
306 wpkt_quanta_old = atomic_load_explicit(&peer->bgp->wpkt_quanta,
307 memory_order_relaxed);
093279cd
QY
308 struct stream *ostreams[wpkt_quanta_old];
309 struct stream **streams = ostreams;
310 struct iovec iov[wpkt_quanta_old];
311
312 s = stream_fifo_head(peer->obuf);
313
314 if (!s)
315 goto done;
316
317 count = iovsz = 0;
318 while (count < wpkt_quanta_old && iovsz < array_size(iov) && s) {
319 ostreams[iovsz] = s;
320 iov[iovsz].iov_base = stream_pnt(s);
321 iov[iovsz].iov_len = STREAM_READABLE(s);
322 writenum += STREAM_READABLE(s);
323 s = s->next;
324 ++iovsz;
325 ++count;
326 }
327
328 strmsz = iovsz;
329 total_written = 0;
330
331 do {
332 num = writev(peer->fd, iov, iovsz);
333
334 if (num < 0) {
335 if (!ERRNO_IO_RETRY(errno)) {
336 BGP_EVENT_ADD(peer, TCP_fatal_error);
337 SET_FLAG(status, BGP_IO_FATAL_ERR);
338 } else {
339 SET_FLAG(status, BGP_IO_TRANS_ERR);
340 }
341
342 break;
343 } else if (num != writenum) {
344 unsigned int msg_written = 0;
345 unsigned int ic = iovsz;
346
347 for (unsigned int i = 0; i < ic; i++) {
348 size_t ss = iov[i].iov_len;
555e09d4 349
093279cd
QY
350 if (ss > (unsigned int) num)
351 break;
56257a44 352
093279cd
QY
353 msg_written++;
354 iovsz--;
355 writenum -= ss;
356 num -= ss;
357 }
56257a44 358
093279cd 359 total_written += msg_written;
56257a44 360
18555366
QY
361 assert(total_written < count);
362
093279cd
QY
363 memmove(&iov, &iov[msg_written],
364 sizeof(iov[0]) * iovsz);
365 streams = &streams[msg_written];
366 stream_forward_getp(streams[0], num);
367 iov[0].iov_base = stream_pnt(streams[0]);
368 iov[0].iov_len = STREAM_READABLE(streams[0]);
369
370 writenum -= num;
371 num = 0;
372 assert(writenum > 0);
373 } else {
374 total_written = strmsz;
375 }
376
377 } while (num != writenum);
378
379 /* Handle statistics */
380 for (unsigned int i = 0; i < total_written; i++) {
381 s = stream_fifo_pop(peer->obuf);
382
383 assert(s == ostreams[i]);
56257a44
QY
384
385 /* Retrieve BGP packet type. */
386 stream_set_getp(s, BGP_MARKER_SIZE + 2);
387 type = stream_getc(s);
388
389 switch (type) {
390 case BGP_MSG_OPEN:
1588f6f4
QY
391 atomic_fetch_add_explicit(&peer->open_out, 1,
392 memory_order_relaxed);
56257a44
QY
393 break;
394 case BGP_MSG_UPDATE:
1588f6f4
QY
395 atomic_fetch_add_explicit(&peer->update_out, 1,
396 memory_order_relaxed);
eb2277cf 397 uo++;
56257a44
QY
398 break;
399 case BGP_MSG_NOTIFY:
1588f6f4
QY
400 atomic_fetch_add_explicit(&peer->notify_out, 1,
401 memory_order_relaxed);
56257a44
QY
402 /* Double start timer. */
403 peer->v_start *= 2;
404
405 /* Overflow check. */
406 if (peer->v_start >= (60 * 2))
407 peer->v_start = (60 * 2);
408
a715eab3
QY
409 /*
410 * Handle Graceful Restart case where the state changes
411 * to Connect instead of Idle.
412 */
56257a44
QY
413 BGP_EVENT_ADD(peer, BGP_Stop);
414 goto done;
415
416 case BGP_MSG_KEEPALIVE:
1588f6f4
QY
417 atomic_fetch_add_explicit(&peer->keepalive_out, 1,
418 memory_order_relaxed);
56257a44
QY
419 break;
420 case BGP_MSG_ROUTE_REFRESH_NEW:
421 case BGP_MSG_ROUTE_REFRESH_OLD:
1588f6f4
QY
422 atomic_fetch_add_explicit(&peer->refresh_out, 1,
423 memory_order_relaxed);
56257a44
QY
424 break;
425 case BGP_MSG_CAPABILITY:
1588f6f4
QY
426 atomic_fetch_add_explicit(&peer->dynamic_cap_out, 1,
427 memory_order_relaxed);
56257a44
QY
428 break;
429 }
430
093279cd
QY
431 stream_free(s);
432 ostreams[i] = NULL;
56257a44
QY
433 update_last_write = 1;
434 }
435
436done : {
eb2277cf
LB
437 /*
438 * Update last_update if UPDATEs were written.
439 * Note: that these are only updated at end,
440 * not per message (i.e., per loop)
441 */
442 if (uo)
1588f6f4
QY
443 atomic_store_explicit(&peer->last_update, bgp_clock(),
444 memory_order_relaxed);
56257a44 445
5c075a90 446 /* If we TXed any flavor of packet */
56257a44 447 if (update_last_write)
1588f6f4
QY
448 atomic_store_explicit(&peer->last_write, bgp_clock(),
449 memory_order_relaxed);
56257a44
QY
450}
451
424ab01d
QY
452 return status;
453}
454
a715eab3 455/*
51abb4b4 456 * Reads a chunk of data from peer->fd into peer->ibuf_work.
424ab01d 457 *
b8cfb2cd
QY
458 * code_p
459 * Pointer to location to store FSM event code in case of fatal error.
460 *
51abb4b4 461 * @return status flag (see top-of-file)
424ab01d 462 */
6af96fa3 463static uint16_t bgp_read(struct peer *peer, int *code_p)
424ab01d 464{
fe2e3bae 465 size_t readsize; // how many bytes we want to read
b750b0ba 466 ssize_t nbytes; // how many bytes we actually read
424ab01d 467 uint16_t status = 0;
fe2e3bae 468 uint8_t ibw[peer->max_packet_size * BGP_READ_PACKET_MAX];
424ab01d 469
fe2e3bae
QY
470 readsize = MIN(ringbuf_space(peer->ibuf_work), sizeof(ibw));
471 nbytes = read(peer->fd, ibw, readsize);
424ab01d 472
74ffbfe6
QY
473 /* EAGAIN or EWOULDBLOCK; come back later */
474 if (nbytes < 0 && ERRNO_IO_RETRY(errno)) {
475 SET_FLAG(status, BGP_IO_TRANS_ERR);
74ffbfe6 476 } else if (nbytes < 0) {
6af96fa3 477 /* Fatal error; tear down session */
e50f7cfd 478 flog_err(EC_BGP_UPDATE_RCV,
1c50c1c0
QY
479 "%s [Error] bgp_read_packet error: %s", peer->host,
480 safe_strerror(errno));
85145b62 481
6af96fa3
MS
482 /* Handle the error in the main pthread. */
483 if (code_p)
484 *code_p = TCP_fatal_error;
424ab01d 485
85145b62 486 SET_FLAG(status, BGP_IO_FATAL_ERR);
6af96fa3 487
74ffbfe6 488 } else if (nbytes == 0) {
6af96fa3 489 /* Received EOF / TCP session closed */
85145b62
QY
490 if (bgp_debug_neighbor_events(peer))
491 zlog_debug("%s [Event] BGP connection closed fd %d",
36235319 492 peer->host, peer->fd);
85145b62 493
6af96fa3
MS
494 /* Handle the error in the main pthread. */
495 if (code_p)
496 *code_p = TCP_connection_closed;
424ab01d 497
85145b62 498 SET_FLAG(status, BGP_IO_FATAL_ERR);
fe2e3bae
QY
499 } else {
500 assert(ringbuf_put(peer->ibuf_work, ibw, nbytes)
501 == (size_t)nbytes);
424ab01d
QY
502 }
503
424ab01d
QY
504 return status;
505}
506
507/*
508 * Called after we have read a BGP packet header. Validates marker, message
509 * type and packet length. If any of these aren't correct, sends a notify.
74ffbfe6
QY
510 *
511 * Assumes that there are at least BGP_HEADER_SIZE readable bytes in the input
512 * buffer.
424ab01d
QY
513 */
514static bool validate_header(struct peer *peer)
515{
3fe63c29
QY
516 uint16_t size;
517 uint8_t type;
74ffbfe6 518 struct ringbuf *pkt = peer->ibuf_work;
424ab01d 519
2b64873d 520 static const uint8_t m_correct[BGP_MARKER_SIZE] = {
74ffbfe6
QY
521 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
522 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
523 uint8_t m_rx[BGP_MARKER_SIZE] = {0x00};
442c9afb 524
74ffbfe6
QY
525 if (ringbuf_peek(pkt, 0, m_rx, BGP_MARKER_SIZE) != BGP_MARKER_SIZE)
526 return false;
527
528 if (memcmp(m_correct, m_rx, BGP_MARKER_SIZE) != 0) {
442c9afb
QY
529 bgp_notify_send(peer, BGP_NOTIFY_HEADER_ERR,
530 BGP_NOTIFY_HEADER_NOT_SYNC);
531 return false;
532 }
424ab01d 533
74ffbfe6
QY
534 /* Get size and type in network byte order. */
535 ringbuf_peek(pkt, BGP_MARKER_SIZE, &size, sizeof(size));
536 ringbuf_peek(pkt, BGP_MARKER_SIZE + 2, &type, sizeof(type));
537
538 size = ntohs(size);
424ab01d
QY
539
540 /* BGP type check. */
541 if (type != BGP_MSG_OPEN && type != BGP_MSG_UPDATE
542 && type != BGP_MSG_NOTIFY && type != BGP_MSG_KEEPALIVE
543 && type != BGP_MSG_ROUTE_REFRESH_NEW
544 && type != BGP_MSG_ROUTE_REFRESH_OLD
545 && type != BGP_MSG_CAPABILITY) {
3fe63c29 546 if (bgp_debug_neighbor_events(peer))
424ab01d
QY
547 zlog_debug("%s unknown message type 0x%02x", peer->host,
548 type);
549
550 bgp_notify_send_with_data(peer, BGP_NOTIFY_HEADER_ERR,
996c9314
LB
551 BGP_NOTIFY_HEADER_BAD_MESTYPE, &type,
552 1);
424ab01d
QY
553 return false;
554 }
555
3fe63c29 556 /* Minimum packet length check. */
ef56aee4 557 if ((size < BGP_HEADER_SIZE) || (size > peer->max_packet_size)
424ab01d
QY
558 || (type == BGP_MSG_OPEN && size < BGP_MSG_OPEN_MIN_SIZE)
559 || (type == BGP_MSG_UPDATE && size < BGP_MSG_UPDATE_MIN_SIZE)
560 || (type == BGP_MSG_NOTIFY && size < BGP_MSG_NOTIFY_MIN_SIZE)
561 || (type == BGP_MSG_KEEPALIVE && size != BGP_MSG_KEEPALIVE_MIN_SIZE)
562 || (type == BGP_MSG_ROUTE_REFRESH_NEW
563 && size < BGP_MSG_ROUTE_REFRESH_MIN_SIZE)
564 || (type == BGP_MSG_ROUTE_REFRESH_OLD
565 && size < BGP_MSG_ROUTE_REFRESH_MIN_SIZE)
566 || (type == BGP_MSG_CAPABILITY
567 && size < BGP_MSG_CAPABILITY_MIN_SIZE)) {
1588f6f4 568 if (bgp_debug_neighbor_events(peer)) {
424ab01d
QY
569 zlog_debug("%s bad message length - %d for %s",
570 peer->host, size,
571 type == 128 ? "ROUTE-REFRESH"
996c9314 572 : bgp_type_str[(int)type]);
1588f6f4 573 }
424ab01d 574
3fe63c29
QY
575 uint16_t nsize = htons(size);
576
424ab01d
QY
577 bgp_notify_send_with_data(peer, BGP_NOTIFY_HEADER_ERR,
578 BGP_NOTIFY_HEADER_BAD_MESLEN,
996c9314 579 (unsigned char *)&nsize, 2);
424ab01d
QY
580 return false;
581 }
582
583 return true;
56257a44 584}