]> git.proxmox.com Git - mirror_qemu.git/blame - block/commit.c
block: Mark bdrv_op_is_blocked() and callers GRAPH_RDLOCK
[mirror_qemu.git] / block / commit.c
CommitLineData
747ff602
JC
1/*
2 * Live block commit
3 *
4 * Copyright Red Hat, Inc. 2012
5 *
6 * Authors:
7 * Jeff Cody <jcody@redhat.com>
8 * Based on stream.c by Stefan Hajnoczi
9 *
10 * This work is licensed under the terms of the GNU LGPL, version 2 or later.
11 * See the COPYING.LIB file in the top-level directory.
12 *
13 */
14
80c71a24 15#include "qemu/osdep.h"
dcbf37ce 16#include "qemu/cutils.h"
747ff602 17#include "trace.h"
737e150e 18#include "block/block_int.h"
c87621ea 19#include "block/blockjob_int.h"
da34e65c 20#include "qapi/error.h"
747ff602 21#include "qemu/ratelimit.h"
5df022cf 22#include "qemu/memalign.h"
373340b2 23#include "sysemu/block-backend.h"
747ff602
JC
24
25enum {
26 /*
27 * Size of data buffer for populating the image file. This should be large
28 * enough to process multiple clusters in a single call, so that populating
29 * contiguous regions of the image is efficient.
30 */
31 COMMIT_BUFFER_SIZE = 512 * 1024, /* in bytes */
32};
33
747ff602
JC
34typedef struct CommitBlockJob {
35 BlockJob common;
8dfba279 36 BlockDriverState *commit_top_bs;
4653456a
KW
37 BlockBackend *top;
38 BlockBackend *base;
22dffcbe 39 BlockDriverState *base_bs;
9a71b9de 40 BlockDriverState *base_overlay;
92aa5c6d 41 BlockdevOnError on_error;
e70cdc57 42 bool base_read_only;
df827336 43 bool chain_frozen;
54e26900 44 char *backing_file_str;
747ff602
JC
45} CommitBlockJob;
46
22dffcbe 47static int commit_prepare(Job *job)
747ff602 48{
1908a559 49 CommitBlockJob *s = container_of(job, CommitBlockJob, common.job);
19ebd13e 50
df827336
AG
51 bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs);
52 s->chain_frozen = false;
53
8dfba279
KW
54 /* Remove base node parent that still uses BLK_PERM_WRITE/RESIZE before
55 * the normal backing chain can be restored. */
56 blk_unref(s->base);
22dffcbe
JS
57 s->base = NULL;
58
59 /* FIXME: bdrv_drop_intermediate treats total failures and partial failures
60 * identically. Further work is needed to disambiguate these cases. */
61 return bdrv_drop_intermediate(s->commit_top_bs, s->base_bs,
62 s->backing_file_str);
63}
9e85cd5c 64
22dffcbe
JS
65static void commit_abort(Job *job)
66{
67 CommitBlockJob *s = container_of(job, CommitBlockJob, common.job);
68 BlockDriverState *top_bs = blk_bs(s->top);
69
df827336
AG
70 if (s->chain_frozen) {
71 bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs);
72 }
73
22dffcbe
JS
74 /* Make sure commit_top_bs and top stay around until bdrv_replace_node() */
75 bdrv_ref(top_bs);
76 bdrv_ref(s->commit_top_bs);
77
78 if (s->base) {
79 blk_unref(s->base);
9e85cd5c
SH
80 }
81
22dffcbe
JS
82 /* free the blockers on the intermediate nodes so that bdrv_replace_nodes
83 * can succeed */
84 block_job_remove_all_bdrv(&s->common);
85
86 /* If bdrv_drop_intermediate() failed (or was not invoked), remove the
87 * commit filter driver from the backing chain now. Do this as the final
88 * step so that the 'consistent read' permission can be granted.
89 *
90 * XXX Can (or should) we somehow keep 'consistent read' blocked even
91 * after the failed/cancelled commit job is gone? If we already wrote
92 * something to base, the intermediate images aren't valid any more. */
9a71b9de 93 bdrv_replace_node(s->commit_top_bs, s->commit_top_bs->backing->bs,
22dffcbe
JS
94 &error_abort);
95
96 bdrv_unref(s->commit_top_bs);
97 bdrv_unref(top_bs);
98}
99
100static void commit_clean(Job *job)
101{
102 CommitBlockJob *s = container_of(job, CommitBlockJob, common.job);
103
9e85cd5c
SH
104 /* restore base open flags here if appropriate (e.g., change the base back
105 * to r/o). These reopens do not need to be atomic, since we won't abort
106 * even on failure here */
e70cdc57
AG
107 if (s->base_read_only) {
108 bdrv_reopen_set_read_only(s->base_bs, true, NULL);
9e85cd5c 109 }
22dffcbe 110
9e85cd5c 111 g_free(s->backing_file_str);
4653456a 112 blk_unref(s->top);
9e85cd5c
SH
113}
114
f67432a2 115static int coroutine_fn commit_run(Job *job, Error **errp)
9e85cd5c 116{
f67432a2 117 CommitBlockJob *s = container_of(job, CommitBlockJob, common.job);
317a6676 118 int64_t offset;
747ff602 119 int ret = 0;
51b0a488 120 int64_t n = 0; /* bytes */
71701708 121 QEMU_AUTO_VFREE void *buf = NULL;
05df8a6a 122 int64_t len, base_len;
747ff602 123
c86422c5 124 len = blk_co_getlength(s->top);
05df8a6a 125 if (len < 0) {
71701708 126 return len;
747ff602 127 }
30a5c887 128 job_progress_set_remaining(&s->common.job, len);
747ff602 129
c86422c5 130 base_len = blk_co_getlength(s->base);
747ff602 131 if (base_len < 0) {
71701708 132 return base_len;
747ff602
JC
133 }
134
05df8a6a 135 if (base_len < len) {
a0667887 136 ret = blk_co_truncate(s->base, len, false, PREALLOC_MODE_OFF, 0, NULL);
747ff602 137 if (ret) {
71701708 138 return ret;
747ff602
JC
139 }
140 }
141
4653456a 142 buf = blk_blockalign(s->top, COMMIT_BUFFER_SIZE);
747ff602 143
05df8a6a 144 for (offset = 0; offset < len; offset += n) {
747ff602 145 bool copy;
9ad1e79f 146 bool error_in_source = true;
747ff602 147
747ff602 148 /* Note that even when no rate limit is applied we need to yield
c57b6656 149 * with no pending I/O here so that bdrv_drain_all() returns.
747ff602 150 */
018e5987 151 block_job_ratelimit_sleep(&s->common);
daa7f2f9 152 if (job_is_cancelled(&s->common.job)) {
747ff602
JC
153 break;
154 }
155 /* Copy if allocated above the base */
ff7e261b
EGE
156 ret = blk_co_is_allocated_above(s->top, s->base_overlay, true,
157 offset, COMMIT_BUFFER_SIZE, &n);
a92b1b06 158 copy = (ret > 0);
51b0a488 159 trace_commit_one_iteration(s, offset, n, ret);
747ff602 160 if (copy) {
0c42e175
KW
161 assert(n < SIZE_MAX);
162
163 ret = blk_co_pread(s->top, offset, n, buf, 0);
164 if (ret >= 0) {
165 ret = blk_co_pwrite(s->base, offset, n, buf, 0);
9ad1e79f
KW
166 if (ret < 0) {
167 error_in_source = false;
168 }
0c42e175 169 }
747ff602
JC
170 }
171 if (ret < 0) {
1e8fb7f1 172 BlockErrorAction action =
9ad1e79f
KW
173 block_job_error_action(&s->common, s->on_error,
174 error_in_source, -ret);
1e8fb7f1 175 if (action == BLOCK_ERROR_ACTION_REPORT) {
71701708 176 return ret;
747ff602
JC
177 } else {
178 n = 0;
179 continue;
180 }
181 }
182 /* Publish progress */
30a5c887 183 job_progress_update(&s->common.job, n);
f14a39cc 184
dee81d51 185 if (copy) {
018e5987 186 block_job_ratelimit_processed_bytes(&s->common, n);
f14a39cc 187 }
747ff602
JC
188 }
189
71701708 190 return 0;
747ff602
JC
191}
192
3fc4b10a 193static const BlockJobDriver commit_job_driver = {
33e9e9bd
KW
194 .job_driver = {
195 .instance_size = sizeof(CommitBlockJob),
252291ea 196 .job_type = JOB_TYPE_COMMIT,
80fa2c75 197 .free = block_job_free,
b15de828 198 .user_resume = block_job_user_resume,
f67432a2 199 .run = commit_run,
22dffcbe
JS
200 .prepare = commit_prepare,
201 .abort = commit_abort,
202 .clean = commit_clean
33e9e9bd 203 },
747ff602
JC
204};
205
b9b10c35
KW
206static int coroutine_fn GRAPH_RDLOCK
207bdrv_commit_top_preadv(BlockDriverState *bs, int64_t offset, int64_t bytes,
208 QEMUIOVector *qiov, BdrvRequestFlags flags)
8dfba279
KW
209{
210 return bdrv_co_preadv(bs->backing, offset, bytes, qiov, flags);
211}
212
998b3a1e 213static void bdrv_commit_top_refresh_filename(BlockDriverState *bs)
dcbf37ce 214{
dcbf37ce
KW
215 pstrcpy(bs->exact_filename, sizeof(bs->exact_filename),
216 bs->backing->bs->filename);
217}
91965658 218
8dfba279 219static void bdrv_commit_top_child_perm(BlockDriverState *bs, BdrvChild *c,
bf8e925e 220 BdrvChildRole role,
e0995dc3 221 BlockReopenQueue *reopen_queue,
8dfba279
KW
222 uint64_t perm, uint64_t shared,
223 uint64_t *nperm, uint64_t *nshared)
224{
225 *nperm = 0;
226 *nshared = BLK_PERM_ALL;
227}
228
229/* Dummy node that provides consistent read to its users without requiring it
230 * from its backing file and that allows writes on the backing file chain. */
231static BlockDriver bdrv_commit_top = {
91965658
KW
232 .format_name = "commit_top",
233 .bdrv_co_preadv = bdrv_commit_top_preadv,
dcbf37ce 234 .bdrv_refresh_filename = bdrv_commit_top_refresh_filename,
91965658 235 .bdrv_child_perm = bdrv_commit_top_child_perm,
6540fd15
HR
236
237 .is_filter = true,
046fd84f 238 .filtered_child_is_backing = true,
8dfba279
KW
239};
240
fd62c609 241void commit_start(const char *job_id, BlockDriverState *bs,
5360782d
JS
242 BlockDriverState *base, BlockDriverState *top,
243 int creation_flags, int64_t speed,
8254b6d9 244 BlockdevOnError on_error, const char *backing_file_str,
0db832f4 245 const char *filter_node_name, Error **errp)
747ff602
JC
246{
247 CommitBlockJob *s;
3e4c5122 248 BlockDriverState *iter;
8dfba279 249 BlockDriverState *commit_top_bs = NULL;
9a71b9de 250 BlockDriverState *filtered_base;
9a71b9de
HR
251 int64_t base_size, top_size;
252 uint64_t base_perms, iter_shared_perms;
d7086422 253 int ret;
747ff602 254
b4ad82aa
EGE
255 GLOBAL_STATE_CODE();
256
18da7f94 257 assert(top != bs);
9a71b9de 258 if (bdrv_skip_filters(top) == bdrv_skip_filters(base)) {
747ff602
JC
259 error_setg(errp, "Invalid files for merge: top and base are the same");
260 return;
261 }
262
9a71b9de
HR
263 base_size = bdrv_getlength(base);
264 if (base_size < 0) {
265 error_setg_errno(errp, -base_size, "Could not inquire base image size");
266 return;
267 }
268
269 top_size = bdrv_getlength(top);
270 if (top_size < 0) {
271 error_setg_errno(errp, -top_size, "Could not inquire top image size");
272 return;
273 }
274
275 base_perms = BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE;
276 if (base_size < top_size) {
277 base_perms |= BLK_PERM_RESIZE;
278 }
279
75859b94 280 s = block_job_create(job_id, &commit_job_driver, NULL, bs, 0, BLK_PERM_ALL,
5360782d 281 speed, creation_flags, NULL, NULL, errp);
834fe28d
AG
282 if (!s) {
283 return;
284 }
285
bde70715 286 /* convert base to r/w, if necessary */
e70cdc57
AG
287 s->base_read_only = bdrv_is_read_only(base);
288 if (s->base_read_only) {
289 if (bdrv_reopen_set_read_only(base, false, errp) != 0) {
d7086422 290 goto fail;
747ff602
JC
291 }
292 }
293
8dfba279
KW
294 /* Insert commit_top block node above top, so we can block consistent read
295 * on the backing chain below it */
0db832f4
KW
296 commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, filter_node_name, 0,
297 errp);
8dfba279
KW
298 if (commit_top_bs == NULL) {
299 goto fail;
300 }
d3c8c674
KW
301 if (!filter_node_name) {
302 commit_top_bs->implicit = true;
303 }
e5182c1c
HR
304
305 /* So that we can always drop this node */
306 commit_top_bs->never_freeze = true;
307
0d0676a1 308 commit_top_bs->total_sectors = top->total_sectors;
8dfba279 309
934aee14 310 ret = bdrv_append(commit_top_bs, top, errp);
ae9d4417 311 bdrv_unref(commit_top_bs); /* referenced by new parents or failed */
934aee14 312 if (ret < 0) {
b69f00dd 313 commit_top_bs = NULL;
b69f00dd
FZ
314 goto fail;
315 }
8dfba279
KW
316
317 s->commit_top_bs = commit_top_bs;
747ff602 318
9a71b9de
HR
319 /*
320 * Block all nodes between top and base, because they will
321 * disappear from the chain after this operation.
322 * Note that this assumes that the user is fine with removing all
323 * nodes (including R/W filters) between top and base. Assuring
324 * this is the responsibility of the interface (i.e. whoever calls
325 * commit_start()).
326 */
327 s->base_overlay = bdrv_find_overlay(top, base);
328 assert(s->base_overlay);
329
330 /*
331 * The topmost node with
332 * bdrv_skip_filters(filtered_base) == bdrv_skip_filters(base)
333 */
334 filtered_base = bdrv_cow_bs(s->base_overlay);
335 assert(bdrv_skip_filters(filtered_base) == bdrv_skip_filters(base));
336
337 /*
338 * XXX BLK_PERM_WRITE needs to be allowed so we don't block ourselves
339 * at s->base (if writes are blocked for a node, they are also blocked
340 * for its backing file). The other options would be a second filter
341 * driver above s->base.
342 */
343 iter_shared_perms = BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE;
344
345 for (iter = top; iter != base; iter = bdrv_filter_or_cow_bs(iter)) {
346 if (iter == filtered_base) {
347 /*
348 * From here on, all nodes are filters on the base. This
349 * allows us to share BLK_PERM_CONSISTENT_READ.
350 */
351 iter_shared_perms |= BLK_PERM_CONSISTENT_READ;
352 }
353
8dfba279 354 ret = block_job_add_bdrv(&s->common, "intermediate node", iter, 0,
9a71b9de 355 iter_shared_perms, errp);
8dfba279
KW
356 if (ret < 0) {
357 goto fail;
358 }
3e4c5122 359 }
8dfba279 360
df827336
AG
361 if (bdrv_freeze_backing_chain(commit_top_bs, base, errp) < 0) {
362 goto fail;
363 }
364 s->chain_frozen = true;
365
8dfba279
KW
366 ret = block_job_add_bdrv(&s->common, "base", base, 0, BLK_PERM_ALL, errp);
367 if (ret < 0) {
368 goto fail;
369 }
370
d861ab3a 371 s->base = blk_new(s->common.job.aio_context,
9a71b9de 372 base_perms,
8dfba279 373 BLK_PERM_CONSISTENT_READ
8dfba279 374 | BLK_PERM_WRITE_UNCHANGED);
d7086422
KW
375 ret = blk_insert_bs(s->base, base, errp);
376 if (ret < 0) {
377 goto fail;
378 }
cf312932 379 blk_set_disable_request_queuing(s->base, true);
22dffcbe 380 s->base_bs = base;
4653456a 381
8dfba279 382 /* Required permissions are already taken with block_job_add_bdrv() */
d861ab3a 383 s->top = blk_new(s->common.job.aio_context, 0, BLK_PERM_ALL);
b247767a 384 ret = blk_insert_bs(s->top, top, errp);
d7086422
KW
385 if (ret < 0) {
386 goto fail;
387 }
cf312932 388 blk_set_disable_request_queuing(s->top, true);
4653456a 389
54e26900 390 s->backing_file_str = g_strdup(backing_file_str);
747ff602 391 s->on_error = on_error;
747ff602 392
5ccac6f1 393 trace_commit_start(bs, base, top, s);
da01ff7f 394 job_start(&s->common.job);
d7086422
KW
395 return;
396
397fail:
df827336
AG
398 if (s->chain_frozen) {
399 bdrv_unfreeze_backing_chain(commit_top_bs, base);
400 }
d7086422
KW
401 if (s->base) {
402 blk_unref(s->base);
403 }
404 if (s->top) {
405 blk_unref(s->top);
406 }
065abf9f
AG
407 if (s->base_read_only) {
408 bdrv_reopen_set_read_only(base, true, NULL);
409 }
2468eed3
AG
410 job_early_fail(&s->common.job);
411 /* commit_top_bs has to be replaced after deleting the block job,
412 * otherwise this would fail because of lack of permissions. */
8dfba279 413 if (commit_top_bs) {
bde70715 414 bdrv_replace_node(commit_top_bs, top, &error_abort);
8dfba279 415 }
747ff602 416}
83fd6dd3
KW
417
418
d6a644bb 419#define COMMIT_BUF_SIZE (2048 * BDRV_SECTOR_SIZE)
83fd6dd3
KW
420
421/* commit COW file into the raw image */
422int bdrv_commit(BlockDriverState *bs)
423{
f8e2bd53 424 BlockBackend *src, *backing;
d3f06759
KW
425 BlockDriverState *backing_file_bs = NULL;
426 BlockDriverState *commit_top_bs = NULL;
83fd6dd3 427 BlockDriver *drv = bs->drv;
d861ab3a 428 AioContext *ctx;
d6a644bb 429 int64_t offset, length, backing_length;
c742a364 430 int ro;
d6a644bb 431 int64_t n;
83fd6dd3 432 int ret = 0;
71701708 433 QEMU_AUTO_VFREE uint8_t *buf = NULL;
d3f06759 434 Error *local_err = NULL;
83fd6dd3 435
f791bf7f 436 GLOBAL_STATE_CODE();
277f2007 437 GRAPH_RDLOCK_GUARD_MAINLOOP();
f791bf7f 438
83fd6dd3
KW
439 if (!drv)
440 return -ENOMEDIUM;
441
9a71b9de
HR
442 backing_file_bs = bdrv_cow_bs(bs);
443
444 if (!backing_file_bs) {
83fd6dd3
KW
445 return -ENOTSUP;
446 }
447
448 if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_COMMIT_SOURCE, NULL) ||
9a71b9de
HR
449 bdrv_op_is_blocked(backing_file_bs, BLOCK_OP_TYPE_COMMIT_TARGET, NULL))
450 {
83fd6dd3
KW
451 return -EBUSY;
452 }
453
307261b2 454 ro = bdrv_is_read_only(backing_file_bs);
83fd6dd3
KW
455
456 if (ro) {
9a71b9de 457 if (bdrv_reopen_set_read_only(backing_file_bs, false, NULL)) {
83fd6dd3
KW
458 return -EACCES;
459 }
460 }
461
d861ab3a 462 ctx = bdrv_get_aio_context(bs);
2d97fde4
HR
463 /* WRITE_UNCHANGED is required for bdrv_make_empty() */
464 src = blk_new(ctx, BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE_UNCHANGED,
465 BLK_PERM_ALL);
d861ab3a 466 backing = blk_new(ctx, BLK_PERM_WRITE | BLK_PERM_RESIZE, BLK_PERM_ALL);
d7086422 467
d3f06759 468 ret = blk_insert_bs(src, bs, &local_err);
d7086422 469 if (ret < 0) {
d3f06759
KW
470 error_report_err(local_err);
471 goto ro_cleanup;
472 }
473
474 /* Insert commit_top block node above backing, so we can write to it */
d3f06759
KW
475 commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, NULL, BDRV_O_RDWR,
476 &local_err);
477 if (commit_top_bs == NULL) {
478 error_report_err(local_err);
d7086422
KW
479 goto ro_cleanup;
480 }
481
12fa4af6
KW
482 bdrv_set_backing_hd(commit_top_bs, backing_file_bs, &error_abort);
483 bdrv_set_backing_hd(bs, commit_top_bs, &error_abort);
d3f06759
KW
484
485 ret = blk_insert_bs(backing, backing_file_bs, &local_err);
d7086422 486 if (ret < 0) {
d3f06759 487 error_report_err(local_err);
d7086422
KW
488 goto ro_cleanup;
489 }
f8e2bd53
KW
490
491 length = blk_getlength(src);
83fd6dd3
KW
492 if (length < 0) {
493 ret = length;
494 goto ro_cleanup;
495 }
496
f8e2bd53 497 backing_length = blk_getlength(backing);
83fd6dd3
KW
498 if (backing_length < 0) {
499 ret = backing_length;
500 goto ro_cleanup;
501 }
502
503 /* If our top snapshot is larger than the backing file image,
504 * grow the backing file image if possible. If not possible,
505 * we must return an error */
506 if (length > backing_length) {
8c6242b6 507 ret = blk_truncate(backing, length, false, PREALLOC_MODE_OFF, 0,
c80d8b06 508 &local_err);
83fd6dd3 509 if (ret < 0) {
ed3d2ec9 510 error_report_err(local_err);
83fd6dd3
KW
511 goto ro_cleanup;
512 }
513 }
514
f8e2bd53
KW
515 /* blk_try_blockalign() for src will choose an alignment that works for
516 * backing as well, so no need to compare the alignment manually. */
d6a644bb 517 buf = blk_try_blockalign(src, COMMIT_BUF_SIZE);
83fd6dd3
KW
518 if (buf == NULL) {
519 ret = -ENOMEM;
520 goto ro_cleanup;
521 }
522
d6a644bb
EB
523 for (offset = 0; offset < length; offset += n) {
524 ret = bdrv_is_allocated(bs, offset, COMMIT_BUF_SIZE, &n);
83fd6dd3
KW
525 if (ret < 0) {
526 goto ro_cleanup;
527 }
528 if (ret) {
a9262f55 529 ret = blk_pread(src, offset, n, buf, 0);
83fd6dd3
KW
530 if (ret < 0) {
531 goto ro_cleanup;
532 }
533
a9262f55 534 ret = blk_pwrite(backing, offset, n, buf, 0);
83fd6dd3
KW
535 if (ret < 0) {
536 goto ro_cleanup;
537 }
538 }
539 }
540
2d97fde4
HR
541 ret = blk_make_empty(src, NULL);
542 /* Ignore -ENOTSUP */
543 if (ret < 0 && ret != -ENOTSUP) {
544 goto ro_cleanup;
83fd6dd3
KW
545 }
546
2d97fde4
HR
547 blk_flush(src);
548
83fd6dd3
KW
549 /*
550 * Make sure all data we wrote to the backing device is actually
551 * stable on disk.
552 */
f8e2bd53 553 blk_flush(backing);
83fd6dd3
KW
554
555 ret = 0;
556ro_cleanup:
f8e2bd53 557 blk_unref(backing);
9a71b9de 558 if (bdrv_cow_bs(bs) != backing_file_bs) {
12fa4af6 559 bdrv_set_backing_hd(bs, backing_file_bs, &error_abort);
d3f06759
KW
560 }
561 bdrv_unref(commit_top_bs);
562 blk_unref(src);
f8e2bd53 563
83fd6dd3
KW
564 if (ro) {
565 /* ignoring error return here */
9a71b9de 566 bdrv_reopen_set_read_only(backing_file_bs, true, NULL);
83fd6dd3
KW
567 }
568
569 return ret;
570}