]> git.proxmox.com Git - mirror_qemu.git/blame - block/commit.c
commit: Use real permissions in commit block job
[mirror_qemu.git] / block / commit.c
CommitLineData
747ff602
JC
1/*
2 * Live block commit
3 *
4 * Copyright Red Hat, Inc. 2012
5 *
6 * Authors:
7 * Jeff Cody <jcody@redhat.com>
8 * Based on stream.c by Stefan Hajnoczi
9 *
10 * This work is licensed under the terms of the GNU LGPL, version 2 or later.
11 * See the COPYING.LIB file in the top-level directory.
12 *
13 */
14
80c71a24 15#include "qemu/osdep.h"
747ff602 16#include "trace.h"
737e150e 17#include "block/block_int.h"
c87621ea 18#include "block/blockjob_int.h"
da34e65c 19#include "qapi/error.h"
cc7a8ea7 20#include "qapi/qmp/qerror.h"
747ff602 21#include "qemu/ratelimit.h"
373340b2 22#include "sysemu/block-backend.h"
747ff602
JC
23
24enum {
25 /*
26 * Size of data buffer for populating the image file. This should be large
27 * enough to process multiple clusters in a single call, so that populating
28 * contiguous regions of the image is efficient.
29 */
30 COMMIT_BUFFER_SIZE = 512 * 1024, /* in bytes */
31};
32
33#define SLICE_TIME 100000000ULL /* ns */
34
35typedef struct CommitBlockJob {
36 BlockJob common;
37 RateLimit limit;
38 BlockDriverState *active;
8dfba279 39 BlockDriverState *commit_top_bs;
4653456a
KW
40 BlockBackend *top;
41 BlockBackend *base;
92aa5c6d 42 BlockdevOnError on_error;
747ff602
JC
43 int base_flags;
44 int orig_overlay_flags;
54e26900 45 char *backing_file_str;
747ff602
JC
46} CommitBlockJob;
47
4653456a 48static int coroutine_fn commit_populate(BlockBackend *bs, BlockBackend *base,
747ff602
JC
49 int64_t sector_num, int nb_sectors,
50 void *buf)
51{
52 int ret = 0;
4653456a
KW
53 QEMUIOVector qiov;
54 struct iovec iov = {
55 .iov_base = buf,
56 .iov_len = nb_sectors * BDRV_SECTOR_SIZE,
57 };
747ff602 58
4653456a
KW
59 qemu_iovec_init_external(&qiov, &iov, 1);
60
61 ret = blk_co_preadv(bs, sector_num * BDRV_SECTOR_SIZE,
62 qiov.size, &qiov, 0);
63 if (ret < 0) {
747ff602
JC
64 return ret;
65 }
66
4653456a
KW
67 ret = blk_co_pwritev(base, sector_num * BDRV_SECTOR_SIZE,
68 qiov.size, &qiov, 0);
69 if (ret < 0) {
747ff602
JC
70 return ret;
71 }
72
73 return 0;
74}
75
9e85cd5c
SH
76typedef struct {
77 int ret;
78} CommitCompleteData;
79
80static void commit_complete(BlockJob *job, void *opaque)
747ff602 81{
9e85cd5c
SH
82 CommitBlockJob *s = container_of(job, CommitBlockJob, common);
83 CommitCompleteData *data = opaque;
747ff602 84 BlockDriverState *active = s->active;
4653456a
KW
85 BlockDriverState *top = blk_bs(s->top);
86 BlockDriverState *base = blk_bs(s->base);
8dfba279 87 BlockDriverState *overlay_bs = bdrv_find_overlay(active, s->commit_top_bs);
9e85cd5c 88 int ret = data->ret;
8dfba279
KW
89 bool remove_commit_top_bs = false;
90
91 /* Remove base node parent that still uses BLK_PERM_WRITE/RESIZE before
92 * the normal backing chain can be restored. */
93 blk_unref(s->base);
9e85cd5c
SH
94
95 if (!block_job_is_cancelled(&s->common) && ret == 0) {
96 /* success */
8dfba279
KW
97 ret = bdrv_drop_intermediate(active, s->commit_top_bs, base,
98 s->backing_file_str);
99 } else if (overlay_bs) {
100 /* XXX Can (or should) we somehow keep 'consistent read' blocked even
101 * after the failed/cancelled commit job is gone? If we already wrote
102 * something to base, the intermediate images aren't valid any more. */
103 remove_commit_top_bs = true;
9e85cd5c
SH
104 }
105
106 /* restore base open flags here if appropriate (e.g., change the base back
107 * to r/o). These reopens do not need to be atomic, since we won't abort
108 * even on failure here */
109 if (s->base_flags != bdrv_get_flags(base)) {
110 bdrv_reopen(base, s->base_flags, NULL);
111 }
9e85cd5c
SH
112 if (overlay_bs && s->orig_overlay_flags != bdrv_get_flags(overlay_bs)) {
113 bdrv_reopen(overlay_bs, s->orig_overlay_flags, NULL);
114 }
115 g_free(s->backing_file_str);
4653456a 116 blk_unref(s->top);
9e85cd5c
SH
117 block_job_completed(&s->common, ret);
118 g_free(data);
8dfba279
KW
119
120 /* If bdrv_drop_intermediate() didn't already do that, remove the commit
121 * filter driver from the backing chain. Do this as the final step so that
122 * the 'consistent read' permission can be granted. */
123 if (remove_commit_top_bs) {
124 bdrv_set_backing_hd(overlay_bs, top);
125 }
9e85cd5c
SH
126}
127
128static void coroutine_fn commit_run(void *opaque)
129{
130 CommitBlockJob *s = opaque;
131 CommitCompleteData *data;
747ff602 132 int64_t sector_num, end;
f14a39cc 133 uint64_t delay_ns = 0;
747ff602
JC
134 int ret = 0;
135 int n = 0;
9e85cd5c 136 void *buf = NULL;
747ff602
JC
137 int bytes_written = 0;
138 int64_t base_len;
139
4653456a 140 ret = s->common.len = blk_getlength(s->top);
747ff602
JC
141
142
143 if (s->common.len < 0) {
9e85cd5c 144 goto out;
747ff602
JC
145 }
146
4653456a 147 ret = base_len = blk_getlength(s->base);
747ff602 148 if (base_len < 0) {
9e85cd5c 149 goto out;
747ff602
JC
150 }
151
152 if (base_len < s->common.len) {
4653456a 153 ret = blk_truncate(s->base, s->common.len);
747ff602 154 if (ret) {
9e85cd5c 155 goto out;
747ff602
JC
156 }
157 }
158
747ff602 159 end = s->common.len >> BDRV_SECTOR_BITS;
4653456a 160 buf = blk_blockalign(s->top, COMMIT_BUFFER_SIZE);
747ff602
JC
161
162 for (sector_num = 0; sector_num < end; sector_num += n) {
747ff602
JC
163 bool copy;
164
747ff602 165 /* Note that even when no rate limit is applied we need to yield
c57b6656 166 * with no pending I/O here so that bdrv_drain_all() returns.
747ff602 167 */
7483d1e5 168 block_job_sleep_ns(&s->common, QEMU_CLOCK_REALTIME, delay_ns);
747ff602
JC
169 if (block_job_is_cancelled(&s->common)) {
170 break;
171 }
172 /* Copy if allocated above the base */
4653456a
KW
173 ret = bdrv_is_allocated_above(blk_bs(s->top), blk_bs(s->base),
174 sector_num,
4f578637
PB
175 COMMIT_BUFFER_SIZE / BDRV_SECTOR_SIZE,
176 &n);
747ff602
JC
177 copy = (ret == 1);
178 trace_commit_one_iteration(s, sector_num, n, ret);
179 if (copy) {
4653456a 180 ret = commit_populate(s->top, s->base, sector_num, n, buf);
747ff602
JC
181 bytes_written += n * BDRV_SECTOR_SIZE;
182 }
183 if (ret < 0) {
1e8fb7f1
KW
184 BlockErrorAction action =
185 block_job_error_action(&s->common, false, s->on_error, -ret);
186 if (action == BLOCK_ERROR_ACTION_REPORT) {
9e85cd5c 187 goto out;
747ff602
JC
188 } else {
189 n = 0;
190 continue;
191 }
192 }
193 /* Publish progress */
194 s->common.offset += n * BDRV_SECTOR_SIZE;
f14a39cc
SS
195
196 if (copy && s->common.speed) {
197 delay_ns = ratelimit_calculate_delay(&s->limit, n);
198 }
747ff602
JC
199 }
200
201 ret = 0;
202
9e85cd5c 203out:
747ff602
JC
204 qemu_vfree(buf);
205
9e85cd5c
SH
206 data = g_malloc(sizeof(*data));
207 data->ret = ret;
208 block_job_defer_to_main_loop(&s->common, commit_complete, data);
747ff602
JC
209}
210
211static void commit_set_speed(BlockJob *job, int64_t speed, Error **errp)
212{
213 CommitBlockJob *s = container_of(job, CommitBlockJob, common);
214
215 if (speed < 0) {
c6bd8c70 216 error_setg(errp, QERR_INVALID_PARAMETER, "speed");
747ff602
JC
217 return;
218 }
219 ratelimit_set_speed(&s->limit, speed / BDRV_SECTOR_SIZE, SLICE_TIME);
220}
221
3fc4b10a 222static const BlockJobDriver commit_job_driver = {
747ff602 223 .instance_size = sizeof(CommitBlockJob),
79e14bf7 224 .job_type = BLOCK_JOB_TYPE_COMMIT,
747ff602 225 .set_speed = commit_set_speed,
a7815a76 226 .start = commit_run,
747ff602
JC
227};
228
8dfba279
KW
229static int coroutine_fn bdrv_commit_top_preadv(BlockDriverState *bs,
230 uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags)
231{
232 return bdrv_co_preadv(bs->backing, offset, bytes, qiov, flags);
233}
234
235static void bdrv_commit_top_close(BlockDriverState *bs)
236{
237}
238
239static void bdrv_commit_top_child_perm(BlockDriverState *bs, BdrvChild *c,
240 const BdrvChildRole *role,
241 uint64_t perm, uint64_t shared,
242 uint64_t *nperm, uint64_t *nshared)
243{
244 *nperm = 0;
245 *nshared = BLK_PERM_ALL;
246}
247
248/* Dummy node that provides consistent read to its users without requiring it
249 * from its backing file and that allows writes on the backing file chain. */
250static BlockDriver bdrv_commit_top = {
251 .format_name = "commit_top",
252 .bdrv_co_preadv = bdrv_commit_top_preadv,
253 .bdrv_close = bdrv_commit_top_close,
254 .bdrv_child_perm = bdrv_commit_top_child_perm,
255};
256
fd62c609
AG
257void commit_start(const char *job_id, BlockDriverState *bs,
258 BlockDriverState *base, BlockDriverState *top, int64_t speed,
8254b6d9
JS
259 BlockdevOnError on_error, const char *backing_file_str,
260 Error **errp)
747ff602
JC
261{
262 CommitBlockJob *s;
263 BlockReopenQueue *reopen_queue = NULL;
264 int orig_overlay_flags;
265 int orig_base_flags;
3e4c5122 266 BlockDriverState *iter;
747ff602 267 BlockDriverState *overlay_bs;
8dfba279 268 BlockDriverState *commit_top_bs = NULL;
747ff602 269 Error *local_err = NULL;
d7086422 270 int ret;
747ff602 271
18da7f94 272 assert(top != bs);
747ff602
JC
273 if (top == base) {
274 error_setg(errp, "Invalid files for merge: top and base are the same");
275 return;
276 }
277
747ff602
JC
278 overlay_bs = bdrv_find_overlay(bs, top);
279
280 if (overlay_bs == NULL) {
281 error_setg(errp, "Could not find overlay image for %s:", top->filename);
282 return;
283 }
284
c6cc12bf
KW
285 s = block_job_create(job_id, &commit_job_driver, bs, 0, BLK_PERM_ALL,
286 speed, BLOCK_JOB_DEFAULT, NULL, NULL, errp);
834fe28d
AG
287 if (!s) {
288 return;
289 }
290
747ff602
JC
291 orig_base_flags = bdrv_get_flags(base);
292 orig_overlay_flags = bdrv_get_flags(overlay_bs);
293
294 /* convert base & overlay_bs to r/w, if necessary */
3db2bd55
AG
295 if (!(orig_base_flags & BDRV_O_RDWR)) {
296 reopen_queue = bdrv_reopen_queue(reopen_queue, base, NULL,
297 orig_base_flags | BDRV_O_RDWR);
298 }
0fe282bb
AG
299 if (!(orig_overlay_flags & BDRV_O_RDWR)) {
300 reopen_queue = bdrv_reopen_queue(reopen_queue, overlay_bs, NULL,
301 orig_overlay_flags | BDRV_O_RDWR);
302 }
747ff602 303 if (reopen_queue) {
720150f3 304 bdrv_reopen_multiple(bdrv_get_aio_context(bs), reopen_queue, &local_err);
747ff602
JC
305 if (local_err != NULL) {
306 error_propagate(errp, local_err);
d7086422 307 goto fail;
747ff602
JC
308 }
309 }
310
8dfba279
KW
311 /* Insert commit_top block node above top, so we can block consistent read
312 * on the backing chain below it */
313 commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, NULL, 0, errp);
314 if (commit_top_bs == NULL) {
315 goto fail;
316 }
317
318 bdrv_set_backing_hd(commit_top_bs, top);
319 bdrv_set_backing_hd(overlay_bs, commit_top_bs);
320
321 s->commit_top_bs = commit_top_bs;
322 bdrv_unref(commit_top_bs);
747ff602 323
3e4c5122
AG
324 /* Block all nodes between top and base, because they will
325 * disappear from the chain after this operation. */
326 assert(bdrv_chain_contains(top, base));
8dfba279
KW
327 for (iter = top; iter != base; iter = backing_bs(iter)) {
328 /* XXX BLK_PERM_WRITE needs to be allowed so we don't block ourselves
329 * at s->base (if writes are blocked for a node, they are also blocked
330 * for its backing file). The other options would be a second filter
331 * driver above s->base. */
332 ret = block_job_add_bdrv(&s->common, "intermediate node", iter, 0,
333 BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE,
334 errp);
335 if (ret < 0) {
336 goto fail;
337 }
3e4c5122 338 }
8dfba279
KW
339
340 ret = block_job_add_bdrv(&s->common, "base", base, 0, BLK_PERM_ALL, errp);
341 if (ret < 0) {
342 goto fail;
343 }
344
3e4c5122 345 /* overlay_bs must be blocked because it needs to be modified to
8dfba279
KW
346 * update the backing image string. */
347 ret = block_job_add_bdrv(&s->common, "overlay of top", overlay_bs,
348 BLK_PERM_GRAPH_MOD, BLK_PERM_ALL, errp);
349 if (ret < 0) {
350 goto fail;
3e4c5122
AG
351 }
352
8dfba279
KW
353 s->base = blk_new(BLK_PERM_CONSISTENT_READ
354 | BLK_PERM_WRITE
355 | BLK_PERM_RESIZE,
356 BLK_PERM_CONSISTENT_READ
357 | BLK_PERM_GRAPH_MOD
358 | BLK_PERM_WRITE_UNCHANGED);
d7086422
KW
359 ret = blk_insert_bs(s->base, base, errp);
360 if (ret < 0) {
361 goto fail;
362 }
4653456a 363
8dfba279 364 /* Required permissions are already taken with block_job_add_bdrv() */
6d0eb64d 365 s->top = blk_new(0, BLK_PERM_ALL);
8dfba279 366 blk_insert_bs(s->top, top, errp);
d7086422
KW
367 if (ret < 0) {
368 goto fail;
369 }
4653456a 370
747ff602
JC
371 s->active = bs;
372
373 s->base_flags = orig_base_flags;
374 s->orig_overlay_flags = orig_overlay_flags;
375
54e26900
JC
376 s->backing_file_str = g_strdup(backing_file_str);
377
747ff602 378 s->on_error = on_error;
747ff602 379
5ccac6f1
JS
380 trace_commit_start(bs, base, top, s);
381 block_job_start(&s->common);
d7086422
KW
382 return;
383
384fail:
385 if (s->base) {
386 blk_unref(s->base);
387 }
388 if (s->top) {
389 blk_unref(s->top);
390 }
8dfba279
KW
391 if (commit_top_bs) {
392 bdrv_set_backing_hd(overlay_bs, top);
393 }
d7086422 394 block_job_unref(&s->common);
747ff602 395}
83fd6dd3
KW
396
397
398#define COMMIT_BUF_SECTORS 2048
399
400/* commit COW file into the raw image */
401int bdrv_commit(BlockDriverState *bs)
402{
f8e2bd53 403 BlockBackend *src, *backing;
83fd6dd3
KW
404 BlockDriver *drv = bs->drv;
405 int64_t sector, total_sectors, length, backing_length;
406 int n, ro, open_flags;
407 int ret = 0;
408 uint8_t *buf = NULL;
409
410 if (!drv)
411 return -ENOMEDIUM;
412
413 if (!bs->backing) {
414 return -ENOTSUP;
415 }
416
417 if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_COMMIT_SOURCE, NULL) ||
418 bdrv_op_is_blocked(bs->backing->bs, BLOCK_OP_TYPE_COMMIT_TARGET, NULL)) {
419 return -EBUSY;
420 }
421
422 ro = bs->backing->bs->read_only;
423 open_flags = bs->backing->bs->open_flags;
424
425 if (ro) {
426 if (bdrv_reopen(bs->backing->bs, open_flags | BDRV_O_RDWR, NULL)) {
427 return -EACCES;
428 }
429 }
430
6d0eb64d
KW
431 /* FIXME Use real permissions */
432 src = blk_new(0, BLK_PERM_ALL);
6d0eb64d 433 backing = blk_new(0, BLK_PERM_ALL);
d7086422
KW
434
435 ret = blk_insert_bs(src, bs, NULL);
436 if (ret < 0) {
437 goto ro_cleanup;
438 }
439
440 ret = blk_insert_bs(backing, bs->backing->bs, NULL);
441 if (ret < 0) {
442 goto ro_cleanup;
443 }
f8e2bd53
KW
444
445 length = blk_getlength(src);
83fd6dd3
KW
446 if (length < 0) {
447 ret = length;
448 goto ro_cleanup;
449 }
450
f8e2bd53 451 backing_length = blk_getlength(backing);
83fd6dd3
KW
452 if (backing_length < 0) {
453 ret = backing_length;
454 goto ro_cleanup;
455 }
456
457 /* If our top snapshot is larger than the backing file image,
458 * grow the backing file image if possible. If not possible,
459 * we must return an error */
460 if (length > backing_length) {
f8e2bd53 461 ret = blk_truncate(backing, length);
83fd6dd3
KW
462 if (ret < 0) {
463 goto ro_cleanup;
464 }
465 }
466
467 total_sectors = length >> BDRV_SECTOR_BITS;
468
f8e2bd53
KW
469 /* blk_try_blockalign() for src will choose an alignment that works for
470 * backing as well, so no need to compare the alignment manually. */
471 buf = blk_try_blockalign(src, COMMIT_BUF_SECTORS * BDRV_SECTOR_SIZE);
83fd6dd3
KW
472 if (buf == NULL) {
473 ret = -ENOMEM;
474 goto ro_cleanup;
475 }
476
477 for (sector = 0; sector < total_sectors; sector += n) {
478 ret = bdrv_is_allocated(bs, sector, COMMIT_BUF_SECTORS, &n);
479 if (ret < 0) {
480 goto ro_cleanup;
481 }
482 if (ret) {
f8e2bd53
KW
483 ret = blk_pread(src, sector * BDRV_SECTOR_SIZE, buf,
484 n * BDRV_SECTOR_SIZE);
83fd6dd3
KW
485 if (ret < 0) {
486 goto ro_cleanup;
487 }
488
f8e2bd53
KW
489 ret = blk_pwrite(backing, sector * BDRV_SECTOR_SIZE, buf,
490 n * BDRV_SECTOR_SIZE, 0);
83fd6dd3
KW
491 if (ret < 0) {
492 goto ro_cleanup;
493 }
494 }
495 }
496
497 if (drv->bdrv_make_empty) {
498 ret = drv->bdrv_make_empty(bs);
499 if (ret < 0) {
500 goto ro_cleanup;
501 }
f8e2bd53 502 blk_flush(src);
83fd6dd3
KW
503 }
504
505 /*
506 * Make sure all data we wrote to the backing device is actually
507 * stable on disk.
508 */
f8e2bd53 509 blk_flush(backing);
83fd6dd3
KW
510
511 ret = 0;
512ro_cleanup:
513 qemu_vfree(buf);
514
f8e2bd53
KW
515 blk_unref(src);
516 blk_unref(backing);
517
83fd6dd3
KW
518 if (ro) {
519 /* ignoring error return here */
520 bdrv_reopen(bs->backing->bs, open_flags & ~BDRV_O_RDWR, NULL);
521 }
522
523 return ret;
524}