]> git.proxmox.com Git - mirror_qemu.git/blame - block/commit.c
Merge tag 'pull-maintainer-may24-160524-2' of https://gitlab.com/stsquad/qemu into...
[mirror_qemu.git] / block / commit.c
CommitLineData
747ff602
JC
1/*
2 * Live block commit
3 *
4 * Copyright Red Hat, Inc. 2012
5 *
6 * Authors:
7 * Jeff Cody <jcody@redhat.com>
8 * Based on stream.c by Stefan Hajnoczi
9 *
10 * This work is licensed under the terms of the GNU LGPL, version 2 or later.
11 * See the COPYING.LIB file in the top-level directory.
12 *
13 */
14
80c71a24 15#include "qemu/osdep.h"
dcbf37ce 16#include "qemu/cutils.h"
747ff602 17#include "trace.h"
737e150e 18#include "block/block_int.h"
c87621ea 19#include "block/blockjob_int.h"
da34e65c 20#include "qapi/error.h"
747ff602 21#include "qemu/ratelimit.h"
5df022cf 22#include "qemu/memalign.h"
373340b2 23#include "sysemu/block-backend.h"
747ff602
JC
24
25enum {
26 /*
27 * Size of data buffer for populating the image file. This should be large
28 * enough to process multiple clusters in a single call, so that populating
29 * contiguous regions of the image is efficient.
30 */
31 COMMIT_BUFFER_SIZE = 512 * 1024, /* in bytes */
32};
33
747ff602
JC
34typedef struct CommitBlockJob {
35 BlockJob common;
8dfba279 36 BlockDriverState *commit_top_bs;
4653456a
KW
37 BlockBackend *top;
38 BlockBackend *base;
22dffcbe 39 BlockDriverState *base_bs;
9a71b9de 40 BlockDriverState *base_overlay;
92aa5c6d 41 BlockdevOnError on_error;
e70cdc57 42 bool base_read_only;
df827336 43 bool chain_frozen;
54e26900 44 char *backing_file_str;
4b028cbe 45 bool backing_mask_protocol;
747ff602
JC
46} CommitBlockJob;
47
22dffcbe 48static int commit_prepare(Job *job)
747ff602 49{
1908a559 50 CommitBlockJob *s = container_of(job, CommitBlockJob, common.job);
19ebd13e 51
9275fc72 52 bdrv_graph_rdlock_main_loop();
df827336
AG
53 bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs);
54 s->chain_frozen = false;
9275fc72 55 bdrv_graph_rdunlock_main_loop();
df827336 56
8dfba279
KW
57 /* Remove base node parent that still uses BLK_PERM_WRITE/RESIZE before
58 * the normal backing chain can be restored. */
59 blk_unref(s->base);
22dffcbe
JS
60 s->base = NULL;
61
62 /* FIXME: bdrv_drop_intermediate treats total failures and partial failures
63 * identically. Further work is needed to disambiguate these cases. */
64 return bdrv_drop_intermediate(s->commit_top_bs, s->base_bs,
4b028cbe
PK
65 s->backing_file_str,
66 s->backing_mask_protocol);
22dffcbe 67}
9e85cd5c 68
22dffcbe
JS
69static void commit_abort(Job *job)
70{
71 CommitBlockJob *s = container_of(job, CommitBlockJob, common.job);
72 BlockDriverState *top_bs = blk_bs(s->top);
ccd6a379 73 BlockDriverState *commit_top_backing_bs;
22dffcbe 74
df827336 75 if (s->chain_frozen) {
9275fc72 76 bdrv_graph_rdlock_main_loop();
df827336 77 bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs);
9275fc72 78 bdrv_graph_rdunlock_main_loop();
df827336
AG
79 }
80
22dffcbe
JS
81 /* Make sure commit_top_bs and top stay around until bdrv_replace_node() */
82 bdrv_ref(top_bs);
83 bdrv_ref(s->commit_top_bs);
84
85 if (s->base) {
86 blk_unref(s->base);
9e85cd5c
SH
87 }
88
22dffcbe
JS
89 /* free the blockers on the intermediate nodes so that bdrv_replace_nodes
90 * can succeed */
91 block_job_remove_all_bdrv(&s->common);
92
93 /* If bdrv_drop_intermediate() failed (or was not invoked), remove the
94 * commit filter driver from the backing chain now. Do this as the final
95 * step so that the 'consistent read' permission can be granted.
96 *
97 * XXX Can (or should) we somehow keep 'consistent read' blocked even
98 * after the failed/cancelled commit job is gone? If we already wrote
99 * something to base, the intermediate images aren't valid any more. */
004915a9 100 bdrv_graph_rdlock_main_loop();
ccd6a379 101 commit_top_backing_bs = s->commit_top_bs->backing->bs;
004915a9
KW
102 bdrv_graph_rdunlock_main_loop();
103
ccd6a379 104 bdrv_drained_begin(commit_top_backing_bs);
6bc30f19 105 bdrv_graph_wrlock();
ccd6a379 106 bdrv_replace_node(s->commit_top_bs, commit_top_backing_bs, &error_abort);
6bc30f19 107 bdrv_graph_wrunlock();
ccd6a379 108 bdrv_drained_end(commit_top_backing_bs);
22dffcbe
JS
109
110 bdrv_unref(s->commit_top_bs);
111 bdrv_unref(top_bs);
112}
113
114static void commit_clean(Job *job)
115{
116 CommitBlockJob *s = container_of(job, CommitBlockJob, common.job);
117
9e85cd5c
SH
118 /* restore base open flags here if appropriate (e.g., change the base back
119 * to r/o). These reopens do not need to be atomic, since we won't abort
120 * even on failure here */
e70cdc57
AG
121 if (s->base_read_only) {
122 bdrv_reopen_set_read_only(s->base_bs, true, NULL);
9e85cd5c 123 }
22dffcbe 124
9e85cd5c 125 g_free(s->backing_file_str);
4653456a 126 blk_unref(s->top);
9e85cd5c
SH
127}
128
f67432a2 129static int coroutine_fn commit_run(Job *job, Error **errp)
9e85cd5c 130{
f67432a2 131 CommitBlockJob *s = container_of(job, CommitBlockJob, common.job);
317a6676 132 int64_t offset;
747ff602 133 int ret = 0;
51b0a488 134 int64_t n = 0; /* bytes */
71701708 135 QEMU_AUTO_VFREE void *buf = NULL;
05df8a6a 136 int64_t len, base_len;
747ff602 137
c86422c5 138 len = blk_co_getlength(s->top);
05df8a6a 139 if (len < 0) {
71701708 140 return len;
747ff602 141 }
30a5c887 142 job_progress_set_remaining(&s->common.job, len);
747ff602 143
c86422c5 144 base_len = blk_co_getlength(s->base);
747ff602 145 if (base_len < 0) {
71701708 146 return base_len;
747ff602
JC
147 }
148
05df8a6a 149 if (base_len < len) {
a0667887 150 ret = blk_co_truncate(s->base, len, false, PREALLOC_MODE_OFF, 0, NULL);
747ff602 151 if (ret) {
71701708 152 return ret;
747ff602
JC
153 }
154 }
155
4653456a 156 buf = blk_blockalign(s->top, COMMIT_BUFFER_SIZE);
747ff602 157
05df8a6a 158 for (offset = 0; offset < len; offset += n) {
747ff602 159 bool copy;
9ad1e79f 160 bool error_in_source = true;
747ff602 161
747ff602 162 /* Note that even when no rate limit is applied we need to yield
c57b6656 163 * with no pending I/O here so that bdrv_drain_all() returns.
747ff602 164 */
018e5987 165 block_job_ratelimit_sleep(&s->common);
daa7f2f9 166 if (job_is_cancelled(&s->common.job)) {
747ff602
JC
167 break;
168 }
169 /* Copy if allocated above the base */
ff7e261b
EGE
170 ret = blk_co_is_allocated_above(s->top, s->base_overlay, true,
171 offset, COMMIT_BUFFER_SIZE, &n);
a92b1b06 172 copy = (ret > 0);
51b0a488 173 trace_commit_one_iteration(s, offset, n, ret);
747ff602 174 if (copy) {
0c42e175
KW
175 assert(n < SIZE_MAX);
176
177 ret = blk_co_pread(s->top, offset, n, buf, 0);
178 if (ret >= 0) {
179 ret = blk_co_pwrite(s->base, offset, n, buf, 0);
9ad1e79f
KW
180 if (ret < 0) {
181 error_in_source = false;
182 }
0c42e175 183 }
747ff602
JC
184 }
185 if (ret < 0) {
1e8fb7f1 186 BlockErrorAction action =
9ad1e79f
KW
187 block_job_error_action(&s->common, s->on_error,
188 error_in_source, -ret);
1e8fb7f1 189 if (action == BLOCK_ERROR_ACTION_REPORT) {
71701708 190 return ret;
747ff602
JC
191 } else {
192 n = 0;
193 continue;
194 }
195 }
196 /* Publish progress */
30a5c887 197 job_progress_update(&s->common.job, n);
f14a39cc 198
dee81d51 199 if (copy) {
018e5987 200 block_job_ratelimit_processed_bytes(&s->common, n);
f14a39cc 201 }
747ff602
JC
202 }
203
71701708 204 return 0;
747ff602
JC
205}
206
3fc4b10a 207static const BlockJobDriver commit_job_driver = {
33e9e9bd
KW
208 .job_driver = {
209 .instance_size = sizeof(CommitBlockJob),
252291ea 210 .job_type = JOB_TYPE_COMMIT,
80fa2c75 211 .free = block_job_free,
b15de828 212 .user_resume = block_job_user_resume,
f67432a2 213 .run = commit_run,
22dffcbe
JS
214 .prepare = commit_prepare,
215 .abort = commit_abort,
216 .clean = commit_clean
33e9e9bd 217 },
747ff602
JC
218};
219
b9b10c35
KW
220static int coroutine_fn GRAPH_RDLOCK
221bdrv_commit_top_preadv(BlockDriverState *bs, int64_t offset, int64_t bytes,
222 QEMUIOVector *qiov, BdrvRequestFlags flags)
8dfba279
KW
223{
224 return bdrv_co_preadv(bs->backing, offset, bytes, qiov, flags);
225}
226
004915a9 227static GRAPH_RDLOCK void bdrv_commit_top_refresh_filename(BlockDriverState *bs)
dcbf37ce 228{
dcbf37ce
KW
229 pstrcpy(bs->exact_filename, sizeof(bs->exact_filename),
230 bs->backing->bs->filename);
231}
91965658 232
8dfba279 233static void bdrv_commit_top_child_perm(BlockDriverState *bs, BdrvChild *c,
bf8e925e 234 BdrvChildRole role,
e0995dc3 235 BlockReopenQueue *reopen_queue,
8dfba279
KW
236 uint64_t perm, uint64_t shared,
237 uint64_t *nperm, uint64_t *nshared)
238{
239 *nperm = 0;
240 *nshared = BLK_PERM_ALL;
241}
242
243/* Dummy node that provides consistent read to its users without requiring it
244 * from its backing file and that allows writes on the backing file chain. */
245static BlockDriver bdrv_commit_top = {
91965658
KW
246 .format_name = "commit_top",
247 .bdrv_co_preadv = bdrv_commit_top_preadv,
dcbf37ce 248 .bdrv_refresh_filename = bdrv_commit_top_refresh_filename,
91965658 249 .bdrv_child_perm = bdrv_commit_top_child_perm,
6540fd15
HR
250
251 .is_filter = true,
046fd84f 252 .filtered_child_is_backing = true,
8dfba279
KW
253};
254
fd62c609 255void commit_start(const char *job_id, BlockDriverState *bs,
5360782d
JS
256 BlockDriverState *base, BlockDriverState *top,
257 int creation_flags, int64_t speed,
8254b6d9 258 BlockdevOnError on_error, const char *backing_file_str,
4b028cbe 259 bool backing_mask_protocol,
0db832f4 260 const char *filter_node_name, Error **errp)
747ff602
JC
261{
262 CommitBlockJob *s;
3e4c5122 263 BlockDriverState *iter;
8dfba279 264 BlockDriverState *commit_top_bs = NULL;
9a71b9de 265 BlockDriverState *filtered_base;
9a71b9de
HR
266 int64_t base_size, top_size;
267 uint64_t base_perms, iter_shared_perms;
d7086422 268 int ret;
747ff602 269
b4ad82aa
EGE
270 GLOBAL_STATE_CODE();
271
18da7f94 272 assert(top != bs);
ad74751f 273 bdrv_graph_rdlock_main_loop();
9a71b9de 274 if (bdrv_skip_filters(top) == bdrv_skip_filters(base)) {
747ff602 275 error_setg(errp, "Invalid files for merge: top and base are the same");
ad74751f 276 bdrv_graph_rdunlock_main_loop();
747ff602
JC
277 return;
278 }
ad74751f 279 bdrv_graph_rdunlock_main_loop();
747ff602 280
9a71b9de
HR
281 base_size = bdrv_getlength(base);
282 if (base_size < 0) {
283 error_setg_errno(errp, -base_size, "Could not inquire base image size");
284 return;
285 }
286
287 top_size = bdrv_getlength(top);
288 if (top_size < 0) {
289 error_setg_errno(errp, -top_size, "Could not inquire top image size");
290 return;
291 }
292
293 base_perms = BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE;
294 if (base_size < top_size) {
295 base_perms |= BLK_PERM_RESIZE;
296 }
297
75859b94 298 s = block_job_create(job_id, &commit_job_driver, NULL, bs, 0, BLK_PERM_ALL,
5360782d 299 speed, creation_flags, NULL, NULL, errp);
834fe28d
AG
300 if (!s) {
301 return;
302 }
303
bde70715 304 /* convert base to r/w, if necessary */
e70cdc57
AG
305 s->base_read_only = bdrv_is_read_only(base);
306 if (s->base_read_only) {
307 if (bdrv_reopen_set_read_only(base, false, errp) != 0) {
d7086422 308 goto fail;
747ff602
JC
309 }
310 }
311
8dfba279
KW
312 /* Insert commit_top block node above top, so we can block consistent read
313 * on the backing chain below it */
0db832f4
KW
314 commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, filter_node_name, 0,
315 errp);
8dfba279
KW
316 if (commit_top_bs == NULL) {
317 goto fail;
318 }
d3c8c674
KW
319 if (!filter_node_name) {
320 commit_top_bs->implicit = true;
321 }
e5182c1c
HR
322
323 /* So that we can always drop this node */
324 commit_top_bs->never_freeze = true;
325
0d0676a1 326 commit_top_bs->total_sectors = top->total_sectors;
8dfba279 327
934aee14 328 ret = bdrv_append(commit_top_bs, top, errp);
ae9d4417 329 bdrv_unref(commit_top_bs); /* referenced by new parents or failed */
934aee14 330 if (ret < 0) {
b69f00dd 331 commit_top_bs = NULL;
b69f00dd
FZ
332 goto fail;
333 }
8dfba279
KW
334
335 s->commit_top_bs = commit_top_bs;
747ff602 336
9a71b9de
HR
337 /*
338 * Block all nodes between top and base, because they will
339 * disappear from the chain after this operation.
340 * Note that this assumes that the user is fine with removing all
341 * nodes (including R/W filters) between top and base. Assuring
342 * this is the responsibility of the interface (i.e. whoever calls
343 * commit_start()).
344 */
6bc30f19 345 bdrv_graph_wrlock();
9a71b9de
HR
346 s->base_overlay = bdrv_find_overlay(top, base);
347 assert(s->base_overlay);
348
349 /*
350 * The topmost node with
351 * bdrv_skip_filters(filtered_base) == bdrv_skip_filters(base)
352 */
353 filtered_base = bdrv_cow_bs(s->base_overlay);
354 assert(bdrv_skip_filters(filtered_base) == bdrv_skip_filters(base));
355
356 /*
357 * XXX BLK_PERM_WRITE needs to be allowed so we don't block ourselves
358 * at s->base (if writes are blocked for a node, they are also blocked
359 * for its backing file). The other options would be a second filter
360 * driver above s->base.
361 */
362 iter_shared_perms = BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE;
363
364 for (iter = top; iter != base; iter = bdrv_filter_or_cow_bs(iter)) {
365 if (iter == filtered_base) {
366 /*
367 * From here on, all nodes are filters on the base. This
368 * allows us to share BLK_PERM_CONSISTENT_READ.
369 */
370 iter_shared_perms |= BLK_PERM_CONSISTENT_READ;
371 }
372
8dfba279 373 ret = block_job_add_bdrv(&s->common, "intermediate node", iter, 0,
9a71b9de 374 iter_shared_perms, errp);
8dfba279 375 if (ret < 0) {
6bc30f19 376 bdrv_graph_wrunlock();
8dfba279
KW
377 goto fail;
378 }
3e4c5122 379 }
8dfba279 380
df827336 381 if (bdrv_freeze_backing_chain(commit_top_bs, base, errp) < 0) {
6bc30f19 382 bdrv_graph_wrunlock();
df827336
AG
383 goto fail;
384 }
385 s->chain_frozen = true;
386
8dfba279 387 ret = block_job_add_bdrv(&s->common, "base", base, 0, BLK_PERM_ALL, errp);
6bc30f19 388 bdrv_graph_wrunlock();
f3bbc53d 389
8dfba279
KW
390 if (ret < 0) {
391 goto fail;
392 }
393
d861ab3a 394 s->base = blk_new(s->common.job.aio_context,
9a71b9de 395 base_perms,
8dfba279 396 BLK_PERM_CONSISTENT_READ
8dfba279 397 | BLK_PERM_WRITE_UNCHANGED);
d7086422
KW
398 ret = blk_insert_bs(s->base, base, errp);
399 if (ret < 0) {
400 goto fail;
401 }
cf312932 402 blk_set_disable_request_queuing(s->base, true);
22dffcbe 403 s->base_bs = base;
4653456a 404
8dfba279 405 /* Required permissions are already taken with block_job_add_bdrv() */
d861ab3a 406 s->top = blk_new(s->common.job.aio_context, 0, BLK_PERM_ALL);
b247767a 407 ret = blk_insert_bs(s->top, top, errp);
d7086422
KW
408 if (ret < 0) {
409 goto fail;
410 }
cf312932 411 blk_set_disable_request_queuing(s->top, true);
4653456a 412
54e26900 413 s->backing_file_str = g_strdup(backing_file_str);
4b028cbe 414 s->backing_mask_protocol = backing_mask_protocol;
747ff602 415 s->on_error = on_error;
747ff602 416
5ccac6f1 417 trace_commit_start(bs, base, top, s);
da01ff7f 418 job_start(&s->common.job);
d7086422
KW
419 return;
420
421fail:
df827336 422 if (s->chain_frozen) {
9275fc72 423 bdrv_graph_rdlock_main_loop();
df827336 424 bdrv_unfreeze_backing_chain(commit_top_bs, base);
9275fc72 425 bdrv_graph_rdunlock_main_loop();
df827336 426 }
d7086422
KW
427 if (s->base) {
428 blk_unref(s->base);
429 }
430 if (s->top) {
431 blk_unref(s->top);
432 }
065abf9f
AG
433 if (s->base_read_only) {
434 bdrv_reopen_set_read_only(base, true, NULL);
435 }
2468eed3
AG
436 job_early_fail(&s->common.job);
437 /* commit_top_bs has to be replaced after deleting the block job,
438 * otherwise this would fail because of lack of permissions. */
8dfba279 439 if (commit_top_bs) {
ccd6a379 440 bdrv_drained_begin(top);
6bc30f19 441 bdrv_graph_wrlock();
bde70715 442 bdrv_replace_node(commit_top_bs, top, &error_abort);
6bc30f19 443 bdrv_graph_wrunlock();
ccd6a379 444 bdrv_drained_end(top);
8dfba279 445 }
747ff602 446}
83fd6dd3
KW
447
448
d6a644bb 449#define COMMIT_BUF_SIZE (2048 * BDRV_SECTOR_SIZE)
83fd6dd3
KW
450
451/* commit COW file into the raw image */
452int bdrv_commit(BlockDriverState *bs)
453{
f8e2bd53 454 BlockBackend *src, *backing;
d3f06759
KW
455 BlockDriverState *backing_file_bs = NULL;
456 BlockDriverState *commit_top_bs = NULL;
83fd6dd3 457 BlockDriver *drv = bs->drv;
d861ab3a 458 AioContext *ctx;
d6a644bb 459 int64_t offset, length, backing_length;
c742a364 460 int ro;
d6a644bb 461 int64_t n;
83fd6dd3 462 int ret = 0;
71701708 463 QEMU_AUTO_VFREE uint8_t *buf = NULL;
d3f06759 464 Error *local_err = NULL;
83fd6dd3 465
f791bf7f 466 GLOBAL_STATE_CODE();
277f2007 467 GRAPH_RDLOCK_GUARD_MAINLOOP();
f791bf7f 468
83fd6dd3
KW
469 if (!drv)
470 return -ENOMEDIUM;
471
9a71b9de
HR
472 backing_file_bs = bdrv_cow_bs(bs);
473
474 if (!backing_file_bs) {
83fd6dd3
KW
475 return -ENOTSUP;
476 }
477
478 if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_COMMIT_SOURCE, NULL) ||
9a71b9de
HR
479 bdrv_op_is_blocked(backing_file_bs, BLOCK_OP_TYPE_COMMIT_TARGET, NULL))
480 {
83fd6dd3
KW
481 return -EBUSY;
482 }
483
307261b2 484 ro = bdrv_is_read_only(backing_file_bs);
83fd6dd3
KW
485
486 if (ro) {
9a71b9de 487 if (bdrv_reopen_set_read_only(backing_file_bs, false, NULL)) {
83fd6dd3
KW
488 return -EACCES;
489 }
490 }
491
d861ab3a 492 ctx = bdrv_get_aio_context(bs);
2d97fde4
HR
493 /* WRITE_UNCHANGED is required for bdrv_make_empty() */
494 src = blk_new(ctx, BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE_UNCHANGED,
495 BLK_PERM_ALL);
d861ab3a 496 backing = blk_new(ctx, BLK_PERM_WRITE | BLK_PERM_RESIZE, BLK_PERM_ALL);
d7086422 497
d3f06759 498 ret = blk_insert_bs(src, bs, &local_err);
d7086422 499 if (ret < 0) {
d3f06759
KW
500 error_report_err(local_err);
501 goto ro_cleanup;
502 }
503
504 /* Insert commit_top block node above backing, so we can write to it */
d3f06759
KW
505 commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, NULL, BDRV_O_RDWR,
506 &local_err);
507 if (commit_top_bs == NULL) {
508 error_report_err(local_err);
d7086422
KW
509 goto ro_cleanup;
510 }
511
12fa4af6
KW
512 bdrv_set_backing_hd(commit_top_bs, backing_file_bs, &error_abort);
513 bdrv_set_backing_hd(bs, commit_top_bs, &error_abort);
d3f06759
KW
514
515 ret = blk_insert_bs(backing, backing_file_bs, &local_err);
d7086422 516 if (ret < 0) {
d3f06759 517 error_report_err(local_err);
d7086422
KW
518 goto ro_cleanup;
519 }
f8e2bd53
KW
520
521 length = blk_getlength(src);
83fd6dd3
KW
522 if (length < 0) {
523 ret = length;
524 goto ro_cleanup;
525 }
526
f8e2bd53 527 backing_length = blk_getlength(backing);
83fd6dd3
KW
528 if (backing_length < 0) {
529 ret = backing_length;
530 goto ro_cleanup;
531 }
532
533 /* If our top snapshot is larger than the backing file image,
534 * grow the backing file image if possible. If not possible,
535 * we must return an error */
536 if (length > backing_length) {
8c6242b6 537 ret = blk_truncate(backing, length, false, PREALLOC_MODE_OFF, 0,
c80d8b06 538 &local_err);
83fd6dd3 539 if (ret < 0) {
ed3d2ec9 540 error_report_err(local_err);
83fd6dd3
KW
541 goto ro_cleanup;
542 }
543 }
544
f8e2bd53
KW
545 /* blk_try_blockalign() for src will choose an alignment that works for
546 * backing as well, so no need to compare the alignment manually. */
d6a644bb 547 buf = blk_try_blockalign(src, COMMIT_BUF_SIZE);
83fd6dd3
KW
548 if (buf == NULL) {
549 ret = -ENOMEM;
550 goto ro_cleanup;
551 }
552
d6a644bb
EB
553 for (offset = 0; offset < length; offset += n) {
554 ret = bdrv_is_allocated(bs, offset, COMMIT_BUF_SIZE, &n);
83fd6dd3
KW
555 if (ret < 0) {
556 goto ro_cleanup;
557 }
558 if (ret) {
a9262f55 559 ret = blk_pread(src, offset, n, buf, 0);
83fd6dd3
KW
560 if (ret < 0) {
561 goto ro_cleanup;
562 }
563
a9262f55 564 ret = blk_pwrite(backing, offset, n, buf, 0);
83fd6dd3
KW
565 if (ret < 0) {
566 goto ro_cleanup;
567 }
568 }
569 }
570
2d97fde4
HR
571 ret = blk_make_empty(src, NULL);
572 /* Ignore -ENOTSUP */
573 if (ret < 0 && ret != -ENOTSUP) {
574 goto ro_cleanup;
83fd6dd3
KW
575 }
576
2d97fde4
HR
577 blk_flush(src);
578
83fd6dd3
KW
579 /*
580 * Make sure all data we wrote to the backing device is actually
581 * stable on disk.
582 */
f8e2bd53 583 blk_flush(backing);
83fd6dd3
KW
584
585 ret = 0;
586ro_cleanup:
f8e2bd53 587 blk_unref(backing);
9a71b9de 588 if (bdrv_cow_bs(bs) != backing_file_bs) {
12fa4af6 589 bdrv_set_backing_hd(bs, backing_file_bs, &error_abort);
d3f06759
KW
590 }
591 bdrv_unref(commit_top_bs);
592 blk_unref(src);
f8e2bd53 593
83fd6dd3
KW
594 if (ro) {
595 /* ignoring error return here */
9a71b9de 596 bdrv_reopen_set_read_only(backing_file_bs, true, NULL);
83fd6dd3
KW
597 }
598
599 return ret;
600}