]>
Commit | Line | Data |
---|---|---|
893f7eba PB |
1 | /* |
2 | * Image mirroring | |
3 | * | |
4 | * Copyright Red Hat, Inc. 2012 | |
5 | * | |
6 | * Authors: | |
7 | * Paolo Bonzini <pbonzini@redhat.com> | |
8 | * | |
9 | * This work is licensed under the terms of the GNU LGPL, version 2 or later. | |
10 | * See the COPYING.LIB file in the top-level directory. | |
11 | * | |
12 | */ | |
13 | ||
80c71a24 | 14 | #include "qemu/osdep.h" |
893f7eba | 15 | #include "trace.h" |
737e150e PB |
16 | #include "block/blockjob.h" |
17 | #include "block/block_int.h" | |
373340b2 | 18 | #include "sysemu/block-backend.h" |
da34e65c | 19 | #include "qapi/error.h" |
cc7a8ea7 | 20 | #include "qapi/qmp/qerror.h" |
893f7eba | 21 | #include "qemu/ratelimit.h" |
b812f671 | 22 | #include "qemu/bitmap.h" |
893f7eba | 23 | |
402a4741 PB |
24 | #define SLICE_TIME 100000000ULL /* ns */ |
25 | #define MAX_IN_FLIGHT 16 | |
48ac0a4d | 26 | #define DEFAULT_MIRROR_BUF_SIZE (10 << 20) |
402a4741 PB |
27 | |
28 | /* The mirroring buffer is a list of granularity-sized chunks. | |
29 | * Free chunks are organized in a list. | |
30 | */ | |
31 | typedef struct MirrorBuffer { | |
32 | QSIMPLEQ_ENTRY(MirrorBuffer) next; | |
33 | } MirrorBuffer; | |
893f7eba PB |
34 | |
35 | typedef struct MirrorBlockJob { | |
36 | BlockJob common; | |
37 | RateLimit limit; | |
e253f4b8 | 38 | BlockBackend *target; |
5bc361b8 | 39 | BlockDriverState *base; |
09158f00 BC |
40 | /* The name of the graph node to replace */ |
41 | char *replaces; | |
42 | /* The BDS to replace */ | |
43 | BlockDriverState *to_replace; | |
44 | /* Used to block operations on the drive-mirror-replace target */ | |
45 | Error *replace_blocker; | |
03544a6e | 46 | bool is_none_mode; |
274fccee | 47 | BlockMirrorBackingMode backing_mode; |
b952b558 | 48 | BlockdevOnError on_source_error, on_target_error; |
d63ffd87 PB |
49 | bool synced; |
50 | bool should_complete; | |
eee13dfe | 51 | int64_t granularity; |
b812f671 | 52 | size_t buf_size; |
b21c7652 | 53 | int64_t bdev_length; |
b812f671 | 54 | unsigned long *cow_bitmap; |
e4654d2d | 55 | BdrvDirtyBitmap *dirty_bitmap; |
8f0720ec | 56 | HBitmapIter hbi; |
893f7eba | 57 | uint8_t *buf; |
402a4741 PB |
58 | QSIMPLEQ_HEAD(, MirrorBuffer) buf_free; |
59 | int buf_free_count; | |
bd48bde8 | 60 | |
402a4741 | 61 | unsigned long *in_flight_bitmap; |
bd48bde8 | 62 | int in_flight; |
b21c7652 | 63 | int sectors_in_flight; |
bd48bde8 | 64 | int ret; |
0fc9f8ea | 65 | bool unmap; |
e424aff5 | 66 | bool waiting_for_io; |
e5b43573 FZ |
67 | int target_cluster_sectors; |
68 | int max_iov; | |
893f7eba PB |
69 | } MirrorBlockJob; |
70 | ||
bd48bde8 PB |
71 | typedef struct MirrorOp { |
72 | MirrorBlockJob *s; | |
73 | QEMUIOVector qiov; | |
bd48bde8 PB |
74 | int64_t sector_num; |
75 | int nb_sectors; | |
76 | } MirrorOp; | |
77 | ||
b952b558 PB |
78 | static BlockErrorAction mirror_error_action(MirrorBlockJob *s, bool read, |
79 | int error) | |
80 | { | |
81 | s->synced = false; | |
82 | if (read) { | |
81e254dc KW |
83 | return block_job_error_action(&s->common, s->on_source_error, |
84 | true, error); | |
b952b558 | 85 | } else { |
81e254dc KW |
86 | return block_job_error_action(&s->common, s->on_target_error, |
87 | false, error); | |
b952b558 PB |
88 | } |
89 | } | |
90 | ||
bd48bde8 PB |
91 | static void mirror_iteration_done(MirrorOp *op, int ret) |
92 | { | |
93 | MirrorBlockJob *s = op->s; | |
402a4741 | 94 | struct iovec *iov; |
bd48bde8 | 95 | int64_t chunk_num; |
402a4741 | 96 | int i, nb_chunks, sectors_per_chunk; |
bd48bde8 PB |
97 | |
98 | trace_mirror_iteration_done(s, op->sector_num, op->nb_sectors, ret); | |
99 | ||
100 | s->in_flight--; | |
b21c7652 | 101 | s->sectors_in_flight -= op->nb_sectors; |
402a4741 PB |
102 | iov = op->qiov.iov; |
103 | for (i = 0; i < op->qiov.niov; i++) { | |
104 | MirrorBuffer *buf = (MirrorBuffer *) iov[i].iov_base; | |
105 | QSIMPLEQ_INSERT_TAIL(&s->buf_free, buf, next); | |
106 | s->buf_free_count++; | |
107 | } | |
108 | ||
bd48bde8 PB |
109 | sectors_per_chunk = s->granularity >> BDRV_SECTOR_BITS; |
110 | chunk_num = op->sector_num / sectors_per_chunk; | |
4150ae60 | 111 | nb_chunks = DIV_ROUND_UP(op->nb_sectors, sectors_per_chunk); |
402a4741 | 112 | bitmap_clear(s->in_flight_bitmap, chunk_num, nb_chunks); |
b21c7652 HR |
113 | if (ret >= 0) { |
114 | if (s->cow_bitmap) { | |
115 | bitmap_set(s->cow_bitmap, chunk_num, nb_chunks); | |
116 | } | |
117 | s->common.offset += (uint64_t)op->nb_sectors * BDRV_SECTOR_SIZE; | |
bd48bde8 PB |
118 | } |
119 | ||
6df3bf8e | 120 | qemu_iovec_destroy(&op->qiov); |
c84b3192 | 121 | g_free(op); |
7b770c72 | 122 | |
e424aff5 | 123 | if (s->waiting_for_io) { |
7b770c72 SH |
124 | qemu_coroutine_enter(s->common.co, NULL); |
125 | } | |
bd48bde8 PB |
126 | } |
127 | ||
128 | static void mirror_write_complete(void *opaque, int ret) | |
129 | { | |
130 | MirrorOp *op = opaque; | |
131 | MirrorBlockJob *s = op->s; | |
132 | if (ret < 0) { | |
bd48bde8 PB |
133 | BlockErrorAction action; |
134 | ||
20dca810 | 135 | bdrv_set_dirty_bitmap(s->dirty_bitmap, op->sector_num, op->nb_sectors); |
bd48bde8 | 136 | action = mirror_error_action(s, false, -ret); |
a589569f | 137 | if (action == BLOCK_ERROR_ACTION_REPORT && s->ret >= 0) { |
bd48bde8 PB |
138 | s->ret = ret; |
139 | } | |
140 | } | |
141 | mirror_iteration_done(op, ret); | |
142 | } | |
143 | ||
144 | static void mirror_read_complete(void *opaque, int ret) | |
145 | { | |
146 | MirrorOp *op = opaque; | |
147 | MirrorBlockJob *s = op->s; | |
148 | if (ret < 0) { | |
bd48bde8 PB |
149 | BlockErrorAction action; |
150 | ||
20dca810 | 151 | bdrv_set_dirty_bitmap(s->dirty_bitmap, op->sector_num, op->nb_sectors); |
bd48bde8 | 152 | action = mirror_error_action(s, true, -ret); |
a589569f | 153 | if (action == BLOCK_ERROR_ACTION_REPORT && s->ret >= 0) { |
bd48bde8 PB |
154 | s->ret = ret; |
155 | } | |
156 | ||
157 | mirror_iteration_done(op, ret); | |
158 | return; | |
159 | } | |
e253f4b8 | 160 | blk_aio_pwritev(s->target, op->sector_num * BDRV_SECTOR_SIZE, &op->qiov, |
73698c30 | 161 | 0, mirror_write_complete, op); |
bd48bde8 PB |
162 | } |
163 | ||
4150ae60 FZ |
164 | static inline void mirror_clip_sectors(MirrorBlockJob *s, |
165 | int64_t sector_num, | |
166 | int *nb_sectors) | |
167 | { | |
168 | *nb_sectors = MIN(*nb_sectors, | |
169 | s->bdev_length / BDRV_SECTOR_SIZE - sector_num); | |
170 | } | |
171 | ||
e5b43573 FZ |
172 | /* Round sector_num and/or nb_sectors to target cluster if COW is needed, and |
173 | * return the offset of the adjusted tail sector against original. */ | |
174 | static int mirror_cow_align(MirrorBlockJob *s, | |
175 | int64_t *sector_num, | |
176 | int *nb_sectors) | |
893f7eba | 177 | { |
e5b43573 FZ |
178 | bool need_cow; |
179 | int ret = 0; | |
180 | int chunk_sectors = s->granularity >> BDRV_SECTOR_BITS; | |
181 | int64_t align_sector_num = *sector_num; | |
182 | int align_nb_sectors = *nb_sectors; | |
183 | int max_sectors = chunk_sectors * s->max_iov; | |
184 | ||
185 | need_cow = !test_bit(*sector_num / chunk_sectors, s->cow_bitmap); | |
186 | need_cow |= !test_bit((*sector_num + *nb_sectors - 1) / chunk_sectors, | |
187 | s->cow_bitmap); | |
188 | if (need_cow) { | |
244483e6 KW |
189 | bdrv_round_sectors_to_clusters(blk_bs(s->target), *sector_num, |
190 | *nb_sectors, &align_sector_num, | |
191 | &align_nb_sectors); | |
e5b43573 | 192 | } |
3515727f | 193 | |
e5b43573 FZ |
194 | if (align_nb_sectors > max_sectors) { |
195 | align_nb_sectors = max_sectors; | |
196 | if (need_cow) { | |
197 | align_nb_sectors = QEMU_ALIGN_DOWN(align_nb_sectors, | |
198 | s->target_cluster_sectors); | |
199 | } | |
8f0720ec | 200 | } |
4150ae60 FZ |
201 | /* Clipping may result in align_nb_sectors unaligned to chunk boundary, but |
202 | * that doesn't matter because it's already the end of source image. */ | |
203 | mirror_clip_sectors(s, align_sector_num, &align_nb_sectors); | |
8f0720ec | 204 | |
e5b43573 FZ |
205 | ret = align_sector_num + align_nb_sectors - (*sector_num + *nb_sectors); |
206 | *sector_num = align_sector_num; | |
207 | *nb_sectors = align_nb_sectors; | |
208 | assert(ret >= 0); | |
209 | return ret; | |
210 | } | |
211 | ||
21cd917f FZ |
212 | static inline void mirror_wait_for_io(MirrorBlockJob *s) |
213 | { | |
214 | assert(!s->waiting_for_io); | |
215 | s->waiting_for_io = true; | |
216 | qemu_coroutine_yield(); | |
217 | s->waiting_for_io = false; | |
218 | } | |
219 | ||
e5b43573 FZ |
220 | /* Submit async read while handling COW. |
221 | * Returns: nb_sectors if no alignment is necessary, or | |
222 | * (new_end - sector_num) if tail is rounded up or down due to | |
223 | * alignment or buffer limit. | |
224 | */ | |
225 | static int mirror_do_read(MirrorBlockJob *s, int64_t sector_num, | |
226 | int nb_sectors) | |
227 | { | |
e253f4b8 | 228 | BlockBackend *source = s->common.blk; |
e5b43573 FZ |
229 | int sectors_per_chunk, nb_chunks; |
230 | int ret = nb_sectors; | |
231 | MirrorOp *op; | |
232 | ||
884fea4e | 233 | sectors_per_chunk = s->granularity >> BDRV_SECTOR_BITS; |
402a4741 | 234 | |
e5b43573 FZ |
235 | /* We can only handle as much as buf_size at a time. */ |
236 | nb_sectors = MIN(s->buf_size >> BDRV_SECTOR_BITS, nb_sectors); | |
237 | assert(nb_sectors); | |
402a4741 | 238 | |
e5b43573 FZ |
239 | if (s->cow_bitmap) { |
240 | ret += mirror_cow_align(s, §or_num, &nb_sectors); | |
241 | } | |
242 | assert(nb_sectors << BDRV_SECTOR_BITS <= s->buf_size); | |
243 | /* The sector range must meet granularity because: | |
244 | * 1) Caller passes in aligned values; | |
245 | * 2) mirror_cow_align is used only when target cluster is larger. */ | |
e5b43573 | 246 | assert(!(sector_num % sectors_per_chunk)); |
4150ae60 | 247 | nb_chunks = DIV_ROUND_UP(nb_sectors, sectors_per_chunk); |
e5b43573 FZ |
248 | |
249 | while (s->buf_free_count < nb_chunks) { | |
402a4741 | 250 | trace_mirror_yield_in_flight(s, sector_num, s->in_flight); |
21cd917f | 251 | mirror_wait_for_io(s); |
b812f671 PB |
252 | } |
253 | ||
bd48bde8 | 254 | /* Allocate a MirrorOp that is used as an AIO callback. */ |
c84b3192 | 255 | op = g_new(MirrorOp, 1); |
bd48bde8 | 256 | op->s = s; |
bd48bde8 PB |
257 | op->sector_num = sector_num; |
258 | op->nb_sectors = nb_sectors; | |
402a4741 PB |
259 | |
260 | /* Now make a QEMUIOVector taking enough granularity-sized chunks | |
261 | * from s->buf_free. | |
262 | */ | |
263 | qemu_iovec_init(&op->qiov, nb_chunks); | |
402a4741 PB |
264 | while (nb_chunks-- > 0) { |
265 | MirrorBuffer *buf = QSIMPLEQ_FIRST(&s->buf_free); | |
e5b43573 | 266 | size_t remaining = nb_sectors * BDRV_SECTOR_SIZE - op->qiov.size; |
5a0f6fd5 | 267 | |
402a4741 PB |
268 | QSIMPLEQ_REMOVE_HEAD(&s->buf_free, next); |
269 | s->buf_free_count--; | |
5a0f6fd5 | 270 | qemu_iovec_add(&op->qiov, buf, MIN(s->granularity, remaining)); |
402a4741 | 271 | } |
bd48bde8 | 272 | |
893f7eba | 273 | /* Copy the dirty cluster. */ |
bd48bde8 | 274 | s->in_flight++; |
b21c7652 | 275 | s->sectors_in_flight += nb_sectors; |
b812f671 | 276 | trace_mirror_one_iteration(s, sector_num, nb_sectors); |
dcfb3beb | 277 | |
73698c30 | 278 | blk_aio_preadv(source, sector_num * BDRV_SECTOR_SIZE, &op->qiov, 0, |
e5b43573 FZ |
279 | mirror_read_complete, op); |
280 | return ret; | |
281 | } | |
282 | ||
283 | static void mirror_do_zero_or_discard(MirrorBlockJob *s, | |
284 | int64_t sector_num, | |
285 | int nb_sectors, | |
286 | bool is_discard) | |
287 | { | |
288 | MirrorOp *op; | |
289 | ||
290 | /* Allocate a MirrorOp that is used as an AIO callback. The qiov is zeroed | |
291 | * so the freeing in mirror_iteration_done is nop. */ | |
292 | op = g_new0(MirrorOp, 1); | |
293 | op->s = s; | |
294 | op->sector_num = sector_num; | |
295 | op->nb_sectors = nb_sectors; | |
296 | ||
297 | s->in_flight++; | |
298 | s->sectors_in_flight += nb_sectors; | |
299 | if (is_discard) { | |
e253f4b8 KW |
300 | blk_aio_discard(s->target, sector_num, op->nb_sectors, |
301 | mirror_write_complete, op); | |
e5b43573 | 302 | } else { |
e253f4b8 KW |
303 | blk_aio_pwrite_zeroes(s->target, sector_num * BDRV_SECTOR_SIZE, |
304 | op->nb_sectors * BDRV_SECTOR_SIZE, | |
dcfb3beb FZ |
305 | s->unmap ? BDRV_REQ_MAY_UNMAP : 0, |
306 | mirror_write_complete, op); | |
e5b43573 FZ |
307 | } |
308 | } | |
309 | ||
310 | static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) | |
311 | { | |
e253f4b8 | 312 | BlockDriverState *source = blk_bs(s->common.blk); |
9c83625b | 313 | int64_t sector_num, first_chunk; |
e5b43573 FZ |
314 | uint64_t delay_ns = 0; |
315 | /* At least the first dirty chunk is mirrored in one iteration. */ | |
316 | int nb_chunks = 1; | |
317 | int64_t end = s->bdev_length / BDRV_SECTOR_SIZE; | |
318 | int sectors_per_chunk = s->granularity >> BDRV_SECTOR_BITS; | |
319 | ||
320 | sector_num = hbitmap_iter_next(&s->hbi); | |
321 | if (sector_num < 0) { | |
322 | bdrv_dirty_iter_init(s->dirty_bitmap, &s->hbi); | |
323 | sector_num = hbitmap_iter_next(&s->hbi); | |
324 | trace_mirror_restart_iter(s, bdrv_get_dirty_count(s->dirty_bitmap)); | |
325 | assert(sector_num >= 0); | |
326 | } | |
327 | ||
9c83625b HR |
328 | first_chunk = sector_num / sectors_per_chunk; |
329 | while (test_bit(first_chunk, s->in_flight_bitmap)) { | |
330 | trace_mirror_yield_in_flight(s, first_chunk, s->in_flight); | |
331 | mirror_wait_for_io(s); | |
332 | } | |
333 | ||
e5b43573 FZ |
334 | /* Find the number of consective dirty chunks following the first dirty |
335 | * one, and wait for in flight requests in them. */ | |
336 | while (nb_chunks * sectors_per_chunk < (s->buf_size >> BDRV_SECTOR_BITS)) { | |
337 | int64_t hbitmap_next; | |
338 | int64_t next_sector = sector_num + nb_chunks * sectors_per_chunk; | |
339 | int64_t next_chunk = next_sector / sectors_per_chunk; | |
340 | if (next_sector >= end || | |
341 | !bdrv_get_dirty(source, s->dirty_bitmap, next_sector)) { | |
342 | break; | |
343 | } | |
344 | if (test_bit(next_chunk, s->in_flight_bitmap)) { | |
9c83625b | 345 | break; |
e5b43573 | 346 | } |
9c83625b HR |
347 | |
348 | hbitmap_next = hbitmap_iter_next(&s->hbi); | |
f27a2742 HR |
349 | if (hbitmap_next > next_sector || hbitmap_next < 0) { |
350 | /* The bitmap iterator's cache is stale, refresh it */ | |
351 | bdrv_set_dirty_iter(&s->hbi, next_sector); | |
352 | hbitmap_next = hbitmap_iter_next(&s->hbi); | |
353 | } | |
9c83625b HR |
354 | assert(hbitmap_next == next_sector); |
355 | nb_chunks++; | |
e5b43573 FZ |
356 | } |
357 | ||
358 | /* Clear dirty bits before querying the block status, because | |
359 | * calling bdrv_get_block_status_above could yield - if some blocks are | |
360 | * marked dirty in this window, we need to know. | |
361 | */ | |
362 | bdrv_reset_dirty_bitmap(s->dirty_bitmap, sector_num, | |
363 | nb_chunks * sectors_per_chunk); | |
364 | bitmap_set(s->in_flight_bitmap, sector_num / sectors_per_chunk, nb_chunks); | |
365 | while (nb_chunks > 0 && sector_num < end) { | |
366 | int ret; | |
367 | int io_sectors; | |
368 | BlockDriverState *file; | |
369 | enum MirrorMethod { | |
370 | MIRROR_METHOD_COPY, | |
371 | MIRROR_METHOD_ZERO, | |
372 | MIRROR_METHOD_DISCARD | |
373 | } mirror_method = MIRROR_METHOD_COPY; | |
374 | ||
375 | assert(!(sector_num % sectors_per_chunk)); | |
376 | ret = bdrv_get_block_status_above(source, NULL, sector_num, | |
377 | nb_chunks * sectors_per_chunk, | |
378 | &io_sectors, &file); | |
379 | if (ret < 0) { | |
380 | io_sectors = nb_chunks * sectors_per_chunk; | |
381 | } | |
382 | ||
383 | io_sectors -= io_sectors % sectors_per_chunk; | |
384 | if (io_sectors < sectors_per_chunk) { | |
385 | io_sectors = sectors_per_chunk; | |
386 | } else if (ret >= 0 && !(ret & BDRV_BLOCK_DATA)) { | |
387 | int64_t target_sector_num; | |
388 | int target_nb_sectors; | |
244483e6 KW |
389 | bdrv_round_sectors_to_clusters(blk_bs(s->target), sector_num, |
390 | io_sectors, &target_sector_num, | |
391 | &target_nb_sectors); | |
e5b43573 FZ |
392 | if (target_sector_num == sector_num && |
393 | target_nb_sectors == io_sectors) { | |
394 | mirror_method = ret & BDRV_BLOCK_ZERO ? | |
395 | MIRROR_METHOD_ZERO : | |
396 | MIRROR_METHOD_DISCARD; | |
397 | } | |
398 | } | |
399 | ||
4150ae60 | 400 | mirror_clip_sectors(s, sector_num, &io_sectors); |
e5b43573 FZ |
401 | switch (mirror_method) { |
402 | case MIRROR_METHOD_COPY: | |
403 | io_sectors = mirror_do_read(s, sector_num, io_sectors); | |
404 | break; | |
405 | case MIRROR_METHOD_ZERO: | |
406 | mirror_do_zero_or_discard(s, sector_num, io_sectors, false); | |
407 | break; | |
408 | case MIRROR_METHOD_DISCARD: | |
409 | mirror_do_zero_or_discard(s, sector_num, io_sectors, true); | |
410 | break; | |
411 | default: | |
412 | abort(); | |
413 | } | |
414 | assert(io_sectors); | |
415 | sector_num += io_sectors; | |
4150ae60 | 416 | nb_chunks -= DIV_ROUND_UP(io_sectors, sectors_per_chunk); |
e5b43573 | 417 | delay_ns += ratelimit_calculate_delay(&s->limit, io_sectors); |
dcfb3beb | 418 | } |
cc8c9d6c | 419 | return delay_ns; |
bd48bde8 | 420 | } |
b952b558 | 421 | |
402a4741 PB |
422 | static void mirror_free_init(MirrorBlockJob *s) |
423 | { | |
424 | int granularity = s->granularity; | |
425 | size_t buf_size = s->buf_size; | |
426 | uint8_t *buf = s->buf; | |
427 | ||
428 | assert(s->buf_free_count == 0); | |
429 | QSIMPLEQ_INIT(&s->buf_free); | |
430 | while (buf_size != 0) { | |
431 | MirrorBuffer *cur = (MirrorBuffer *)buf; | |
432 | QSIMPLEQ_INSERT_TAIL(&s->buf_free, cur, next); | |
433 | s->buf_free_count++; | |
434 | buf_size -= granularity; | |
435 | buf += granularity; | |
436 | } | |
437 | } | |
438 | ||
bd48bde8 PB |
439 | static void mirror_drain(MirrorBlockJob *s) |
440 | { | |
441 | while (s->in_flight > 0) { | |
21cd917f | 442 | mirror_wait_for_io(s); |
bd48bde8 | 443 | } |
893f7eba PB |
444 | } |
445 | ||
5a7e7a0b SH |
446 | typedef struct { |
447 | int ret; | |
448 | } MirrorExitData; | |
449 | ||
450 | static void mirror_exit(BlockJob *job, void *opaque) | |
451 | { | |
452 | MirrorBlockJob *s = container_of(job, MirrorBlockJob, common); | |
453 | MirrorExitData *data = opaque; | |
454 | AioContext *replace_aio_context = NULL; | |
e253f4b8 KW |
455 | BlockDriverState *src = blk_bs(s->common.blk); |
456 | BlockDriverState *target_bs = blk_bs(s->target); | |
3f09bfbc KW |
457 | |
458 | /* Make sure that the source BDS doesn't go away before we called | |
459 | * block_job_completed(). */ | |
460 | bdrv_ref(src); | |
5a7e7a0b SH |
461 | |
462 | if (s->to_replace) { | |
463 | replace_aio_context = bdrv_get_aio_context(s->to_replace); | |
464 | aio_context_acquire(replace_aio_context); | |
465 | } | |
466 | ||
467 | if (s->should_complete && data->ret == 0) { | |
e253f4b8 | 468 | BlockDriverState *to_replace = src; |
5a7e7a0b SH |
469 | if (s->to_replace) { |
470 | to_replace = s->to_replace; | |
471 | } | |
40365552 | 472 | |
e253f4b8 KW |
473 | if (bdrv_get_flags(target_bs) != bdrv_get_flags(to_replace)) { |
474 | bdrv_reopen(target_bs, bdrv_get_flags(to_replace), NULL); | |
5a7e7a0b | 475 | } |
b8804815 KW |
476 | |
477 | /* The mirror job has no requests in flight any more, but we need to | |
478 | * drain potential other users of the BDS before changing the graph. */ | |
e253f4b8 KW |
479 | bdrv_drained_begin(target_bs); |
480 | bdrv_replace_in_backing_chain(to_replace, target_bs); | |
481 | bdrv_drained_end(target_bs); | |
b8804815 | 482 | |
b6d2e599 KW |
483 | /* We just changed the BDS the job BB refers to */ |
484 | blk_remove_bs(job->blk); | |
485 | blk_insert_bs(job->blk, src); | |
5a7e7a0b SH |
486 | } |
487 | if (s->to_replace) { | |
488 | bdrv_op_unblock_all(s->to_replace, s->replace_blocker); | |
489 | error_free(s->replace_blocker); | |
490 | bdrv_unref(s->to_replace); | |
491 | } | |
492 | if (replace_aio_context) { | |
493 | aio_context_release(replace_aio_context); | |
494 | } | |
495 | g_free(s->replaces); | |
e253f4b8 KW |
496 | bdrv_op_unblock_all(target_bs, s->common.blocker); |
497 | blk_unref(s->target); | |
5a7e7a0b SH |
498 | block_job_completed(&s->common, data->ret); |
499 | g_free(data); | |
176c3699 | 500 | bdrv_drained_end(src); |
ab27c3b5 FZ |
501 | if (qemu_get_aio_context() == bdrv_get_aio_context(src)) { |
502 | aio_enable_external(iohandler_get_aio_context()); | |
503 | } | |
3f09bfbc | 504 | bdrv_unref(src); |
5a7e7a0b SH |
505 | } |
506 | ||
893f7eba PB |
507 | static void coroutine_fn mirror_run(void *opaque) |
508 | { | |
509 | MirrorBlockJob *s = opaque; | |
5a7e7a0b | 510 | MirrorExitData *data; |
e253f4b8 KW |
511 | BlockDriverState *bs = blk_bs(s->common.blk); |
512 | BlockDriverState *target_bs = blk_bs(s->target); | |
99900697 | 513 | int64_t sector_num, end, length; |
bd48bde8 | 514 | uint64_t last_pause_ns; |
b812f671 | 515 | BlockDriverInfo bdi; |
1d33936e JC |
516 | char backing_filename[2]; /* we only need 2 characters because we are only |
517 | checking for a NULL string */ | |
893f7eba PB |
518 | int ret = 0; |
519 | int n; | |
e5b43573 | 520 | int target_cluster_size = BDRV_SECTOR_SIZE; |
893f7eba PB |
521 | |
522 | if (block_job_is_cancelled(&s->common)) { | |
523 | goto immediate_exit; | |
524 | } | |
525 | ||
b21c7652 HR |
526 | s->bdev_length = bdrv_getlength(bs); |
527 | if (s->bdev_length < 0) { | |
528 | ret = s->bdev_length; | |
373df5b1 | 529 | goto immediate_exit; |
b21c7652 | 530 | } else if (s->bdev_length == 0) { |
9e48b025 FZ |
531 | /* Report BLOCK_JOB_READY and wait for complete. */ |
532 | block_job_event_ready(&s->common); | |
533 | s->synced = true; | |
534 | while (!block_job_is_cancelled(&s->common) && !s->should_complete) { | |
535 | block_job_yield(&s->common); | |
536 | } | |
537 | s->common.cancelled = false; | |
538 | goto immediate_exit; | |
893f7eba PB |
539 | } |
540 | ||
b21c7652 | 541 | length = DIV_ROUND_UP(s->bdev_length, s->granularity); |
402a4741 PB |
542 | s->in_flight_bitmap = bitmap_new(length); |
543 | ||
b812f671 PB |
544 | /* If we have no backing file yet in the destination, we cannot let |
545 | * the destination do COW. Instead, we copy sectors around the | |
546 | * dirty data if needed. We need a bitmap to do that. | |
547 | */ | |
e253f4b8 | 548 | bdrv_get_backing_filename(target_bs, backing_filename, |
b812f671 | 549 | sizeof(backing_filename)); |
e253f4b8 | 550 | if (!bdrv_get_info(target_bs, &bdi) && bdi.cluster_size) { |
e5b43573 FZ |
551 | target_cluster_size = bdi.cluster_size; |
552 | } | |
e253f4b8 | 553 | if (backing_filename[0] && !target_bs->backing |
e5b43573 FZ |
554 | && s->granularity < target_cluster_size) { |
555 | s->buf_size = MAX(s->buf_size, target_cluster_size); | |
556 | s->cow_bitmap = bitmap_new(length); | |
b812f671 | 557 | } |
e5b43573 | 558 | s->target_cluster_sectors = target_cluster_size >> BDRV_SECTOR_BITS; |
e253f4b8 | 559 | s->max_iov = MIN(bs->bl.max_iov, target_bs->bl.max_iov); |
b812f671 | 560 | |
b21c7652 | 561 | end = s->bdev_length / BDRV_SECTOR_SIZE; |
7504edf4 KW |
562 | s->buf = qemu_try_blockalign(bs, s->buf_size); |
563 | if (s->buf == NULL) { | |
564 | ret = -ENOMEM; | |
565 | goto immediate_exit; | |
566 | } | |
567 | ||
402a4741 | 568 | mirror_free_init(s); |
893f7eba | 569 | |
4c0cbd6f | 570 | last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME); |
03544a6e | 571 | if (!s->is_none_mode) { |
893f7eba | 572 | /* First part, loop on the sectors and initialize the dirty bitmap. */ |
5bc361b8 | 573 | BlockDriverState *base = s->base; |
e253f4b8 | 574 | bool mark_all_dirty = s->base == NULL && !bdrv_has_zero_init(target_bs); |
5279efeb | 575 | |
893f7eba | 576 | for (sector_num = 0; sector_num < end; ) { |
99900697 FZ |
577 | /* Just to make sure we are not exceeding int limit. */ |
578 | int nb_sectors = MIN(INT_MAX >> BDRV_SECTOR_BITS, | |
579 | end - sector_num); | |
4c0cbd6f FZ |
580 | int64_t now = qemu_clock_get_ns(QEMU_CLOCK_REALTIME); |
581 | ||
582 | if (now - last_pause_ns > SLICE_TIME) { | |
583 | last_pause_ns = now; | |
584 | block_job_sleep_ns(&s->common, QEMU_CLOCK_REALTIME, 0); | |
585 | } | |
586 | ||
587 | if (block_job_is_cancelled(&s->common)) { | |
588 | goto immediate_exit; | |
589 | } | |
590 | ||
99900697 | 591 | ret = bdrv_is_allocated_above(bs, base, sector_num, nb_sectors, &n); |
893f7eba PB |
592 | |
593 | if (ret < 0) { | |
594 | goto immediate_exit; | |
595 | } | |
596 | ||
597 | assert(n > 0); | |
5279efeb | 598 | if (ret == 1 || mark_all_dirty) { |
20dca810 | 599 | bdrv_set_dirty_bitmap(s->dirty_bitmap, sector_num, n); |
893f7eba | 600 | } |
99900697 | 601 | sector_num += n; |
893f7eba PB |
602 | } |
603 | } | |
604 | ||
20dca810 | 605 | bdrv_dirty_iter_init(s->dirty_bitmap, &s->hbi); |
893f7eba | 606 | for (;;) { |
cc8c9d6c | 607 | uint64_t delay_ns = 0; |
893f7eba PB |
608 | int64_t cnt; |
609 | bool should_complete; | |
610 | ||
bd48bde8 PB |
611 | if (s->ret < 0) { |
612 | ret = s->ret; | |
613 | goto immediate_exit; | |
614 | } | |
615 | ||
20dca810 | 616 | cnt = bdrv_get_dirty_count(s->dirty_bitmap); |
b21c7652 HR |
617 | /* s->common.offset contains the number of bytes already processed so |
618 | * far, cnt is the number of dirty sectors remaining and | |
619 | * s->sectors_in_flight is the number of sectors currently being | |
620 | * processed; together those are the current total operation length */ | |
621 | s->common.len = s->common.offset + | |
622 | (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE; | |
bd48bde8 PB |
623 | |
624 | /* Note that even when no rate limit is applied we need to yield | |
a7282330 | 625 | * periodically with no pending I/O so that bdrv_drain_all() returns. |
bd48bde8 PB |
626 | * We do so every SLICE_TIME nanoseconds, or when there is an error, |
627 | * or when the source is clean, whichever comes first. | |
628 | */ | |
bc72ad67 | 629 | if (qemu_clock_get_ns(QEMU_CLOCK_REALTIME) - last_pause_ns < SLICE_TIME && |
bd48bde8 | 630 | s->common.iostatus == BLOCK_DEVICE_IO_STATUS_OK) { |
402a4741 PB |
631 | if (s->in_flight == MAX_IN_FLIGHT || s->buf_free_count == 0 || |
632 | (cnt == 0 && s->in_flight > 0)) { | |
633 | trace_mirror_yield(s, s->in_flight, s->buf_free_count, cnt); | |
21cd917f | 634 | mirror_wait_for_io(s); |
bd48bde8 PB |
635 | continue; |
636 | } else if (cnt != 0) { | |
cc8c9d6c | 637 | delay_ns = mirror_iteration(s); |
893f7eba | 638 | } |
893f7eba PB |
639 | } |
640 | ||
641 | should_complete = false; | |
bd48bde8 | 642 | if (s->in_flight == 0 && cnt == 0) { |
893f7eba | 643 | trace_mirror_before_flush(s); |
e253f4b8 | 644 | ret = blk_flush(s->target); |
893f7eba | 645 | if (ret < 0) { |
a589569f WX |
646 | if (mirror_error_action(s, false, -ret) == |
647 | BLOCK_ERROR_ACTION_REPORT) { | |
b952b558 PB |
648 | goto immediate_exit; |
649 | } | |
650 | } else { | |
651 | /* We're out of the streaming phase. From now on, if the job | |
652 | * is cancelled we will actually complete all pending I/O and | |
653 | * report completion. This way, block-job-cancel will leave | |
654 | * the target in a consistent state. | |
655 | */ | |
b952b558 | 656 | if (!s->synced) { |
bcada37b | 657 | block_job_event_ready(&s->common); |
b952b558 PB |
658 | s->synced = true; |
659 | } | |
660 | ||
661 | should_complete = s->should_complete || | |
662 | block_job_is_cancelled(&s->common); | |
20dca810 | 663 | cnt = bdrv_get_dirty_count(s->dirty_bitmap); |
d63ffd87 | 664 | } |
893f7eba PB |
665 | } |
666 | ||
667 | if (cnt == 0 && should_complete) { | |
668 | /* The dirty bitmap is not updated while operations are pending. | |
669 | * If we're about to exit, wait for pending operations before | |
670 | * calling bdrv_get_dirty_count(bs), or we may exit while the | |
671 | * source has dirty data to copy! | |
672 | * | |
673 | * Note that I/O can be submitted by the guest while | |
674 | * mirror_populate runs. | |
675 | */ | |
676 | trace_mirror_before_drain(s, cnt); | |
39bf92dd | 677 | bdrv_co_drain(bs); |
20dca810 | 678 | cnt = bdrv_get_dirty_count(s->dirty_bitmap); |
893f7eba PB |
679 | } |
680 | ||
681 | ret = 0; | |
cc8c9d6c | 682 | trace_mirror_before_sleep(s, cnt, s->synced, delay_ns); |
d63ffd87 | 683 | if (!s->synced) { |
7483d1e5 | 684 | block_job_sleep_ns(&s->common, QEMU_CLOCK_REALTIME, delay_ns); |
893f7eba PB |
685 | if (block_job_is_cancelled(&s->common)) { |
686 | break; | |
687 | } | |
688 | } else if (!should_complete) { | |
bd48bde8 | 689 | delay_ns = (s->in_flight == 0 && cnt == 0 ? SLICE_TIME : 0); |
7483d1e5 | 690 | block_job_sleep_ns(&s->common, QEMU_CLOCK_REALTIME, delay_ns); |
893f7eba PB |
691 | } else if (cnt == 0) { |
692 | /* The two disks are in sync. Exit and report successful | |
693 | * completion. | |
694 | */ | |
695 | assert(QLIST_EMPTY(&bs->tracked_requests)); | |
696 | s->common.cancelled = false; | |
697 | break; | |
698 | } | |
bc72ad67 | 699 | last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME); |
893f7eba PB |
700 | } |
701 | ||
702 | immediate_exit: | |
bd48bde8 PB |
703 | if (s->in_flight > 0) { |
704 | /* We get here only if something went wrong. Either the job failed, | |
705 | * or it was cancelled prematurely so that we do not guarantee that | |
706 | * the target is a copy of the source. | |
707 | */ | |
708 | assert(ret < 0 || (!s->synced && block_job_is_cancelled(&s->common))); | |
709 | mirror_drain(s); | |
710 | } | |
711 | ||
712 | assert(s->in_flight == 0); | |
7191bf31 | 713 | qemu_vfree(s->buf); |
b812f671 | 714 | g_free(s->cow_bitmap); |
402a4741 | 715 | g_free(s->in_flight_bitmap); |
e4654d2d | 716 | bdrv_release_dirty_bitmap(bs, s->dirty_bitmap); |
5a7e7a0b SH |
717 | |
718 | data = g_malloc(sizeof(*data)); | |
719 | data->ret = ret; | |
176c3699 FZ |
720 | /* Before we switch to target in mirror_exit, make sure data doesn't |
721 | * change. */ | |
e253f4b8 | 722 | bdrv_drained_begin(bs); |
ab27c3b5 FZ |
723 | if (qemu_get_aio_context() == bdrv_get_aio_context(bs)) { |
724 | /* FIXME: virtio host notifiers run on iohandler_ctx, therefore the | |
725 | * above bdrv_drained_end isn't enough to quiesce it. This is ugly, we | |
726 | * need a block layer API change to achieve this. */ | |
727 | aio_disable_external(iohandler_get_aio_context()); | |
728 | } | |
5a7e7a0b | 729 | block_job_defer_to_main_loop(&s->common, mirror_exit, data); |
893f7eba PB |
730 | } |
731 | ||
732 | static void mirror_set_speed(BlockJob *job, int64_t speed, Error **errp) | |
733 | { | |
734 | MirrorBlockJob *s = container_of(job, MirrorBlockJob, common); | |
735 | ||
736 | if (speed < 0) { | |
c6bd8c70 | 737 | error_setg(errp, QERR_INVALID_PARAMETER, "speed"); |
893f7eba PB |
738 | return; |
739 | } | |
740 | ratelimit_set_speed(&s->limit, speed / BDRV_SECTOR_SIZE, SLICE_TIME); | |
741 | } | |
742 | ||
d63ffd87 PB |
743 | static void mirror_complete(BlockJob *job, Error **errp) |
744 | { | |
745 | MirrorBlockJob *s = container_of(job, MirrorBlockJob, common); | |
274fccee HR |
746 | BlockDriverState *src, *target; |
747 | ||
748 | src = blk_bs(job->blk); | |
749 | target = blk_bs(s->target); | |
d63ffd87 | 750 | |
d63ffd87 | 751 | if (!s->synced) { |
8ccb9569 | 752 | error_setg(errp, QERR_BLOCK_JOB_NOT_READY, job->id); |
d63ffd87 PB |
753 | return; |
754 | } | |
755 | ||
274fccee HR |
756 | if (s->backing_mode == MIRROR_OPEN_BACKING_CHAIN) { |
757 | int ret; | |
758 | ||
759 | assert(!target->backing); | |
760 | ret = bdrv_open_backing_file(target, NULL, "backing", errp); | |
761 | if (ret < 0) { | |
762 | return; | |
763 | } | |
764 | } | |
765 | ||
09158f00 BC |
766 | /* check the target bs is not blocked and block all operations on it */ |
767 | if (s->replaces) { | |
5a7e7a0b SH |
768 | AioContext *replace_aio_context; |
769 | ||
e12f3784 | 770 | s->to_replace = bdrv_find_node(s->replaces); |
09158f00 | 771 | if (!s->to_replace) { |
e12f3784 | 772 | error_setg(errp, "Node name '%s' not found", s->replaces); |
09158f00 BC |
773 | return; |
774 | } | |
775 | ||
5a7e7a0b SH |
776 | replace_aio_context = bdrv_get_aio_context(s->to_replace); |
777 | aio_context_acquire(replace_aio_context); | |
778 | ||
09158f00 BC |
779 | error_setg(&s->replace_blocker, |
780 | "block device is in use by block-job-complete"); | |
781 | bdrv_op_block_all(s->to_replace, s->replace_blocker); | |
782 | bdrv_ref(s->to_replace); | |
5a7e7a0b SH |
783 | |
784 | aio_context_release(replace_aio_context); | |
09158f00 BC |
785 | } |
786 | ||
274fccee HR |
787 | if (s->backing_mode == MIRROR_SOURCE_BACKING_CHAIN) { |
788 | BlockDriverState *backing = s->is_none_mode ? src : s->base; | |
789 | if (backing_bs(target) != backing) { | |
790 | bdrv_set_backing_hd(target, backing); | |
791 | } | |
792 | } | |
793 | ||
d63ffd87 | 794 | s->should_complete = true; |
751ebd76 | 795 | block_job_enter(&s->common); |
d63ffd87 PB |
796 | } |
797 | ||
3fc4b10a | 798 | static const BlockJobDriver mirror_job_driver = { |
893f7eba | 799 | .instance_size = sizeof(MirrorBlockJob), |
79e14bf7 | 800 | .job_type = BLOCK_JOB_TYPE_MIRROR, |
893f7eba | 801 | .set_speed = mirror_set_speed, |
d63ffd87 | 802 | .complete = mirror_complete, |
893f7eba PB |
803 | }; |
804 | ||
03544a6e FZ |
805 | static const BlockJobDriver commit_active_job_driver = { |
806 | .instance_size = sizeof(MirrorBlockJob), | |
807 | .job_type = BLOCK_JOB_TYPE_COMMIT, | |
808 | .set_speed = mirror_set_speed, | |
03544a6e FZ |
809 | .complete = mirror_complete, |
810 | }; | |
811 | ||
812 | static void mirror_start_job(BlockDriverState *bs, BlockDriverState *target, | |
09158f00 | 813 | const char *replaces, |
5fba6c0e | 814 | int64_t speed, uint32_t granularity, |
09158f00 | 815 | int64_t buf_size, |
274fccee | 816 | BlockMirrorBackingMode backing_mode, |
09158f00 BC |
817 | BlockdevOnError on_source_error, |
818 | BlockdevOnError on_target_error, | |
0fc9f8ea | 819 | bool unmap, |
097310b5 | 820 | BlockCompletionFunc *cb, |
09158f00 BC |
821 | void *opaque, Error **errp, |
822 | const BlockJobDriver *driver, | |
823 | bool is_none_mode, BlockDriverState *base) | |
893f7eba PB |
824 | { |
825 | MirrorBlockJob *s; | |
826 | ||
eee13dfe | 827 | if (granularity == 0) { |
341ebc2f | 828 | granularity = bdrv_get_default_bitmap_granularity(target); |
eee13dfe PB |
829 | } |
830 | ||
831 | assert ((granularity & (granularity - 1)) == 0); | |
832 | ||
48ac0a4d WC |
833 | if (buf_size < 0) { |
834 | error_setg(errp, "Invalid parameter 'buf-size'"); | |
835 | return; | |
836 | } | |
837 | ||
838 | if (buf_size == 0) { | |
839 | buf_size = DEFAULT_MIRROR_BUF_SIZE; | |
840 | } | |
5bc361b8 | 841 | |
03544a6e | 842 | s = block_job_create(driver, bs, speed, cb, opaque, errp); |
893f7eba PB |
843 | if (!s) { |
844 | return; | |
845 | } | |
846 | ||
e253f4b8 KW |
847 | s->target = blk_new(); |
848 | blk_insert_bs(s->target, target); | |
849 | ||
09158f00 | 850 | s->replaces = g_strdup(replaces); |
b952b558 PB |
851 | s->on_source_error = on_source_error; |
852 | s->on_target_error = on_target_error; | |
03544a6e | 853 | s->is_none_mode = is_none_mode; |
274fccee | 854 | s->backing_mode = backing_mode; |
5bc361b8 | 855 | s->base = base; |
eee13dfe | 856 | s->granularity = granularity; |
48ac0a4d | 857 | s->buf_size = ROUND_UP(buf_size, granularity); |
0fc9f8ea | 858 | s->unmap = unmap; |
b812f671 | 859 | |
0db6e54a | 860 | s->dirty_bitmap = bdrv_create_dirty_bitmap(bs, granularity, NULL, errp); |
b8afb520 | 861 | if (!s->dirty_bitmap) { |
97031164 | 862 | g_free(s->replaces); |
e253f4b8 | 863 | blk_unref(s->target); |
18930ba3 | 864 | block_job_unref(&s->common); |
b8afb520 FZ |
865 | return; |
866 | } | |
10f3cd15 | 867 | |
e253f4b8 | 868 | bdrv_op_block_all(target, s->common.blocker); |
10f3cd15 | 869 | |
893f7eba PB |
870 | s->common.co = qemu_coroutine_create(mirror_run); |
871 | trace_mirror_start(bs, s, s->common.co, opaque); | |
872 | qemu_coroutine_enter(s->common.co, s); | |
873 | } | |
03544a6e FZ |
874 | |
875 | void mirror_start(BlockDriverState *bs, BlockDriverState *target, | |
09158f00 | 876 | const char *replaces, |
5fba6c0e | 877 | int64_t speed, uint32_t granularity, int64_t buf_size, |
274fccee HR |
878 | MirrorSyncMode mode, BlockMirrorBackingMode backing_mode, |
879 | BlockdevOnError on_source_error, | |
03544a6e | 880 | BlockdevOnError on_target_error, |
0fc9f8ea | 881 | bool unmap, |
097310b5 | 882 | BlockCompletionFunc *cb, |
03544a6e FZ |
883 | void *opaque, Error **errp) |
884 | { | |
885 | bool is_none_mode; | |
886 | BlockDriverState *base; | |
887 | ||
4b80ab2b JS |
888 | if (mode == MIRROR_SYNC_MODE_INCREMENTAL) { |
889 | error_setg(errp, "Sync mode 'incremental' not supported"); | |
d58d8453 JS |
890 | return; |
891 | } | |
03544a6e | 892 | is_none_mode = mode == MIRROR_SYNC_MODE_NONE; |
760e0063 | 893 | base = mode == MIRROR_SYNC_MODE_TOP ? backing_bs(bs) : NULL; |
09158f00 | 894 | mirror_start_job(bs, target, replaces, |
274fccee | 895 | speed, granularity, buf_size, backing_mode, |
0fc9f8ea | 896 | on_source_error, on_target_error, unmap, cb, opaque, errp, |
03544a6e FZ |
897 | &mirror_job_driver, is_none_mode, base); |
898 | } | |
899 | ||
900 | void commit_active_start(BlockDriverState *bs, BlockDriverState *base, | |
901 | int64_t speed, | |
902 | BlockdevOnError on_error, | |
097310b5 | 903 | BlockCompletionFunc *cb, |
03544a6e FZ |
904 | void *opaque, Error **errp) |
905 | { | |
4da83585 JC |
906 | int64_t length, base_length; |
907 | int orig_base_flags; | |
39a611a3 | 908 | int ret; |
cc67f4d1 | 909 | Error *local_err = NULL; |
4da83585 JC |
910 | |
911 | orig_base_flags = bdrv_get_flags(base); | |
912 | ||
20a63d2c FZ |
913 | if (bdrv_reopen(base, bs->open_flags, errp)) { |
914 | return; | |
915 | } | |
4da83585 JC |
916 | |
917 | length = bdrv_getlength(bs); | |
918 | if (length < 0) { | |
39a611a3 JC |
919 | error_setg_errno(errp, -length, |
920 | "Unable to determine length of %s", bs->filename); | |
4da83585 JC |
921 | goto error_restore_flags; |
922 | } | |
923 | ||
924 | base_length = bdrv_getlength(base); | |
925 | if (base_length < 0) { | |
39a611a3 JC |
926 | error_setg_errno(errp, -base_length, |
927 | "Unable to determine length of %s", base->filename); | |
4da83585 JC |
928 | goto error_restore_flags; |
929 | } | |
930 | ||
931 | if (length > base_length) { | |
39a611a3 JC |
932 | ret = bdrv_truncate(base, length); |
933 | if (ret < 0) { | |
934 | error_setg_errno(errp, -ret, | |
935 | "Top image %s is larger than base image %s, and " | |
4da83585 JC |
936 | "resize of base image failed", |
937 | bs->filename, base->filename); | |
938 | goto error_restore_flags; | |
939 | } | |
940 | } | |
941 | ||
274fccee | 942 | mirror_start_job(bs, base, NULL, speed, 0, 0, MIRROR_LEAVE_BACKING_CHAIN, |
0fc9f8ea | 943 | on_error, on_error, false, cb, opaque, &local_err, |
03544a6e | 944 | &commit_active_job_driver, false, base); |
0fb6395c | 945 | if (local_err) { |
cc67f4d1 | 946 | error_propagate(errp, local_err); |
4da83585 JC |
947 | goto error_restore_flags; |
948 | } | |
949 | ||
950 | return; | |
951 | ||
952 | error_restore_flags: | |
953 | /* ignore error and errp for bdrv_reopen, because we want to propagate | |
954 | * the original error */ | |
955 | bdrv_reopen(base, orig_base_flags, NULL); | |
956 | return; | |
03544a6e | 957 | } |