projects / pve-qemu-kvm.git / blame
| Commit | Line | Data |
|---|---|---|
| 06fb0513 WB |
1 | From e74703fab04c39c9a01385bbe3d79e47f7db4ccb Mon Sep 17 00:00:00 2001 |
| 2 | From: Prasad J Pandit <pjp@fedoraproject.org> | |
| 3 | Date: Wed, 25 May 2016 17:41:44 +0530 | |
| 4 | Subject: [PATCH 1/9] scsi: megasas: initialise local configuration data buffer | |
| 5 | ||
| 6 | When reading MegaRAID SAS controller configuration via MegaRAID | |
| 7 | Firmware Interface(MFI) commands, routine megasas_dcmd_cfg_read | |
| 8 | uses an uninitialised local data buffer. Initialise this buffer | |
| 9 | to avoid stack information leakage. | |
| 10 | ||
| 11 | Reported-by: Li Qiang <liqiang6-s@360.cn> | |
| 12 | Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org> | |
| 13 | Message-Id: <1464178304-12831-1-git-send-email-ppandit@redhat.com> | |
| 14 | Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> | |
| 15 | --- | |
| 16 | ||
| 17 | Notes: | |
| 18 | CVE-2016-5105 | |
| 19 | ||
| 20 | hw/scsi/megasas.c | 2 +- | |
| 21 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
| 22 | ||
| 23 | diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c | |
| 24 | index 576f56c..8526c01 100644 | |
| 25 | --- a/hw/scsi/megasas.c | |
| 26 | +++ b/hw/scsi/megasas.c | |
| 27 | @@ -1292,7 +1292,7 @@ static int megasas_dcmd_ld_get_info(MegasasState *s, MegasasCmd *cmd) | |
| 28 | ||
| 29 | static int megasas_dcmd_cfg_read(MegasasState *s, MegasasCmd *cmd) | |
| 30 | { | |
| 31 | - uint8_t data[4096]; | |
| 32 | + uint8_t data[4096] = { 0 }; | |
| 33 | struct mfi_config_data *info; | |
| 34 | int num_pd_disks = 0, array_offset, ld_offset; | |
| 35 | BusChild *kid; | |
| 36 | -- | |
| 37 | 2.1.4 | |
| 38 |