[mirror_ubuntu-bionic-kernel.git] / drivers / gpu / drm / i915 / intel_dvo.c

/*
 * Copyright 2006 Dave Airlie <airlied@linux.ie>
 * Copyright © 2006-2007 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 */
#include <linux/i2c.h>
#include <linux/slab.h>
#include <drm/drmP.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_crtc.h>
#include "intel_drv.h"
#include <drm/i915_drm.h>
#include "i915_drv.h"
#include "dvo.h"

#define SIL164_ADDR	0x38
#define CH7xxx_ADDR	0x76
#define TFP410_ADDR	0x38
#define NS2501_ADDR     0x38

static const struct intel_dvo_device intel_dvo_devices[] = {
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "sil164",
		.dvo_reg = DVOC,
		.dvo_srcdim_reg = DVOC_SRCDIM,
		.slave_addr = SIL164_ADDR,
		.dev_ops = &sil164_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "ch7xxx",
		.dvo_reg = DVOC,
		.dvo_srcdim_reg = DVOC_SRCDIM,
		.slave_addr = CH7xxx_ADDR,
		.dev_ops = &ch7xxx_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "ch7xxx",
		.dvo_reg = DVOC,
		.dvo_srcdim_reg = DVOC_SRCDIM,
		.slave_addr = 0x75, /* For some ch7010 */
		.dev_ops = &ch7xxx_ops,
	},
	{
		.type = INTEL_DVO_CHIP_LVDS,
		.name = "ivch",
		.dvo_reg = DVOA,
		.dvo_srcdim_reg = DVOA_SRCDIM,
		.slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
		.dev_ops = &ivch_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "tfp410",
		.dvo_reg = DVOC,
		.dvo_srcdim_reg = DVOC_SRCDIM,
		.slave_addr = TFP410_ADDR,
		.dev_ops = &tfp410_ops,
	},
	{
		.type = INTEL_DVO_CHIP_LVDS,
		.name = "ch7017",
		.dvo_reg = DVOC,
		.dvo_srcdim_reg = DVOC_SRCDIM,
		.slave_addr = 0x75,
		.gpio = GMBUS_PIN_DPB,
		.dev_ops = &ch7017_ops,
	},
	{
	        .type = INTEL_DVO_CHIP_TMDS,
		.name = "ns2501",
		.dvo_reg = DVOB,
		.dvo_srcdim_reg = DVOB_SRCDIM,
		.slave_addr = NS2501_ADDR,
		.dev_ops = &ns2501_ops,
       }
};

struct intel_dvo {
	struct intel_encoder base;

	struct intel_dvo_device dev;

	struct intel_connector *attached_connector;

	bool panel_wants_dither;
};

static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
{
	return container_of(encoder, struct intel_dvo, base);
}

static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
{
	return enc_to_dvo(intel_attached_encoder(connector));
}

static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
{
	struct drm_device *dev = connector->base.dev;
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
	u32 tmp;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);

	if (!(tmp & DVO_ENABLE))
		return false;

	return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
}

static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
				   enum pipe *pipe)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	u32 tmp;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);

	if (!(tmp & DVO_ENABLE))
		return false;

	*pipe = PORT_TO_PIPE(tmp);

	return true;
}

static void intel_dvo_get_config(struct intel_encoder *encoder,
				 struct intel_crtc_state *pipe_config)
{
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	u32 tmp, flags = 0;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);
	if (tmp & DVO_HSYNC_ACTIVE_HIGH)
		flags |= DRM_MODE_FLAG_PHSYNC;
	else
		flags |= DRM_MODE_FLAG_NHSYNC;
	if (tmp & DVO_VSYNC_ACTIVE_HIGH)
		flags |= DRM_MODE_FLAG_PVSYNC;
	else
		flags |= DRM_MODE_FLAG_NVSYNC;

	pipe_config->base.adjusted_mode.flags |= flags;

	pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
}

static void intel_disable_dvo(struct intel_encoder *encoder,
			      const struct intel_crtc_state *old_crtc_state,
			      const struct drm_connector_state *old_conn_state)
{
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
	u32 temp = I915_READ(dvo_reg);

	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
	I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
	I915_READ(dvo_reg);
}

static void intel_enable_dvo(struct intel_encoder *encoder,
			     const struct intel_crtc_state *pipe_config,
			     const struct drm_connector_state *conn_state)
{
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
	u32 temp = I915_READ(dvo_reg);

	intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
					 &pipe_config->base.mode,
					 &pipe_config->base.adjusted_mode);

	I915_WRITE(dvo_reg, temp | DVO_ENABLE);
	I915_READ(dvo_reg);

	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
}

static enum drm_mode_status
intel_dvo_mode_valid(struct drm_connector *connector,
		     struct drm_display_mode *mode)
{
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
	const struct drm_display_mode *fixed_mode =
		to_intel_connector(connector)->panel.fixed_mode;
	int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
	int target_clock = mode->clock;

	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

	/* XXX: Validate clock range */

	if (fixed_mode) {
		if (mode->hdisplay > fixed_mode->hdisplay)
			return MODE_PANEL;
		if (mode->vdisplay > fixed_mode->vdisplay)
			return MODE_PANEL;

		target_clock = fixed_mode->clock;
	}

	if (target_clock > max_dotclk)
		return MODE_CLOCK_HIGH;

	return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
}

static bool intel_dvo_compute_config(struct intel_encoder *encoder,
				     struct intel_crtc_state *pipe_config,
				     struct drm_connector_state *conn_state)
{
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	const struct drm_display_mode *fixed_mode =
		intel_dvo->attached_connector->panel.fixed_mode;
	struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;

	/* If we have timings from the BIOS for the panel, put them in
	 * to the adjusted mode.  The CRTC will be set up for this mode,
	 * with the panel scaling set up to source from the H/VDisplay
	 * of the original mode.
	 */
	if (fixed_mode)
		intel_fixed_panel_mode(fixed_mode, adjusted_mode);

	return true;
}

static void intel_dvo_pre_enable(struct intel_encoder *encoder,
				 const struct intel_crtc_state *pipe_config,
				 const struct drm_connector_state *conn_state)
{
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
	struct intel_crtc *crtc = to_intel_crtc(pipe_config->base.crtc);
	const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	int pipe = crtc->pipe;
	u32 dvo_val;
	i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
	i915_reg_t dvo_srcdim_reg = intel_dvo->dev.dvo_srcdim_reg;

	/* Save the data order, since I don't know what it should be set to. */
	dvo_val = I915_READ(dvo_reg) &
		  (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
	dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
		   DVO_BLANK_ACTIVE_HIGH;

	if (pipe == 1)
		dvo_val |= DVO_PIPE_B_SELECT;
	dvo_val |= DVO_PIPE_STALL;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
		dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
		dvo_val |= DVO_VSYNC_ACTIVE_HIGH;

	/*I915_WRITE(DVOB_SRCDIM,
	  (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
	  (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
	I915_WRITE(dvo_srcdim_reg,
		   (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
		   (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
	/*I915_WRITE(DVOB, dvo_val);*/
	I915_WRITE(dvo_reg, dvo_val);
}

/**
 * Detect the output connection on our DVO device.
 *
 * Unimplemented.
 */
static enum drm_connector_status
intel_dvo_detect(struct drm_connector *connector, bool force)
{
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
		      connector->base.id, connector->name);
	return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
}

static int intel_dvo_get_modes(struct drm_connector *connector)
{
	struct drm_i915_private *dev_priv = to_i915(connector->dev);
	const struct drm_display_mode *fixed_mode =
		to_intel_connector(connector)->panel.fixed_mode;

	/* We should probably have an i2c driver get_modes function for those
	 * devices which will have a fixed set of modes determined by the chip
	 * (TV-out, for example), but for now with just TMDS and LVDS,
	 * that's not the case.
	 */
	intel_ddc_get_modes(connector,
			    intel_gmbus_get_adapter(dev_priv, GMBUS_PIN_DPC));
	if (!list_empty(&connector->probed_modes))
		return 1;

	if (fixed_mode) {
		struct drm_display_mode *mode;
		mode = drm_mode_duplicate(connector->dev, fixed_mode);
		if (mode) {
			drm_mode_probed_add(connector, mode);
			return 1;
		}
	}

	return 0;
}

static void intel_dvo_destroy(struct drm_connector *connector)
{
	drm_connector_cleanup(connector);
	intel_panel_fini(&to_intel_connector(connector)->panel);
	kfree(connector);
}

static const struct drm_connector_funcs intel_dvo_connector_funcs = {
	.detect = intel_dvo_detect,
	.late_register = intel_connector_register,
	.early_unregister = intel_connector_unregister,
	.destroy = intel_dvo_destroy,
	.fill_modes = drm_helper_probe_single_connector_modes,
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
};

static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
	.mode_valid = intel_dvo_mode_valid,
	.get_modes = intel_dvo_get_modes,
};

static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
{
	struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));

	if (intel_dvo->dev.dev_ops->destroy)
		intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);

	intel_encoder_destroy(encoder);
}

static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
	.destroy = intel_dvo_enc_destroy,
};

/**
 * Attempts to get a fixed panel timing for LVDS (currently only the i830).
 *
 * Other chips with DVO LVDS will need to extend this to deal with the LVDS
 * chip being on DVOB/C and having multiple pipes.
 */
static struct drm_display_mode *
intel_dvo_get_current_mode(struct intel_encoder *encoder)
{
	struct drm_display_mode *mode;

	mode = intel_encoder_current_mode(encoder);
	if (mode) {
		DRM_DEBUG_KMS("using current (BIOS) mode: ");
		drm_mode_debug_printmodeline(mode);
		mode->type |= DRM_MODE_TYPE_PREFERRED;
	}

	return mode;
}

static enum port intel_dvo_port(i915_reg_t dvo_reg)
{
	if (i915_mmio_reg_equal(dvo_reg, DVOA))
		return PORT_A;
	else if (i915_mmio_reg_equal(dvo_reg, DVOB))
		return PORT_B;
	else
		return PORT_C;
}

void intel_dvo_init(struct drm_i915_private *dev_priv)
{
	struct intel_encoder *intel_encoder;
	struct intel_dvo *intel_dvo;
	struct intel_connector *intel_connector;
	int i;
	int encoder_type = DRM_MODE_ENCODER_NONE;

	intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
	if (!intel_dvo)
		return;

	intel_connector = intel_connector_alloc();
	if (!intel_connector) {
		kfree(intel_dvo);
		return;
	}

	intel_dvo->attached_connector = intel_connector;

	intel_encoder = &intel_dvo->base;

	intel_encoder->disable = intel_disable_dvo;
	intel_encoder->enable = intel_enable_dvo;
	intel_encoder->get_hw_state = intel_dvo_get_hw_state;
	intel_encoder->get_config = intel_dvo_get_config;
	intel_encoder->compute_config = intel_dvo_compute_config;
	intel_encoder->pre_enable = intel_dvo_pre_enable;
	intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;

	/* Now, try to find a controller */
	for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
		struct drm_connector *connector = &intel_connector->base;
		const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
		struct i2c_adapter *i2c;
		int gpio;
		bool dvoinit;
		enum pipe pipe;
		uint32_t dpll[I915_MAX_PIPES];
		enum port port;

		/* Allow the I2C driver info to specify the GPIO to be used in
		 * special cases, but otherwise default to what's defined
		 * in the spec.
		 */
		if (intel_gmbus_is_valid_pin(dev_priv, dvo->gpio))
			gpio = dvo->gpio;
		else if (dvo->type == INTEL_DVO_CHIP_LVDS)
			gpio = GMBUS_PIN_SSC;
		else
			gpio = GMBUS_PIN_DPB;

		/* Set up the I2C bus necessary for the chip we're probing.
		 * It appears that everything is on GPIOE except for panels
		 * on i830 laptops, which are on GPIOB (DVOA).
		 */
		i2c = intel_gmbus_get_adapter(dev_priv, gpio);

		intel_dvo->dev = *dvo;

		/* GMBUS NAK handling seems to be unstable, hence let the
		 * transmitter detection run in bit banging mode for now.
		 */
		intel_gmbus_force_bit(i2c, true);

		/* ns2501 requires the DVO 2x clock before it will
		 * respond to i2c accesses, so make sure we have
		 * have the clock enabled before we attempt to
		 * initialize the device.
		 */
		for_each_pipe(dev_priv, pipe) {
			dpll[pipe] = I915_READ(DPLL(pipe));
			I915_WRITE(DPLL(pipe), dpll[pipe] | DPLL_DVO_2X_MODE);
		}

		dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);

		/* restore the DVO 2x clock state to original */
		for_each_pipe(dev_priv, pipe) {
			I915_WRITE(DPLL(pipe), dpll[pipe]);
		}

		intel_gmbus_force_bit(i2c, false);

		if (!dvoinit)
			continue;

		port = intel_dvo_port(dvo->dvo_reg);
		drm_encoder_init(&dev_priv->drm, &intel_encoder->base,
				 &intel_dvo_enc_funcs, encoder_type,
				 "DVO %c", port_name(port));

		intel_encoder->type = INTEL_OUTPUT_DVO;
		intel_encoder->power_domain = POWER_DOMAIN_PORT_OTHER;
		intel_encoder->port = port;
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1);

		switch (dvo->type) {
		case INTEL_DVO_CHIP_TMDS:
			intel_encoder->cloneable = (1 << INTEL_OUTPUT_ANALOG) |
				(1 << INTEL_OUTPUT_DVO);
			drm_connector_init(&dev_priv->drm, connector,
					   &intel_dvo_connector_funcs,
					   DRM_MODE_CONNECTOR_DVII);
			encoder_type = DRM_MODE_ENCODER_TMDS;
			break;
		case INTEL_DVO_CHIP_LVDS:
			intel_encoder->cloneable = 0;
			drm_connector_init(&dev_priv->drm, connector,
					   &intel_dvo_connector_funcs,
					   DRM_MODE_CONNECTOR_LVDS);
			encoder_type = DRM_MODE_ENCODER_LVDS;
			break;
		}

		drm_connector_helper_add(connector,
					 &intel_dvo_connector_helper_funcs);
		connector->display_info.subpixel_order = SubPixelHorizontalRGB;
		connector->interlace_allowed = false;
		connector->doublescan_allowed = false;

		intel_connector_attach_encoder(intel_connector, intel_encoder);
		if (dvo->type == INTEL_DVO_CHIP_LVDS) {
			/* For our LVDS chipsets, we should hopefully be able
			 * to dig the fixed panel mode out of the BIOS data.
			 * However, it's in a different format from the BIOS
			 * data on chipsets with integrated LVDS (stored in AIM
			 * headers, likely), so for now, just get the current
			 * mode being output through DVO.
			 */
			intel_panel_init(&intel_connector->panel,
					 intel_dvo_get_current_mode(intel_encoder),
					 NULL);
			intel_dvo->panel_wants_dither = true;
		}

		return;
	}

	kfree(intel_dvo);
	kfree(intel_connector);
}
Commit	Line	Data
79e53945 JB	1	/*
	2	* Copyright 2006 Dave Airlie <airlied@linux.ie>
	3	* Copyright © 2006-2007 Intel Corporation
	4	*
	5	* Permission is hereby granted, free of charge, to any person obtaining a
	6	* copy of this software and associated documentation files (the "Software"),
	7	* to deal in the Software without restriction, including without limitation
	8	* the rights to use, copy, modify, merge, publish, distribute, sublicense,
	9	* and/or sell copies of the Software, and to permit persons to whom the
	10	* Software is furnished to do so, subject to the following conditions:
	11	*
	12	* The above copyright notice and this permission notice (including the next
	13	* paragraph) shall be included in all copies or substantial portions of the
	14	* Software.
	15	*
	16	* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
	17	* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
	18	* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
	19	* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
	20	* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
	21	* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
	22	* DEALINGS IN THE SOFTWARE.
	23	*
	24	* Authors:
	25	* Eric Anholt <eric@anholt.net>
	26	*/
	27	#include <linux/i2c.h>
5a0e3ad6	28	#include <linux/slab.h>
760285e7	29	#include <drm/drmP.h>
c6f95f27	30	#include <drm/drm_atomic_helper.h>
760285e7	31	#include <drm/drm_crtc.h>
79e53945	32	#include "intel_drv.h"
760285e7	33	#include <drm/i915_drm.h>
79e53945 JB	34	#include "i915_drv.h"
	35	#include "dvo.h"
	36
	37	#define SIL164_ADDR 0x38
	38	#define CH7xxx_ADDR 0x76
	39	#define TFP410_ADDR 0x38
7434a255	40	#define NS2501_ADDR 0x38
79e53945	41
ea5b213a	42	static const struct intel_dvo_device intel_dvo_devices[] = {
79e53945 JB	43	{
	44	.type = INTEL_DVO_CHIP_TMDS,
	45	.name = "sil164",
	46	.dvo_reg = DVOC,
78e0d2e3	47	.dvo_srcdim_reg = DVOC_SRCDIM,
79e53945 JB	48	.slave_addr = SIL164_ADDR,
	49	.dev_ops = &sil164_ops,
	50	},
	51	{
	52	.type = INTEL_DVO_CHIP_TMDS,
	53	.name = "ch7xxx",
	54	.dvo_reg = DVOC,
78e0d2e3	55	.dvo_srcdim_reg = DVOC_SRCDIM,
79e53945 JB	56	.slave_addr = CH7xxx_ADDR,
	57	.dev_ops = &ch7xxx_ops,
	58	},
98304ad1	59	{
	60	.type = INTEL_DVO_CHIP_TMDS,
	61	.name = "ch7xxx",
	62	.dvo_reg = DVOC,
78e0d2e3	63	.dvo_srcdim_reg = DVOC_SRCDIM,
98304ad1	64	.slave_addr = 0x75, /* For some ch7010 */
	65	.dev_ops = &ch7xxx_ops,
	66	},
79e53945 JB	67	{
	68	.type = INTEL_DVO_CHIP_LVDS,
	69	.name = "ivch",
	70	.dvo_reg = DVOA,
78e0d2e3	71	.dvo_srcdim_reg = DVOA_SRCDIM,
79e53945 JB	72	.slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
	73	.dev_ops = &ivch_ops,
	74	},
	75	{
	76	.type = INTEL_DVO_CHIP_TMDS,
	77	.name = "tfp410",
	78	.dvo_reg = DVOC,
78e0d2e3	79	.dvo_srcdim_reg = DVOC_SRCDIM,
79e53945 JB	80	.slave_addr = TFP410_ADDR,
	81	.dev_ops = &tfp410_ops,
	82	},
	83	{
	84	.type = INTEL_DVO_CHIP_LVDS,
	85	.name = "ch7017",
	86	.dvo_reg = DVOC,
78e0d2e3	87	.dvo_srcdim_reg = DVOC_SRCDIM,
79e53945	88	.slave_addr = 0x75,
988c7015	89	.gpio = GMBUS_PIN_DPB,
79e53945	90	.dev_ops = &ch7017_ops,
7434a255 TR	91	},
	92	{
	93	.type = INTEL_DVO_CHIP_TMDS,
	94	.name = "ns2501",
316e0157	95	.dvo_reg = DVOB,
78e0d2e3	96	.dvo_srcdim_reg = DVOB_SRCDIM,
7434a255 TR	97	.slave_addr = NS2501_ADDR,
	98	.dev_ops = &ns2501_ops,
	99	}
79e53945 JB	100	};
79e53945 JB	101
ea5b213a CW	102	struct intel_dvo {
	103	struct intel_encoder base;
	104
	105	struct intel_dvo_device dev;
	106
28694070 VS	107	struct intel_connector *attached_connector;
28694070 VS	108
ea5b213a CW	109	bool panel_wants_dither;
	110	};
	111
69438e64	112	static struct intel_dvo enc_to_dvo(struct intel_encoder encoder)
ea5b213a	113	{
69438e64	114	return container_of(encoder, struct intel_dvo, base);
ea5b213a CW	115	}
ea5b213a CW	116
df0e9248 CW	117	static struct intel_dvo intel_attached_dvo(struct drm_connector connector)
df0e9248 CW	118	{
79fde301	119	return enc_to_dvo(intel_attached_encoder(connector));
df0e9248 CW	120	}
df0e9248 CW	121
732ce74f	122	static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
79e53945	123	{
f417c11b	124	struct drm_device *dev = connector->base.dev;
fac5e23e	125	struct drm_i915_private *dev_priv = to_i915(dev);
732ce74f	126	struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
f417c11b VS	127	u32 tmp;
	128
	129	tmp = I915_READ(intel_dvo->dev.dvo_reg);
	130
	131	if (!(tmp & DVO_ENABLE))
	132	return false;
732ce74f DV	133
	134	return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
	135	}
	136
	137	static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
	138	enum pipe *pipe)
	139	{
	140	struct drm_device *dev = encoder->base.dev;
fac5e23e	141	struct drm_i915_private *dev_priv = to_i915(dev);
69438e64	142	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
732ce74f DV	143	u32 tmp;
	144
	145	tmp = I915_READ(intel_dvo->dev.dvo_reg);
	146
	147	if (!(tmp & DVO_ENABLE))
	148	return false;
	149
	150	*pipe = PORT_TO_PIPE(tmp);
	151
	152	return true;
	153	}
	154
045ac3b5	155	static void intel_dvo_get_config(struct intel_encoder *encoder,
5cec258b	156	struct intel_crtc_state *pipe_config)
045ac3b5	157	{
fac5e23e	158	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
69438e64	159	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
045ac3b5 JB	160	u32 tmp, flags = 0;
	161
	162	tmp = I915_READ(intel_dvo->dev.dvo_reg);
	163	if (tmp & DVO_HSYNC_ACTIVE_HIGH)
	164	flags \|= DRM_MODE_FLAG_PHSYNC;
	165	else
	166	flags \|= DRM_MODE_FLAG_NHSYNC;
	167	if (tmp & DVO_VSYNC_ACTIVE_HIGH)
	168	flags \|= DRM_MODE_FLAG_PVSYNC;
	169	else
	170	flags \|= DRM_MODE_FLAG_NVSYNC;
	171
2d112de7	172	pipe_config->base.adjusted_mode.flags \|= flags;
18442d08	173
2d112de7	174	pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
045ac3b5 JB	175	}
045ac3b5 JB	176
fd6bbda9	177	static void intel_disable_dvo(struct intel_encoder *encoder,
5f88a9c6 VS	178	const struct intel_crtc_state *old_crtc_state,
5f88a9c6 VS	179	const struct drm_connector_state *old_conn_state)
19c63fa8	180	{
fac5e23e	181	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
69438e64	182	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
f0f59a00	183	i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
19c63fa8 DV	184	u32 temp = I915_READ(dvo_reg);
	185
	186	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
	187	I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
	188	I915_READ(dvo_reg);
	189	}
	190
fd6bbda9	191	static void intel_enable_dvo(struct intel_encoder *encoder,
5f88a9c6 VS	192	const struct intel_crtc_state *pipe_config,
5f88a9c6 VS	193	const struct drm_connector_state *conn_state)
19c63fa8	194	{
fac5e23e	195	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
69438e64	196	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
f0f59a00	197	i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
79e53945 JB	198	u32 temp = I915_READ(dvo_reg);
79e53945 JB	199
48f34e10	200	intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
ae9a911b ML	201	&pipe_config->base.mode,
ae9a911b ML	202	&pipe_config->base.adjusted_mode);
48f34e10	203
c9c054c2 VS	204	I915_WRITE(dvo_reg, temp \| DVO_ENABLE);
	205	I915_READ(dvo_reg);
	206
19c63fa8 DV	207	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
	208	}
	209
c19de8eb DL	210	static enum drm_mode_status
	211	intel_dvo_mode_valid(struct drm_connector *connector,
	212	struct drm_display_mode *mode)
79e53945	213	{
df0e9248	214	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
28694070 VS	215	const struct drm_display_mode *fixed_mode =
28694070 VS	216	to_intel_connector(connector)->panel.fixed_mode;
26a91555 MK	217	int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
26a91555 MK	218	int target_clock = mode->clock;
79e53945 JB	219
	220	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
	221	return MODE_NO_DBLESCAN;
	222
	223	/* XXX: Validate clock range */
	224
28694070 VS	225	if (fixed_mode) {
28694070 VS	226	if (mode->hdisplay > fixed_mode->hdisplay)
79e53945	227	return MODE_PANEL;
28694070	228	if (mode->vdisplay > fixed_mode->vdisplay)
79e53945	229	return MODE_PANEL;
26a91555	230
28694070	231	target_clock = fixed_mode->clock;
79e53945 JB	232	}
79e53945 JB	233
26a91555 MK	234	if (target_clock > max_dotclk)
	235	return MODE_CLOCK_HIGH;
	236
ea5b213a	237	return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
79e53945 JB	238	}
79e53945 JB	239
a3470375	240	static bool intel_dvo_compute_config(struct intel_encoder *encoder,
0a478c27 ML	241	struct intel_crtc_state *pipe_config,
0a478c27 ML	242	struct drm_connector_state *conn_state)
79e53945	243	{
a3470375	244	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
28694070 VS	245	const struct drm_display_mode *fixed_mode =
28694070 VS	246	intel_dvo->attached_connector->panel.fixed_mode;
2d112de7	247	struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
79e53945 JB	248
	249	/* If we have timings from the BIOS for the panel, put them in
	250	* to the adjusted mode. The CRTC will be set up for this mode,
	251	* with the panel scaling set up to source from the H/VDisplay
	252	* of the original mode.
	253	*/
28694070 VS	254	if (fixed_mode)
28694070 VS	255	intel_fixed_panel_mode(fixed_mode, adjusted_mode);
79e53945	256
79e53945 JB	257	return true;
	258	}
	259
fd6bbda9	260	static void intel_dvo_pre_enable(struct intel_encoder *encoder,
5f88a9c6 VS	261	const struct intel_crtc_state *pipe_config,
5f88a9c6 VS	262	const struct drm_connector_state *conn_state)
79e53945	263	{
ae9a911b ML	264	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
	265	struct intel_crtc *crtc = to_intel_crtc(pipe_config->base.crtc);
	266	const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
79fde301 DV	267	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
79fde301 DV	268	int pipe = crtc->pipe;
79e53945	269	u32 dvo_val;
f0f59a00 VS	270	i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
f0f59a00 VS	271	i915_reg_t dvo_srcdim_reg = intel_dvo->dev.dvo_srcdim_reg;
79e53945	272
79e53945 JB	273	/* Save the data order, since I don't know what it should be set to. */
	274	dvo_val = I915_READ(dvo_reg) &
	275	(DVO_PRESERVE_MASK \| DVO_DATA_ORDER_GBRG);
	276	dvo_val \|= DVO_DATA_ORDER_FP \| DVO_BORDER_ENABLE \|
	277	DVO_BLANK_ACTIVE_HIGH;
	278
	279	if (pipe == 1)
	280	dvo_val \|= DVO_PIPE_B_SELECT;
	281	dvo_val \|= DVO_PIPE_STALL;
	282	if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
	283	dvo_val \|= DVO_HSYNC_ACTIVE_HIGH;
	284	if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
	285	dvo_val \|= DVO_VSYNC_ACTIVE_HIGH;
	286
79e53945	287	/*I915_WRITE(DVOB_SRCDIM,
aad941d5 VS	288	(adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) \|
aad941d5 VS	289	(adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
79e53945	290	I915_WRITE(dvo_srcdim_reg,
aad941d5 VS	291	(adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) \|
aad941d5 VS	292	(adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
79e53945 JB	293	/I915_WRITE(DVOB, dvo_val);/
	294	I915_WRITE(dvo_reg, dvo_val);
	295	}
	296
	297	/**
	298	* Detect the output connection on our DVO device.
	299	*
	300	* Unimplemented.
	301	*/
7b334fcb	302	static enum drm_connector_status
930a9e28	303	intel_dvo_detect(struct drm_connector *connector, bool force)
79e53945	304	{
df0e9248	305	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
164c8598	306	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
c23cc417	307	connector->base.id, connector->name);
ea5b213a	308	return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
79e53945 JB	309	}
	310
	311	static int intel_dvo_get_modes(struct drm_connector *connector)
	312	{
fac5e23e	313	struct drm_i915_private *dev_priv = to_i915(connector->dev);
28694070 VS	314	const struct drm_display_mode *fixed_mode =
28694070 VS	315	to_intel_connector(connector)->panel.fixed_mode;
79e53945 JB	316
	317	/* We should probably have an i2c driver get_modes function for those
	318	* devices which will have a fixed set of modes determined by the chip
	319	* (TV-out, for example), but for now with just TMDS and LVDS,
	320	* that's not the case.
	321	*/
f899fc64	322	intel_ddc_get_modes(connector,
988c7015	323	intel_gmbus_get_adapter(dev_priv, GMBUS_PIN_DPC));
79e53945 JB	324	if (!list_empty(&connector->probed_modes))
	325	return 1;
	326
28694070	327	if (fixed_mode) {
79e53945	328	struct drm_display_mode *mode;
28694070	329	mode = drm_mode_duplicate(connector->dev, fixed_mode);
79e53945 JB	330	if (mode) {
	331	drm_mode_probed_add(connector, mode);
	332	return 1;
	333	}
	334	}
ea5b213a	335
79e53945 JB	336	return 0;
	337	}
	338
ea5b213a	339	static void intel_dvo_destroy(struct drm_connector *connector)
79e53945	340	{
79e53945	341	drm_connector_cleanup(connector);
28694070	342	intel_panel_fini(&to_intel_connector(connector)->panel);
599be16c	343	kfree(connector);
79e53945	344	}
79e53945	345
79e53945	346	static const struct drm_connector_funcs intel_dvo_connector_funcs = {
79e53945	347	.detect = intel_dvo_detect,
1ebaa0b9	348	.late_register = intel_connector_register,
c191eca1	349	.early_unregister = intel_connector_unregister,
79e53945 JB	350	.destroy = intel_dvo_destroy,
79e53945 JB	351	.fill_modes = drm_helper_probe_single_connector_modes,
c6f95f27	352	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
98969725	353	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
79e53945 JB	354	};
	355
	356	static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
	357	.mode_valid = intel_dvo_mode_valid,
	358	.get_modes = intel_dvo_get_modes,
79e53945 JB	359	};
79e53945 JB	360
b358d0a6	361	static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
79e53945	362	{
69438e64	363	struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
ea5b213a CW	364
	365	if (intel_dvo->dev.dev_ops->destroy)
	366	intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);
	367
ea5b213a	368	intel_encoder_destroy(encoder);
79e53945 JB	369	}
	370
	371	static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
	372	.destroy = intel_dvo_enc_destroy,
	373	};
	374
79e53945 JB	375	/**
	376	* Attempts to get a fixed panel timing for LVDS (currently only the i830).
	377	*
	378	* Other chips with DVO LVDS will need to extend this to deal with the LVDS
	379	* chip being on DVOB/C and having multiple pipes.
	380	*/
	381	static struct drm_display_mode *
de330815	382	intel_dvo_get_current_mode(struct intel_encoder *encoder)
79e53945	383	{
de330815	384	struct drm_display_mode *mode;
79e53945	385
de330815 VS	386	mode = intel_encoder_current_mode(encoder);
	387	if (mode) {
	388	DRM_DEBUG_KMS("using current (BIOS) mode: ");
	389	drm_mode_debug_printmodeline(mode);
	390	mode->type \|= DRM_MODE_TYPE_PREFERRED;
79e53945	391	}
ea5b213a	392
79e53945 JB	393	return mode;
	394	}
	395
5748be60	396	static enum port intel_dvo_port(i915_reg_t dvo_reg)
580d8ed5 VS	397	{
580d8ed5 VS	398	if (i915_mmio_reg_equal(dvo_reg, DVOA))
5748be60	399	return PORT_A;
580d8ed5	400	else if (i915_mmio_reg_equal(dvo_reg, DVOB))
5748be60	401	return PORT_B;
580d8ed5	402	else
5748be60	403	return PORT_C;
580d8ed5 VS	404	}
580d8ed5 VS	405
c39055b0	406	void intel_dvo_init(struct drm_i915_private *dev_priv)
79e53945	407	{
21d40d37	408	struct intel_encoder *intel_encoder;
ea5b213a	409	struct intel_dvo *intel_dvo;
599be16c	410	struct intel_connector *intel_connector;
79e53945	411	int i;
79e53945	412	int encoder_type = DRM_MODE_ENCODER_NONE;
ea5b213a	413
b14c5679	414	intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
ea5b213a	415	if (!intel_dvo)
79e53945 JB	416	return;
79e53945 JB	417
9bdbd0b9	418	intel_connector = intel_connector_alloc();
599be16c	419	if (!intel_connector) {
ea5b213a	420	kfree(intel_dvo);
599be16c ZW	421	return;
	422	}
	423
28694070 VS	424	intel_dvo->attached_connector = intel_connector;
28694070 VS	425
ea5b213a CW	426	intel_encoder = &intel_dvo->base;
ea5b213a CW	427
19c63fa8 DV	428	intel_encoder->disable = intel_disable_dvo;
19c63fa8 DV	429	intel_encoder->enable = intel_enable_dvo;
732ce74f	430	intel_encoder->get_hw_state = intel_dvo_get_hw_state;
045ac3b5	431	intel_encoder->get_config = intel_dvo_get_config;
a3470375	432	intel_encoder->compute_config = intel_dvo_compute_config;
912b0e2d	433	intel_encoder->pre_enable = intel_dvo_pre_enable;
732ce74f	434	intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
19c63fa8	435
79e53945 JB	436	/* Now, try to find a controller */
79e53945 JB	437	for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
599be16c	438	struct drm_connector *connector = &intel_connector->base;
ea5b213a	439	const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
f899fc64	440	struct i2c_adapter *i2c;
79e53945	441	int gpio;
e4bfff54	442	bool dvoinit;
46509475	443	enum pipe pipe;
699ab787	444	uint32_t dpll[I915_MAX_PIPES];
5748be60	445	enum port port;
79e53945	446
79e53945 JB	447	/* Allow the I2C driver info to specify the GPIO to be used in
	448	* special cases, but otherwise default to what's defined
	449	* in the spec.
	450	*/
88ac7939	451	if (intel_gmbus_is_valid_pin(dev_priv, dvo->gpio))
79e53945 JB	452	gpio = dvo->gpio;
79e53945 JB	453	else if (dvo->type == INTEL_DVO_CHIP_LVDS)
988c7015	454	gpio = GMBUS_PIN_SSC;
79e53945	455	else
988c7015	456	gpio = GMBUS_PIN_DPB;
79e53945 JB	457
	458	/* Set up the I2C bus necessary for the chip we're probing.
	459	* It appears that everything is on GPIOE except for panels
	460	* on i830 laptops, which are on GPIOB (DVOA).
	461	*/
3bd7d909	462	i2c = intel_gmbus_get_adapter(dev_priv, gpio);
79e53945	463
ea5b213a	464	intel_dvo->dev = *dvo;
e4bfff54 DMEA	465
	466	/* GMBUS NAK handling seems to be unstable, hence let the
	467	* transmitter detection run in bit banging mode for now.
	468	*/
	469	intel_gmbus_force_bit(i2c, true);
	470
46509475 VS	471	/* ns2501 requires the DVO 2x clock before it will
	472	* respond to i2c accesses, so make sure we have
	473	* have the clock enabled before we attempt to
	474	* initialize the device.
	475	*/
	476	for_each_pipe(dev_priv, pipe) {
	477	dpll[pipe] = I915_READ(DPLL(pipe));
	478	I915_WRITE(DPLL(pipe), dpll[pipe] \| DPLL_DVO_2X_MODE);
	479	}
	480
e4bfff54 DMEA	481	dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);
e4bfff54 DMEA	482
46509475 VS	483	/* restore the DVO 2x clock state to original */
	484	for_each_pipe(dev_priv, pipe) {
	485	I915_WRITE(DPLL(pipe), dpll[pipe]);
	486	}
	487
e4bfff54 DMEA	488	intel_gmbus_force_bit(i2c, false);
	489
	490	if (!dvoinit)
79e53945 JB	491	continue;
79e53945 JB	492
5748be60	493	port = intel_dvo_port(dvo->dvo_reg);
c39055b0	494	drm_encoder_init(&dev_priv->drm, &intel_encoder->base,
580d8ed5	495	&intel_dvo_enc_funcs, encoder_type,
5748be60	496	"DVO %c", port_name(port));
580d8ed5	497
21d40d37	498	intel_encoder->type = INTEL_OUTPUT_DVO;
79f255a0	499	intel_encoder->power_domain = POWER_DOMAIN_PORT_OTHER;
03cdc1d4	500	intel_encoder->port = port;
21d40d37	501	intel_encoder->crtc_mask = (1 << 0) \| (1 << 1);
03cdc1d4	502
79e53945 JB	503	switch (dvo->type) {
79e53945 JB	504	case INTEL_DVO_CHIP_TMDS:
bc079e8b VS	505	intel_encoder->cloneable = (1 << INTEL_OUTPUT_ANALOG) \|
bc079e8b VS	506	(1 << INTEL_OUTPUT_DVO);
c39055b0	507	drm_connector_init(&dev_priv->drm, connector,
79e53945 JB	508	&intel_dvo_connector_funcs,
	509	DRM_MODE_CONNECTOR_DVII);
	510	encoder_type = DRM_MODE_ENCODER_TMDS;
	511	break;
	512	case INTEL_DVO_CHIP_LVDS:
bc079e8b	513	intel_encoder->cloneable = 0;
c39055b0	514	drm_connector_init(&dev_priv->drm, connector,
79e53945 JB	515	&intel_dvo_connector_funcs,
	516	DRM_MODE_CONNECTOR_LVDS);
	517	encoder_type = DRM_MODE_ENCODER_LVDS;
	518	break;
	519	}
	520
	521	drm_connector_helper_add(connector,
	522	&intel_dvo_connector_helper_funcs);
	523	connector->display_info.subpixel_order = SubPixelHorizontalRGB;
	524	connector->interlace_allowed = false;
	525	connector->doublescan_allowed = false;
	526
df0e9248	527	intel_connector_attach_encoder(intel_connector, intel_encoder);
79e53945 JB	528	if (dvo->type == INTEL_DVO_CHIP_LVDS) {
	529	/* For our LVDS chipsets, we should hopefully be able
	530	* to dig the fixed panel mode out of the BIOS data.
	531	* However, it's in a different format from the BIOS
	532	* data on chipsets with integrated LVDS (stored in AIM
	533	* headers, likely), so for now, just get the current
	534	* mode being output through DVO.
	535	*/
28694070	536	intel_panel_init(&intel_connector->panel,
de330815	537	intel_dvo_get_current_mode(intel_encoder),
0dcb8112	538	NULL);
ea5b213a	539	intel_dvo->panel_wants_dither = true;
79e53945 JB	540	}
79e53945 JB	541
79e53945 JB	542	return;
	543	}
	544
ea5b213a	545	kfree(intel_dvo);
599be16c	546	kfree(intel_connector);
79e53945	547	}