]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/blame - drivers/gpu/drm/i915/intel_dvo.c
drm/i915: rip out legacy encoder->mode_fixup logic
[mirror_ubuntu-zesty-kernel.git] / drivers / gpu / drm / i915 / intel_dvo.c
CommitLineData
79e53945
JB
1/*
2 * Copyright 2006 Dave Airlie <airlied@linux.ie>
3 * Copyright © 2006-2007 Intel Corporation
4 *
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
11 *
12 * The above copyright notice and this permission notice (including the next
13 * paragraph) shall be included in all copies or substantial portions of the
14 * Software.
15 *
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
22 * DEALINGS IN THE SOFTWARE.
23 *
24 * Authors:
25 * Eric Anholt <eric@anholt.net>
26 */
27#include <linux/i2c.h>
5a0e3ad6 28#include <linux/slab.h>
760285e7
DH
29#include <drm/drmP.h>
30#include <drm/drm_crtc.h>
79e53945 31#include "intel_drv.h"
760285e7 32#include <drm/i915_drm.h>
79e53945
JB
33#include "i915_drv.h"
34#include "dvo.h"
35
36#define SIL164_ADDR 0x38
37#define CH7xxx_ADDR 0x76
38#define TFP410_ADDR 0x38
7434a255 39#define NS2501_ADDR 0x38
79e53945 40
ea5b213a 41static const struct intel_dvo_device intel_dvo_devices[] = {
79e53945
JB
42 {
43 .type = INTEL_DVO_CHIP_TMDS,
44 .name = "sil164",
45 .dvo_reg = DVOC,
46 .slave_addr = SIL164_ADDR,
47 .dev_ops = &sil164_ops,
48 },
49 {
50 .type = INTEL_DVO_CHIP_TMDS,
51 .name = "ch7xxx",
52 .dvo_reg = DVOC,
53 .slave_addr = CH7xxx_ADDR,
54 .dev_ops = &ch7xxx_ops,
55 },
98304ad1 56 {
57 .type = INTEL_DVO_CHIP_TMDS,
58 .name = "ch7xxx",
59 .dvo_reg = DVOC,
60 .slave_addr = 0x75, /* For some ch7010 */
61 .dev_ops = &ch7xxx_ops,
62 },
79e53945
JB
63 {
64 .type = INTEL_DVO_CHIP_LVDS,
65 .name = "ivch",
66 .dvo_reg = DVOA,
67 .slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
68 .dev_ops = &ivch_ops,
69 },
70 {
71 .type = INTEL_DVO_CHIP_TMDS,
72 .name = "tfp410",
73 .dvo_reg = DVOC,
74 .slave_addr = TFP410_ADDR,
75 .dev_ops = &tfp410_ops,
76 },
77 {
78 .type = INTEL_DVO_CHIP_LVDS,
79 .name = "ch7017",
80 .dvo_reg = DVOC,
81 .slave_addr = 0x75,
a6b17b43 82 .gpio = GMBUS_PORT_DPB,
79e53945 83 .dev_ops = &ch7017_ops,
7434a255
TR
84 },
85 {
86 .type = INTEL_DVO_CHIP_TMDS,
87 .name = "ns2501",
88 .dvo_reg = DVOC,
89 .slave_addr = NS2501_ADDR,
90 .dev_ops = &ns2501_ops,
91 }
79e53945
JB
92};
93
ea5b213a
CW
94struct intel_dvo {
95 struct intel_encoder base;
96
97 struct intel_dvo_device dev;
98
99 struct drm_display_mode *panel_fixed_mode;
100 bool panel_wants_dither;
101};
102
69438e64 103static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
ea5b213a 104{
69438e64 105 return container_of(encoder, struct intel_dvo, base);
ea5b213a
CW
106}
107
df0e9248
CW
108static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
109{
110 return container_of(intel_attached_encoder(connector),
111 struct intel_dvo, base);
112}
113
732ce74f 114static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
79e53945 115{
732ce74f
DV
116 struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
117
118 return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
119}
120
121static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
122 enum pipe *pipe)
123{
124 struct drm_device *dev = encoder->base.dev;
125 struct drm_i915_private *dev_priv = dev->dev_private;
69438e64 126 struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
732ce74f
DV
127 u32 tmp;
128
129 tmp = I915_READ(intel_dvo->dev.dvo_reg);
130
131 if (!(tmp & DVO_ENABLE))
132 return false;
133
134 *pipe = PORT_TO_PIPE(tmp);
135
136 return true;
137}
138
045ac3b5
JB
139static void intel_dvo_get_config(struct intel_encoder *encoder,
140 struct intel_crtc_config *pipe_config)
141{
142 struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
69438e64 143 struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
045ac3b5
JB
144 u32 tmp, flags = 0;
145
146 tmp = I915_READ(intel_dvo->dev.dvo_reg);
147 if (tmp & DVO_HSYNC_ACTIVE_HIGH)
148 flags |= DRM_MODE_FLAG_PHSYNC;
149 else
150 flags |= DRM_MODE_FLAG_NHSYNC;
151 if (tmp & DVO_VSYNC_ACTIVE_HIGH)
152 flags |= DRM_MODE_FLAG_PVSYNC;
153 else
154 flags |= DRM_MODE_FLAG_NVSYNC;
155
156 pipe_config->adjusted_mode.flags |= flags;
157}
158
19c63fa8
DV
159static void intel_disable_dvo(struct intel_encoder *encoder)
160{
161 struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
69438e64 162 struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
19c63fa8
DV
163 u32 dvo_reg = intel_dvo->dev.dvo_reg;
164 u32 temp = I915_READ(dvo_reg);
165
166 intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
167 I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
168 I915_READ(dvo_reg);
169}
170
171static void intel_enable_dvo(struct intel_encoder *encoder)
172{
173 struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
69438e64 174 struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
ea5b213a 175 u32 dvo_reg = intel_dvo->dev.dvo_reg;
79e53945
JB
176 u32 temp = I915_READ(dvo_reg);
177
19c63fa8
DV
178 I915_WRITE(dvo_reg, temp | DVO_ENABLE);
179 I915_READ(dvo_reg);
180 intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
181}
182
6b1c087b 183/* Special dpms function to support cloning between dvo/sdvo/crt. */
b2cabb0e 184static void intel_dvo_dpms(struct drm_connector *connector, int mode)
79e53945 185{
b2cabb0e
DV
186 struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
187 struct drm_crtc *crtc;
188
189 /* dvo supports only 2 dpms states. */
190 if (mode != DRM_MODE_DPMS_ON)
191 mode = DRM_MODE_DPMS_OFF;
192
193 if (mode == connector->dpms)
194 return;
195
196 connector->dpms = mode;
197
198 /* Only need to change hw state when actually enabled */
199 crtc = intel_dvo->base.base.crtc;
200 if (!crtc) {
201 intel_dvo->base.connectors_active = false;
202 return;
203 }
79e53945 204
6b1c087b
JN
205 /* We call connector dpms manually below in case pipe dpms doesn't
206 * change due to cloning. */
79e53945 207 if (mode == DRM_MODE_DPMS_ON) {
b2cabb0e
DV
208 intel_dvo->base.connectors_active = true;
209
210 intel_crtc_update_dpms(crtc);
211
fac3274c 212 intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
79e53945 213 } else {
fac3274c 214 intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
b2cabb0e
DV
215
216 intel_dvo->base.connectors_active = false;
217
218 intel_crtc_update_dpms(crtc);
79e53945 219 }
0a91ca29 220
b980514c 221 intel_modeset_check_state(connector->dev);
79e53945
JB
222}
223
79e53945
JB
224static int intel_dvo_mode_valid(struct drm_connector *connector,
225 struct drm_display_mode *mode)
226{
df0e9248 227 struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
79e53945
JB
228
229 if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
230 return MODE_NO_DBLESCAN;
231
232 /* XXX: Validate clock range */
233
ea5b213a
CW
234 if (intel_dvo->panel_fixed_mode) {
235 if (mode->hdisplay > intel_dvo->panel_fixed_mode->hdisplay)
79e53945 236 return MODE_PANEL;
ea5b213a 237 if (mode->vdisplay > intel_dvo->panel_fixed_mode->vdisplay)
79e53945
JB
238 return MODE_PANEL;
239 }
240
ea5b213a 241 return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
79e53945
JB
242}
243
a3470375
DV
244static bool intel_dvo_compute_config(struct intel_encoder *encoder,
245 struct intel_crtc_config *pipe_config)
79e53945 246{
a3470375
DV
247 struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
248 struct drm_display_mode *adjusted_mode = &pipe_config->adjusted_mode;
79e53945
JB
249
250 /* If we have timings from the BIOS for the panel, put them in
251 * to the adjusted mode. The CRTC will be set up for this mode,
252 * with the panel scaling set up to source from the H/VDisplay
253 * of the original mode.
254 */
ea5b213a
CW
255 if (intel_dvo->panel_fixed_mode != NULL) {
256#define C(x) adjusted_mode->x = intel_dvo->panel_fixed_mode->x
79e53945
JB
257 C(hdisplay);
258 C(hsync_start);
259 C(hsync_end);
260 C(htotal);
261 C(vdisplay);
262 C(vsync_start);
263 C(vsync_end);
264 C(vtotal);
265 C(clock);
79e53945
JB
266#undef C
267 }
268
ea5b213a 269 if (intel_dvo->dev.dev_ops->mode_fixup)
a3470375
DV
270 return intel_dvo->dev.dev_ops->mode_fixup(&intel_dvo->dev,
271 &pipe_config->requested_mode,
272 adjusted_mode);
79e53945
JB
273
274 return true;
275}
276
277static void intel_dvo_mode_set(struct drm_encoder *encoder,
278 struct drm_display_mode *mode,
279 struct drm_display_mode *adjusted_mode)
280{
281 struct drm_device *dev = encoder->dev;
282 struct drm_i915_private *dev_priv = dev->dev_private;
283 struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
69438e64 284 struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
79e53945
JB
285 int pipe = intel_crtc->pipe;
286 u32 dvo_val;
ea5b213a 287 u32 dvo_reg = intel_dvo->dev.dvo_reg, dvo_srcdim_reg;
79e53945
JB
288
289 switch (dvo_reg) {
290 case DVOA:
291 default:
292 dvo_srcdim_reg = DVOA_SRCDIM;
293 break;
294 case DVOB:
295 dvo_srcdim_reg = DVOB_SRCDIM;
296 break;
297 case DVOC:
298 dvo_srcdim_reg = DVOC_SRCDIM;
299 break;
300 }
301
ea5b213a 302 intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev, mode, adjusted_mode);
79e53945
JB
303
304 /* Save the data order, since I don't know what it should be set to. */
305 dvo_val = I915_READ(dvo_reg) &
306 (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
307 dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
308 DVO_BLANK_ACTIVE_HIGH;
309
310 if (pipe == 1)
311 dvo_val |= DVO_PIPE_B_SELECT;
312 dvo_val |= DVO_PIPE_STALL;
313 if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
314 dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
315 if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
316 dvo_val |= DVO_VSYNC_ACTIVE_HIGH;
317
79e53945
JB
318 /*I915_WRITE(DVOB_SRCDIM,
319 (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
320 (adjusted_mode->VDisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
321 I915_WRITE(dvo_srcdim_reg,
322 (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
323 (adjusted_mode->vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
324 /*I915_WRITE(DVOB, dvo_val);*/
325 I915_WRITE(dvo_reg, dvo_val);
326}
327
328/**
329 * Detect the output connection on our DVO device.
330 *
331 * Unimplemented.
332 */
7b334fcb 333static enum drm_connector_status
930a9e28 334intel_dvo_detect(struct drm_connector *connector, bool force)
79e53945 335{
df0e9248 336 struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
164c8598
CW
337 DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
338 connector->base.id, drm_get_connector_name(connector));
ea5b213a 339 return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
79e53945
JB
340}
341
342static int intel_dvo_get_modes(struct drm_connector *connector)
343{
df0e9248 344 struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
f899fc64 345 struct drm_i915_private *dev_priv = connector->dev->dev_private;
79e53945
JB
346
347 /* We should probably have an i2c driver get_modes function for those
348 * devices which will have a fixed set of modes determined by the chip
349 * (TV-out, for example), but for now with just TMDS and LVDS,
350 * that's not the case.
351 */
f899fc64 352 intel_ddc_get_modes(connector,
3bd7d909 353 intel_gmbus_get_adapter(dev_priv, GMBUS_PORT_DPC));
79e53945
JB
354 if (!list_empty(&connector->probed_modes))
355 return 1;
356
ea5b213a 357 if (intel_dvo->panel_fixed_mode != NULL) {
79e53945 358 struct drm_display_mode *mode;
ea5b213a 359 mode = drm_mode_duplicate(connector->dev, intel_dvo->panel_fixed_mode);
79e53945
JB
360 if (mode) {
361 drm_mode_probed_add(connector, mode);
362 return 1;
363 }
364 }
ea5b213a 365
79e53945
JB
366 return 0;
367}
368
ea5b213a 369static void intel_dvo_destroy(struct drm_connector *connector)
79e53945 370{
79e53945
JB
371 drm_sysfs_connector_remove(connector);
372 drm_connector_cleanup(connector);
599be16c 373 kfree(connector);
79e53945 374}
79e53945
JB
375
376static const struct drm_encoder_helper_funcs intel_dvo_helper_funcs = {
79e53945 377 .mode_set = intel_dvo_mode_set,
79e53945
JB
378};
379
380static const struct drm_connector_funcs intel_dvo_connector_funcs = {
b2cabb0e 381 .dpms = intel_dvo_dpms,
79e53945
JB
382 .detect = intel_dvo_detect,
383 .destroy = intel_dvo_destroy,
384 .fill_modes = drm_helper_probe_single_connector_modes,
385};
386
387static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
388 .mode_valid = intel_dvo_mode_valid,
389 .get_modes = intel_dvo_get_modes,
df0e9248 390 .best_encoder = intel_best_encoder,
79e53945
JB
391};
392
b358d0a6 393static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
79e53945 394{
69438e64 395 struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
ea5b213a
CW
396
397 if (intel_dvo->dev.dev_ops->destroy)
398 intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);
399
400 kfree(intel_dvo->panel_fixed_mode);
401
402 intel_encoder_destroy(encoder);
79e53945
JB
403}
404
405static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
406 .destroy = intel_dvo_enc_destroy,
407};
408
79e53945
JB
409/**
410 * Attempts to get a fixed panel timing for LVDS (currently only the i830).
411 *
412 * Other chips with DVO LVDS will need to extend this to deal with the LVDS
413 * chip being on DVOB/C and having multiple pipes.
414 */
415static struct drm_display_mode *
ea5b213a 416intel_dvo_get_current_mode(struct drm_connector *connector)
79e53945
JB
417{
418 struct drm_device *dev = connector->dev;
419 struct drm_i915_private *dev_priv = dev->dev_private;
df0e9248 420 struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
ea5b213a 421 uint32_t dvo_val = I915_READ(intel_dvo->dev.dvo_reg);
79e53945
JB
422 struct drm_display_mode *mode = NULL;
423
424 /* If the DVO port is active, that'll be the LVDS, so we can pull out
425 * its timings to get how the BIOS set up the panel.
426 */
427 if (dvo_val & DVO_ENABLE) {
428 struct drm_crtc *crtc;
429 int pipe = (dvo_val & DVO_PIPE_B_SELECT) ? 1 : 0;
430
f875c15a 431 crtc = intel_get_crtc_for_pipe(dev, pipe);
79e53945
JB
432 if (crtc) {
433 mode = intel_crtc_mode_get(dev, crtc);
79e53945
JB
434 if (mode) {
435 mode->type |= DRM_MODE_TYPE_PREFERRED;
436 if (dvo_val & DVO_HSYNC_ACTIVE_HIGH)
437 mode->flags |= DRM_MODE_FLAG_PHSYNC;
438 if (dvo_val & DVO_VSYNC_ACTIVE_HIGH)
439 mode->flags |= DRM_MODE_FLAG_PVSYNC;
440 }
441 }
442 }
ea5b213a 443
79e53945
JB
444 return mode;
445}
446
447void intel_dvo_init(struct drm_device *dev)
448{
f899fc64 449 struct drm_i915_private *dev_priv = dev->dev_private;
21d40d37 450 struct intel_encoder *intel_encoder;
ea5b213a 451 struct intel_dvo *intel_dvo;
599be16c 452 struct intel_connector *intel_connector;
79e53945 453 int i;
79e53945 454 int encoder_type = DRM_MODE_ENCODER_NONE;
ea5b213a
CW
455
456 intel_dvo = kzalloc(sizeof(struct intel_dvo), GFP_KERNEL);
457 if (!intel_dvo)
79e53945
JB
458 return;
459
599be16c
ZW
460 intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL);
461 if (!intel_connector) {
ea5b213a 462 kfree(intel_dvo);
599be16c
ZW
463 return;
464 }
465
ea5b213a 466 intel_encoder = &intel_dvo->base;
373a3cf7
CW
467 drm_encoder_init(dev, &intel_encoder->base,
468 &intel_dvo_enc_funcs, encoder_type);
ea5b213a 469
19c63fa8
DV
470 intel_encoder->disable = intel_disable_dvo;
471 intel_encoder->enable = intel_enable_dvo;
732ce74f 472 intel_encoder->get_hw_state = intel_dvo_get_hw_state;
045ac3b5 473 intel_encoder->get_config = intel_dvo_get_config;
a3470375 474 intel_encoder->compute_config = intel_dvo_compute_config;
732ce74f 475 intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
19c63fa8 476
79e53945
JB
477 /* Now, try to find a controller */
478 for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
599be16c 479 struct drm_connector *connector = &intel_connector->base;
ea5b213a 480 const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
f899fc64 481 struct i2c_adapter *i2c;
79e53945 482 int gpio;
e4bfff54 483 bool dvoinit;
79e53945 484
79e53945
JB
485 /* Allow the I2C driver info to specify the GPIO to be used in
486 * special cases, but otherwise default to what's defined
487 * in the spec.
488 */
3bd7d909 489 if (intel_gmbus_is_port_valid(dvo->gpio))
79e53945
JB
490 gpio = dvo->gpio;
491 else if (dvo->type == INTEL_DVO_CHIP_LVDS)
f573c660 492 gpio = GMBUS_PORT_SSC;
79e53945 493 else
a6b17b43 494 gpio = GMBUS_PORT_DPB;
79e53945
JB
495
496 /* Set up the I2C bus necessary for the chip we're probing.
497 * It appears that everything is on GPIOE except for panels
498 * on i830 laptops, which are on GPIOB (DVOA).
499 */
3bd7d909 500 i2c = intel_gmbus_get_adapter(dev_priv, gpio);
79e53945 501
ea5b213a 502 intel_dvo->dev = *dvo;
e4bfff54
DMEA
503
504 /* GMBUS NAK handling seems to be unstable, hence let the
505 * transmitter detection run in bit banging mode for now.
506 */
507 intel_gmbus_force_bit(i2c, true);
508
509 dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);
510
511 intel_gmbus_force_bit(i2c, false);
512
513 if (!dvoinit)
79e53945
JB
514 continue;
515
21d40d37
EA
516 intel_encoder->type = INTEL_OUTPUT_DVO;
517 intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
79e53945
JB
518 switch (dvo->type) {
519 case INTEL_DVO_CHIP_TMDS:
66a9278e 520 intel_encoder->cloneable = true;
79e53945
JB
521 drm_connector_init(dev, connector,
522 &intel_dvo_connector_funcs,
523 DRM_MODE_CONNECTOR_DVII);
524 encoder_type = DRM_MODE_ENCODER_TMDS;
525 break;
526 case INTEL_DVO_CHIP_LVDS:
66a9278e 527 intel_encoder->cloneable = false;
79e53945
JB
528 drm_connector_init(dev, connector,
529 &intel_dvo_connector_funcs,
530 DRM_MODE_CONNECTOR_LVDS);
531 encoder_type = DRM_MODE_ENCODER_LVDS;
532 break;
533 }
534
535 drm_connector_helper_add(connector,
536 &intel_dvo_connector_helper_funcs);
537 connector->display_info.subpixel_order = SubPixelHorizontalRGB;
538 connector->interlace_allowed = false;
539 connector->doublescan_allowed = false;
540
4ef69c7a 541 drm_encoder_helper_add(&intel_encoder->base,
79e53945
JB
542 &intel_dvo_helper_funcs);
543
df0e9248 544 intel_connector_attach_encoder(intel_connector, intel_encoder);
79e53945
JB
545 if (dvo->type == INTEL_DVO_CHIP_LVDS) {
546 /* For our LVDS chipsets, we should hopefully be able
547 * to dig the fixed panel mode out of the BIOS data.
548 * However, it's in a different format from the BIOS
549 * data on chipsets with integrated LVDS (stored in AIM
550 * headers, likely), so for now, just get the current
551 * mode being output through DVO.
552 */
ea5b213a 553 intel_dvo->panel_fixed_mode =
79e53945 554 intel_dvo_get_current_mode(connector);
ea5b213a 555 intel_dvo->panel_wants_dither = true;
79e53945
JB
556 }
557
558 drm_sysfs_connector_add(connector);
559 return;
560 }
561
373a3cf7 562 drm_encoder_cleanup(&intel_encoder->base);
ea5b213a 563 kfree(intel_dvo);
599be16c 564 kfree(intel_connector);
79e53945 565}