]>
Commit | Line | Data |
---|---|---|
7198e6b0 RC |
1 | /* |
2 | * Copyright (C) 2013 Red Hat | |
3 | * Author: Rob Clark <robdclark@gmail.com> | |
4 | * | |
5 | * This program is free software; you can redistribute it and/or modify it | |
6 | * under the terms of the GNU General Public License version 2 as published by | |
7 | * the Free Software Foundation. | |
8 | * | |
9 | * This program is distributed in the hope that it will be useful, but WITHOUT | |
10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for | |
12 | * more details. | |
13 | * | |
14 | * You should have received a copy of the GNU General Public License along with | |
15 | * this program. If not, see <http://www.gnu.org/licenses/>. | |
16 | */ | |
17 | ||
f0a42bb5 RC |
18 | #include <linux/sync_file.h> |
19 | ||
7198e6b0 RC |
20 | #include "msm_drv.h" |
21 | #include "msm_gpu.h" | |
22 | #include "msm_gem.h" | |
23 | ||
24 | /* | |
25 | * Cmdstream submission: | |
26 | */ | |
27 | ||
7198e6b0 | 28 | /* make sure these don't conflict w/ MSM_SUBMIT_BO_x */ |
340faef2 | 29 | #define BO_VALID 0x8000 /* is current addr in cmdstream correct/valid? */ |
7198e6b0 RC |
30 | #define BO_LOCKED 0x4000 |
31 | #define BO_PINNED 0x2000 | |
32 | ||
7198e6b0 | 33 | static struct msm_gem_submit *submit_create(struct drm_device *dev, |
6b597ce2 | 34 | struct msm_gpu *gpu, int nr_bos, int nr_cmds) |
7198e6b0 RC |
35 | { |
36 | struct msm_gem_submit *submit; | |
6b597ce2 RC |
37 | int sz = sizeof(*submit) + (nr_bos * sizeof(submit->bos[0])) + |
38 | (nr_cmds * sizeof(*submit->cmd)); | |
7198e6b0 RC |
39 | |
40 | submit = kmalloc(sz, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY); | |
6860b56c RC |
41 | if (!submit) |
42 | return NULL; | |
7198e6b0 | 43 | |
6860b56c RC |
44 | submit->dev = dev; |
45 | submit->gpu = gpu; | |
ba344afd | 46 | submit->fence = NULL; |
4816b626 | 47 | submit->pid = get_pid(task_pid(current)); |
6b597ce2 | 48 | submit->cmd = (void *)&submit->bos[nr_bos]; |
7198e6b0 | 49 | |
6860b56c RC |
50 | /* initially, until copy_from_user() and bo lookup succeeds: */ |
51 | submit->nr_bos = 0; | |
52 | submit->nr_cmds = 0; | |
53 | ||
ba344afd | 54 | INIT_LIST_HEAD(&submit->node); |
6860b56c RC |
55 | INIT_LIST_HEAD(&submit->bo_list); |
56 | ww_acquire_init(&submit->ticket, &reservation_ww_class); | |
7198e6b0 RC |
57 | |
58 | return submit; | |
59 | } | |
60 | ||
40e6815b RC |
61 | void msm_gem_submit_free(struct msm_gem_submit *submit) |
62 | { | |
f54d1867 | 63 | dma_fence_put(submit->fence); |
40e6815b | 64 | list_del(&submit->node); |
4816b626 | 65 | put_pid(submit->pid); |
40e6815b RC |
66 | kfree(submit); |
67 | } | |
68 | ||
89f82cbb RC |
69 | static inline unsigned long __must_check |
70 | copy_from_user_inatomic(void *to, const void __user *from, unsigned long n) | |
71 | { | |
72 | if (access_ok(VERIFY_READ, from, n)) | |
73 | return __copy_from_user_inatomic(to, from, n); | |
74 | return -EFAULT; | |
75 | } | |
76 | ||
7198e6b0 RC |
77 | static int submit_lookup_objects(struct msm_gem_submit *submit, |
78 | struct drm_msm_gem_submit *args, struct drm_file *file) | |
79 | { | |
80 | unsigned i; | |
81 | int ret = 0; | |
82 | ||
83 | spin_lock(&file->table_lock); | |
89f82cbb | 84 | pagefault_disable(); |
7198e6b0 RC |
85 | |
86 | for (i = 0; i < args->nr_bos; i++) { | |
87 | struct drm_msm_gem_submit_bo submit_bo; | |
88 | struct drm_gem_object *obj; | |
89 | struct msm_gem_object *msm_obj; | |
90 | void __user *userptr = | |
3ed605bc | 91 | u64_to_user_ptr(args->bos + (i * sizeof(submit_bo))); |
7198e6b0 | 92 | |
a9e26cab RC |
93 | /* make sure we don't have garbage flags, in case we hit |
94 | * error path before flags is initialized: | |
95 | */ | |
96 | submit->bos[i].flags = 0; | |
97 | ||
21c42da1 | 98 | if (copy_from_user_inatomic(&submit_bo, userptr, sizeof(submit_bo))) { |
89f82cbb RC |
99 | pagefault_enable(); |
100 | spin_unlock(&file->table_lock); | |
21c42da1 DC |
101 | if (copy_from_user(&submit_bo, userptr, sizeof(submit_bo))) { |
102 | ret = -EFAULT; | |
89f82cbb | 103 | goto out; |
21c42da1 | 104 | } |
89f82cbb RC |
105 | spin_lock(&file->table_lock); |
106 | pagefault_disable(); | |
7198e6b0 RC |
107 | } |
108 | ||
a6cb3b86 JC |
109 | if ((submit_bo.flags & ~MSM_SUBMIT_BO_FLAGS) || |
110 | !(submit_bo.flags & MSM_SUBMIT_BO_FLAGS)) { | |
19872533 | 111 | DRM_ERROR("invalid flags: %x\n", submit_bo.flags); |
7198e6b0 RC |
112 | ret = -EINVAL; |
113 | goto out_unlock; | |
114 | } | |
115 | ||
116 | submit->bos[i].flags = submit_bo.flags; | |
117 | /* in validate_objects() we figure out if this is true: */ | |
118 | submit->bos[i].iova = submit_bo.presumed; | |
119 | ||
120 | /* normally use drm_gem_object_lookup(), but for bulk lookup | |
121 | * all under single table_lock just hit object_idr directly: | |
122 | */ | |
123 | obj = idr_find(&file->object_idr, submit_bo.handle); | |
124 | if (!obj) { | |
19872533 | 125 | DRM_ERROR("invalid handle %u at index %u\n", submit_bo.handle, i); |
7198e6b0 RC |
126 | ret = -EINVAL; |
127 | goto out_unlock; | |
128 | } | |
129 | ||
130 | msm_obj = to_msm_bo(obj); | |
131 | ||
132 | if (!list_empty(&msm_obj->submit_entry)) { | |
19872533 | 133 | DRM_ERROR("handle %u at index %u already on submit list\n", |
7198e6b0 RC |
134 | submit_bo.handle, i); |
135 | ret = -EINVAL; | |
136 | goto out_unlock; | |
137 | } | |
138 | ||
139 | drm_gem_object_reference(obj); | |
140 | ||
141 | submit->bos[i].obj = msm_obj; | |
142 | ||
143 | list_add_tail(&msm_obj->submit_entry, &submit->bo_list); | |
144 | } | |
145 | ||
146 | out_unlock: | |
89f82cbb | 147 | pagefault_enable(); |
7198e6b0 RC |
148 | spin_unlock(&file->table_lock); |
149 | ||
89f82cbb RC |
150 | out: |
151 | submit->nr_bos = i; | |
152 | ||
7198e6b0 RC |
153 | return ret; |
154 | } | |
155 | ||
156 | static void submit_unlock_unpin_bo(struct msm_gem_submit *submit, int i) | |
157 | { | |
158 | struct msm_gem_object *msm_obj = submit->bos[i].obj; | |
159 | ||
160 | if (submit->bos[i].flags & BO_PINNED) | |
161 | msm_gem_put_iova(&msm_obj->base, submit->gpu->id); | |
162 | ||
163 | if (submit->bos[i].flags & BO_LOCKED) | |
164 | ww_mutex_unlock(&msm_obj->resv->lock); | |
165 | ||
166 | if (!(submit->bos[i].flags & BO_VALID)) | |
167 | submit->bos[i].iova = 0; | |
168 | ||
169 | submit->bos[i].flags &= ~(BO_LOCKED | BO_PINNED); | |
170 | } | |
171 | ||
172 | /* This is where we make sure all the bo's are reserved and pin'd: */ | |
340faef2 | 173 | static int submit_lock_objects(struct msm_gem_submit *submit) |
7198e6b0 RC |
174 | { |
175 | int contended, slow_locked = -1, i, ret = 0; | |
176 | ||
177 | retry: | |
7198e6b0 RC |
178 | for (i = 0; i < submit->nr_bos; i++) { |
179 | struct msm_gem_object *msm_obj = submit->bos[i].obj; | |
7198e6b0 RC |
180 | |
181 | if (slow_locked == i) | |
182 | slow_locked = -1; | |
183 | ||
184 | contended = i; | |
185 | ||
186 | if (!(submit->bos[i].flags & BO_LOCKED)) { | |
187 | ret = ww_mutex_lock_interruptible(&msm_obj->resv->lock, | |
188 | &submit->ticket); | |
189 | if (ret) | |
190 | goto fail; | |
191 | submit->bos[i].flags |= BO_LOCKED; | |
192 | } | |
7198e6b0 RC |
193 | } |
194 | ||
195 | ww_acquire_done(&submit->ticket); | |
196 | ||
197 | return 0; | |
198 | ||
199 | fail: | |
200 | for (; i >= 0; i--) | |
201 | submit_unlock_unpin_bo(submit, i); | |
202 | ||
203 | if (slow_locked > 0) | |
204 | submit_unlock_unpin_bo(submit, slow_locked); | |
205 | ||
206 | if (ret == -EDEADLK) { | |
207 | struct msm_gem_object *msm_obj = submit->bos[contended].obj; | |
208 | /* we lost out in a seqno race, lock and retry.. */ | |
209 | ret = ww_mutex_lock_slow_interruptible(&msm_obj->resv->lock, | |
210 | &submit->ticket); | |
211 | if (!ret) { | |
212 | submit->bos[contended].flags |= BO_LOCKED; | |
213 | slow_locked = contended; | |
214 | goto retry; | |
215 | } | |
216 | } | |
217 | ||
218 | return ret; | |
219 | } | |
220 | ||
b6295f9a RC |
221 | static int submit_fence_sync(struct msm_gem_submit *submit) |
222 | { | |
223 | int i, ret = 0; | |
224 | ||
225 | for (i = 0; i < submit->nr_bos; i++) { | |
226 | struct msm_gem_object *msm_obj = submit->bos[i].obj; | |
227 | bool write = submit->bos[i].flags & MSM_SUBMIT_BO_WRITE; | |
228 | ||
229 | ret = msm_gem_sync_object(&msm_obj->base, submit->gpu->fctx, write); | |
230 | if (ret) | |
231 | break; | |
232 | } | |
233 | ||
234 | return ret; | |
235 | } | |
236 | ||
340faef2 RC |
237 | static int submit_pin_objects(struct msm_gem_submit *submit) |
238 | { | |
239 | int i, ret = 0; | |
240 | ||
241 | submit->valid = true; | |
242 | ||
243 | for (i = 0; i < submit->nr_bos; i++) { | |
244 | struct msm_gem_object *msm_obj = submit->bos[i].obj; | |
78babc16 | 245 | uint64_t iova; |
340faef2 RC |
246 | |
247 | /* if locking succeeded, pin bo: */ | |
248 | ret = msm_gem_get_iova_locked(&msm_obj->base, | |
249 | submit->gpu->id, &iova); | |
250 | ||
251 | if (ret) | |
252 | break; | |
253 | ||
254 | submit->bos[i].flags |= BO_PINNED; | |
255 | ||
256 | if (iova == submit->bos[i].iova) { | |
257 | submit->bos[i].flags |= BO_VALID; | |
258 | } else { | |
259 | submit->bos[i].iova = iova; | |
260 | /* iova changed, so address in cmdstream is not valid: */ | |
261 | submit->bos[i].flags &= ~BO_VALID; | |
262 | submit->valid = false; | |
263 | } | |
264 | } | |
265 | ||
266 | return ret; | |
267 | } | |
268 | ||
7198e6b0 | 269 | static int submit_bo(struct msm_gem_submit *submit, uint32_t idx, |
78babc16 | 270 | struct msm_gem_object **obj, uint64_t *iova, bool *valid) |
7198e6b0 RC |
271 | { |
272 | if (idx >= submit->nr_bos) { | |
19872533 RC |
273 | DRM_ERROR("invalid buffer index: %u (out of %u)\n", |
274 | idx, submit->nr_bos); | |
275 | return -EINVAL; | |
7198e6b0 RC |
276 | } |
277 | ||
278 | if (obj) | |
279 | *obj = submit->bos[idx].obj; | |
280 | if (iova) | |
281 | *iova = submit->bos[idx].iova; | |
282 | if (valid) | |
283 | *valid = !!(submit->bos[idx].flags & BO_VALID); | |
284 | ||
285 | return 0; | |
286 | } | |
287 | ||
288 | /* process the reloc's and patch up the cmdstream as needed: */ | |
289 | static int submit_reloc(struct msm_gem_submit *submit, struct msm_gem_object *obj, | |
290 | uint32_t offset, uint32_t nr_relocs, uint64_t relocs) | |
291 | { | |
292 | uint32_t i, last_offset = 0; | |
293 | uint32_t *ptr; | |
6490abc4 | 294 | int ret = 0; |
7198e6b0 RC |
295 | |
296 | if (offset % 4) { | |
19872533 | 297 | DRM_ERROR("non-aligned cmdstream buffer: %u\n", offset); |
7198e6b0 RC |
298 | return -EINVAL; |
299 | } | |
300 | ||
301 | /* For now, just map the entire thing. Eventually we probably | |
302 | * to do it page-by-page, w/ kmap() if not vmap()d.. | |
303 | */ | |
18f23049 | 304 | ptr = msm_gem_get_vaddr_locked(&obj->base); |
7198e6b0 RC |
305 | |
306 | if (IS_ERR(ptr)) { | |
307 | ret = PTR_ERR(ptr); | |
308 | DBG("failed to map: %d", ret); | |
309 | return ret; | |
310 | } | |
311 | ||
312 | for (i = 0; i < nr_relocs; i++) { | |
313 | struct drm_msm_gem_submit_reloc submit_reloc; | |
314 | void __user *userptr = | |
3ed605bc | 315 | u64_to_user_ptr(relocs + (i * sizeof(submit_reloc))); |
78babc16 RC |
316 | uint32_t off; |
317 | uint64_t iova; | |
7198e6b0 RC |
318 | bool valid; |
319 | ||
21c42da1 DC |
320 | if (copy_from_user(&submit_reloc, userptr, sizeof(submit_reloc))) { |
321 | ret = -EFAULT; | |
6490abc4 | 322 | goto out; |
21c42da1 | 323 | } |
7198e6b0 RC |
324 | |
325 | if (submit_reloc.submit_offset % 4) { | |
19872533 | 326 | DRM_ERROR("non-aligned reloc offset: %u\n", |
7198e6b0 | 327 | submit_reloc.submit_offset); |
6490abc4 JC |
328 | ret = -EINVAL; |
329 | goto out; | |
7198e6b0 RC |
330 | } |
331 | ||
332 | /* offset in dwords: */ | |
333 | off = submit_reloc.submit_offset / 4; | |
334 | ||
335 | if ((off >= (obj->base.size / 4)) || | |
336 | (off < last_offset)) { | |
19872533 | 337 | DRM_ERROR("invalid offset %u at reloc %u\n", off, i); |
6490abc4 JC |
338 | ret = -EINVAL; |
339 | goto out; | |
7198e6b0 RC |
340 | } |
341 | ||
342 | ret = submit_bo(submit, submit_reloc.reloc_idx, NULL, &iova, &valid); | |
343 | if (ret) | |
6490abc4 | 344 | goto out; |
7198e6b0 RC |
345 | |
346 | if (valid) | |
347 | continue; | |
348 | ||
349 | iova += submit_reloc.reloc_offset; | |
350 | ||
351 | if (submit_reloc.shift < 0) | |
352 | iova >>= -submit_reloc.shift; | |
353 | else | |
354 | iova <<= submit_reloc.shift; | |
355 | ||
356 | ptr[off] = iova | submit_reloc.or; | |
357 | ||
358 | last_offset = off; | |
359 | } | |
360 | ||
6490abc4 | 361 | out: |
18f23049 RC |
362 | msm_gem_put_vaddr_locked(&obj->base); |
363 | ||
6490abc4 | 364 | return ret; |
7198e6b0 RC |
365 | } |
366 | ||
40e6815b | 367 | static void submit_cleanup(struct msm_gem_submit *submit) |
7198e6b0 RC |
368 | { |
369 | unsigned i; | |
370 | ||
7198e6b0 RC |
371 | for (i = 0; i < submit->nr_bos; i++) { |
372 | struct msm_gem_object *msm_obj = submit->bos[i].obj; | |
373 | submit_unlock_unpin_bo(submit, i); | |
374 | list_del_init(&msm_obj->submit_entry); | |
375 | drm_gem_object_unreference(&msm_obj->base); | |
376 | } | |
7198e6b0 RC |
377 | |
378 | ww_acquire_fini(&submit->ticket); | |
7198e6b0 RC |
379 | } |
380 | ||
381 | int msm_ioctl_gem_submit(struct drm_device *dev, void *data, | |
382 | struct drm_file *file) | |
383 | { | |
384 | struct msm_drm_private *priv = dev->dev_private; | |
385 | struct drm_msm_gem_submit *args = data; | |
386 | struct msm_file_private *ctx = file->driver_priv; | |
387 | struct msm_gem_submit *submit; | |
c01a958e | 388 | struct msm_gpu *gpu = priv->gpu; |
f54d1867 | 389 | struct dma_fence *in_fence = NULL; |
4cd09459 RC |
390 | struct sync_file *sync_file = NULL; |
391 | int out_fence_fd = -1; | |
7198e6b0 RC |
392 | unsigned i; |
393 | int ret; | |
394 | ||
c01a958e RC |
395 | if (!gpu) |
396 | return -ENXIO; | |
397 | ||
7198e6b0 RC |
398 | /* for now, we just have 3d pipe.. eventually this would need to |
399 | * be more clever to dispatch to appropriate gpu module: | |
400 | */ | |
d9c181e2 RC |
401 | if (MSM_PIPE_ID(args->flags) != MSM_PIPE_3D0) |
402 | return -EINVAL; | |
403 | ||
404 | if (MSM_PIPE_FLAGS(args->flags) & ~MSM_SUBMIT_FLAGS) | |
7198e6b0 RC |
405 | return -EINVAL; |
406 | ||
48f243c9 RC |
407 | if (args->flags & MSM_SUBMIT_FENCE_FD_IN) { |
408 | in_fence = sync_file_get_fence(args->fence_fd); | |
409 | ||
410 | if (!in_fence) | |
411 | return -EINVAL; | |
412 | ||
3cfac69c PZ |
413 | /* |
414 | * Wait if the fence is from a foreign context, or if the fence | |
415 | * array contains any fence from a foreign context. | |
48f243c9 | 416 | */ |
3cfac69c | 417 | if (!dma_fence_match_context(in_fence, gpu->fctx->context)) { |
48f243c9 RC |
418 | ret = dma_fence_wait(in_fence, true); |
419 | if (ret) | |
420 | return ret; | |
421 | } | |
422 | } | |
423 | ||
b5b4c264 RC |
424 | ret = mutex_lock_interruptible(&dev->struct_mutex); |
425 | if (ret) | |
426 | return ret; | |
687f084a | 427 | |
4cd09459 RC |
428 | if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) { |
429 | out_fence_fd = get_unused_fd_flags(O_CLOEXEC); | |
430 | if (out_fence_fd < 0) { | |
431 | ret = out_fence_fd; | |
432 | goto out_unlock; | |
433 | } | |
434 | } | |
d78d383a | 435 | priv->struct_mutex_task = current; |
4cd09459 | 436 | |
6b597ce2 | 437 | submit = submit_create(dev, gpu, args->nr_bos, args->nr_cmds); |
b5b4c264 RC |
438 | if (!submit) { |
439 | ret = -ENOMEM; | |
440 | goto out_unlock; | |
441 | } | |
7198e6b0 RC |
442 | |
443 | ret = submit_lookup_objects(submit, args, file); | |
444 | if (ret) | |
445 | goto out; | |
446 | ||
340faef2 RC |
447 | ret = submit_lock_objects(submit); |
448 | if (ret) | |
449 | goto out; | |
450 | ||
f0a42bb5 RC |
451 | if (!(args->fence & MSM_SUBMIT_NO_IMPLICIT)) { |
452 | ret = submit_fence_sync(submit); | |
453 | if (ret) | |
454 | goto out; | |
455 | } | |
b6295f9a | 456 | |
340faef2 | 457 | ret = submit_pin_objects(submit); |
7198e6b0 RC |
458 | if (ret) |
459 | goto out; | |
460 | ||
461 | for (i = 0; i < args->nr_cmds; i++) { | |
462 | struct drm_msm_gem_submit_cmd submit_cmd; | |
463 | void __user *userptr = | |
3ed605bc | 464 | u64_to_user_ptr(args->cmds + (i * sizeof(submit_cmd))); |
7198e6b0 | 465 | struct msm_gem_object *msm_obj; |
78babc16 | 466 | uint64_t iova; |
7198e6b0 RC |
467 | |
468 | ret = copy_from_user(&submit_cmd, userptr, sizeof(submit_cmd)); | |
469 | if (ret) { | |
470 | ret = -EFAULT; | |
471 | goto out; | |
472 | } | |
473 | ||
93ddb0d3 RC |
474 | /* validate input from userspace: */ |
475 | switch (submit_cmd.type) { | |
476 | case MSM_SUBMIT_CMD_BUF: | |
477 | case MSM_SUBMIT_CMD_IB_TARGET_BUF: | |
478 | case MSM_SUBMIT_CMD_CTX_RESTORE_BUF: | |
479 | break; | |
480 | default: | |
481 | DRM_ERROR("invalid type: %08x\n", submit_cmd.type); | |
482 | ret = -EINVAL; | |
483 | goto out; | |
484 | } | |
485 | ||
7198e6b0 RC |
486 | ret = submit_bo(submit, submit_cmd.submit_idx, |
487 | &msm_obj, &iova, NULL); | |
488 | if (ret) | |
489 | goto out; | |
490 | ||
491 | if (submit_cmd.size % 4) { | |
19872533 | 492 | DRM_ERROR("non-aligned cmdstream buffer size: %u\n", |
7198e6b0 RC |
493 | submit_cmd.size); |
494 | ret = -EINVAL; | |
495 | goto out; | |
496 | } | |
497 | ||
d72fea53 JC |
498 | if (!submit_cmd.size || |
499 | ((submit_cmd.size + submit_cmd.submit_offset) > | |
500 | msm_obj->base.size)) { | |
19872533 | 501 | DRM_ERROR("invalid cmdstream size: %u\n", submit_cmd.size); |
7198e6b0 RC |
502 | ret = -EINVAL; |
503 | goto out; | |
504 | } | |
505 | ||
506 | submit->cmd[i].type = submit_cmd.type; | |
507 | submit->cmd[i].size = submit_cmd.size / 4; | |
508 | submit->cmd[i].iova = iova + submit_cmd.submit_offset; | |
a7d3c950 | 509 | submit->cmd[i].idx = submit_cmd.submit_idx; |
7198e6b0 RC |
510 | |
511 | if (submit->valid) | |
512 | continue; | |
513 | ||
514 | ret = submit_reloc(submit, msm_obj, submit_cmd.submit_offset, | |
515 | submit_cmd.nr_relocs, submit_cmd.relocs); | |
516 | if (ret) | |
517 | goto out; | |
518 | } | |
519 | ||
520 | submit->nr_cmds = i; | |
521 | ||
f44d32c7 RC |
522 | submit->fence = msm_fence_alloc(gpu->fctx); |
523 | if (IS_ERR(submit->fence)) { | |
524 | ret = PTR_ERR(submit->fence); | |
525 | submit->fence = NULL; | |
526 | goto out; | |
527 | } | |
528 | ||
4cd09459 RC |
529 | if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) { |
530 | sync_file = sync_file_create(submit->fence); | |
531 | if (!sync_file) { | |
532 | ret = -ENOMEM; | |
533 | goto out; | |
534 | } | |
535 | } | |
536 | ||
f44d32c7 | 537 | msm_gpu_submit(gpu, submit, ctx); |
7198e6b0 | 538 | |
b6295f9a | 539 | args->fence = submit->fence->seqno; |
7198e6b0 | 540 | |
4cd09459 RC |
541 | if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) { |
542 | fd_install(out_fence_fd, sync_file->file); | |
543 | args->fence_fd = out_fence_fd; | |
544 | } | |
545 | ||
7198e6b0 | 546 | out: |
f0a42bb5 | 547 | if (in_fence) |
f54d1867 | 548 | dma_fence_put(in_fence); |
40e6815b RC |
549 | submit_cleanup(submit); |
550 | if (ret) | |
551 | msm_gem_submit_free(submit); | |
b5b4c264 | 552 | out_unlock: |
4cd09459 RC |
553 | if (ret && (out_fence_fd >= 0)) |
554 | put_unused_fd(out_fence_fd); | |
d78d383a | 555 | priv->struct_mutex_task = NULL; |
c2703b13 | 556 | mutex_unlock(&dev->struct_mutex); |
7198e6b0 RC |
557 | return ret; |
558 | } |