[mirror_ubuntu-bionic-kernel.git] / drivers / gpu / drm / omapdrm / omap_connector.c

/*
 * drivers/gpu/drm/omapdrm/omap_connector.c
 *
 * Copyright (C) 2011 Texas Instruments
 * Author: Rob Clark <rob@ti.com>
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 * more details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program.  If not, see <http://www.gnu.org/licenses/>.
 */

#include <drm/drm_atomic_helper.h>
#include <drm/drm_crtc.h>
#include <drm/drm_crtc_helper.h>

#include "omap_drv.h"

/*
 * connector funcs
 */

#define to_omap_connector(x) container_of(x, struct omap_connector, base)

struct omap_connector {
	struct drm_connector base;
	struct omap_dss_device *dssdev;
	bool hdmi_mode;
};

bool omap_connector_get_hdmi_mode(struct drm_connector *connector)
{
	struct omap_connector *omap_connector = to_omap_connector(connector);

	return omap_connector->hdmi_mode;
}

void copy_timings_omap_to_drm(struct drm_display_mode *mode,
		struct omap_video_timings *timings)
{
	mode->clock = timings->pixelclock / 1000;

	mode->hdisplay = timings->x_res;
	mode->hsync_start = mode->hdisplay + timings->hfp;
	mode->hsync_end = mode->hsync_start + timings->hsw;
	mode->htotal = mode->hsync_end + timings->hbp;

	mode->vdisplay = timings->y_res;
	mode->vsync_start = mode->vdisplay + timings->vfp;
	mode->vsync_end = mode->vsync_start + timings->vsw;
	mode->vtotal = mode->vsync_end + timings->vbp;

	mode->flags = 0;

	if (timings->interlace)
		mode->flags |= DRM_MODE_FLAG_INTERLACE;

	if (timings->double_pixel)
		mode->flags |= DRM_MODE_FLAG_DBLCLK;

	if (timings->hsync_level == OMAPDSS_SIG_ACTIVE_HIGH)
		mode->flags |= DRM_MODE_FLAG_PHSYNC;
	else
		mode->flags |= DRM_MODE_FLAG_NHSYNC;

	if (timings->vsync_level == OMAPDSS_SIG_ACTIVE_HIGH)
		mode->flags |= DRM_MODE_FLAG_PVSYNC;
	else
		mode->flags |= DRM_MODE_FLAG_NVSYNC;
}

void copy_timings_drm_to_omap(struct omap_video_timings *timings,
		struct drm_display_mode *mode)
{
	timings->pixelclock = mode->clock * 1000;

	timings->x_res = mode->hdisplay;
	timings->hfp = mode->hsync_start - mode->hdisplay;
	timings->hsw = mode->hsync_end - mode->hsync_start;
	timings->hbp = mode->htotal - mode->hsync_end;

	timings->y_res = mode->vdisplay;
	timings->vfp = mode->vsync_start - mode->vdisplay;
	timings->vsw = mode->vsync_end - mode->vsync_start;
	timings->vbp = mode->vtotal - mode->vsync_end;

	timings->interlace = !!(mode->flags & DRM_MODE_FLAG_INTERLACE);
	timings->double_pixel = !!(mode->flags & DRM_MODE_FLAG_DBLCLK);

	if (mode->flags & DRM_MODE_FLAG_PHSYNC)
		timings->hsync_level = OMAPDSS_SIG_ACTIVE_HIGH;
	else
		timings->hsync_level = OMAPDSS_SIG_ACTIVE_LOW;

	if (mode->flags & DRM_MODE_FLAG_PVSYNC)
		timings->vsync_level = OMAPDSS_SIG_ACTIVE_HIGH;
	else
		timings->vsync_level = OMAPDSS_SIG_ACTIVE_LOW;

	timings->data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
	timings->de_level = OMAPDSS_SIG_ACTIVE_HIGH;
	timings->sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE;
}

static enum drm_connector_status omap_connector_detect(
		struct drm_connector *connector, bool force)
{
	struct omap_connector *omap_connector = to_omap_connector(connector);
	struct omap_dss_device *dssdev = omap_connector->dssdev;
	struct omap_dss_driver *dssdrv = dssdev->driver;
	enum drm_connector_status ret;

	if (dssdrv->detect) {
		if (dssdrv->detect(dssdev))
			ret = connector_status_connected;
		else
			ret = connector_status_disconnected;
	} else if (dssdev->type == OMAP_DISPLAY_TYPE_DPI ||
			dssdev->type == OMAP_DISPLAY_TYPE_DBI ||
			dssdev->type == OMAP_DISPLAY_TYPE_SDI ||
			dssdev->type == OMAP_DISPLAY_TYPE_DSI) {
		ret = connector_status_connected;
	} else {
		ret = connector_status_unknown;
	}

	VERB("%s: %d (force=%d)", omap_connector->dssdev->name, ret, force);

	return ret;
}

static void omap_connector_destroy(struct drm_connector *connector)
{
	struct omap_connector *omap_connector = to_omap_connector(connector);
	struct omap_dss_device *dssdev = omap_connector->dssdev;

	DBG("%s", omap_connector->dssdev->name);
	drm_connector_unregister(connector);
	drm_connector_cleanup(connector);
	kfree(omap_connector);

	omap_dss_put_device(dssdev);
}

#define MAX_EDID  512

static int omap_connector_get_modes(struct drm_connector *connector)
{
	struct omap_connector *omap_connector = to_omap_connector(connector);
	struct omap_dss_device *dssdev = omap_connector->dssdev;
	struct omap_dss_driver *dssdrv = dssdev->driver;
	struct drm_device *dev = connector->dev;
	int n = 0;

	DBG("%s", omap_connector->dssdev->name);

	/* if display exposes EDID, then we parse that in the normal way to
	 * build table of supported modes.. otherwise (ie. fixed resolution
	 * LCD panels) we just return a single mode corresponding to the
	 * currently configured timings:
	 */
	if (dssdrv->read_edid) {
		void *edid = kzalloc(MAX_EDID, GFP_KERNEL);

		if ((dssdrv->read_edid(dssdev, edid, MAX_EDID) > 0) &&
				drm_edid_is_valid(edid)) {
			drm_mode_connector_update_edid_property(
					connector, edid);
			n = drm_add_edid_modes(connector, edid);

			omap_connector->hdmi_mode =
				drm_detect_hdmi_monitor(edid);
		} else {
			drm_mode_connector_update_edid_property(
					connector, NULL);
		}

		kfree(edid);
	} else {
		struct drm_display_mode *mode = drm_mode_create(dev);
		struct omap_video_timings timings = {0};

		dssdrv->get_timings(dssdev, &timings);

		copy_timings_omap_to_drm(mode, &timings);

		mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
		drm_mode_set_name(mode);
		drm_mode_probed_add(connector, mode);

		n = 1;
	}

	return n;
}

static int omap_connector_mode_valid(struct drm_connector *connector,
				 struct drm_display_mode *mode)
{
	struct omap_connector *omap_connector = to_omap_connector(connector);
	struct omap_dss_device *dssdev = omap_connector->dssdev;
	struct omap_dss_driver *dssdrv = dssdev->driver;
	struct omap_video_timings timings = {0};
	struct drm_device *dev = connector->dev;
	struct drm_display_mode *new_mode;
	int r, ret = MODE_BAD;

	copy_timings_drm_to_omap(&timings, mode);
	mode->vrefresh = drm_mode_vrefresh(mode);

	/*
	 * if the panel driver doesn't have a check_timings, it's most likely
	 * a fixed resolution panel, check if the timings match with the
	 * panel's timings
	 */
	if (dssdrv->check_timings) {
		r = dssdrv->check_timings(dssdev, &timings);
	} else {
		struct omap_video_timings t = {0};

		dssdrv->get_timings(dssdev, &t);

		if (memcmp(&timings, &t, sizeof(struct omap_video_timings)))
			r = -EINVAL;
		else
			r = 0;
	}

	if (!r) {
		/* check if vrefresh is still valid */
		new_mode = drm_mode_duplicate(dev, mode);
		new_mode->clock = timings.pixelclock / 1000;
		new_mode->vrefresh = 0;
		if (mode->vrefresh == drm_mode_vrefresh(new_mode))
			ret = MODE_OK;
		drm_mode_destroy(dev, new_mode);
	}

	DBG("connector: mode %s: "
			"%d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
			(ret == MODE_OK) ? "valid" : "invalid",
			mode->base.id, mode->name, mode->vrefresh, mode->clock,
			mode->hdisplay, mode->hsync_start,
			mode->hsync_end, mode->htotal,
			mode->vdisplay, mode->vsync_start,
			mode->vsync_end, mode->vtotal, mode->type, mode->flags);

	return ret;
}

static const struct drm_connector_funcs omap_connector_funcs = {
	.dpms = drm_atomic_helper_connector_dpms,
	.reset = drm_atomic_helper_connector_reset,
	.detect = omap_connector_detect,
	.fill_modes = drm_helper_probe_single_connector_modes,
	.destroy = omap_connector_destroy,
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
};

static const struct drm_connector_helper_funcs omap_connector_helper_funcs = {
	.get_modes = omap_connector_get_modes,
	.mode_valid = omap_connector_mode_valid,
};

/* initialize connector */
struct drm_connector *omap_connector_init(struct drm_device *dev,
		int connector_type, struct omap_dss_device *dssdev,
		struct drm_encoder *encoder)
{
	struct drm_connector *connector = NULL;
	struct omap_connector *omap_connector;

	DBG("%s", dssdev->name);

	omap_dss_get_device(dssdev);

	omap_connector = kzalloc(sizeof(struct omap_connector), GFP_KERNEL);
	if (!omap_connector)
		goto fail;

	omap_connector->dssdev = dssdev;

	connector = &omap_connector->base;

	drm_connector_init(dev, connector, &omap_connector_funcs,
				connector_type);
	drm_connector_helper_add(connector, &omap_connector_helper_funcs);

#if 0 /* enable when dss2 supports hotplug */
	if (dssdev->caps & OMAP_DSS_DISPLAY_CAP_HPD)
		connector->polled = 0;
	else
#endif
		connector->polled = DRM_CONNECTOR_POLL_CONNECT |
				DRM_CONNECTOR_POLL_DISCONNECT;

	connector->interlace_allowed = 1;
	connector->doublescan_allowed = 0;

	drm_connector_register(connector);

	return connector;

fail:
	if (connector)
		omap_connector_destroy(connector);

	return NULL;
}
Commit	Line	Data
cd5351f4	1	/*
8bb0daff	2	* drivers/gpu/drm/omapdrm/omap_connector.c
cd5351f4 RC	3	*
	4	* Copyright (C) 2011 Texas Instruments
	5	* Author: Rob Clark <rob@ti.com>
	6	*
	7	* This program is free software; you can redistribute it and/or modify it
	8	* under the terms of the GNU General Public License version 2 as published by
	9	* the Free Software Foundation.
	10	*
	11	* This program is distributed in the hope that it will be useful, but WITHOUT
	12	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
	13	* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
	14	* more details.
	15	*
	16	* You should have received a copy of the GNU General Public License along with
	17	* this program. If not, see <http://www.gnu.org/licenses/>.
	18	*/
	19
69a12263	20	#include <drm/drm_atomic_helper.h>
2d278f54 LP	21	#include <drm/drm_crtc.h>
2d278f54 LP	22	#include <drm/drm_crtc_helper.h>
cd5351f4	23
2d278f54	24	#include "omap_drv.h"
cd5351f4 RC	25
	26	/*
	27	* connector funcs
	28	*/
	29
	30	#define to_omap_connector(x) container_of(x, struct omap_connector, base)
	31
	32	struct omap_connector {
	33	struct drm_connector base;
	34	struct omap_dss_device *dssdev;
4f930c0f	35	bool hdmi_mode;
cd5351f4 RC	36	};
cd5351f4 RC	37
4f930c0f TV	38	bool omap_connector_get_hdmi_mode(struct drm_connector *connector)
	39	{
	40	struct omap_connector *omap_connector = to_omap_connector(connector);
	41
	42	return omap_connector->hdmi_mode;
	43	}
	44
f5f9454c	45	void copy_timings_omap_to_drm(struct drm_display_mode *mode,
cd5351f4 RC	46	struct omap_video_timings *timings)
cd5351f4 RC	47	{
d8d78941	48	mode->clock = timings->pixelclock / 1000;
cd5351f4 RC	49
	50	mode->hdisplay = timings->x_res;
	51	mode->hsync_start = mode->hdisplay + timings->hfp;
	52	mode->hsync_end = mode->hsync_start + timings->hsw;
	53	mode->htotal = mode->hsync_end + timings->hbp;
	54
	55	mode->vdisplay = timings->y_res;
	56	mode->vsync_start = mode->vdisplay + timings->vfp;
	57	mode->vsync_end = mode->vsync_start + timings->vsw;
	58	mode->vtotal = mode->vsync_end + timings->vbp;
	59
0b0d7b62 RC	60	mode->flags = 0;
	61
	62	if (timings->interlace)
	63	mode->flags \|= DRM_MODE_FLAG_INTERLACE;
94254edc	64
25358958 TV	65	if (timings->double_pixel)
	66	mode->flags \|= DRM_MODE_FLAG_DBLCLK;
	67
94254edc RC	68	if (timings->hsync_level == OMAPDSS_SIG_ACTIVE_HIGH)
	69	mode->flags \|= DRM_MODE_FLAG_PHSYNC;
	70	else
	71	mode->flags \|= DRM_MODE_FLAG_NHSYNC;
	72
	73	if (timings->vsync_level == OMAPDSS_SIG_ACTIVE_HIGH)
	74	mode->flags \|= DRM_MODE_FLAG_PVSYNC;
	75	else
	76	mode->flags \|= DRM_MODE_FLAG_NVSYNC;
cd5351f4 RC	77	}
cd5351f4 RC	78
f5f9454c	79	void copy_timings_drm_to_omap(struct omap_video_timings *timings,
cd5351f4 RC	80	struct drm_display_mode *mode)
cd5351f4 RC	81	{
d8d78941	82	timings->pixelclock = mode->clock * 1000;
cd5351f4 RC	83
	84	timings->x_res = mode->hdisplay;
	85	timings->hfp = mode->hsync_start - mode->hdisplay;
	86	timings->hsw = mode->hsync_end - mode->hsync_start;
	87	timings->hbp = mode->htotal - mode->hsync_end;
	88
	89	timings->y_res = mode->vdisplay;
	90	timings->vfp = mode->vsync_start - mode->vdisplay;
	91	timings->vsw = mode->vsync_end - mode->vsync_start;
	92	timings->vbp = mode->vtotal - mode->vsync_end;
0b0d7b62 RC	93
0b0d7b62 RC	94	timings->interlace = !!(mode->flags & DRM_MODE_FLAG_INTERLACE);
25358958	95	timings->double_pixel = !!(mode->flags & DRM_MODE_FLAG_DBLCLK);
94254edc RC	96
	97	if (mode->flags & DRM_MODE_FLAG_PHSYNC)
	98	timings->hsync_level = OMAPDSS_SIG_ACTIVE_HIGH;
	99	else
	100	timings->hsync_level = OMAPDSS_SIG_ACTIVE_LOW;
	101
	102	if (mode->flags & DRM_MODE_FLAG_PVSYNC)
	103	timings->vsync_level = OMAPDSS_SIG_ACTIVE_HIGH;
	104	else
	105	timings->vsync_level = OMAPDSS_SIG_ACTIVE_LOW;
	106
	107	timings->data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE;
	108	timings->de_level = OMAPDSS_SIG_ACTIVE_HIGH;
7a16360d	109	timings->sync_pclk_edge = OMAPDSS_DRIVE_SIG_FALLING_EDGE;
cd5351f4 RC	110	}
cd5351f4 RC	111
f5f9454c	112	static enum drm_connector_status omap_connector_detect(
cd5351f4 RC	113	struct drm_connector *connector, bool force)
	114	{
	115	struct omap_connector *omap_connector = to_omap_connector(connector);
	116	struct omap_dss_device *dssdev = omap_connector->dssdev;
	117	struct omap_dss_driver *dssdrv = dssdev->driver;
	118	enum drm_connector_status ret;
	119
	120	if (dssdrv->detect) {
fdbf20b3	121	if (dssdrv->detect(dssdev))
cd5351f4	122	ret = connector_status_connected;
fdbf20b3	123	else
cd5351f4	124	ret = connector_status_disconnected;
bddabbe1 AT	125	} else if (dssdev->type == OMAP_DISPLAY_TYPE_DPI \|\|
	126	dssdev->type == OMAP_DISPLAY_TYPE_DBI \|\|
	127	dssdev->type == OMAP_DISPLAY_TYPE_SDI \|\|
	128	dssdev->type == OMAP_DISPLAY_TYPE_DSI) {
	129	ret = connector_status_connected;
cd5351f4 RC	130	} else {
	131	ret = connector_status_unknown;
	132	}
	133
	134	VERB("%s: %d (force=%d)", omap_connector->dssdev->name, ret, force);
	135
	136	return ret;
	137	}
	138
	139	static void omap_connector_destroy(struct drm_connector *connector)
	140	{
	141	struct omap_connector *omap_connector = to_omap_connector(connector);
	142	struct omap_dss_device *dssdev = omap_connector->dssdev;
	143
cd5351f4	144	DBG("%s", omap_connector->dssdev->name);
34ea3d38	145	drm_connector_unregister(connector);
cd5351f4 RC	146	drm_connector_cleanup(connector);
	147	kfree(omap_connector);
	148
	149	omap_dss_put_device(dssdev);
	150	}
	151
	152	#define MAX_EDID 512
	153
	154	static int omap_connector_get_modes(struct drm_connector *connector)
	155	{
	156	struct omap_connector *omap_connector = to_omap_connector(connector);
	157	struct omap_dss_device *dssdev = omap_connector->dssdev;
	158	struct omap_dss_driver *dssdrv = dssdev->driver;
	159	struct drm_device *dev = connector->dev;
	160	int n = 0;
	161
	162	DBG("%s", omap_connector->dssdev->name);
	163
	164	/* if display exposes EDID, then we parse that in the normal way to
	165	* build table of supported modes.. otherwise (ie. fixed resolution
	166	* LCD panels) we just return a single mode corresponding to the
	167	* currently configured timings:
	168	*/
	169	if (dssdrv->read_edid) {
	170	void *edid = kzalloc(MAX_EDID, GFP_KERNEL);
	171
	172	if ((dssdrv->read_edid(dssdev, edid, MAX_EDID) > 0) &&
	173	drm_edid_is_valid(edid)) {
	174	drm_mode_connector_update_edid_property(
	175	connector, edid);
	176	n = drm_add_edid_modes(connector, edid);
4f930c0f TV	177
	178	omap_connector->hdmi_mode =
	179	drm_detect_hdmi_monitor(edid);
cd5351f4 RC	180	} else {
	181	drm_mode_connector_update_edid_property(
	182	connector, NULL);
cd5351f4	183	}
4f930c0f	184
451023dc	185	kfree(edid);
cd5351f4 RC	186	} else {
cd5351f4 RC	187	struct drm_display_mode *mode = drm_mode_create(dev);
0b0d7b62	188	struct omap_video_timings timings = {0};
cd5351f4 RC	189
	190	dssdrv->get_timings(dssdev, &timings);
	191
	192	copy_timings_omap_to_drm(mode, &timings);
	193
	194	mode->type = DRM_MODE_TYPE_DRIVER \| DRM_MODE_TYPE_PREFERRED;
	195	drm_mode_set_name(mode);
	196	drm_mode_probed_add(connector, mode);
	197
	198	n = 1;
	199	}
	200
	201	return n;
	202	}
	203
	204	static int omap_connector_mode_valid(struct drm_connector *connector,
	205	struct drm_display_mode *mode)
	206	{
	207	struct omap_connector *omap_connector = to_omap_connector(connector);
	208	struct omap_dss_device *dssdev = omap_connector->dssdev;
	209	struct omap_dss_driver *dssdrv = dssdev->driver;
	210	struct omap_video_timings timings = {0};
	211	struct drm_device *dev = connector->dev;
	212	struct drm_display_mode *new_mode;
bddabbe1	213	int r, ret = MODE_BAD;
cd5351f4 RC	214
	215	copy_timings_drm_to_omap(&timings, mode);
	216	mode->vrefresh = drm_mode_vrefresh(mode);
	217
bddabbe1 AT	218	/*
	219	* if the panel driver doesn't have a check_timings, it's most likely
	220	* a fixed resolution panel, check if the timings match with the
	221	* panel's timings
	222	*/
	223	if (dssdrv->check_timings) {
	224	r = dssdrv->check_timings(dssdev, &timings);
	225	} else {
	226	struct omap_video_timings t = {0};
	227
	228	dssdrv->get_timings(dssdev, &t);
	229
	230	if (memcmp(&timings, &t, sizeof(struct omap_video_timings)))
	231	r = -EINVAL;
	232	else
	233	r = 0;
	234	}
	235
	236	if (!r) {
cd5351f4 RC	237	/* check if vrefresh is still valid */
cd5351f4 RC	238	new_mode = drm_mode_duplicate(dev, mode);
d8d78941	239	new_mode->clock = timings.pixelclock / 1000;
cd5351f4 RC	240	new_mode->vrefresh = 0;
	241	if (mode->vrefresh == drm_mode_vrefresh(new_mode))
	242	ret = MODE_OK;
	243	drm_mode_destroy(dev, new_mode);
	244	}
	245
	246	DBG("connector: mode %s: "
	247	"%d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
	248	(ret == MODE_OK) ? "valid" : "invalid",
	249	mode->base.id, mode->name, mode->vrefresh, mode->clock,
	250	mode->hdisplay, mode->hsync_start,
	251	mode->hsync_end, mode->htotal,
	252	mode->vdisplay, mode->vsync_start,
	253	mode->vsync_end, mode->vtotal, mode->type, mode->flags);
	254
	255	return ret;
	256	}
	257
cd5351f4	258	static const struct drm_connector_funcs omap_connector_funcs = {
aea3cab1	259	.dpms = drm_atomic_helper_connector_dpms,
69a12263	260	.reset = drm_atomic_helper_connector_reset,
cd5351f4 RC	261	.detect = omap_connector_detect,
	262	.fill_modes = drm_helper_probe_single_connector_modes,
	263	.destroy = omap_connector_destroy,
69a12263 LP	264	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
69a12263 LP	265	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
cd5351f4 RC	266	};
	267
	268	static const struct drm_connector_helper_funcs omap_connector_helper_funcs = {
	269	.get_modes = omap_connector_get_modes,
	270	.mode_valid = omap_connector_mode_valid,
cd5351f4 RC	271	};
cd5351f4 RC	272
cd5351f4 RC	273	/* initialize connector */
cd5351f4 RC	274	struct drm_connector omap_connector_init(struct drm_device dev,
f5f9454c RC	275	int connector_type, struct omap_dss_device *dssdev,
f5f9454c RC	276	struct drm_encoder *encoder)
cd5351f4 RC	277	{
	278	struct drm_connector *connector = NULL;
	279	struct omap_connector *omap_connector;
	280
	281	DBG("%s", dssdev->name);
	282
	283	omap_dss_get_device(dssdev);
	284
	285	omap_connector = kzalloc(sizeof(struct omap_connector), GFP_KERNEL);
78110bb8	286	if (!omap_connector)
cd5351f4	287	goto fail;
cd5351f4 RC	288
cd5351f4 RC	289	omap_connector->dssdev = dssdev;
f5f9454c	290
cd5351f4 RC	291	connector = &omap_connector->base;
	292
	293	drm_connector_init(dev, connector, &omap_connector_funcs,
	294	connector_type);
	295	drm_connector_helper_add(connector, &omap_connector_helper_funcs);
	296
	297	#if 0 /* enable when dss2 supports hotplug */
	298	if (dssdev->caps & OMAP_DSS_DISPLAY_CAP_HPD)
	299	connector->polled = 0;
	300	else
	301	#endif
	302	connector->polled = DRM_CONNECTOR_POLL_CONNECT \|
	303	DRM_CONNECTOR_POLL_DISCONNECT;
	304
	305	connector->interlace_allowed = 1;
	306	connector->doublescan_allowed = 0;
	307
34ea3d38	308	drm_connector_register(connector);
cd5351f4 RC	309
	310	return connector;
	311
	312	fail:
fdbf20b3	313	if (connector)
cd5351f4	314	omap_connector_destroy(connector);
cd5351f4 RC	315
	316	return NULL;
	317	}