[mirror_ubuntu-zesty-kernel.git] / drivers / hwmon / ds1621.c

/*
    ds1621.c - Part of lm_sensors, Linux kernel modules for hardware
             monitoring
    Christian W. Zuckschwerdt  <zany@triq.net>  2000-11-23
    based on lm75.c by Frodo Looijaard <frodol@dds.nl>
    Ported to Linux 2.6 by Aurelien Jarno <aurelien@aurel32.net> with 
    the help of Jean Delvare <khali@linux-fr.org>

    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 2 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software
    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/

#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/jiffies.h>
#include <linux/i2c.h>
#include <linux/hwmon.h>
#include <linux/err.h>
#include "lm75.h"

/* Addresses to scan */
static unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b, 0x4c,
					0x4d, 0x4e, 0x4f, I2C_CLIENT_END };

/* Insmod parameters */
I2C_CLIENT_INSMOD_1(ds1621);
static int polarity = -1;
module_param(polarity, int, 0);
MODULE_PARM_DESC(polarity, "Output's polarity: 0 = active high, 1 = active low");

/* Many DS1621 constants specified below */
/* Config register used for detection         */
/*  7    6    5    4    3    2    1    0      */
/* |Done|THF |TLF |NVB | X  | X  |POL |1SHOT| */
#define DS1621_REG_CONFIG_NVB		0x10
#define DS1621_REG_CONFIG_POLARITY	0x02
#define DS1621_REG_CONFIG_1SHOT		0x01
#define DS1621_REG_CONFIG_DONE		0x80

/* The DS1621 registers */
#define DS1621_REG_TEMP			0xAA /* word, RO */
#define DS1621_REG_TEMP_MIN		0xA1 /* word, RW */
#define DS1621_REG_TEMP_MAX		0xA2 /* word, RW */
#define DS1621_REG_CONF			0xAC /* byte, RW */
#define DS1621_COM_START		0xEE /* no data */
#define DS1621_COM_STOP			0x22 /* no data */

/* The DS1621 configuration register */
#define DS1621_ALARM_TEMP_HIGH		0x40
#define DS1621_ALARM_TEMP_LOW		0x20

/* Conversions. Rounding and limit checking is only done on the TO_REG
   variants. Note that you should be a bit careful with which arguments
   these macros are called: arguments may be evaluated more than once.
   Fixing this is just not worth it. */
#define ALARMS_FROM_REG(val) ((val) & \
                              (DS1621_ALARM_TEMP_HIGH | DS1621_ALARM_TEMP_LOW))

/* Each client has this additional data */
struct ds1621_data {
	struct i2c_client client;
	struct class_device *class_dev;
	struct semaphore update_lock;
	char valid;			/* !=0 if following fields are valid */
	unsigned long last_updated;	/* In jiffies */

	u16 temp, temp_min, temp_max;	/* Register values, word */
	u8 conf;			/* Register encoding, combined */
};

static int ds1621_attach_adapter(struct i2c_adapter *adapter);
static int ds1621_detect(struct i2c_adapter *adapter, int address,
			 int kind);
static void ds1621_init_client(struct i2c_client *client);
static int ds1621_detach_client(struct i2c_client *client);
static struct ds1621_data *ds1621_update_client(struct device *dev);

/* This is the driver that will be inserted */
static struct i2c_driver ds1621_driver = {
	.owner		= THIS_MODULE,
	.name		= "ds1621",
	.id		= I2C_DRIVERID_DS1621,
	.flags		= I2C_DF_NOTIFY,
	.attach_adapter	= ds1621_attach_adapter,
	.detach_client	= ds1621_detach_client,
};

/* All registers are word-sized, except for the configuration register.
   DS1621 uses a high-byte first convention, which is exactly opposite to
   the usual practice. */
static int ds1621_read_value(struct i2c_client *client, u8 reg)
{
	if (reg == DS1621_REG_CONF)
		return i2c_smbus_read_byte_data(client, reg);
	else
		return swab16(i2c_smbus_read_word_data(client, reg));
}

/* All registers are word-sized, except for the configuration register.
   DS1621 uses a high-byte first convention, which is exactly opposite to
   the usual practice. */
static int ds1621_write_value(struct i2c_client *client, u8 reg, u16 value)
{
	if (reg == DS1621_REG_CONF)
		return i2c_smbus_write_byte_data(client, reg, value);
	else
		return i2c_smbus_write_word_data(client, reg, swab16(value));
}

static void ds1621_init_client(struct i2c_client *client)
{
	int reg = ds1621_read_value(client, DS1621_REG_CONF);
	/* switch to continuous conversion mode */
	reg &= ~ DS1621_REG_CONFIG_1SHOT;

	/* setup output polarity */
	if (polarity == 0)
		reg &= ~DS1621_REG_CONFIG_POLARITY;
	else if (polarity == 1)
		reg |= DS1621_REG_CONFIG_POLARITY;
	
	ds1621_write_value(client, DS1621_REG_CONF, reg);
	
	/* start conversion */
	i2c_smbus_write_byte(client, DS1621_COM_START);
}

#define show(value)							\
static ssize_t show_##value(struct device *dev, struct device_attribute *attr, char *buf)		\
{									\
	struct ds1621_data *data = ds1621_update_client(dev);		\
	return sprintf(buf, "%d\n", LM75_TEMP_FROM_REG(data->value));	\
}

show(temp);
show(temp_min);
show(temp_max);

#define set_temp(suffix, value, reg)					\
static ssize_t set_temp_##suffix(struct device *dev, struct device_attribute *attr, const char *buf,	\
				 size_t count)				\
{									\
	struct i2c_client *client = to_i2c_client(dev);			\
	struct ds1621_data *data = ds1621_update_client(dev);		\
	u16 val = LM75_TEMP_TO_REG(simple_strtoul(buf, NULL, 10));	\
									\
	down(&data->update_lock);					\
	data->value = val;						\
	ds1621_write_value(client, reg, data->value);			\
	up(&data->update_lock);						\
	return count;							\
}

set_temp(min, temp_min, DS1621_REG_TEMP_MIN);
set_temp(max, temp_max, DS1621_REG_TEMP_MAX);

static ssize_t show_alarms(struct device *dev, struct device_attribute *attr, char *buf)
{
	struct ds1621_data *data = ds1621_update_client(dev);
	return sprintf(buf, "%d\n", ALARMS_FROM_REG(data->conf));
}

static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
static DEVICE_ATTR(temp1_input, S_IRUGO , show_temp, NULL);
static DEVICE_ATTR(temp1_min, S_IWUSR | S_IRUGO , show_temp_min, set_temp_min);
static DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_temp_max, set_temp_max);


static int ds1621_attach_adapter(struct i2c_adapter *adapter)
{
	return i2c_probe(adapter, &addr_data, ds1621_detect);
}

/* This function is called by i2c_probe */
int ds1621_detect(struct i2c_adapter *adapter, int address,
                  int kind)
{
	int conf, temp;
	struct i2c_client *new_client;
	struct ds1621_data *data;
	int err = 0;

	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA 
				     | I2C_FUNC_SMBUS_WORD_DATA 
				     | I2C_FUNC_SMBUS_WRITE_BYTE))
		goto exit;

	/* OK. For now, we presume we have a valid client. We now create the
	   client structure, even though we cannot fill it completely yet.
	   But it allows us to access ds1621_{read,write}_value. */
	if (!(data = kmalloc(sizeof(struct ds1621_data), GFP_KERNEL))) {
		err = -ENOMEM;
		goto exit;
	}
	memset(data, 0, sizeof(struct ds1621_data));
	
	new_client = &data->client;
	i2c_set_clientdata(new_client, data);
	new_client->addr = address;
	new_client->adapter = adapter;
	new_client->driver = &ds1621_driver;
	new_client->flags = 0;


	/* Now, we do the remaining detection. It is lousy. */
	if (kind < 0) {
		/* The NVB bit should be low if no EEPROM write has been 
		   requested during the latest 10ms, which is highly 
		   improbable in our case. */
		conf = ds1621_read_value(new_client, DS1621_REG_CONF);
		if (conf & DS1621_REG_CONFIG_NVB)
			goto exit_free;
		/* The 7 lowest bits of a temperature should always be 0. */
		temp = ds1621_read_value(new_client, DS1621_REG_TEMP);
		if (temp & 0x007f)
			goto exit_free;
		temp = ds1621_read_value(new_client, DS1621_REG_TEMP_MIN);
		if (temp & 0x007f)
			goto exit_free;
		temp = ds1621_read_value(new_client, DS1621_REG_TEMP_MAX);
		if (temp & 0x007f)
			goto exit_free;
	}

	/* Determine the chip type - only one kind supported! */
	if (kind <= 0)
		kind = ds1621;

	/* Fill in remaining client fields and put it into the global list */
	strlcpy(new_client->name, "ds1621", I2C_NAME_SIZE);
	data->valid = 0;
	init_MUTEX(&data->update_lock);

	/* Tell the I2C layer a new client has arrived */
	if ((err = i2c_attach_client(new_client)))
		goto exit_free;

	/* Initialize the DS1621 chip */
	ds1621_init_client(new_client);

	/* Register sysfs hooks */
	data->class_dev = hwmon_device_register(&new_client->dev);
	if (IS_ERR(data->class_dev)) {
		err = PTR_ERR(data->class_dev);
		goto exit_detach;
	}

	device_create_file(&new_client->dev, &dev_attr_alarms);
	device_create_file(&new_client->dev, &dev_attr_temp1_input);
	device_create_file(&new_client->dev, &dev_attr_temp1_min);
	device_create_file(&new_client->dev, &dev_attr_temp1_max);
	
	return 0;

/* OK, this is not exactly good programming practice, usually. But it is
   very code-efficient in this case. */
      exit_detach:
	i2c_detach_client(new_client);
      exit_free:
	kfree(data);
      exit:
	return err;
}

static int ds1621_detach_client(struct i2c_client *client)
{
	struct ds1621_data *data = i2c_get_clientdata(client);
	int err;

	hwmon_device_unregister(data->class_dev);

	if ((err = i2c_detach_client(client)))
		return err;

	kfree(data);

	return 0;
}


static struct ds1621_data *ds1621_update_client(struct device *dev)
{
	struct i2c_client *client = to_i2c_client(dev);
	struct ds1621_data *data = i2c_get_clientdata(client);
	u8 new_conf;

	down(&data->update_lock);

	if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
	    || !data->valid) {

		dev_dbg(&client->dev, "Starting ds1621 update\n");

		data->conf = ds1621_read_value(client, DS1621_REG_CONF);

		data->temp = ds1621_read_value(client, DS1621_REG_TEMP);
		
		data->temp_min = ds1621_read_value(client,
		                                    DS1621_REG_TEMP_MIN);
		data->temp_max = ds1621_read_value(client,
						    DS1621_REG_TEMP_MAX);

		/* reset alarms if necessary */
		new_conf = data->conf;
		if (data->temp < data->temp_min)
			new_conf &= ~DS1621_ALARM_TEMP_LOW;
		if (data->temp > data->temp_max)
			new_conf &= ~DS1621_ALARM_TEMP_HIGH;
		if (data->conf != new_conf)
			ds1621_write_value(client, DS1621_REG_CONF,
					   new_conf);

		data->last_updated = jiffies;
		data->valid = 1;
	}

	up(&data->update_lock);

	return data;
}

static int __init ds1621_init(void)
{
	return i2c_add_driver(&ds1621_driver);
}

static void __exit ds1621_exit(void)
{
	i2c_del_driver(&ds1621_driver);
}


MODULE_AUTHOR("Christian W. Zuckschwerdt <zany@triq.net>");
MODULE_DESCRIPTION("DS1621 driver");
MODULE_LICENSE("GPL");

module_init(ds1621_init);
module_exit(ds1621_exit);
Commit	Line	Data
1da177e4 LT	1	/*
	2	ds1621.c - Part of lm_sensors, Linux kernel modules for hardware
	3	monitoring
	4	Christian W. Zuckschwerdt <zany@triq.net> 2000-11-23
	5	based on lm75.c by Frodo Looijaard <frodol@dds.nl>
	6	Ported to Linux 2.6 by Aurelien Jarno <aurelien@aurel32.net> with
	7	the help of Jean Delvare <khali@linux-fr.org>
	8
	9	This program is free software; you can redistribute it and/or modify
	10	it under the terms of the GNU General Public License as published by
	11	the Free Software Foundation; either version 2 of the License, or
	12	(at your option) any later version.
	13
	14	This program is distributed in the hope that it will be useful,
	15	but WITHOUT ANY WARRANTY; without even the implied warranty of
	16	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	17	GNU General Public License for more details.
	18
	19	You should have received a copy of the GNU General Public License
	20	along with this program; if not, write to the Free Software
	21	Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
	22	*/
	23
	24	#include <linux/module.h>
	25	#include <linux/init.h>
	26	#include <linux/slab.h>
	27	#include <linux/jiffies.h>
	28	#include <linux/i2c.h>
943b0830 MH	29	#include <linux/hwmon.h>
943b0830 MH	30	#include <linux/err.h>
1da177e4 LT	31	#include "lm75.h"
	32
	33	/* Addresses to scan */
	34	static unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b, 0x4c,
	35	0x4d, 0x4e, 0x4f, I2C_CLIENT_END };
1da177e4 LT	36
1da177e4 LT	37	/* Insmod parameters */
f4b50261	38	I2C_CLIENT_INSMOD_1(ds1621);
1da177e4 LT	39	static int polarity = -1;
	40	module_param(polarity, int, 0);
	41	MODULE_PARM_DESC(polarity, "Output's polarity: 0 = active high, 1 = active low");
	42
	43	/* Many DS1621 constants specified below */
	44	/* Config register used for detection */
	45	/* 7 6 5 4 3 2 1 0 */
	46	/* \|Done\|THF \|TLF \|NVB \| X \| X \|POL \|1SHOT\| */
	47	#define DS1621_REG_CONFIG_NVB 0x10
	48	#define DS1621_REG_CONFIG_POLARITY 0x02
	49	#define DS1621_REG_CONFIG_1SHOT 0x01
	50	#define DS1621_REG_CONFIG_DONE 0x80
	51
	52	/* The DS1621 registers */
	53	#define DS1621_REG_TEMP 0xAA /* word, RO */
	54	#define DS1621_REG_TEMP_MIN 0xA1 /* word, RW */
	55	#define DS1621_REG_TEMP_MAX 0xA2 /* word, RW */
	56	#define DS1621_REG_CONF 0xAC /* byte, RW */
	57	#define DS1621_COM_START 0xEE /* no data */
	58	#define DS1621_COM_STOP 0x22 /* no data */
	59
	60	/* The DS1621 configuration register */
	61	#define DS1621_ALARM_TEMP_HIGH 0x40
	62	#define DS1621_ALARM_TEMP_LOW 0x20
	63
	64	/* Conversions. Rounding and limit checking is only done on the TO_REG
	65	variants. Note that you should be a bit careful with which arguments
	66	these macros are called: arguments may be evaluated more than once.
	67	Fixing this is just not worth it. */
	68	#define ALARMS_FROM_REG(val) ((val) & \
	69	(DS1621_ALARM_TEMP_HIGH \| DS1621_ALARM_TEMP_LOW))
	70
	71	/* Each client has this additional data */
	72	struct ds1621_data {
	73	struct i2c_client client;
943b0830	74	struct class_device *class_dev;
1da177e4 LT	75	struct semaphore update_lock;
	76	char valid; /* !=0 if following fields are valid */
	77	unsigned long last_updated; /* In jiffies */
	78
	79	u16 temp, temp_min, temp_max; /* Register values, word */
	80	u8 conf; /* Register encoding, combined */
	81	};
	82
	83	static int ds1621_attach_adapter(struct i2c_adapter *adapter);
	84	static int ds1621_detect(struct i2c_adapter *adapter, int address,
	85	int kind);
	86	static void ds1621_init_client(struct i2c_client *client);
	87	static int ds1621_detach_client(struct i2c_client *client);
	88	static struct ds1621_data ds1621_update_client(struct device dev);
	89
	90	/* This is the driver that will be inserted */
	91	static struct i2c_driver ds1621_driver = {
	92	.owner = THIS_MODULE,
	93	.name = "ds1621",
	94	.id = I2C_DRIVERID_DS1621,
	95	.flags = I2C_DF_NOTIFY,
	96	.attach_adapter = ds1621_attach_adapter,
	97	.detach_client = ds1621_detach_client,
	98	};
	99
	100	/* All registers are word-sized, except for the configuration register.
	101	DS1621 uses a high-byte first convention, which is exactly opposite to
	102	the usual practice. */
	103	static int ds1621_read_value(struct i2c_client *client, u8 reg)
	104	{
	105	if (reg == DS1621_REG_CONF)
	106	return i2c_smbus_read_byte_data(client, reg);
	107	else
	108	return swab16(i2c_smbus_read_word_data(client, reg));
	109	}
	110
	111	/* All registers are word-sized, except for the configuration register.
	112	DS1621 uses a high-byte first convention, which is exactly opposite to
	113	the usual practice. */
	114	static int ds1621_write_value(struct i2c_client *client, u8 reg, u16 value)
	115	{
	116	if (reg == DS1621_REG_CONF)
	117	return i2c_smbus_write_byte_data(client, reg, value);
	118	else
	119	return i2c_smbus_write_word_data(client, reg, swab16(value));
	120	}
	121
	122	static void ds1621_init_client(struct i2c_client *client)
	123	{
	124	int reg = ds1621_read_value(client, DS1621_REG_CONF);
44bbe87e	125	/* switch to continuous conversion mode */
1da177e4 LT	126	reg &= ~ DS1621_REG_CONFIG_1SHOT;
	127
	128	/* setup output polarity */
	129	if (polarity == 0)
	130	reg &= ~DS1621_REG_CONFIG_POLARITY;
	131	else if (polarity == 1)
	132	reg \|= DS1621_REG_CONFIG_POLARITY;
	133
	134	ds1621_write_value(client, DS1621_REG_CONF, reg);
	135
	136	/* start conversion */
	137	i2c_smbus_write_byte(client, DS1621_COM_START);
	138	}
	139
	140	#define show(value) \
30f74292	141	static ssize_t show_##value(struct device dev, struct device_attribute attr, char *buf) \
1da177e4 LT	142	{ \
	143	struct ds1621_data *data = ds1621_update_client(dev); \
	144	return sprintf(buf, "%d\n", LM75_TEMP_FROM_REG(data->value)); \
	145	}
	146
	147	show(temp);
	148	show(temp_min);
	149	show(temp_max);
	150
	151	#define set_temp(suffix, value, reg) \
30f74292	152	static ssize_t set_temp_##suffix(struct device dev, struct device_attribute attr, const char *buf, \
1da177e4 LT	153	size_t count) \
	154	{ \
	155	struct i2c_client *client = to_i2c_client(dev); \
	156	struct ds1621_data *data = ds1621_update_client(dev); \
	157	u16 val = LM75_TEMP_TO_REG(simple_strtoul(buf, NULL, 10)); \
	158	\
	159	down(&data->update_lock); \
	160	data->value = val; \
	161	ds1621_write_value(client, reg, data->value); \
	162	up(&data->update_lock); \
	163	return count; \
	164	}
	165
	166	set_temp(min, temp_min, DS1621_REG_TEMP_MIN);
	167	set_temp(max, temp_max, DS1621_REG_TEMP_MAX);
	168
30f74292	169	static ssize_t show_alarms(struct device dev, struct device_attribute attr, char *buf)
1da177e4 LT	170	{
	171	struct ds1621_data *data = ds1621_update_client(dev);
	172	return sprintf(buf, "%d\n", ALARMS_FROM_REG(data->conf));
	173	}
	174
	175	static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
	176	static DEVICE_ATTR(temp1_input, S_IRUGO , show_temp, NULL);
	177	static DEVICE_ATTR(temp1_min, S_IWUSR \| S_IRUGO , show_temp_min, set_temp_min);
	178	static DEVICE_ATTR(temp1_max, S_IWUSR \| S_IRUGO, show_temp_max, set_temp_max);
	179
	180
	181	static int ds1621_attach_adapter(struct i2c_adapter *adapter)
	182	{
2ed2dc3c	183	return i2c_probe(adapter, &addr_data, ds1621_detect);
1da177e4 LT	184	}
1da177e4 LT	185
2ed2dc3c	186	/* This function is called by i2c_probe */
1da177e4 LT	187	int ds1621_detect(struct i2c_adapter *adapter, int address,
	188	int kind)
	189	{
	190	int conf, temp;
	191	struct i2c_client *new_client;
	192	struct ds1621_data *data;
	193	int err = 0;
	194
	195	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA
	196	\| I2C_FUNC_SMBUS_WORD_DATA
	197	\| I2C_FUNC_SMBUS_WRITE_BYTE))
	198	goto exit;
	199
	200	/* OK. For now, we presume we have a valid client. We now create the
	201	client structure, even though we cannot fill it completely yet.
	202	But it allows us to access ds1621_{read,write}_value. */
	203	if (!(data = kmalloc(sizeof(struct ds1621_data), GFP_KERNEL))) {
	204	err = -ENOMEM;
	205	goto exit;
	206	}
	207	memset(data, 0, sizeof(struct ds1621_data));
	208
	209	new_client = &data->client;
	210	i2c_set_clientdata(new_client, data);
	211	new_client->addr = address;
	212	new_client->adapter = adapter;
	213	new_client->driver = &ds1621_driver;
	214	new_client->flags = 0;
	215
	216
	217	/* Now, we do the remaining detection. It is lousy. */
	218	if (kind < 0) {
	219	/* The NVB bit should be low if no EEPROM write has been
	220	requested during the latest 10ms, which is highly
	221	improbable in our case. */
	222	conf = ds1621_read_value(new_client, DS1621_REG_CONF);
	223	if (conf & DS1621_REG_CONFIG_NVB)
	224	goto exit_free;
	225	/* The 7 lowest bits of a temperature should always be 0. */
	226	temp = ds1621_read_value(new_client, DS1621_REG_TEMP);
	227	if (temp & 0x007f)
	228	goto exit_free;
	229	temp = ds1621_read_value(new_client, DS1621_REG_TEMP_MIN);
	230	if (temp & 0x007f)
	231	goto exit_free;
	232	temp = ds1621_read_value(new_client, DS1621_REG_TEMP_MAX);
	233	if (temp & 0x007f)
	234	goto exit_free;
	235	}
	236
	237	/* Determine the chip type - only one kind supported! */
	238	if (kind <= 0)
	239	kind = ds1621;
	240
	241	/* Fill in remaining client fields and put it into the global list */
	242	strlcpy(new_client->name, "ds1621", I2C_NAME_SIZE);
	243	data->valid = 0;
	244	init_MUTEX(&data->update_lock);
	245
	246	/* Tell the I2C layer a new client has arrived */
	247	if ((err = i2c_attach_client(new_client)))
	248	goto exit_free;
	249
	250	/* Initialize the DS1621 chip */
251	ds1621_init_client(new_client);
252
253	/* Register sysfs hooks */
943b0830 MH	254	data->class_dev = hwmon_device_register(&new_client->dev);
	255	if (IS_ERR(data->class_dev)) {
	256	err = PTR_ERR(data->class_dev);
	257	goto exit_detach;
	258	}
	259
1da177e4 LT	260	device_create_file(&new_client->dev, &dev_attr_alarms);
	261	device_create_file(&new_client->dev, &dev_attr_temp1_input);
	262	device_create_file(&new_client->dev, &dev_attr_temp1_min);
	263	device_create_file(&new_client->dev, &dev_attr_temp1_max);
	264
	265	return 0;
	266
	267	/* OK, this is not exactly good programming practice, usually. But it is
	268	very code-efficient in this case. */
943b0830 MH	269	exit_detach:
943b0830 MH	270	i2c_detach_client(new_client);
1da177e4 LT	271	exit_free:
	272	kfree(data);
	273	exit:
	274	return err;
	275	}
	276
	277	static int ds1621_detach_client(struct i2c_client *client)
	278	{
943b0830	279	struct ds1621_data *data = i2c_get_clientdata(client);
1da177e4 LT	280	int err;
1da177e4 LT	281
943b0830 MH	282	hwmon_device_unregister(data->class_dev);
943b0830 MH	283
7bef5594	284	if ((err = i2c_detach_client(client)))
1da177e4	285	return err;
1da177e4	286
943b0830	287	kfree(data);
1da177e4 LT	288
	289	return 0;
	290	}
	291
	292
	293	static struct ds1621_data ds1621_update_client(struct device dev)
	294	{
	295	struct i2c_client *client = to_i2c_client(dev);
	296	struct ds1621_data *data = i2c_get_clientdata(client);
	297	u8 new_conf;
	298
	299	down(&data->update_lock);
	300
	301	if (time_after(jiffies, data->last_updated + HZ + HZ / 2)
	302	\|\| !data->valid) {
	303
	304	dev_dbg(&client->dev, "Starting ds1621 update\n");
	305
	306	data->conf = ds1621_read_value(client, DS1621_REG_CONF);
	307
	308	data->temp = ds1621_read_value(client, DS1621_REG_TEMP);
	309
	310	data->temp_min = ds1621_read_value(client,
	311	DS1621_REG_TEMP_MIN);
	312	data->temp_max = ds1621_read_value(client,
	313	DS1621_REG_TEMP_MAX);
	314
44bbe87e	315	/* reset alarms if necessary */
1da177e4 LT	316	new_conf = data->conf;
	317	if (data->temp < data->temp_min)
	318	new_conf &= ~DS1621_ALARM_TEMP_LOW;
	319	if (data->temp > data->temp_max)
	320	new_conf &= ~DS1621_ALARM_TEMP_HIGH;
	321	if (data->conf != new_conf)
	322	ds1621_write_value(client, DS1621_REG_CONF,
	323	new_conf);
	324
	325	data->last_updated = jiffies;
	326	data->valid = 1;
	327	}
	328
	329	up(&data->update_lock);
	330
	331	return data;
	332	}
	333
	334	static int __init ds1621_init(void)
	335	{
	336	return i2c_add_driver(&ds1621_driver);
	337	}
	338
	339	static void __exit ds1621_exit(void)
	340	{
	341	i2c_del_driver(&ds1621_driver);
	342	}
	343
	344
	345	MODULE_AUTHOR("Christian W. Zuckschwerdt <zany@triq.net>");
	346	MODULE_DESCRIPTION("DS1621 driver");
	347	MODULE_LICENSE("GPL");
	348
	349	module_init(ds1621_init);
	350	module_exit(ds1621_exit);