[mirror_ubuntu-bionic-kernel.git] / drivers / iio / light / max44000.c

/*
 * MAX44000 Ambient and Infrared Proximity Sensor
 *
 * Copyright (c) 2016, Intel Corporation.
 *
 * This file is subject to the terms and conditions of version 2 of
 * the GNU General Public License.  See the file COPYING in the main
 * directory of this archive for more details.
 *
 * Data sheet: https://datasheets.maximintegrated.com/en/ds/MAX44000.pdf
 *
 * 7-bit I2C slave address 0x4a
 */

#include <linux/module.h>
#include <linux/init.h>
#include <linux/i2c.h>
#include <linux/regmap.h>
#include <linux/util_macros.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
#include <linux/iio/buffer.h>
#include <linux/iio/trigger_consumer.h>
#include <linux/iio/triggered_buffer.h>
#include <linux/acpi.h>

#define MAX44000_DRV_NAME		"max44000"

/* Registers in datasheet order */
#define MAX44000_REG_STATUS		0x00
#define MAX44000_REG_CFG_MAIN		0x01
#define MAX44000_REG_CFG_RX		0x02
#define MAX44000_REG_CFG_TX		0x03
#define MAX44000_REG_ALS_DATA_HI	0x04
#define MAX44000_REG_ALS_DATA_LO	0x05
#define MAX44000_REG_PRX_DATA		0x16
#define MAX44000_REG_ALS_UPTHR_HI	0x06
#define MAX44000_REG_ALS_UPTHR_LO	0x07
#define MAX44000_REG_ALS_LOTHR_HI	0x08
#define MAX44000_REG_ALS_LOTHR_LO	0x09
#define MAX44000_REG_PST		0x0a
#define MAX44000_REG_PRX_IND		0x0b
#define MAX44000_REG_PRX_THR		0x0c
#define MAX44000_REG_TRIM_GAIN_GREEN	0x0f
#define MAX44000_REG_TRIM_GAIN_IR	0x10

/* REG_CFG bits */
#define MAX44000_CFG_ALSINTE            0x01
#define MAX44000_CFG_PRXINTE            0x02
#define MAX44000_CFG_MASK               0x1c
#define MAX44000_CFG_MODE_SHUTDOWN      0x00
#define MAX44000_CFG_MODE_ALS_GIR       0x04
#define MAX44000_CFG_MODE_ALS_G         0x08
#define MAX44000_CFG_MODE_ALS_IR        0x0c
#define MAX44000_CFG_MODE_ALS_PRX       0x10
#define MAX44000_CFG_MODE_PRX           0x14
#define MAX44000_CFG_TRIM               0x20

/*
 * Upper 4 bits are not documented but start as 1 on powerup
 * Setting them to 0 causes proximity to misbehave so set them to 1
 */
#define MAX44000_REG_CFG_RX_DEFAULT 0xf0

/* REG_RX bits */
#define MAX44000_CFG_RX_ALSTIM_MASK	0x0c
#define MAX44000_CFG_RX_ALSTIM_SHIFT	2
#define MAX44000_CFG_RX_ALSPGA_MASK	0x03
#define MAX44000_CFG_RX_ALSPGA_SHIFT	0

/* REG_TX bits */
#define MAX44000_LED_CURRENT_MASK	0xf
#define MAX44000_LED_CURRENT_MAX	11
#define MAX44000_LED_CURRENT_DEFAULT	6

#define MAX44000_ALSDATA_OVERFLOW	0x4000

struct max44000_data {
	struct mutex lock;
	struct regmap *regmap;
};

/* Default scale is set to the minimum of 0.03125 or 1 / (1 << 5) lux */
#define MAX44000_ALS_TO_LUX_DEFAULT_FRACTION_LOG2 5

/* Scale can be multiplied by up to 128x via ALSPGA for measurement gain */
static const int max44000_alspga_shift[] = {0, 2, 4, 7};
#define MAX44000_ALSPGA_MAX_SHIFT 7

/*
 * Scale can be multiplied by up to 64x via ALSTIM because of lost resolution
 *
 * This scaling factor is hidden from userspace and instead accounted for when
 * reading raw values from the device.
 *
 * This makes it possible to cleanly expose ALSPGA as IIO_CHAN_INFO_SCALE and
 * ALSTIM as IIO_CHAN_INFO_INT_TIME without the values affecting each other.
 *
 * Handling this internally is also required for buffer support because the
 * channel's scan_type can't be modified dynamically.
 */
static const int max44000_alstim_shift[] = {0, 2, 4, 6};
#define MAX44000_ALSTIM_SHIFT(alstim) (2 * (alstim))

/* Available integration times with pretty manual alignment: */
static const int max44000_int_time_avail_ns_array[] = {
	   100000000,
	    25000000,
	     6250000,
	     1562500,
};
static const char max44000_int_time_avail_str[] =
	"0.100 "
	"0.025 "
	"0.00625 "
	"0.0015625";

/* Available scales (internal to ulux) with pretty manual alignment: */
static const int max44000_scale_avail_ulux_array[] = {
	    31250,
	   125000,
	   500000,
	  4000000,
};
static const char max44000_scale_avail_str[] =
	"0.03125 "
	"0.125 "
	"0.5 "
	 "4";

#define MAX44000_SCAN_INDEX_ALS 0
#define MAX44000_SCAN_INDEX_PRX 1

static const struct iio_chan_spec max44000_channels[] = {
	{
		.type = IIO_LIGHT,
		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |
					    BIT(IIO_CHAN_INFO_INT_TIME),
		.scan_index = MAX44000_SCAN_INDEX_ALS,
		.scan_type = {
			.sign		= 'u',
			.realbits	= 14,
			.storagebits	= 16,
		}
	},
	{
		.type = IIO_PROXIMITY,
		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
		.scan_index = MAX44000_SCAN_INDEX_PRX,
		.scan_type = {
			.sign		= 'u',
			.realbits	= 8,
			.storagebits	= 16,
		}
	},
	IIO_CHAN_SOFT_TIMESTAMP(2),
	{
		.type = IIO_CURRENT,
		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
				      BIT(IIO_CHAN_INFO_SCALE),
		.extend_name = "led",
		.output = 1,
		.scan_index = -1,
	},
};

static int max44000_read_alstim(struct max44000_data *data)
{
	unsigned int val;
	int ret;

	ret = regmap_read(data->regmap, MAX44000_REG_CFG_RX, &val);
	if (ret < 0)
		return ret;
	return (val & MAX44000_CFG_RX_ALSTIM_MASK) >> MAX44000_CFG_RX_ALSTIM_SHIFT;
}

static int max44000_write_alstim(struct max44000_data *data, int val)
{
	return regmap_write_bits(data->regmap, MAX44000_REG_CFG_RX,
				 MAX44000_CFG_RX_ALSTIM_MASK,
				 val << MAX44000_CFG_RX_ALSTIM_SHIFT);
}

static int max44000_read_alspga(struct max44000_data *data)
{
	unsigned int val;
	int ret;

	ret = regmap_read(data->regmap, MAX44000_REG_CFG_RX, &val);
	if (ret < 0)
		return ret;
	return (val & MAX44000_CFG_RX_ALSPGA_MASK) >> MAX44000_CFG_RX_ALSPGA_SHIFT;
}

static int max44000_write_alspga(struct max44000_data *data, int val)
{
	return regmap_write_bits(data->regmap, MAX44000_REG_CFG_RX,
				 MAX44000_CFG_RX_ALSPGA_MASK,
				 val << MAX44000_CFG_RX_ALSPGA_SHIFT);
}

static int max44000_read_alsval(struct max44000_data *data)
{
	u16 regval;
	__be16 val;
	int alstim, ret;

	ret = regmap_bulk_read(data->regmap, MAX44000_REG_ALS_DATA_HI,
			       &val, sizeof(val));
	if (ret < 0)
		return ret;
	alstim = ret = max44000_read_alstim(data);
	if (ret < 0)
		return ret;

	regval = be16_to_cpu(val);

	/*
	 * Overflow is explained on datasheet page 17.
	 *
	 * It's a warning that either the G or IR channel has become saturated
	 * and that the value in the register is likely incorrect.
	 *
	 * The recommendation is to change the scale (ALSPGA).
	 * The driver just returns the max representable value.
	 */
	if (regval & MAX44000_ALSDATA_OVERFLOW)
		return 0x3FFF;

	return regval << MAX44000_ALSTIM_SHIFT(alstim);
}

static int max44000_write_led_current_raw(struct max44000_data *data, int val)
{
	/* Maybe we should clamp the value instead? */
	if (val < 0 || val > MAX44000_LED_CURRENT_MAX)
		return -ERANGE;
	if (val >= 8)
		val += 4;
	return regmap_write_bits(data->regmap, MAX44000_REG_CFG_TX,
				 MAX44000_LED_CURRENT_MASK, val);
}

static int max44000_read_led_current_raw(struct max44000_data *data)
{
	unsigned int regval;
	int ret;

	ret = regmap_read(data->regmap, MAX44000_REG_CFG_TX, &regval);
	if (ret < 0)
		return ret;
	regval &= MAX44000_LED_CURRENT_MASK;
	if (regval >= 8)
		regval -= 4;
	return regval;
}

static int max44000_read_raw(struct iio_dev *indio_dev,
			     struct iio_chan_spec const *chan,
			     int *val, int *val2, long mask)
{
	struct max44000_data *data = iio_priv(indio_dev);
	int alstim, alspga;
	unsigned int regval;
	int ret;

	switch (mask) {
	case IIO_CHAN_INFO_RAW:
		switch (chan->type) {
		case IIO_LIGHT:
			mutex_lock(&data->lock);
			ret = max44000_read_alsval(data);
			mutex_unlock(&data->lock);
			if (ret < 0)
				return ret;
			*val = ret;
			return IIO_VAL_INT;

		case IIO_PROXIMITY:
			mutex_lock(&data->lock);
			ret = regmap_read(data->regmap, MAX44000_REG_PRX_DATA, &regval);
			mutex_unlock(&data->lock);
			if (ret < 0)
				return ret;
			*val = regval;
			return IIO_VAL_INT;

		case IIO_CURRENT:
			mutex_lock(&data->lock);
			ret = max44000_read_led_current_raw(data);
			mutex_unlock(&data->lock);
			if (ret < 0)
				return ret;
			*val = ret;
			return IIO_VAL_INT;

		default:
			return -EINVAL;
		}

	case IIO_CHAN_INFO_SCALE:
		switch (chan->type) {
		case IIO_CURRENT:
			/* Output register is in 10s of miliamps */
			*val = 10;
			return IIO_VAL_INT;

		case IIO_LIGHT:
			mutex_lock(&data->lock);
			alspga = ret = max44000_read_alspga(data);
			mutex_unlock(&data->lock);
			if (ret < 0)
				return ret;

			/* Avoid negative shifts */
			*val = (1 << MAX44000_ALSPGA_MAX_SHIFT);
			*val2 = MAX44000_ALS_TO_LUX_DEFAULT_FRACTION_LOG2
					+ MAX44000_ALSPGA_MAX_SHIFT
					- max44000_alspga_shift[alspga];
			return IIO_VAL_FRACTIONAL_LOG2;

		default:
			return -EINVAL;
		}

	case IIO_CHAN_INFO_INT_TIME:
		mutex_lock(&data->lock);
		alstim = ret = max44000_read_alstim(data);
		mutex_unlock(&data->lock);

		if (ret < 0)
			return ret;
		*val = 0;
		*val2 = max44000_int_time_avail_ns_array[alstim];
		return IIO_VAL_INT_PLUS_NANO;

	default:
		return -EINVAL;
	}
}

static int max44000_write_raw(struct iio_dev *indio_dev,
			      struct iio_chan_spec const *chan,
			      int val, int val2, long mask)
{
	struct max44000_data *data = iio_priv(indio_dev);
	int ret;

	if (mask == IIO_CHAN_INFO_RAW && chan->type == IIO_CURRENT) {
		mutex_lock(&data->lock);
		ret = max44000_write_led_current_raw(data, val);
		mutex_unlock(&data->lock);
		return ret;
	} else if (mask == IIO_CHAN_INFO_INT_TIME && chan->type == IIO_LIGHT) {
		s64 valns = val * NSEC_PER_SEC + val2;
		int alstim = find_closest_descending(valns,
				max44000_int_time_avail_ns_array,
				ARRAY_SIZE(max44000_int_time_avail_ns_array));
		mutex_lock(&data->lock);
		ret = max44000_write_alstim(data, alstim);
		mutex_unlock(&data->lock);
		return ret;
	} else if (mask == IIO_CHAN_INFO_SCALE && chan->type == IIO_LIGHT) {
		s64 valus = val * USEC_PER_SEC + val2;
		int alspga = find_closest(valus,
				max44000_scale_avail_ulux_array,
				ARRAY_SIZE(max44000_scale_avail_ulux_array));
		mutex_lock(&data->lock);
		ret = max44000_write_alspga(data, alspga);
		mutex_unlock(&data->lock);
		return ret;
	}

	return -EINVAL;
}

static int max44000_write_raw_get_fmt(struct iio_dev *indio_dev,
				      struct iio_chan_spec const *chan,
				      long mask)
{
	if (mask == IIO_CHAN_INFO_INT_TIME && chan->type == IIO_LIGHT)
		return IIO_VAL_INT_PLUS_NANO;
	else if (mask == IIO_CHAN_INFO_SCALE && chan->type == IIO_LIGHT)
		return IIO_VAL_INT_PLUS_MICRO;
	else
		return IIO_VAL_INT;
}

static IIO_CONST_ATTR(illuminance_integration_time_available, max44000_int_time_avail_str);
static IIO_CONST_ATTR(illuminance_scale_available, max44000_scale_avail_str);

static struct attribute *max44000_attributes[] = {
	&iio_const_attr_illuminance_integration_time_available.dev_attr.attr,
	&iio_const_attr_illuminance_scale_available.dev_attr.attr,
	NULL
};

static const struct attribute_group max44000_attribute_group = {
	.attrs = max44000_attributes,
};

static const struct iio_info max44000_info = {
	.read_raw		= max44000_read_raw,
	.write_raw		= max44000_write_raw,
	.write_raw_get_fmt	= max44000_write_raw_get_fmt,
	.attrs			= &max44000_attribute_group,
};

static bool max44000_readable_reg(struct device *dev, unsigned int reg)
{
	switch (reg) {
	case MAX44000_REG_STATUS:
	case MAX44000_REG_CFG_MAIN:
	case MAX44000_REG_CFG_RX:
	case MAX44000_REG_CFG_TX:
	case MAX44000_REG_ALS_DATA_HI:
	case MAX44000_REG_ALS_DATA_LO:
	case MAX44000_REG_PRX_DATA:
	case MAX44000_REG_ALS_UPTHR_HI:
	case MAX44000_REG_ALS_UPTHR_LO:
	case MAX44000_REG_ALS_LOTHR_HI:
	case MAX44000_REG_ALS_LOTHR_LO:
	case MAX44000_REG_PST:
	case MAX44000_REG_PRX_IND:
	case MAX44000_REG_PRX_THR:
	case MAX44000_REG_TRIM_GAIN_GREEN:
	case MAX44000_REG_TRIM_GAIN_IR:
		return true;
	default:
		return false;
	}
}

static bool max44000_writeable_reg(struct device *dev, unsigned int reg)
{
	switch (reg) {
	case MAX44000_REG_CFG_MAIN:
	case MAX44000_REG_CFG_RX:
	case MAX44000_REG_CFG_TX:
	case MAX44000_REG_ALS_UPTHR_HI:
	case MAX44000_REG_ALS_UPTHR_LO:
	case MAX44000_REG_ALS_LOTHR_HI:
	case MAX44000_REG_ALS_LOTHR_LO:
	case MAX44000_REG_PST:
	case MAX44000_REG_PRX_IND:
	case MAX44000_REG_PRX_THR:
	case MAX44000_REG_TRIM_GAIN_GREEN:
	case MAX44000_REG_TRIM_GAIN_IR:
		return true;
	default:
		return false;
	}
}

static bool max44000_volatile_reg(struct device *dev, unsigned int reg)
{
	switch (reg) {
	case MAX44000_REG_STATUS:
	case MAX44000_REG_ALS_DATA_HI:
	case MAX44000_REG_ALS_DATA_LO:
	case MAX44000_REG_PRX_DATA:
		return true;
	default:
		return false;
	}
}

static bool max44000_precious_reg(struct device *dev, unsigned int reg)
{
	return reg == MAX44000_REG_STATUS;
}

static const struct regmap_config max44000_regmap_config = {
	.reg_bits	= 8,
	.val_bits	= 8,

	.max_register	= MAX44000_REG_PRX_DATA,
	.readable_reg	= max44000_readable_reg,
	.writeable_reg	= max44000_writeable_reg,
	.volatile_reg	= max44000_volatile_reg,
	.precious_reg	= max44000_precious_reg,

	.use_single_rw	= 1,
	.cache_type	= REGCACHE_RBTREE,
};

static irqreturn_t max44000_trigger_handler(int irq, void *p)
{
	struct iio_poll_func *pf = p;
	struct iio_dev *indio_dev = pf->indio_dev;
	struct max44000_data *data = iio_priv(indio_dev);
	u16 buf[8]; /* 2x u16 + padding + 8 bytes timestamp */
	int index = 0;
	unsigned int regval;
	int ret;

	mutex_lock(&data->lock);
	if (test_bit(MAX44000_SCAN_INDEX_ALS, indio_dev->active_scan_mask)) {
		ret = max44000_read_alsval(data);
		if (ret < 0)
			goto out_unlock;
		buf[index++] = ret;
	}
	if (test_bit(MAX44000_SCAN_INDEX_PRX, indio_dev->active_scan_mask)) {
		ret = regmap_read(data->regmap, MAX44000_REG_PRX_DATA, &regval);
		if (ret < 0)
			goto out_unlock;
		buf[index] = regval;
	}
	mutex_unlock(&data->lock);

	iio_push_to_buffers_with_timestamp(indio_dev, buf,
					   iio_get_time_ns(indio_dev));
	iio_trigger_notify_done(indio_dev->trig);
	return IRQ_HANDLED;

out_unlock:
	mutex_unlock(&data->lock);
	iio_trigger_notify_done(indio_dev->trig);
	return IRQ_HANDLED;
}

static int max44000_probe(struct i2c_client *client,
			  const struct i2c_device_id *id)
{
	struct max44000_data *data;
	struct iio_dev *indio_dev;
	int ret, reg;

	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
	if (!indio_dev)
		return -ENOMEM;
	data = iio_priv(indio_dev);
	data->regmap = devm_regmap_init_i2c(client, &max44000_regmap_config);
	if (IS_ERR(data->regmap)) {
		dev_err(&client->dev, "regmap_init failed!\n");
		return PTR_ERR(data->regmap);
	}

	i2c_set_clientdata(client, indio_dev);
	mutex_init(&data->lock);
	indio_dev->dev.parent = &client->dev;
	indio_dev->info = &max44000_info;
	indio_dev->name = MAX44000_DRV_NAME;
	indio_dev->channels = max44000_channels;
	indio_dev->num_channels = ARRAY_SIZE(max44000_channels);

	/*
	 * The device doesn't have a reset function so we just clear some
	 * important bits at probe time to ensure sane operation.
	 *
	 * Since we don't support interrupts/events the threshold values are
	 * not important. We also don't touch trim values.
	 */

	/* Reset ALS scaling bits */
	ret = regmap_write(data->regmap, MAX44000_REG_CFG_RX,
			   MAX44000_REG_CFG_RX_DEFAULT);
	if (ret < 0) {
		dev_err(&client->dev, "failed to write default CFG_RX: %d\n",
			ret);
		return ret;
	}

	/*
	 * By default the LED pulse used for the proximity sensor is disabled.
	 * Set a middle value so that we get some sort of valid data by default.
	 */
	ret = max44000_write_led_current_raw(data, MAX44000_LED_CURRENT_DEFAULT);
	if (ret < 0) {
		dev_err(&client->dev, "failed to write init config: %d\n", ret);
		return ret;
	}

	/* Reset CFG bits to ALS_PRX mode which allows easy reading of both values. */
	reg = MAX44000_CFG_TRIM | MAX44000_CFG_MODE_ALS_PRX;
	ret = regmap_write(data->regmap, MAX44000_REG_CFG_MAIN, reg);
	if (ret < 0) {
		dev_err(&client->dev, "failed to write init config: %d\n", ret);
		return ret;
	}

	/* Read status at least once to clear any stale interrupt bits. */
	ret = regmap_read(data->regmap, MAX44000_REG_STATUS, &reg);
	if (ret < 0) {
		dev_err(&client->dev, "failed to read init status: %d\n", ret);
		return ret;
	}

	ret = iio_triggered_buffer_setup(indio_dev, NULL, max44000_trigger_handler, NULL);
	if (ret < 0) {
		dev_err(&client->dev, "iio triggered buffer setup failed\n");
		return ret;
	}

	return iio_device_register(indio_dev);
}

static int max44000_remove(struct i2c_client *client)
{
	struct iio_dev *indio_dev = i2c_get_clientdata(client);

	iio_device_unregister(indio_dev);
	iio_triggered_buffer_cleanup(indio_dev);

	return 0;
}

static const struct i2c_device_id max44000_id[] = {
	{"max44000", 0},
	{ }
};
MODULE_DEVICE_TABLE(i2c, max44000_id);

#ifdef CONFIG_ACPI
static const struct acpi_device_id max44000_acpi_match[] = {
	{"MAX44000", 0},
	{ }
};
MODULE_DEVICE_TABLE(acpi, max44000_acpi_match);
#endif

static struct i2c_driver max44000_driver = {
	.driver = {
		.name	= MAX44000_DRV_NAME,
		.acpi_match_table = ACPI_PTR(max44000_acpi_match),
	},
	.probe		= max44000_probe,
	.remove		= max44000_remove,
	.id_table	= max44000_id,
};

module_i2c_driver(max44000_driver);

MODULE_AUTHOR("Crestez Dan Leonard <leonard.crestez@intel.com>");
MODULE_DESCRIPTION("MAX44000 Ambient and Infrared Proximity Sensor");
MODULE_LICENSE("GPL v2");
Commit	Line	Data
b9567e66 CDL	1	/*
	2	* MAX44000 Ambient and Infrared Proximity Sensor
	3	*
	4	* Copyright (c) 2016, Intel Corporation.
	5	*
	6	* This file is subject to the terms and conditions of version 2 of
	7	* the GNU General Public License. See the file COPYING in the main
	8	* directory of this archive for more details.
	9	*
	10	* Data sheet: https://datasheets.maximintegrated.com/en/ds/MAX44000.pdf
	11	*
	12	* 7-bit I2C slave address 0x4a
	13	*/
	14
	15	#include <linux/module.h>
	16	#include <linux/init.h>
	17	#include <linux/i2c.h>
	18	#include <linux/regmap.h>
	19	#include <linux/util_macros.h>
	20	#include <linux/iio/iio.h>
	21	#include <linux/iio/sysfs.h>
06ad7ea1 CDL	22	#include <linux/iio/buffer.h>
	23	#include <linux/iio/trigger_consumer.h>
	24	#include <linux/iio/triggered_buffer.h>
b9567e66 CDL	25	#include <linux/acpi.h>
	26
	27	#define MAX44000_DRV_NAME "max44000"
	28
	29	/* Registers in datasheet order */
	30	#define MAX44000_REG_STATUS 0x00
	31	#define MAX44000_REG_CFG_MAIN 0x01
	32	#define MAX44000_REG_CFG_RX 0x02
	33	#define MAX44000_REG_CFG_TX 0x03
	34	#define MAX44000_REG_ALS_DATA_HI 0x04
	35	#define MAX44000_REG_ALS_DATA_LO 0x05
	36	#define MAX44000_REG_PRX_DATA 0x16
	37	#define MAX44000_REG_ALS_UPTHR_HI 0x06
	38	#define MAX44000_REG_ALS_UPTHR_LO 0x07
	39	#define MAX44000_REG_ALS_LOTHR_HI 0x08
	40	#define MAX44000_REG_ALS_LOTHR_LO 0x09
	41	#define MAX44000_REG_PST 0x0a
	42	#define MAX44000_REG_PRX_IND 0x0b
	43	#define MAX44000_REG_PRX_THR 0x0c
	44	#define MAX44000_REG_TRIM_GAIN_GREEN 0x0f
	45	#define MAX44000_REG_TRIM_GAIN_IR 0x10
	46
	47	/* REG_CFG bits */
	48	#define MAX44000_CFG_ALSINTE 0x01
	49	#define MAX44000_CFG_PRXINTE 0x02
	50	#define MAX44000_CFG_MASK 0x1c
	51	#define MAX44000_CFG_MODE_SHUTDOWN 0x00
	52	#define MAX44000_CFG_MODE_ALS_GIR 0x04
	53	#define MAX44000_CFG_MODE_ALS_G 0x08
	54	#define MAX44000_CFG_MODE_ALS_IR 0x0c
	55	#define MAX44000_CFG_MODE_ALS_PRX 0x10
	56	#define MAX44000_CFG_MODE_PRX 0x14
	57	#define MAX44000_CFG_TRIM 0x20
	58
	59	/*
	60	* Upper 4 bits are not documented but start as 1 on powerup
	61	* Setting them to 0 causes proximity to misbehave so set them to 1
	62	*/
	63	#define MAX44000_REG_CFG_RX_DEFAULT 0xf0
	64
d5d8f49b CDL	65	/* REG_RX bits */
	66	#define MAX44000_CFG_RX_ALSTIM_MASK 0x0c
	67	#define MAX44000_CFG_RX_ALSTIM_SHIFT 2
	68	#define MAX44000_CFG_RX_ALSPGA_MASK 0x03
	69	#define MAX44000_CFG_RX_ALSPGA_SHIFT 0
	70
35b651f3 CDL	71	/* REG_TX bits */
	72	#define MAX44000_LED_CURRENT_MASK 0xf
	73	#define MAX44000_LED_CURRENT_MAX 11
	74	#define MAX44000_LED_CURRENT_DEFAULT 6
	75
b9567e66 CDL	76	#define MAX44000_ALSDATA_OVERFLOW 0x4000
	77
	78	struct max44000_data {
	79	struct mutex lock;
	80	struct regmap *regmap;
	81	};
	82
	83	/* Default scale is set to the minimum of 0.03125 or 1 / (1 << 5) lux */
	84	#define MAX44000_ALS_TO_LUX_DEFAULT_FRACTION_LOG2 5
	85
d5d8f49b CDL	86	/* Scale can be multiplied by up to 128x via ALSPGA for measurement gain */
	87	static const int max44000_alspga_shift[] = {0, 2, 4, 7};
	88	#define MAX44000_ALSPGA_MAX_SHIFT 7
	89
	90	/*
	91	* Scale can be multiplied by up to 64x via ALSTIM because of lost resolution
	92	*
	93	* This scaling factor is hidden from userspace and instead accounted for when
	94	* reading raw values from the device.
	95	*
	96	* This makes it possible to cleanly expose ALSPGA as IIO_CHAN_INFO_SCALE and
	97	* ALSTIM as IIO_CHAN_INFO_INT_TIME without the values affecting each other.
	98	*
	99	* Handling this internally is also required for buffer support because the
	100	* channel's scan_type can't be modified dynamically.
	101	*/
	102	static const int max44000_alstim_shift[] = {0, 2, 4, 6};
	103	#define MAX44000_ALSTIM_SHIFT(alstim) (2 * (alstim))
	104
	105	/* Available integration times with pretty manual alignment: */
	106	static const int max44000_int_time_avail_ns_array[] = {
	107	100000000,
	108	25000000,
	109	6250000,
	110	1562500,
	111	};
	112	static const char max44000_int_time_avail_str[] =
	113	"0.100 "
	114	"0.025 "
	115	"0.00625 "
b4e8a0eb	116	"0.0015625";
d5d8f49b CDL	117
	118	/* Available scales (internal to ulux) with pretty manual alignment: */
	119	static const int max44000_scale_avail_ulux_array[] = {
	120	31250,
	121	125000,
	122	500000,
	123	4000000,
	124	};
	125	static const char max44000_scale_avail_str[] =
	126	"0.03125 "
	127	"0.125 "
	128	"0.5 "
	129	"4";
	130
06ad7ea1 CDL	131	#define MAX44000_SCAN_INDEX_ALS 0
	132	#define MAX44000_SCAN_INDEX_PRX 1
	133
b9567e66 CDL	134	static const struct iio_chan_spec max44000_channels[] = {
	135	{
	136	.type = IIO_LIGHT,
	137	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
d5d8f49b CDL	138	.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) \|
d5d8f49b CDL	139	BIT(IIO_CHAN_INFO_INT_TIME),
06ad7ea1 CDL	140	.scan_index = MAX44000_SCAN_INDEX_ALS,
	141	.scan_type = {
	142	.sign = 'u',
	143	.realbits = 14,
	144	.storagebits = 16,
	145	}
b9567e66	146	},
35b651f3 CDL	147	{
	148	.type = IIO_PROXIMITY,
	149	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
06ad7ea1 CDL	150	.scan_index = MAX44000_SCAN_INDEX_PRX,
	151	.scan_type = {
	152	.sign = 'u',
	153	.realbits = 8,
	154	.storagebits = 16,
	155	}
35b651f3	156	},
06ad7ea1	157	IIO_CHAN_SOFT_TIMESTAMP(2),
237a378b CDL	158	{
	159	.type = IIO_CURRENT,
	160	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) \|
	161	BIT(IIO_CHAN_INFO_SCALE),
	162	.extend_name = "led",
	163	.output = 1,
06ad7ea1	164	.scan_index = -1,
237a378b	165	},
b9567e66 CDL	166	};
b9567e66 CDL	167
d5d8f49b CDL	168	static int max44000_read_alstim(struct max44000_data *data)
	169	{
	170	unsigned int val;
	171	int ret;
	172
	173	ret = regmap_read(data->regmap, MAX44000_REG_CFG_RX, &val);
	174	if (ret < 0)
	175	return ret;
	176	return (val & MAX44000_CFG_RX_ALSTIM_MASK) >> MAX44000_CFG_RX_ALSTIM_SHIFT;
	177	}
	178
	179	static int max44000_write_alstim(struct max44000_data *data, int val)
	180	{
	181	return regmap_write_bits(data->regmap, MAX44000_REG_CFG_RX,
	182	MAX44000_CFG_RX_ALSTIM_MASK,
	183	val << MAX44000_CFG_RX_ALSTIM_SHIFT);
	184	}
	185
	186	static int max44000_read_alspga(struct max44000_data *data)
	187	{
	188	unsigned int val;
	189	int ret;
	190
	191	ret = regmap_read(data->regmap, MAX44000_REG_CFG_RX, &val);
	192	if (ret < 0)
	193	return ret;
	194	return (val & MAX44000_CFG_RX_ALSPGA_MASK) >> MAX44000_CFG_RX_ALSPGA_SHIFT;
	195	}
	196
	197	static int max44000_write_alspga(struct max44000_data *data, int val)
	198	{
	199	return regmap_write_bits(data->regmap, MAX44000_REG_CFG_RX,
	200	MAX44000_CFG_RX_ALSPGA_MASK,
	201	val << MAX44000_CFG_RX_ALSPGA_SHIFT);
	202	}
	203
b9567e66 CDL	204	static int max44000_read_alsval(struct max44000_data *data)
	205	{
	206	u16 regval;
2a20af72	207	__be16 val;
d5d8f49b	208	int alstim, ret;
b9567e66 CDL	209
b9567e66 CDL	210	ret = regmap_bulk_read(data->regmap, MAX44000_REG_ALS_DATA_HI,
2a20af72	211	&val, sizeof(val));
b9567e66 CDL	212	if (ret < 0)
b9567e66 CDL	213	return ret;
d5d8f49b CDL	214	alstim = ret = max44000_read_alstim(data);
	215	if (ret < 0)
	216	return ret;
b9567e66	217
2a20af72	218	regval = be16_to_cpu(val);
b9567e66 CDL	219
	220	/*
	221	* Overflow is explained on datasheet page 17.
	222	*
	223	* It's a warning that either the G or IR channel has become saturated
	224	* and that the value in the register is likely incorrect.
	225	*
	226	* The recommendation is to change the scale (ALSPGA).
	227	* The driver just returns the max representable value.
	228	*/
	229	if (regval & MAX44000_ALSDATA_OVERFLOW)
	230	return 0x3FFF;
	231
d5d8f49b	232	return regval << MAX44000_ALSTIM_SHIFT(alstim);
b9567e66 CDL	233	}
b9567e66 CDL	234
35b651f3 CDL	235	static int max44000_write_led_current_raw(struct max44000_data *data, int val)
	236	{
	237	/* Maybe we should clamp the value instead? */
	238	if (val < 0 \|\| val > MAX44000_LED_CURRENT_MAX)
	239	return -ERANGE;
	240	if (val >= 8)
	241	val += 4;
	242	return regmap_write_bits(data->regmap, MAX44000_REG_CFG_TX,
	243	MAX44000_LED_CURRENT_MASK, val);
	244	}
	245
237a378b CDL	246	static int max44000_read_led_current_raw(struct max44000_data *data)
	247	{
	248	unsigned int regval;
	249	int ret;
	250
	251	ret = regmap_read(data->regmap, MAX44000_REG_CFG_TX, &regval);
	252	if (ret < 0)
	253	return ret;
	254	regval &= MAX44000_LED_CURRENT_MASK;
	255	if (regval >= 8)
	256	regval -= 4;
	257	return regval;
	258	}
	259
b9567e66 CDL	260	static int max44000_read_raw(struct iio_dev *indio_dev,
	261	struct iio_chan_spec const *chan,
	262	int val, int val2, long mask)
	263	{
	264	struct max44000_data *data = iio_priv(indio_dev);
d5d8f49b	265	int alstim, alspga;
35b651f3	266	unsigned int regval;
b9567e66 CDL	267	int ret;
	268
	269	switch (mask) {
	270	case IIO_CHAN_INFO_RAW:
	271	switch (chan->type) {
	272	case IIO_LIGHT:
	273	mutex_lock(&data->lock);
	274	ret = max44000_read_alsval(data);
	275	mutex_unlock(&data->lock);
	276	if (ret < 0)
	277	return ret;
	278	*val = ret;
	279	return IIO_VAL_INT;
	280
35b651f3 CDL	281	case IIO_PROXIMITY:
	282	mutex_lock(&data->lock);
	283	ret = regmap_read(data->regmap, MAX44000_REG_PRX_DATA, &regval);
	284	mutex_unlock(&data->lock);
	285	if (ret < 0)
	286	return ret;
	287	*val = regval;
	288	return IIO_VAL_INT;
	289
237a378b CDL	290	case IIO_CURRENT:
	291	mutex_lock(&data->lock);
	292	ret = max44000_read_led_current_raw(data);
	293	mutex_unlock(&data->lock);
	294	if (ret < 0)
	295	return ret;
	296	*val = ret;
	297	return IIO_VAL_INT;
	298
b9567e66 CDL	299	default:
	300	return -EINVAL;
	301	}
	302
	303	case IIO_CHAN_INFO_SCALE:
	304	switch (chan->type) {
237a378b CDL	305	case IIO_CURRENT:
	306	/* Output register is in 10s of miliamps */
	307	*val = 10;
	308	return IIO_VAL_INT;
	309
b9567e66	310	case IIO_LIGHT:
d5d8f49b CDL	311	mutex_lock(&data->lock);
	312	alspga = ret = max44000_read_alspga(data);
	313	mutex_unlock(&data->lock);
	314	if (ret < 0)
	315	return ret;
	316
	317	/* Avoid negative shifts */
	318	*val = (1 << MAX44000_ALSPGA_MAX_SHIFT);
	319	*val2 = MAX44000_ALS_TO_LUX_DEFAULT_FRACTION_LOG2
	320	+ MAX44000_ALSPGA_MAX_SHIFT
	321	- max44000_alspga_shift[alspga];
b9567e66 CDL	322	return IIO_VAL_FRACTIONAL_LOG2;
	323
	324	default:
	325	return -EINVAL;
	326	}
	327
d5d8f49b CDL	328	case IIO_CHAN_INFO_INT_TIME:
	329	mutex_lock(&data->lock);
	330	alstim = ret = max44000_read_alstim(data);
	331	mutex_unlock(&data->lock);
	332
	333	if (ret < 0)
	334	return ret;
	335	*val = 0;
	336	*val2 = max44000_int_time_avail_ns_array[alstim];
	337	return IIO_VAL_INT_PLUS_NANO;
	338
b9567e66 CDL	339	default:
	340	return -EINVAL;
	341	}
	342	}
	343
237a378b CDL	344	static int max44000_write_raw(struct iio_dev *indio_dev,
	345	struct iio_chan_spec const *chan,
	346	int val, int val2, long mask)
	347	{
	348	struct max44000_data *data = iio_priv(indio_dev);
	349	int ret;
	350
	351	if (mask == IIO_CHAN_INFO_RAW && chan->type == IIO_CURRENT) {
	352	mutex_lock(&data->lock);
	353	ret = max44000_write_led_current_raw(data, val);
	354	mutex_unlock(&data->lock);
	355	return ret;
d5d8f49b CDL	356	} else if (mask == IIO_CHAN_INFO_INT_TIME && chan->type == IIO_LIGHT) {
	357	s64 valns = val * NSEC_PER_SEC + val2;
	358	int alstim = find_closest_descending(valns,
	359	max44000_int_time_avail_ns_array,
	360	ARRAY_SIZE(max44000_int_time_avail_ns_array));
	361	mutex_lock(&data->lock);
	362	ret = max44000_write_alstim(data, alstim);
	363	mutex_unlock(&data->lock);
	364	return ret;
	365	} else if (mask == IIO_CHAN_INFO_SCALE && chan->type == IIO_LIGHT) {
	366	s64 valus = val * USEC_PER_SEC + val2;
	367	int alspga = find_closest(valus,
	368	max44000_scale_avail_ulux_array,
	369	ARRAY_SIZE(max44000_scale_avail_ulux_array));
	370	mutex_lock(&data->lock);
	371	ret = max44000_write_alspga(data, alspga);
	372	mutex_unlock(&data->lock);
	373	return ret;
237a378b CDL	374	}
	375
	376	return -EINVAL;
	377	}
	378
d5d8f49b CDL	379	static int max44000_write_raw_get_fmt(struct iio_dev *indio_dev,
	380	struct iio_chan_spec const *chan,
	381	long mask)
	382	{
	383	if (mask == IIO_CHAN_INFO_INT_TIME && chan->type == IIO_LIGHT)
	384	return IIO_VAL_INT_PLUS_NANO;
	385	else if (mask == IIO_CHAN_INFO_SCALE && chan->type == IIO_LIGHT)
	386	return IIO_VAL_INT_PLUS_MICRO;
	387	else
	388	return IIO_VAL_INT;
	389	}
	390
	391	static IIO_CONST_ATTR(illuminance_integration_time_available, max44000_int_time_avail_str);
	392	static IIO_CONST_ATTR(illuminance_scale_available, max44000_scale_avail_str);
	393
	394	static struct attribute *max44000_attributes[] = {
	395	&iio_const_attr_illuminance_integration_time_available.dev_attr.attr,
	396	&iio_const_attr_illuminance_scale_available.dev_attr.attr,
	397	NULL
	398	};
	399
	400	static const struct attribute_group max44000_attribute_group = {
	401	.attrs = max44000_attributes,
	402	};
	403
b9567e66	404	static const struct iio_info max44000_info = {
b9567e66	405	.read_raw = max44000_read_raw,
237a378b	406	.write_raw = max44000_write_raw,
d5d8f49b CDL	407	.write_raw_get_fmt = max44000_write_raw_get_fmt,
d5d8f49b CDL	408	.attrs = &max44000_attribute_group,
b9567e66 CDL	409	};
	410
	411	static bool max44000_readable_reg(struct device *dev, unsigned int reg)
	412	{
	413	switch (reg) {
	414	case MAX44000_REG_STATUS:
	415	case MAX44000_REG_CFG_MAIN:
	416	case MAX44000_REG_CFG_RX:
	417	case MAX44000_REG_CFG_TX:
	418	case MAX44000_REG_ALS_DATA_HI:
	419	case MAX44000_REG_ALS_DATA_LO:
	420	case MAX44000_REG_PRX_DATA:
	421	case MAX44000_REG_ALS_UPTHR_HI:
	422	case MAX44000_REG_ALS_UPTHR_LO:
	423	case MAX44000_REG_ALS_LOTHR_HI:
	424	case MAX44000_REG_ALS_LOTHR_LO:
	425	case MAX44000_REG_PST:
	426	case MAX44000_REG_PRX_IND:
	427	case MAX44000_REG_PRX_THR:
	428	case MAX44000_REG_TRIM_GAIN_GREEN:
	429	case MAX44000_REG_TRIM_GAIN_IR:
	430	return true;
	431	default:
	432	return false;
	433	}
	434	}
	435
	436	static bool max44000_writeable_reg(struct device *dev, unsigned int reg)
	437	{
	438	switch (reg) {
	439	case MAX44000_REG_CFG_MAIN:
	440	case MAX44000_REG_CFG_RX:
	441	case MAX44000_REG_CFG_TX:
	442	case MAX44000_REG_ALS_UPTHR_HI:
	443	case MAX44000_REG_ALS_UPTHR_LO:
	444	case MAX44000_REG_ALS_LOTHR_HI:
	445	case MAX44000_REG_ALS_LOTHR_LO:
	446	case MAX44000_REG_PST:
	447	case MAX44000_REG_PRX_IND:
	448	case MAX44000_REG_PRX_THR:
	449	case MAX44000_REG_TRIM_GAIN_GREEN:
	450	case MAX44000_REG_TRIM_GAIN_IR:
	451	return true;
	452	default:
	453	return false;
	454	}
	455	}
	456
	457	static bool max44000_volatile_reg(struct device *dev, unsigned int reg)
	458	{
	459	switch (reg) {
	460	case MAX44000_REG_STATUS:
	461	case MAX44000_REG_ALS_DATA_HI:
	462	case MAX44000_REG_ALS_DATA_LO:
	463	case MAX44000_REG_PRX_DATA:
	464	return true;
	465	default:
	466	return false;
	467	}
	468	}
	469
	470	static bool max44000_precious_reg(struct device *dev, unsigned int reg)
	471	{
	472	return reg == MAX44000_REG_STATUS;
473	}
474
475	static const struct regmap_config max44000_regmap_config = {
476	.reg_bits = 8,
477	.val_bits = 8,
478
479	.max_register = MAX44000_REG_PRX_DATA,
480	.readable_reg = max44000_readable_reg,
481	.writeable_reg = max44000_writeable_reg,
482	.volatile_reg = max44000_volatile_reg,
483	.precious_reg = max44000_precious_reg,
484
485	.use_single_rw = 1,
486	.cache_type = REGCACHE_RBTREE,
487	};
488
06ad7ea1 CDL	489	static irqreturn_t max44000_trigger_handler(int irq, void *p)
	490	{
	491	struct iio_poll_func *pf = p;
	492	struct iio_dev *indio_dev = pf->indio_dev;
	493	struct max44000_data *data = iio_priv(indio_dev);
	494	u16 buf[8]; /* 2x u16 + padding + 8 bytes timestamp */
	495	int index = 0;
	496	unsigned int regval;
	497	int ret;
	498
	499	mutex_lock(&data->lock);
	500	if (test_bit(MAX44000_SCAN_INDEX_ALS, indio_dev->active_scan_mask)) {
	501	ret = max44000_read_alsval(data);
	502	if (ret < 0)
	503	goto out_unlock;
	504	buf[index++] = ret;
	505	}
	506	if (test_bit(MAX44000_SCAN_INDEX_PRX, indio_dev->active_scan_mask)) {
	507	ret = regmap_read(data->regmap, MAX44000_REG_PRX_DATA, &regval);
	508	if (ret < 0)
	509	goto out_unlock;
	510	buf[index] = regval;
	511	}
	512	mutex_unlock(&data->lock);
	513
bc2b7dab GB	514	iio_push_to_buffers_with_timestamp(indio_dev, buf,
bc2b7dab GB	515	iio_get_time_ns(indio_dev));
06ad7ea1 CDL	516	iio_trigger_notify_done(indio_dev->trig);
	517	return IRQ_HANDLED;
	518
	519	out_unlock:
	520	mutex_unlock(&data->lock);
	521	iio_trigger_notify_done(indio_dev->trig);
	522	return IRQ_HANDLED;
	523	}
	524
b9567e66 CDL	525	static int max44000_probe(struct i2c_client *client,
	526	const struct i2c_device_id *id)
	527	{
	528	struct max44000_data *data;
	529	struct iio_dev *indio_dev;
	530	int ret, reg;
	531
	532	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
	533	if (!indio_dev)
	534	return -ENOMEM;
	535	data = iio_priv(indio_dev);
	536	data->regmap = devm_regmap_init_i2c(client, &max44000_regmap_config);
	537	if (IS_ERR(data->regmap)) {
	538	dev_err(&client->dev, "regmap_init failed!\n");
	539	return PTR_ERR(data->regmap);
	540	}
	541
	542	i2c_set_clientdata(client, indio_dev);
	543	mutex_init(&data->lock);
	544	indio_dev->dev.parent = &client->dev;
	545	indio_dev->info = &max44000_info;
	546	indio_dev->name = MAX44000_DRV_NAME;
	547	indio_dev->channels = max44000_channels;
	548	indio_dev->num_channels = ARRAY_SIZE(max44000_channels);
	549
	550	/*
	551	* The device doesn't have a reset function so we just clear some
	552	* important bits at probe time to ensure sane operation.
	553	*
	554	* Since we don't support interrupts/events the threshold values are
	555	* not important. We also don't touch trim values.
	556	*/
	557
	558	/* Reset ALS scaling bits */
35b651f3 CDL	559	ret = regmap_write(data->regmap, MAX44000_REG_CFG_RX,
	560	MAX44000_REG_CFG_RX_DEFAULT);
	561	if (ret < 0) {
	562	dev_err(&client->dev, "failed to write default CFG_RX: %d\n",
	563	ret);
	564	return ret;
	565	}
	566
	567	/*
	568	* By default the LED pulse used for the proximity sensor is disabled.
	569	* Set a middle value so that we get some sort of valid data by default.
	570	*/
	571	ret = max44000_write_led_current_raw(data, MAX44000_LED_CURRENT_DEFAULT);
b9567e66	572	if (ret < 0) {
35b651f3	573	dev_err(&client->dev, "failed to write init config: %d\n", ret);
b9567e66 CDL	574	return ret;
	575	}
	576
35b651f3 CDL	577	/* Reset CFG bits to ALS_PRX mode which allows easy reading of both values. */
35b651f3 CDL	578	reg = MAX44000_CFG_TRIM \| MAX44000_CFG_MODE_ALS_PRX;
b9567e66 CDL	579	ret = regmap_write(data->regmap, MAX44000_REG_CFG_MAIN, reg);
	580	if (ret < 0) {
	581	dev_err(&client->dev, "failed to write init config: %d\n", ret);
	582	return ret;
	583	}
	584
	585	/* Read status at least once to clear any stale interrupt bits. */
	586	ret = regmap_read(data->regmap, MAX44000_REG_STATUS, &reg);
	587	if (ret < 0) {
	588	dev_err(&client->dev, "failed to read init status: %d\n", ret);
	589	return ret;
	590	}
	591
06ad7ea1 CDL	592	ret = iio_triggered_buffer_setup(indio_dev, NULL, max44000_trigger_handler, NULL);
	593	if (ret < 0) {
	594	dev_err(&client->dev, "iio triggered buffer setup failed\n");
	595	return ret;
	596	}
	597
b9567e66 CDL	598	return iio_device_register(indio_dev);
	599	}
	600
	601	static int max44000_remove(struct i2c_client *client)
	602	{
	603	struct iio_dev *indio_dev = i2c_get_clientdata(client);
	604
	605	iio_device_unregister(indio_dev);
06ad7ea1	606	iio_triggered_buffer_cleanup(indio_dev);
b9567e66 CDL	607
	608	return 0;
	609	}
	610
	611	static const struct i2c_device_id max44000_id[] = {
	612	{"max44000", 0},
	613	{ }
	614	};
	615	MODULE_DEVICE_TABLE(i2c, max44000_id);
	616
	617	#ifdef CONFIG_ACPI
	618	static const struct acpi_device_id max44000_acpi_match[] = {
	619	{"MAX44000", 0},
	620	{ }
	621	};
	622	MODULE_DEVICE_TABLE(acpi, max44000_acpi_match);
	623	#endif
	624
	625	static struct i2c_driver max44000_driver = {
	626	.driver = {
	627	.name = MAX44000_DRV_NAME,
	628	.acpi_match_table = ACPI_PTR(max44000_acpi_match),
	629	},
	630	.probe = max44000_probe,
	631	.remove = max44000_remove,
	632	.id_table = max44000_id,
	633	};
	634
	635	module_i2c_driver(max44000_driver);
	636
	637	MODULE_AUTHOR("Crestez Dan Leonard <leonard.crestez@intel.com>");
	638	MODULE_DESCRIPTION("MAX44000 Ambient and Infrared Proximity Sensor");
	639	MODULE_LICENSE("GPL v2");