]>
Commit | Line | Data |
---|---|---|
74ba9207 | 1 | // SPDX-License-Identifier: GPL-2.0-or-later |
10b89ee3 MCC |
2 | /* |
3 | Driver for SAA6588 RDS decoder | |
4 | ||
5 | (c) 2005 Hans J. Koch | |
6 | ||
10b89ee3 MCC |
7 | */ |
8 | ||
9 | ||
10 | #include <linux/module.h> | |
11 | #include <linux/kernel.h> | |
12 | #include <linux/i2c.h> | |
13 | #include <linux/types.h> | |
7f6adeaf | 14 | #include <linux/videodev2.h> |
10b89ee3 MCC |
15 | #include <linux/init.h> |
16 | #include <linux/errno.h> | |
17 | #include <linux/slab.h> | |
18 | #include <linux/poll.h> | |
19 | #include <linux/wait.h> | |
7c0f6ba6 | 20 | #include <linux/uaccess.h> |
10b89ee3 | 21 | |
b5dcee22 | 22 | #include <media/i2c/saa6588.h> |
c3fda7f8 | 23 | #include <media/v4l2-device.h> |
10b89ee3 | 24 | |
10b89ee3 MCC |
25 | |
26 | /* insmod options */ | |
ff699e6b DSL |
27 | static unsigned int debug; |
28 | static unsigned int xtal; | |
3c86cf7a | 29 | static unsigned int mmbs; |
ff699e6b | 30 | static unsigned int plvl; |
10b89ee3 MCC |
31 | static unsigned int bufblocks = 100; |
32 | ||
9b565eb7 | 33 | module_param(debug, int, 0644); |
10b89ee3 | 34 | MODULE_PARM_DESC(debug, "enable debug messages"); |
9b565eb7 | 35 | module_param(xtal, int, 0); |
10b89ee3 | 36 | MODULE_PARM_DESC(xtal, "select oscillator frequency (0..3), default 0"); |
3c86cf7a HV |
37 | module_param(mmbs, int, 0); |
38 | MODULE_PARM_DESC(mmbs, "enable MMBS mode: 0=off (default), 1=on"); | |
9b565eb7 | 39 | module_param(plvl, int, 0); |
10b89ee3 | 40 | MODULE_PARM_DESC(plvl, "select pause level (0..3), default 0"); |
9b565eb7 | 41 | module_param(bufblocks, int, 0); |
10b89ee3 MCC |
42 | MODULE_PARM_DESC(bufblocks, "number of buffered blocks, default 100"); |
43 | ||
44 | MODULE_DESCRIPTION("v4l2 driver module for SAA6588 RDS decoder"); | |
45 | MODULE_AUTHOR("Hans J. Koch <koch@hjk-az.de>"); | |
46 | ||
47 | MODULE_LICENSE("GPL"); | |
48 | ||
49 | /* ---------------------------------------------------------------------- */ | |
50 | ||
51 | #define UNSET (-1U) | |
52 | #define PREFIX "saa6588: " | |
53 | #define dprintk if (debug) printk | |
54 | ||
55 | struct saa6588 { | |
c3fda7f8 | 56 | struct v4l2_subdev sd; |
fb6991d4 | 57 | struct delayed_work work; |
10b89ee3 MCC |
58 | spinlock_t lock; |
59 | unsigned char *buffer; | |
60 | unsigned int buf_size; | |
61 | unsigned int rd_index; | |
62 | unsigned int wr_index; | |
63 | unsigned int block_count; | |
64 | unsigned char last_blocknum; | |
65 | wait_queue_head_t read_queue; | |
66 | int data_available_for_read; | |
3c86cf7a | 67 | u8 sync; |
10b89ee3 MCC |
68 | }; |
69 | ||
c3fda7f8 HV |
70 | static inline struct saa6588 *to_saa6588(struct v4l2_subdev *sd) |
71 | { | |
72 | return container_of(sd, struct saa6588, sd); | |
73 | } | |
74 | ||
10b89ee3 MCC |
75 | /* ---------------------------------------------------------------------- */ |
76 | ||
77 | /* | |
78 | * SAA6588 defines | |
79 | */ | |
80 | ||
81 | /* Initialization and mode control byte (0w) */ | |
82 | ||
83 | /* bit 0+1 (DAC0/DAC1) */ | |
84 | #define cModeStandard 0x00 | |
85 | #define cModeFastPI 0x01 | |
86 | #define cModeReducedRequest 0x02 | |
87 | #define cModeInvalid 0x03 | |
88 | ||
89 | /* bit 2 (RBDS) */ | |
90 | #define cProcessingModeRDS 0x00 | |
91 | #define cProcessingModeRBDS 0x04 | |
92 | ||
93 | /* bit 3+4 (SYM0/SYM1) */ | |
94 | #define cErrCorrectionNone 0x00 | |
95 | #define cErrCorrection2Bits 0x08 | |
96 | #define cErrCorrection5Bits 0x10 | |
97 | #define cErrCorrectionNoneRBDS 0x18 | |
98 | ||
99 | /* bit 5 (NWSY) */ | |
100 | #define cSyncNormal 0x00 | |
101 | #define cSyncRestart 0x20 | |
102 | ||
103 | /* bit 6 (TSQD) */ | |
104 | #define cSigQualityDetectOFF 0x00 | |
105 | #define cSigQualityDetectON 0x40 | |
106 | ||
107 | /* bit 7 (SQCM) */ | |
108 | #define cSigQualityTriggered 0x00 | |
109 | #define cSigQualityContinous 0x80 | |
110 | ||
111 | /* Pause level and flywheel control byte (1w) */ | |
112 | ||
113 | /* bits 0..5 (FEB0..FEB5) */ | |
114 | #define cFlywheelMaxBlocksMask 0x3F | |
115 | #define cFlywheelDefault 0x20 | |
116 | ||
117 | /* bits 6+7 (PL0/PL1) */ | |
118 | #define cPauseLevel_11mV 0x00 | |
119 | #define cPauseLevel_17mV 0x40 | |
120 | #define cPauseLevel_27mV 0x80 | |
121 | #define cPauseLevel_43mV 0xC0 | |
122 | ||
123 | /* Pause time/oscillator frequency/quality detector control byte (1w) */ | |
124 | ||
125 | /* bits 0..4 (SQS0..SQS4) */ | |
126 | #define cQualityDetectSensMask 0x1F | |
127 | #define cQualityDetectDefault 0x0F | |
128 | ||
129 | /* bit 5 (SOSC) */ | |
130 | #define cSelectOscFreqOFF 0x00 | |
131 | #define cSelectOscFreqON 0x20 | |
132 | ||
133 | /* bit 6+7 (PTF0/PTF1) */ | |
134 | #define cOscFreq_4332kHz 0x00 | |
135 | #define cOscFreq_8664kHz 0x40 | |
136 | #define cOscFreq_12996kHz 0x80 | |
137 | #define cOscFreq_17328kHz 0xC0 | |
138 | ||
139 | /* ---------------------------------------------------------------------- */ | |
140 | ||
09092787 | 141 | static bool block_from_buf(struct saa6588 *s, unsigned char *buf) |
10b89ee3 MCC |
142 | { |
143 | int i; | |
144 | ||
145 | if (s->rd_index == s->wr_index) { | |
146 | if (debug > 2) | |
147 | dprintk(PREFIX "Read: buffer empty.\n"); | |
09092787 | 148 | return false; |
10b89ee3 MCC |
149 | } |
150 | ||
151 | if (debug > 2) { | |
152 | dprintk(PREFIX "Read: "); | |
153 | for (i = s->rd_index; i < s->rd_index + 3; i++) | |
154 | dprintk("0x%02x ", s->buffer[i]); | |
155 | } | |
156 | ||
09092787 | 157 | memcpy(buf, &s->buffer[s->rd_index], 3); |
10b89ee3 MCC |
158 | |
159 | s->rd_index += 3; | |
160 | if (s->rd_index >= s->buf_size) | |
161 | s->rd_index = 0; | |
162 | s->block_count--; | |
163 | ||
164 | if (debug > 2) | |
165 | dprintk("%d blocks total.\n", s->block_count); | |
166 | ||
09092787 | 167 | return true; |
10b89ee3 MCC |
168 | } |
169 | ||
b9218f2f | 170 | static void read_from_buf(struct saa6588 *s, struct saa6588_command *a) |
10b89ee3 | 171 | { |
ae8aed03 | 172 | unsigned char __user *buf_ptr = a->buffer; |
09092787 HV |
173 | unsigned char buf[3]; |
174 | unsigned long flags; | |
10b89ee3 | 175 | unsigned int rd_blocks; |
09092787 | 176 | unsigned int i; |
10b89ee3 MCC |
177 | |
178 | a->result = 0; | |
179 | if (!a->buffer) | |
180 | return; | |
181 | ||
09092787 | 182 | while (!a->nonblocking && !s->data_available_for_read) { |
10b89ee3 MCC |
183 | int ret = wait_event_interruptible(s->read_queue, |
184 | s->data_available_for_read); | |
185 | if (ret == -ERESTARTSYS) { | |
186 | a->result = -EINTR; | |
187 | return; | |
188 | } | |
189 | } | |
190 | ||
10b89ee3 | 191 | rd_blocks = a->block_count; |
09092787 | 192 | spin_lock_irqsave(&s->lock, flags); |
10b89ee3 MCC |
193 | if (rd_blocks > s->block_count) |
194 | rd_blocks = s->block_count; | |
09092787 | 195 | spin_unlock_irqrestore(&s->lock, flags); |
10b89ee3 | 196 | |
09092787 | 197 | if (!rd_blocks) |
10b89ee3 MCC |
198 | return; |
199 | ||
200 | for (i = 0; i < rd_blocks; i++) { | |
09092787 HV |
201 | bool got_block; |
202 | ||
203 | spin_lock_irqsave(&s->lock, flags); | |
204 | got_block = block_from_buf(s, buf); | |
205 | spin_unlock_irqrestore(&s->lock, flags); | |
206 | if (!got_block) | |
10b89ee3 | 207 | break; |
09092787 HV |
208 | if (copy_to_user(buf_ptr, buf, 3)) { |
209 | a->result = -EFAULT; | |
210 | return; | |
211 | } | |
212 | buf_ptr += 3; | |
213 | a->result += 3; | |
10b89ee3 | 214 | } |
09092787 | 215 | spin_lock_irqsave(&s->lock, flags); |
10b89ee3 MCC |
216 | s->data_available_for_read = (s->block_count > 0); |
217 | spin_unlock_irqrestore(&s->lock, flags); | |
218 | } | |
219 | ||
220 | static void block_to_buf(struct saa6588 *s, unsigned char *blockbuf) | |
221 | { | |
222 | unsigned int i; | |
223 | ||
224 | if (debug > 3) | |
225 | dprintk(PREFIX "New block: "); | |
226 | ||
227 | for (i = 0; i < 3; ++i) { | |
228 | if (debug > 3) | |
229 | dprintk("0x%02x ", blockbuf[i]); | |
230 | s->buffer[s->wr_index] = blockbuf[i]; | |
231 | s->wr_index++; | |
232 | } | |
233 | ||
234 | if (s->wr_index >= s->buf_size) | |
235 | s->wr_index = 0; | |
236 | ||
237 | if (s->wr_index == s->rd_index) { | |
6c3d67ab | 238 | s->rd_index += 3; |
10b89ee3 MCC |
239 | if (s->rd_index >= s->buf_size) |
240 | s->rd_index = 0; | |
241 | } else | |
242 | s->block_count++; | |
243 | ||
244 | if (debug > 3) | |
245 | dprintk("%d blocks total.\n", s->block_count); | |
246 | } | |
247 | ||
248 | static void saa6588_i2c_poll(struct saa6588 *s) | |
249 | { | |
c3fda7f8 | 250 | struct i2c_client *client = v4l2_get_subdevdata(&s->sd); |
10b89ee3 MCC |
251 | unsigned long flags; |
252 | unsigned char tmpbuf[6]; | |
253 | unsigned char blocknum; | |
254 | unsigned char tmp; | |
255 | ||
256 | /* Although we only need 3 bytes, we have to read at least 6. | |
3c86cf7a | 257 | SAA6588 returns garbage otherwise. */ |
c3fda7f8 | 258 | if (6 != i2c_master_recv(client, &tmpbuf[0], 6)) { |
10b89ee3 MCC |
259 | if (debug > 1) |
260 | dprintk(PREFIX "read error!\n"); | |
261 | return; | |
262 | } | |
263 | ||
3c86cf7a HV |
264 | s->sync = tmpbuf[0] & 0x10; |
265 | if (!s->sync) | |
266 | return; | |
10b89ee3 MCC |
267 | blocknum = tmpbuf[0] >> 5; |
268 | if (blocknum == s->last_blocknum) { | |
269 | if (debug > 3) | |
270 | dprintk("Saw block %d again.\n", blocknum); | |
271 | return; | |
272 | } | |
273 | ||
274 | s->last_blocknum = blocknum; | |
275 | ||
276 | /* | |
277 | Byte order according to v4l2 specification: | |
278 | ||
279 | Byte 0: Least Significant Byte of RDS Block | |
280 | Byte 1: Most Significant Byte of RDS Block | |
281 | Byte 2 Bit 7: Error bit. Indicates that an uncorrectable error | |
282 | occurred during reception of this block. | |
283 | Bit 6: Corrected bit. Indicates that an error was | |
284 | corrected for this data block. | |
3c86cf7a HV |
285 | Bits 5-3: Same as bits 0-2. |
286 | Bits 2-0: Block number. | |
10b89ee3 MCC |
287 | |
288 | SAA6588 byte order is Status-MSB-LSB, so we have to swap the | |
289 | first and the last of the 3 bytes block. | |
290 | */ | |
291 | ||
f47c183c | 292 | swap(tmpbuf[2], tmpbuf[0]); |
10b89ee3 | 293 | |
3c86cf7a HV |
294 | /* Map 'Invalid block E' to 'Invalid Block' */ |
295 | if (blocknum == 6) | |
296 | blocknum = V4L2_RDS_BLOCK_INVALID; | |
297 | /* And if are not in mmbs mode, then 'Block E' is also mapped | |
298 | to 'Invalid Block'. As far as I can tell MMBS is discontinued, | |
299 | and if there is ever a need to support E blocks, then please | |
300 | contact the linux-media mailinglist. */ | |
301 | else if (!mmbs && blocknum == 5) | |
302 | blocknum = V4L2_RDS_BLOCK_INVALID; | |
10b89ee3 MCC |
303 | tmp = blocknum; |
304 | tmp |= blocknum << 3; /* Received offset == Offset Name (OK ?) */ | |
305 | if ((tmpbuf[2] & 0x03) == 0x03) | |
3c86cf7a | 306 | tmp |= V4L2_RDS_BLOCK_ERROR; /* uncorrectable error */ |
10b89ee3 | 307 | else if ((tmpbuf[2] & 0x03) != 0x00) |
3c86cf7a | 308 | tmp |= V4L2_RDS_BLOCK_CORRECTED; /* corrected error */ |
10b89ee3 MCC |
309 | tmpbuf[2] = tmp; /* Is this enough ? Should we also check other bits ? */ |
310 | ||
311 | spin_lock_irqsave(&s->lock, flags); | |
312 | block_to_buf(s, tmpbuf); | |
313 | spin_unlock_irqrestore(&s->lock, flags); | |
314 | s->data_available_for_read = 1; | |
315 | wake_up_interruptible(&s->read_queue); | |
316 | } | |
317 | ||
c4028958 | 318 | static void saa6588_work(struct work_struct *work) |
10b89ee3 | 319 | { |
fb6991d4 | 320 | struct saa6588 *s = container_of(work, struct saa6588, work.work); |
10b89ee3 MCC |
321 | |
322 | saa6588_i2c_poll(s); | |
fb6991d4 | 323 | schedule_delayed_work(&s->work, msecs_to_jiffies(20)); |
10b89ee3 MCC |
324 | } |
325 | ||
3c86cf7a | 326 | static void saa6588_configure(struct saa6588 *s) |
10b89ee3 | 327 | { |
c3fda7f8 | 328 | struct i2c_client *client = v4l2_get_subdevdata(&s->sd); |
10b89ee3 MCC |
329 | unsigned char buf[3]; |
330 | int rc; | |
331 | ||
332 | buf[0] = cSyncRestart; | |
3c86cf7a | 333 | if (mmbs) |
10b89ee3 MCC |
334 | buf[0] |= cProcessingModeRBDS; |
335 | ||
336 | buf[1] = cFlywheelDefault; | |
337 | switch (plvl) { | |
338 | case 0: | |
339 | buf[1] |= cPauseLevel_11mV; | |
340 | break; | |
341 | case 1: | |
342 | buf[1] |= cPauseLevel_17mV; | |
343 | break; | |
344 | case 2: | |
345 | buf[1] |= cPauseLevel_27mV; | |
346 | break; | |
347 | case 3: | |
348 | buf[1] |= cPauseLevel_43mV; | |
349 | break; | |
350 | default: /* nothing */ | |
351 | break; | |
352 | } | |
353 | ||
354 | buf[2] = cQualityDetectDefault | cSelectOscFreqON; | |
355 | ||
356 | switch (xtal) { | |
357 | case 0: | |
358 | buf[2] |= cOscFreq_4332kHz; | |
359 | break; | |
360 | case 1: | |
361 | buf[2] |= cOscFreq_8664kHz; | |
362 | break; | |
363 | case 2: | |
364 | buf[2] |= cOscFreq_12996kHz; | |
365 | break; | |
366 | case 3: | |
367 | buf[2] |= cOscFreq_17328kHz; | |
368 | break; | |
369 | default: /* nothing */ | |
370 | break; | |
371 | } | |
372 | ||
373 | dprintk(PREFIX "writing: 0w=0x%02x 1w=0x%02x 2w=0x%02x\n", | |
374 | buf[0], buf[1], buf[2]); | |
375 | ||
c3fda7f8 | 376 | rc = i2c_master_send(client, buf, 3); |
b5ffc223 | 377 | if (rc != 3) |
10b89ee3 | 378 | printk(PREFIX "i2c i/o error: rc == %d (should be 3)\n", rc); |
10b89ee3 MCC |
379 | } |
380 | ||
381 | /* ---------------------------------------------------------------------- */ | |
382 | ||
c3fda7f8 HV |
383 | static long saa6588_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg) |
384 | { | |
385 | struct saa6588 *s = to_saa6588(sd); | |
b9218f2f | 386 | struct saa6588_command *a = arg; |
c3fda7f8 HV |
387 | |
388 | switch (cmd) { | |
c3fda7f8 | 389 | /* --- close() for /dev/radio --- */ |
b9218f2f | 390 | case SAA6588_CMD_CLOSE: |
c3fda7f8 HV |
391 | s->data_available_for_read = 1; |
392 | wake_up_interruptible(&s->read_queue); | |
af2c5deb | 393 | s->data_available_for_read = 0; |
c3fda7f8 HV |
394 | a->result = 0; |
395 | break; | |
396 | /* --- read() for /dev/radio --- */ | |
b9218f2f | 397 | case SAA6588_CMD_READ: |
c3fda7f8 HV |
398 | read_from_buf(s, a); |
399 | break; | |
400 | /* --- poll() for /dev/radio --- */ | |
b9218f2f | 401 | case SAA6588_CMD_POLL: |
37b3c6a6 | 402 | a->poll_mask = 0; |
09092787 | 403 | if (s->data_available_for_read) |
37b3c6a6 | 404 | a->poll_mask |= EPOLLIN | EPOLLRDNORM; |
c3fda7f8 HV |
405 | poll_wait(a->instance, &s->read_queue, a->event_list); |
406 | break; | |
407 | ||
408 | default: | |
409 | /* nothing */ | |
410 | return -ENOIOCTLCMD; | |
411 | } | |
412 | return 0; | |
413 | } | |
414 | ||
3c86cf7a HV |
415 | static int saa6588_g_tuner(struct v4l2_subdev *sd, struct v4l2_tuner *vt) |
416 | { | |
417 | struct saa6588 *s = to_saa6588(sd); | |
418 | ||
cb0ed222 | 419 | vt->capability |= V4L2_TUNER_CAP_RDS | V4L2_TUNER_CAP_RDS_BLOCK_IO; |
3c86cf7a HV |
420 | if (s->sync) |
421 | vt->rxsubchans |= V4L2_TUNER_SUB_RDS; | |
422 | return 0; | |
423 | } | |
424 | ||
2f73c7c5 | 425 | static int saa6588_s_tuner(struct v4l2_subdev *sd, const struct v4l2_tuner *vt) |
3c86cf7a HV |
426 | { |
427 | struct saa6588 *s = to_saa6588(sd); | |
428 | ||
429 | saa6588_configure(s); | |
430 | return 0; | |
431 | } | |
432 | ||
c3fda7f8 HV |
433 | /* ----------------------------------------------------------------------- */ |
434 | ||
435 | static const struct v4l2_subdev_core_ops saa6588_core_ops = { | |
436 | .ioctl = saa6588_ioctl, | |
437 | }; | |
438 | ||
3c86cf7a HV |
439 | static const struct v4l2_subdev_tuner_ops saa6588_tuner_ops = { |
440 | .g_tuner = saa6588_g_tuner, | |
441 | .s_tuner = saa6588_s_tuner, | |
442 | }; | |
443 | ||
c3fda7f8 HV |
444 | static const struct v4l2_subdev_ops saa6588_ops = { |
445 | .core = &saa6588_core_ops, | |
3c86cf7a | 446 | .tuner = &saa6588_tuner_ops, |
c3fda7f8 HV |
447 | }; |
448 | ||
449 | /* ---------------------------------------------------------------------- */ | |
450 | ||
b5ffc223 HV |
451 | static int saa6588_probe(struct i2c_client *client, |
452 | const struct i2c_device_id *id) | |
10b89ee3 MCC |
453 | { |
454 | struct saa6588 *s; | |
c3fda7f8 | 455 | struct v4l2_subdev *sd; |
10b89ee3 | 456 | |
b5ffc223 HV |
457 | v4l_info(client, "saa6588 found @ 0x%x (%s)\n", |
458 | client->addr << 1, client->adapter->name); | |
10b89ee3 | 459 | |
c02b211d | 460 | s = devm_kzalloc(&client->dev, sizeof(*s), GFP_KERNEL); |
b5ffc223 | 461 | if (s == NULL) |
10b89ee3 MCC |
462 | return -ENOMEM; |
463 | ||
464 | s->buf_size = bufblocks * 3; | |
465 | ||
c02b211d LP |
466 | s->buffer = devm_kzalloc(&client->dev, s->buf_size, GFP_KERNEL); |
467 | if (s->buffer == NULL) | |
10b89ee3 | 468 | return -ENOMEM; |
c3fda7f8 HV |
469 | sd = &s->sd; |
470 | v4l2_i2c_subdev_init(sd, client, &saa6588_ops); | |
588005e1 | 471 | spin_lock_init(&s->lock); |
10b89ee3 MCC |
472 | s->block_count = 0; |
473 | s->wr_index = 0; | |
474 | s->rd_index = 0; | |
475 | s->last_blocknum = 0xff; | |
476 | init_waitqueue_head(&s->read_queue); | |
477 | s->data_available_for_read = 0; | |
10b89ee3 MCC |
478 | |
479 | saa6588_configure(s); | |
480 | ||
481 | /* start polling via eventd */ | |
fb6991d4 JD |
482 | INIT_DELAYED_WORK(&s->work, saa6588_work); |
483 | schedule_delayed_work(&s->work, 0); | |
10b89ee3 MCC |
484 | return 0; |
485 | } | |
486 | ||
b5ffc223 | 487 | static int saa6588_remove(struct i2c_client *client) |
10b89ee3 | 488 | { |
c3fda7f8 HV |
489 | struct v4l2_subdev *sd = i2c_get_clientdata(client); |
490 | struct saa6588 *s = to_saa6588(sd); | |
491 | ||
492 | v4l2_device_unregister_subdev(sd); | |
10b89ee3 | 493 | |
fb6991d4 | 494 | cancel_delayed_work_sync(&s->work); |
10b89ee3 | 495 | |
10b89ee3 MCC |
496 | return 0; |
497 | } | |
498 | ||
10b89ee3 MCC |
499 | /* ----------------------------------------------------------------------- */ |
500 | ||
b5ffc223 HV |
501 | static const struct i2c_device_id saa6588_id[] = { |
502 | { "saa6588", 0 }, | |
503 | { } | |
10b89ee3 | 504 | }; |
b5ffc223 | 505 | MODULE_DEVICE_TABLE(i2c, saa6588_id); |
10b89ee3 | 506 | |
440d0516 HV |
507 | static struct i2c_driver saa6588_driver = { |
508 | .driver = { | |
440d0516 HV |
509 | .name = "saa6588", |
510 | }, | |
511 | .probe = saa6588_probe, | |
512 | .remove = saa6588_remove, | |
513 | .id_table = saa6588_id, | |
10b89ee3 | 514 | }; |
440d0516 | 515 | |
c6e8d86f | 516 | module_i2c_driver(saa6588_driver); |