]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/blame - drivers/mfd/tps6586x.c
Merge tag 'for-linus-4.15-rc8-tag' of git://git.kernel.org/pub/scm/linux/kernel/git...
[mirror_ubuntu-bionic-kernel.git] / drivers / mfd / tps6586x.c
CommitLineData
c6c19332
MR
1/*
2 * Core driver for TI TPS6586x PMIC family
3 *
4 * Copyright (c) 2010 CompuLab Ltd.
5 * Mike Rapoport <mike@compulab.co.il>
6 *
7 * Based on da903x.c.
8 * Copyright (C) 2008 Compulab, Ltd.
9 * Mike Rapoport <mike@compulab.co.il>
10 * Copyright (C) 2006-2008 Marvell International Ltd.
11 * Eric Miao <eric.miao@marvell.com>
12 *
13 * This program is free software; you can redistribute it and/or modify
14 * it under the terms of the GNU General Public License version 2 as
15 * published by the Free Software Foundation.
16 */
17
c26448c4
GK
18#include <linux/interrupt.h>
19#include <linux/irq.h>
605511a8 20#include <linux/irqdomain.h>
c6c19332
MR
21#include <linux/kernel.h>
22#include <linux/module.h>
23#include <linux/mutex.h>
24#include <linux/slab.h>
1176b5be 25#include <linux/err.h>
c6c19332 26#include <linux/i2c.h>
605511a8 27#include <linux/platform_device.h>
1176b5be 28#include <linux/regmap.h>
06bf3c2f 29#include <linux/of.h>
c6c19332
MR
30
31#include <linux/mfd/core.h>
32#include <linux/mfd/tps6586x.h>
33
004c15a6
BH
34#define TPS6586X_SUPPLYENE 0x14
35#define EXITSLREQ_BIT BIT(1)
36#define SLEEP_MODE_BIT BIT(3)
37
c26448c4
GK
38/* interrupt control registers */
39#define TPS6586X_INT_ACK1 0xb5
40#define TPS6586X_INT_ACK2 0xb6
41#define TPS6586X_INT_ACK3 0xb7
42#define TPS6586X_INT_ACK4 0xb8
43
44/* interrupt mask registers */
45#define TPS6586X_INT_MASK1 0xb0
46#define TPS6586X_INT_MASK2 0xb1
47#define TPS6586X_INT_MASK3 0xb2
48#define TPS6586X_INT_MASK4 0xb3
49#define TPS6586X_INT_MASK5 0xb4
50
c6c19332
MR
51/* device id */
52#define TPS6586X_VERSIONCRC 0xcd
c6c19332 53
1176b5be 54/* Maximum register */
088d862c 55#define TPS6586X_MAX_REGISTER TPS6586X_VERSIONCRC
1176b5be 56
c26448c4
GK
57struct tps6586x_irq_data {
58 u8 mask_reg;
59 u8 mask_mask;
60};
61
62#define TPS6586X_IRQ(_reg, _mask) \
63 { \
64 .mask_reg = (_reg) - TPS6586X_INT_MASK1, \
65 .mask_mask = (_mask), \
66 }
67
68static const struct tps6586x_irq_data tps6586x_irqs[] = {
69 [TPS6586X_INT_PLDO_0] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 0),
70 [TPS6586X_INT_PLDO_1] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 1),
71 [TPS6586X_INT_PLDO_2] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 2),
72 [TPS6586X_INT_PLDO_3] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 3),
73 [TPS6586X_INT_PLDO_4] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 4),
74 [TPS6586X_INT_PLDO_5] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 5),
75 [TPS6586X_INT_PLDO_6] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 6),
76 [TPS6586X_INT_PLDO_7] = TPS6586X_IRQ(TPS6586X_INT_MASK1, 1 << 7),
77 [TPS6586X_INT_COMP_DET] = TPS6586X_IRQ(TPS6586X_INT_MASK4, 1 << 0),
78 [TPS6586X_INT_ADC] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 1),
79 [TPS6586X_INT_PLDO_8] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 2),
80 [TPS6586X_INT_PLDO_9] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 3),
81 [TPS6586X_INT_PSM_0] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 4),
82 [TPS6586X_INT_PSM_1] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 5),
83 [TPS6586X_INT_PSM_2] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 6),
84 [TPS6586X_INT_PSM_3] = TPS6586X_IRQ(TPS6586X_INT_MASK2, 1 << 7),
85 [TPS6586X_INT_RTC_ALM1] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 1 << 4),
86 [TPS6586X_INT_ACUSB_OVP] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 0x03),
87 [TPS6586X_INT_USB_DET] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 1 << 2),
88 [TPS6586X_INT_AC_DET] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 1 << 3),
89 [TPS6586X_INT_BAT_DET] = TPS6586X_IRQ(TPS6586X_INT_MASK3, 1 << 0),
90 [TPS6586X_INT_CHG_STAT] = TPS6586X_IRQ(TPS6586X_INT_MASK4, 0xfc),
91 [TPS6586X_INT_CHG_TEMP] = TPS6586X_IRQ(TPS6586X_INT_MASK3, 0x06),
92 [TPS6586X_INT_PP] = TPS6586X_IRQ(TPS6586X_INT_MASK3, 0xf0),
93 [TPS6586X_INT_RESUME] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 1 << 5),
94 [TPS6586X_INT_LOW_SYS] = TPS6586X_IRQ(TPS6586X_INT_MASK5, 1 << 6),
95 [TPS6586X_INT_RTC_ALM2] = TPS6586X_IRQ(TPS6586X_INT_MASK4, 1 << 1),
96};
97
5b8b1fe2
LD
98static struct resource tps6586x_rtc_resources[] = {
99 {
100 .start = TPS6586X_INT_RTC_ALM1,
101 .end = TPS6586X_INT_RTC_ALM1,
102 .flags = IORESOURCE_IRQ,
103 },
104};
105
30fe2b5b 106static const struct mfd_cell tps6586x_cell[] = {
7a7487cb
LD
107 {
108 .name = "tps6586x-gpio",
109 },
64e48160 110 {
ec8da805 111 .name = "tps6586x-regulator",
64e48160 112 },
7a7487cb
LD
113 {
114 .name = "tps6586x-rtc",
5b8b1fe2
LD
115 .num_resources = ARRAY_SIZE(tps6586x_rtc_resources),
116 .resources = &tps6586x_rtc_resources[0],
7a7487cb
LD
117 },
118 {
119 .name = "tps6586x-onkey",
120 },
121};
122
c6c19332 123struct tps6586x {
c6c19332
MR
124 struct device *dev;
125 struct i2c_client *client;
1176b5be 126 struct regmap *regmap;
e0a3da80 127 int version;
c6c19332 128
234506ad 129 int irq;
c26448c4
GK
130 struct irq_chip irq_chip;
131 struct mutex irq_lock;
132 int irq_base;
133 u32 irq_en;
c26448c4 134 u8 mask_reg[5];
605511a8 135 struct irq_domain *irq_domain;
c6c19332
MR
136};
137
1176b5be 138static inline struct tps6586x *dev_to_tps6586x(struct device *dev)
c6c19332 139{
1176b5be 140 return i2c_get_clientdata(to_i2c_client(dev));
c6c19332
MR
141}
142
143int tps6586x_write(struct device *dev, int reg, uint8_t val)
144{
1176b5be
LD
145 struct tps6586x *tps6586x = dev_to_tps6586x(dev);
146
147 return regmap_write(tps6586x->regmap, reg, val);
c6c19332
MR
148}
149EXPORT_SYMBOL_GPL(tps6586x_write);
150
151int tps6586x_writes(struct device *dev, int reg, int len, uint8_t *val)
152{
1176b5be
LD
153 struct tps6586x *tps6586x = dev_to_tps6586x(dev);
154
155 return regmap_bulk_write(tps6586x->regmap, reg, val, len);
c6c19332
MR
156}
157EXPORT_SYMBOL_GPL(tps6586x_writes);
158
159int tps6586x_read(struct device *dev, int reg, uint8_t *val)
160{
1176b5be
LD
161 struct tps6586x *tps6586x = dev_to_tps6586x(dev);
162 unsigned int rval;
163 int ret;
164
165 ret = regmap_read(tps6586x->regmap, reg, &rval);
166 if (!ret)
167 *val = rval;
168 return ret;
c6c19332
MR
169}
170EXPORT_SYMBOL_GPL(tps6586x_read);
171
172int tps6586x_reads(struct device *dev, int reg, int len, uint8_t *val)
173{
1176b5be
LD
174 struct tps6586x *tps6586x = dev_to_tps6586x(dev);
175
176 return regmap_bulk_read(tps6586x->regmap, reg, val, len);
c6c19332
MR
177}
178EXPORT_SYMBOL_GPL(tps6586x_reads);
179
180int tps6586x_set_bits(struct device *dev, int reg, uint8_t bit_mask)
181{
1176b5be 182 struct tps6586x *tps6586x = dev_to_tps6586x(dev);
c6c19332 183
1176b5be 184 return regmap_update_bits(tps6586x->regmap, reg, bit_mask, bit_mask);
c6c19332
MR
185}
186EXPORT_SYMBOL_GPL(tps6586x_set_bits);
187
188int tps6586x_clr_bits(struct device *dev, int reg, uint8_t bit_mask)
189{
1176b5be 190 struct tps6586x *tps6586x = dev_to_tps6586x(dev);
c6c19332 191
1176b5be 192 return regmap_update_bits(tps6586x->regmap, reg, bit_mask, 0);
c6c19332
MR
193}
194EXPORT_SYMBOL_GPL(tps6586x_clr_bits);
195
196int tps6586x_update(struct device *dev, int reg, uint8_t val, uint8_t mask)
197{
1176b5be 198 struct tps6586x *tps6586x = dev_to_tps6586x(dev);
c6c19332 199
1176b5be 200 return regmap_update_bits(tps6586x->regmap, reg, mask, val);
c6c19332
MR
201}
202EXPORT_SYMBOL_GPL(tps6586x_update);
203
605511a8
LD
204int tps6586x_irq_get_virq(struct device *dev, int irq)
205{
206 struct tps6586x *tps6586x = dev_to_tps6586x(dev);
207
208 return irq_create_mapping(tps6586x->irq_domain, irq);
209}
210EXPORT_SYMBOL_GPL(tps6586x_irq_get_virq);
211
e0a3da80
SA
212int tps6586x_get_version(struct device *dev)
213{
214 struct tps6586x *tps6586x = dev_get_drvdata(dev);
215
216 return tps6586x->version;
217}
218EXPORT_SYMBOL_GPL(tps6586x_get_version);
219
c6c19332
MR
220static int __remove_subdev(struct device *dev, void *unused)
221{
222 platform_device_unregister(to_platform_device(dev));
223 return 0;
224}
225
226static int tps6586x_remove_subdevs(struct tps6586x *tps6586x)
227{
228 return device_for_each_child(tps6586x->dev, NULL, __remove_subdev);
229}
230
96e824bd 231static void tps6586x_irq_lock(struct irq_data *data)
c26448c4 232{
96e824bd 233 struct tps6586x *tps6586x = irq_data_get_irq_chip_data(data);
c26448c4
GK
234
235 mutex_lock(&tps6586x->irq_lock);
236}
237
96e824bd 238static void tps6586x_irq_enable(struct irq_data *irq_data)
c26448c4 239{
96e824bd 240 struct tps6586x *tps6586x = irq_data_get_irq_chip_data(irq_data);
605511a8 241 unsigned int __irq = irq_data->hwirq;
c26448c4
GK
242 const struct tps6586x_irq_data *data = &tps6586x_irqs[__irq];
243
244 tps6586x->mask_reg[data->mask_reg] &= ~data->mask_mask;
245 tps6586x->irq_en |= (1 << __irq);
246}
247
96e824bd 248static void tps6586x_irq_disable(struct irq_data *irq_data)
c26448c4 249{
96e824bd 250 struct tps6586x *tps6586x = irq_data_get_irq_chip_data(irq_data);
c26448c4 251
605511a8 252 unsigned int __irq = irq_data->hwirq;
c26448c4
GK
253 const struct tps6586x_irq_data *data = &tps6586x_irqs[__irq];
254
255 tps6586x->mask_reg[data->mask_reg] |= data->mask_mask;
256 tps6586x->irq_en &= ~(1 << __irq);
257}
258
96e824bd 259static void tps6586x_irq_sync_unlock(struct irq_data *data)
c26448c4 260{
96e824bd 261 struct tps6586x *tps6586x = irq_data_get_irq_chip_data(data);
c26448c4
GK
262 int i;
263
264 for (i = 0; i < ARRAY_SIZE(tps6586x->mask_reg); i++) {
75edd5af
LD
265 int ret;
266 ret = tps6586x_write(tps6586x->dev,
267 TPS6586X_INT_MASK1 + i,
268 tps6586x->mask_reg[i]);
269 WARN_ON(ret);
c26448c4
GK
270 }
271
272 mutex_unlock(&tps6586x->irq_lock);
273}
274
234506ad
SW
275#ifdef CONFIG_PM_SLEEP
276static int tps6586x_irq_set_wake(struct irq_data *irq_data, unsigned int on)
277{
278 struct tps6586x *tps6586x = irq_data_get_irq_chip_data(irq_data);
279 return irq_set_irq_wake(tps6586x->irq, on);
280}
281#else
282#define tps6586x_irq_set_wake NULL
283#endif
284
605511a8
LD
285static struct irq_chip tps6586x_irq_chip = {
286 .name = "tps6586x",
287 .irq_bus_lock = tps6586x_irq_lock,
288 .irq_bus_sync_unlock = tps6586x_irq_sync_unlock,
289 .irq_disable = tps6586x_irq_disable,
290 .irq_enable = tps6586x_irq_enable,
234506ad 291 .irq_set_wake = tps6586x_irq_set_wake,
605511a8
LD
292};
293
294static int tps6586x_irq_map(struct irq_domain *h, unsigned int virq,
295 irq_hw_number_t hw)
296{
297 struct tps6586x *tps6586x = h->host_data;
298
299 irq_set_chip_data(virq, tps6586x);
300 irq_set_chip_and_handler(virq, &tps6586x_irq_chip, handle_simple_irq);
301 irq_set_nested_thread(virq, 1);
605511a8 302 irq_set_noprobe(virq);
605511a8
LD
303
304 return 0;
305}
306
7ce7b26f 307static const struct irq_domain_ops tps6586x_domain_ops = {
605511a8
LD
308 .map = tps6586x_irq_map,
309 .xlate = irq_domain_xlate_twocell,
310};
311
c26448c4
GK
312static irqreturn_t tps6586x_irq(int irq, void *data)
313{
314 struct tps6586x *tps6586x = data;
315 u32 acks;
316 int ret = 0;
317
318 ret = tps6586x_reads(tps6586x->dev, TPS6586X_INT_ACK1,
319 sizeof(acks), (uint8_t *)&acks);
320
321 if (ret < 0) {
322 dev_err(tps6586x->dev, "failed to read interrupt status\n");
323 return IRQ_NONE;
324 }
325
326 acks = le32_to_cpu(acks);
327
328 while (acks) {
329 int i = __ffs(acks);
330
331 if (tps6586x->irq_en & (1 << i))
605511a8
LD
332 handle_nested_irq(
333 irq_find_mapping(tps6586x->irq_domain, i));
c26448c4
GK
334
335 acks &= ~(1 << i);
336 }
337
338 return IRQ_HANDLED;
339}
340
f791be49 341static int tps6586x_irq_init(struct tps6586x *tps6586x, int irq,
c26448c4
GK
342 int irq_base)
343{
344 int i, ret;
345 u8 tmp[4];
605511a8
LD
346 int new_irq_base;
347 int irq_num = ARRAY_SIZE(tps6586x_irqs);
c26448c4 348
234506ad
SW
349 tps6586x->irq = irq;
350
c26448c4
GK
351 mutex_init(&tps6586x->irq_lock);
352 for (i = 0; i < 5; i++) {
c26448c4
GK
353 tps6586x->mask_reg[i] = 0xff;
354 tps6586x_write(tps6586x->dev, TPS6586X_INT_MASK1 + i, 0xff);
355 }
356
357 tps6586x_reads(tps6586x->dev, TPS6586X_INT_ACK1, sizeof(tmp), tmp);
358
605511a8
LD
359 if (irq_base > 0) {
360 new_irq_base = irq_alloc_descs(irq_base, 0, irq_num, -1);
361 if (new_irq_base < 0) {
362 dev_err(tps6586x->dev,
363 "Failed to alloc IRQs: %d\n", new_irq_base);
364 return new_irq_base;
365 }
366 } else {
367 new_irq_base = 0;
c26448c4
GK
368 }
369
605511a8
LD
370 tps6586x->irq_domain = irq_domain_add_simple(tps6586x->dev->of_node,
371 irq_num, new_irq_base, &tps6586x_domain_ops,
372 tps6586x);
373 if (!tps6586x->irq_domain) {
374 dev_err(tps6586x->dev, "Failed to create IRQ domain\n");
375 return -ENOMEM;
376 }
c26448c4
GK
377 ret = request_threaded_irq(irq, NULL, tps6586x_irq, IRQF_ONESHOT,
378 "tps6586x", tps6586x);
379
234506ad 380 if (!ret)
c26448c4 381 device_init_wakeup(tps6586x->dev, 1);
c26448c4
GK
382
383 return ret;
384}
385
f791be49 386static int tps6586x_add_subdevs(struct tps6586x *tps6586x,
c6c19332
MR
387 struct tps6586x_platform_data *pdata)
388{
389 struct tps6586x_subdev_info *subdev;
390 struct platform_device *pdev;
391 int i, ret = 0;
392
393 for (i = 0; i < pdata->num_subdevs; i++) {
394 subdev = &pdata->subdevs[i];
395
396 pdev = platform_device_alloc(subdev->name, subdev->id);
929980ab
AL
397 if (!pdev) {
398 ret = -ENOMEM;
399 goto failed;
400 }
c6c19332
MR
401
402 pdev->dev.parent = tps6586x->dev;
403 pdev->dev.platform_data = subdev->platform_data;
62f6b087 404 pdev->dev.of_node = subdev->of_node;
c6c19332
MR
405
406 ret = platform_device_add(pdev);
929980ab
AL
407 if (ret) {
408 platform_device_put(pdev);
c6c19332 409 goto failed;
929980ab 410 }
c6c19332
MR
411 }
412 return 0;
413
414failed:
415 tps6586x_remove_subdevs(tps6586x);
416 return ret;
417}
418
62f6b087 419#ifdef CONFIG_OF
62f6b087
TR
420static struct tps6586x_platform_data *tps6586x_parse_dt(struct i2c_client *client)
421{
62f6b087
TR
422 struct device_node *np = client->dev.of_node;
423 struct tps6586x_platform_data *pdata;
62f6b087
TR
424
425 pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);
64e48160
LD
426 if (!pdata) {
427 dev_err(&client->dev, "Memory allocation failed\n");
62f6b087 428 return NULL;
64e48160 429 }
62f6b087 430
64e48160
LD
431 pdata->num_subdevs = 0;
432 pdata->subdevs = NULL;
62f6b087
TR
433 pdata->gpio_base = -1;
434 pdata->irq_base = -1;
004c15a6 435 pdata->pm_off = of_property_read_bool(np, "ti,system-power-controller");
62f6b087
TR
436
437 return pdata;
438}
439
a58cc84c 440static const struct of_device_id tps6586x_of_match[] = {
62f6b087
TR
441 { .compatible = "ti,tps6586x", },
442 { },
443};
444#else
445static struct tps6586x_platform_data *tps6586x_parse_dt(struct i2c_client *client)
446{
447 return NULL;
448}
449#endif
450
75edd5af
LD
451static bool is_volatile_reg(struct device *dev, unsigned int reg)
452{
453 /* Cache all interrupt mask register */
454 if ((reg >= TPS6586X_INT_MASK1) && (reg <= TPS6586X_INT_MASK5))
455 return false;
456
457 return true;
458}
459
1176b5be
LD
460static const struct regmap_config tps6586x_regmap_config = {
461 .reg_bits = 8,
462 .val_bits = 8,
088d862c 463 .max_register = TPS6586X_MAX_REGISTER,
75edd5af
LD
464 .volatile_reg = is_volatile_reg,
465 .cache_type = REGCACHE_RBTREE,
1176b5be
LD
466};
467
004c15a6
BH
468static struct device *tps6586x_dev;
469static void tps6586x_power_off(void)
470{
471 if (tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT))
472 return;
473
474 tps6586x_set_bits(tps6586x_dev, TPS6586X_SUPPLYENE, SLEEP_MODE_BIT);
475}
476
e0a3da80
SA
477static void tps6586x_print_version(struct i2c_client *client, int version)
478{
479 const char *name;
480
481 switch (version) {
482 case TPS658621A:
483 name = "TPS658621A";
484 break;
485 case TPS658621CD:
486 name = "TPS658621C/D";
487 break;
488 case TPS658623:
489 name = "TPS658623";
490 break;
6c46ccc8
AB
491 case TPS658640:
492 case TPS658640v2:
493 name = "TPS658640";
494 break;
e0a3da80
SA
495 case TPS658643:
496 name = "TPS658643";
497 break;
498 default:
499 name = "TPS6586X";
500 break;
501 }
502
503 dev_info(&client->dev, "Found %s, VERSIONCRC is %02x\n", name, version);
504}
505
f791be49 506static int tps6586x_i2c_probe(struct i2c_client *client,
c6c19332
MR
507 const struct i2c_device_id *id)
508{
334a41ce 509 struct tps6586x_platform_data *pdata = dev_get_platdata(&client->dev);
c6c19332
MR
510 struct tps6586x *tps6586x;
511 int ret;
e0a3da80 512 int version;
c6c19332 513
62f6b087
TR
514 if (!pdata && client->dev.of_node)
515 pdata = tps6586x_parse_dt(client);
516
c6c19332
MR
517 if (!pdata) {
518 dev_err(&client->dev, "tps6586x requires platform data\n");
519 return -ENOTSUPP;
520 }
521
e0a3da80
SA
522 version = i2c_smbus_read_byte_data(client, TPS6586X_VERSIONCRC);
523 if (version < 0) {
524 dev_err(&client->dev, "Chip ID read failed: %d\n", version);
c6c19332
MR
525 return -EIO;
526 }
527
b6719412 528 tps6586x = devm_kzalloc(&client->dev, sizeof(*tps6586x), GFP_KERNEL);
e0a3da80 529 if (!tps6586x)
c6c19332 530 return -ENOMEM;
e0a3da80
SA
531
532 tps6586x->version = version;
533 tps6586x_print_version(client, tps6586x->version);
c6c19332
MR
534
535 tps6586x->client = client;
536 tps6586x->dev = &client->dev;
537 i2c_set_clientdata(client, tps6586x);
538
1176b5be
LD
539 tps6586x->regmap = devm_regmap_init_i2c(client,
540 &tps6586x_regmap_config);
541 if (IS_ERR(tps6586x->regmap)) {
542 ret = PTR_ERR(tps6586x->regmap);
543 dev_err(&client->dev, "regmap init failed: %d\n", ret);
544 return ret;
545 }
546
c6c19332 547
c26448c4
GK
548 if (client->irq) {
549 ret = tps6586x_irq_init(tps6586x, client->irq,
550 pdata->irq_base);
551 if (ret) {
552 dev_err(&client->dev, "IRQ init failed: %d\n", ret);
b6719412 553 return ret;
c26448c4
GK
554 }
555 }
556
7a7487cb 557 ret = mfd_add_devices(tps6586x->dev, -1,
0848c94f 558 tps6586x_cell, ARRAY_SIZE(tps6586x_cell),
5b8b1fe2 559 NULL, 0, tps6586x->irq_domain);
7a7487cb
LD
560 if (ret < 0) {
561 dev_err(&client->dev, "mfd_add_devices failed: %d\n", ret);
562 goto err_mfd_add;
6f9f13bf
VP
563 }
564
c6c19332
MR
565 ret = tps6586x_add_subdevs(tps6586x, pdata);
566 if (ret) {
567 dev_err(&client->dev, "add devices failed: %d\n", ret);
568 goto err_add_devs;
569 }
570
004c15a6
BH
571 if (pdata->pm_off && !pm_power_off) {
572 tps6586x_dev = &client->dev;
573 pm_power_off = tps6586x_power_off;
574 }
575
c6c19332
MR
576 return 0;
577
578err_add_devs:
7a7487cb
LD
579 mfd_remove_devices(tps6586x->dev);
580err_mfd_add:
c26448c4
GK
581 if (client->irq)
582 free_irq(client->irq, tps6586x);
c6c19332
MR
583 return ret;
584}
585
4740f73f 586static int tps6586x_i2c_remove(struct i2c_client *client)
c6c19332 587{
4b751cf5 588 struct tps6586x *tps6586x = i2c_get_clientdata(client);
4b751cf5 589
7a7487cb
LD
590 tps6586x_remove_subdevs(tps6586x);
591 mfd_remove_devices(tps6586x->dev);
c26448c4
GK
592 if (client->irq)
593 free_irq(client->irq, tps6586x);
c6c19332
MR
594 return 0;
595}
596
597static const struct i2c_device_id tps6586x_id_table[] = {
598 { "tps6586x", 0 },
599 { },
600};
601MODULE_DEVICE_TABLE(i2c, tps6586x_id_table);
602
603static struct i2c_driver tps6586x_driver = {
604 .driver = {
605 .name = "tps6586x",
62f6b087 606 .of_match_table = of_match_ptr(tps6586x_of_match),
c6c19332
MR
607 },
608 .probe = tps6586x_i2c_probe,
84449216 609 .remove = tps6586x_i2c_remove,
c6c19332
MR
610 .id_table = tps6586x_id_table,
611};
612
613static int __init tps6586x_init(void)
614{
615 return i2c_add_driver(&tps6586x_driver);
616}
617subsys_initcall(tps6586x_init);
618
619static void __exit tps6586x_exit(void)
620{
621 i2c_del_driver(&tps6586x_driver);
622}
623module_exit(tps6586x_exit);
624
625MODULE_DESCRIPTION("TPS6586X core driver");
626MODULE_AUTHOR("Mike Rapoport <mike@compulab.co.il>");
627MODULE_LICENSE("GPL");