]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/blame - drivers/nvdimm/pmem.c
libnvdimm, pmem: fix kmap_atomic() leak in error path
[mirror_ubuntu-jammy-kernel.git] / drivers / nvdimm / pmem.c
CommitLineData
9e853f23
RZ
1/*
2 * Persistent Memory Driver
3 *
9f53f9fa 4 * Copyright (c) 2014-2015, Intel Corporation.
9e853f23
RZ
5 * Copyright (c) 2015, Christoph Hellwig <hch@lst.de>.
6 * Copyright (c) 2015, Boaz Harrosh <boaz@plexistor.com>.
7 *
8 * This program is free software; you can redistribute it and/or modify it
9 * under the terms and conditions of the GNU General Public License,
10 * version 2, as published by the Free Software Foundation.
11 *
12 * This program is distributed in the hope it will be useful, but WITHOUT
13 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
14 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
15 * more details.
16 */
17
18#include <asm/cacheflush.h>
19#include <linux/blkdev.h>
20#include <linux/hdreg.h>
21#include <linux/init.h>
22#include <linux/platform_device.h>
23#include <linux/module.h>
24#include <linux/moduleparam.h>
b95f5f43 25#include <linux/badblocks.h>
9476df7d 26#include <linux/memremap.h>
32ab0a3f 27#include <linux/vmalloc.h>
34c0fd54 28#include <linux/pfn_t.h>
9e853f23 29#include <linux/slab.h>
61031952 30#include <linux/pmem.h>
9f53f9fa 31#include <linux/nd.h>
32ab0a3f 32#include "pfn.h"
9f53f9fa 33#include "nd.h"
9e853f23
RZ
34
35struct pmem_device {
36 struct request_queue *pmem_queue;
37 struct gendisk *pmem_disk;
32ab0a3f 38 struct nd_namespace_common *ndns;
9e853f23
RZ
39
40 /* One contiguous memory region per device */
41 phys_addr_t phys_addr;
32ab0a3f
DW
42 /* when non-zero this device is hosting a 'pfn' instance */
43 phys_addr_t data_offset;
c4544205 44 u64 pfn_flags;
61031952 45 void __pmem *virt_addr;
9e853f23 46 size_t size;
b95f5f43 47 struct badblocks bb;
9e853f23
RZ
48};
49
50static int pmem_major;
9e853f23 51
e10624f8
DW
52static bool is_bad_pmem(struct badblocks *bb, sector_t sector, unsigned int len)
53{
54 if (bb->count) {
55 sector_t first_bad;
56 int num_bad;
57
58 return !!badblocks_check(bb, sector, len / 512, &first_bad,
59 &num_bad);
60 }
61
62 return false;
63}
64
65static int pmem_do_bvec(struct pmem_device *pmem, struct page *page,
9e853f23
RZ
66 unsigned int len, unsigned int off, int rw,
67 sector_t sector)
68{
b5ebc8ec 69 int rc = 0;
9e853f23 70 void *mem = kmap_atomic(page);
32ab0a3f 71 phys_addr_t pmem_off = sector * 512 + pmem->data_offset;
61031952 72 void __pmem *pmem_addr = pmem->virt_addr + pmem_off;
9e853f23
RZ
73
74 if (rw == READ) {
e10624f8 75 if (unlikely(is_bad_pmem(&pmem->bb, sector, len)))
b5ebc8ec
DW
76 rc = -EIO;
77 else {
78 memcpy_from_pmem(mem + off, pmem_addr, len);
79 flush_dcache_page(page);
80 }
9e853f23
RZ
81 } else {
82 flush_dcache_page(page);
61031952 83 memcpy_to_pmem(pmem_addr, mem + off, len);
9e853f23
RZ
84 }
85
86 kunmap_atomic(mem);
b5ebc8ec 87 return rc;
9e853f23
RZ
88}
89
dece1635 90static blk_qc_t pmem_make_request(struct request_queue *q, struct bio *bio)
9e853f23 91{
e10624f8 92 int rc = 0;
f0dc089c
DW
93 bool do_acct;
94 unsigned long start;
9e853f23 95 struct bio_vec bvec;
9e853f23 96 struct bvec_iter iter;
edc870e5
DW
97 struct block_device *bdev = bio->bi_bdev;
98 struct pmem_device *pmem = bdev->bd_disk->private_data;
9e853f23 99
f0dc089c 100 do_acct = nd_iostat_start(bio, &start);
e10624f8
DW
101 bio_for_each_segment(bvec, bio, iter) {
102 rc = pmem_do_bvec(pmem, bvec.bv_page, bvec.bv_len,
103 bvec.bv_offset, bio_data_dir(bio),
104 iter.bi_sector);
105 if (rc) {
106 bio->bi_error = rc;
107 break;
108 }
109 }
f0dc089c
DW
110 if (do_acct)
111 nd_iostat_end(bio, start);
61031952
RZ
112
113 if (bio_data_dir(bio))
114 wmb_pmem();
115
4246a0b6 116 bio_endio(bio);
dece1635 117 return BLK_QC_T_NONE;
9e853f23
RZ
118}
119
120static int pmem_rw_page(struct block_device *bdev, sector_t sector,
121 struct page *page, int rw)
122{
123 struct pmem_device *pmem = bdev->bd_disk->private_data;
e10624f8 124 int rc;
9e853f23 125
e10624f8 126 rc = pmem_do_bvec(pmem, page, PAGE_CACHE_SIZE, 0, rw, sector);
ba8fe0f8
RZ
127 if (rw & WRITE)
128 wmb_pmem();
9e853f23 129
e10624f8
DW
130 /*
131 * The ->rw_page interface is subtle and tricky. The core
132 * retries on any error, so we can only invoke page_endio() in
133 * the successful completion case. Otherwise, we'll see crashes
134 * caused by double completion.
135 */
136 if (rc == 0)
137 page_endio(page, rw & WRITE, 0);
138
139 return rc;
9e853f23
RZ
140}
141
142static long pmem_direct_access(struct block_device *bdev, sector_t sector,
34c0fd54 143 void __pmem **kaddr, pfn_t *pfn)
9e853f23
RZ
144{
145 struct pmem_device *pmem = bdev->bd_disk->private_data;
32ab0a3f 146 resource_size_t offset = sector * 512 + pmem->data_offset;
589e75d1 147
e2e05394 148 *kaddr = pmem->virt_addr + offset;
34c0fd54 149 *pfn = phys_to_pfn_t(pmem->phys_addr + offset, pmem->pfn_flags);
9e853f23 150
589e75d1 151 return pmem->size - offset;
9e853f23
RZ
152}
153
154static const struct block_device_operations pmem_fops = {
155 .owner = THIS_MODULE,
156 .rw_page = pmem_rw_page,
157 .direct_access = pmem_direct_access,
58138820 158 .revalidate_disk = nvdimm_revalidate_disk,
9e853f23
RZ
159};
160
9f53f9fa
DW
161static struct pmem_device *pmem_alloc(struct device *dev,
162 struct resource *res, int id)
9e853f23
RZ
163{
164 struct pmem_device *pmem;
468ded03 165 struct request_queue *q;
9e853f23 166
708ab62b 167 pmem = devm_kzalloc(dev, sizeof(*pmem), GFP_KERNEL);
9e853f23 168 if (!pmem)
8c2f7e86 169 return ERR_PTR(-ENOMEM);
9e853f23
RZ
170
171 pmem->phys_addr = res->start;
172 pmem->size = resource_size(res);
96601adb 173 if (!arch_has_wmb_pmem())
61031952 174 dev_warn(dev, "unable to guarantee persistence of writes\n");
9e853f23 175
708ab62b
CH
176 if (!devm_request_mem_region(dev, pmem->phys_addr, pmem->size,
177 dev_name(dev))) {
9f53f9fa
DW
178 dev_warn(dev, "could not reserve region [0x%pa:0x%zx]\n",
179 &pmem->phys_addr, pmem->size);
8c2f7e86 180 return ERR_PTR(-EBUSY);
9e853f23
RZ
181 }
182
468ded03
DW
183 q = blk_alloc_queue_node(GFP_KERNEL, dev_to_node(dev));
184 if (!q)
185 return ERR_PTR(-ENOMEM);
186
34c0fd54
DW
187 pmem->pfn_flags = PFN_DEV;
188 if (pmem_should_map_pages(dev)) {
4b94ffdc 189 pmem->virt_addr = (void __pmem *) devm_memremap_pages(dev, res,
5c2c2587 190 &q->q_usage_counter, NULL);
34c0fd54
DW
191 pmem->pfn_flags |= PFN_MAP;
192 } else
a639315d
DW
193 pmem->virt_addr = (void __pmem *) devm_memremap(dev,
194 pmem->phys_addr, pmem->size,
195 ARCH_MEMREMAP_PMEM);
b36f4761 196
468ded03
DW
197 if (IS_ERR(pmem->virt_addr)) {
198 blk_cleanup_queue(q);
b36f4761 199 return (void __force *) pmem->virt_addr;
468ded03 200 }
8c2f7e86 201
468ded03 202 pmem->pmem_queue = q;
8c2f7e86
DW
203 return pmem;
204}
205
206static void pmem_detach_disk(struct pmem_device *pmem)
207{
32ab0a3f
DW
208 if (!pmem->pmem_disk)
209 return;
210
8c2f7e86
DW
211 del_gendisk(pmem->pmem_disk);
212 put_disk(pmem->pmem_disk);
213 blk_cleanup_queue(pmem->pmem_queue);
214}
215
32ab0a3f
DW
216static int pmem_attach_disk(struct device *dev,
217 struct nd_namespace_common *ndns, struct pmem_device *pmem)
8c2f7e86 218{
538ea4aa 219 int nid = dev_to_node(dev);
8c2f7e86 220 struct gendisk *disk;
9e853f23 221
9e853f23 222 blk_queue_make_request(pmem->pmem_queue, pmem_make_request);
6b47496a 223 blk_queue_physical_block_size(pmem->pmem_queue, PAGE_SIZE);
43d3fa3a 224 blk_queue_max_hw_sectors(pmem->pmem_queue, UINT_MAX);
9e853f23 225 blk_queue_bounce_limit(pmem->pmem_queue, BLK_BOUNCE_ANY);
0f51c4fa 226 queue_flag_set_unlocked(QUEUE_FLAG_NONROT, pmem->pmem_queue);
9e853f23 227
538ea4aa 228 disk = alloc_disk_node(0, nid);
8c2f7e86
DW
229 if (!disk) {
230 blk_cleanup_queue(pmem->pmem_queue);
231 return -ENOMEM;
232 }
9e853f23 233
9e853f23 234 disk->major = pmem_major;
9f53f9fa 235 disk->first_minor = 0;
9e853f23
RZ
236 disk->fops = &pmem_fops;
237 disk->private_data = pmem;
238 disk->queue = pmem->pmem_queue;
239 disk->flags = GENHD_FL_EXT_DEVT;
5212e11f 240 nvdimm_namespace_disk_name(ndns, disk->disk_name);
32ab0a3f
DW
241 disk->driverfs_dev = dev;
242 set_capacity(disk, (pmem->size - pmem->data_offset) / 512);
9e853f23 243 pmem->pmem_disk = disk;
710d69cc 244 devm_exit_badblocks(dev, &pmem->bb);
b95f5f43
DW
245 if (devm_init_badblocks(dev, &pmem->bb))
246 return -ENOMEM;
247 nvdimm_namespace_add_poison(ndns, &pmem->bb, pmem->data_offset);
9e853f23 248
57f7f317 249 disk->bb = &pmem->bb;
9e853f23 250 add_disk(disk);
58138820 251 revalidate_disk(disk);
9e853f23 252
8c2f7e86
DW
253 return 0;
254}
9e853f23 255
8c2f7e86
DW
256static int pmem_rw_bytes(struct nd_namespace_common *ndns,
257 resource_size_t offset, void *buf, size_t size, int rw)
258{
259 struct pmem_device *pmem = dev_get_drvdata(ndns->claim);
260
261 if (unlikely(offset + size > pmem->size)) {
262 dev_WARN_ONCE(&ndns->dev, 1, "request out of range\n");
263 return -EFAULT;
264 }
265
710d69cc
DW
266 if (rw == READ) {
267 unsigned int sz_align = ALIGN(size + (offset & (512 - 1)), 512);
268
269 if (unlikely(is_bad_pmem(&pmem->bb, offset / 512, sz_align)))
270 return -EIO;
61031952 271 memcpy_from_pmem(buf, pmem->virt_addr + offset, size);
710d69cc 272 } else {
61031952
RZ
273 memcpy_to_pmem(pmem->virt_addr + offset, buf, size);
274 wmb_pmem();
275 }
8c2f7e86
DW
276
277 return 0;
278}
279
32ab0a3f
DW
280static int nd_pfn_init(struct nd_pfn *nd_pfn)
281{
282 struct nd_pfn_sb *pfn_sb = kzalloc(sizeof(*pfn_sb), GFP_KERNEL);
283 struct pmem_device *pmem = dev_get_drvdata(&nd_pfn->dev);
284 struct nd_namespace_common *ndns = nd_pfn->ndns;
285 struct nd_region *nd_region;
286 unsigned long npfns;
287 phys_addr_t offset;
288 u64 checksum;
289 int rc;
290
291 if (!pfn_sb)
292 return -ENOMEM;
293
294 nd_pfn->pfn_sb = pfn_sb;
295 rc = nd_pfn_validate(nd_pfn);
3fa96268
DW
296 if (rc == -ENODEV)
297 /* no info block, do init */;
298 else
32ab0a3f
DW
299 return rc;
300
32ab0a3f
DW
301 nd_region = to_nd_region(nd_pfn->dev.parent);
302 if (nd_region->ro) {
303 dev_info(&nd_pfn->dev,
304 "%s is read-only, unable to init metadata\n",
305 dev_name(&nd_region->dev));
306 goto err;
307 }
308
309 memset(pfn_sb, 0, sizeof(*pfn_sb));
310 npfns = (pmem->size - SZ_8K) / SZ_4K;
311 /*
312 * Note, we use 64 here for the standard size of struct page,
313 * debugging options may cause it to be larger in which case the
314 * implementation will limit the pfns advertised through
315 * ->direct_access() to those that are included in the memmap.
316 */
317 if (nd_pfn->mode == PFN_MODE_PMEM)
315c5625 318 offset = ALIGN(SZ_8K + 64 * npfns, nd_pfn->align);
32ab0a3f 319 else if (nd_pfn->mode == PFN_MODE_RAM)
315c5625 320 offset = ALIGN(SZ_8K, nd_pfn->align);
32ab0a3f
DW
321 else
322 goto err;
323
324 npfns = (pmem->size - offset) / SZ_4K;
325 pfn_sb->mode = cpu_to_le32(nd_pfn->mode);
326 pfn_sb->dataoff = cpu_to_le64(offset);
327 pfn_sb->npfns = cpu_to_le64(npfns);
328 memcpy(pfn_sb->signature, PFN_SIG, PFN_SIG_LEN);
329 memcpy(pfn_sb->uuid, nd_pfn->uuid, 16);
a34d5e8a 330 memcpy(pfn_sb->parent_uuid, nd_dev_to_uuid(&ndns->dev), 16);
32ab0a3f
DW
331 pfn_sb->version_major = cpu_to_le16(1);
332 checksum = nd_sb_checksum((struct nd_gen_sb *) pfn_sb);
333 pfn_sb->checksum = cpu_to_le64(checksum);
334
335 rc = nvdimm_write_bytes(ndns, SZ_4K, pfn_sb, sizeof(*pfn_sb));
336 if (rc)
337 goto err;
338
339 return 0;
340 err:
341 nd_pfn->pfn_sb = NULL;
342 kfree(pfn_sb);
343 return -ENXIO;
344}
345
346static int nvdimm_namespace_detach_pfn(struct nd_namespace_common *ndns)
347{
348 struct nd_pfn *nd_pfn = to_nd_pfn(ndns->claim);
349 struct pmem_device *pmem;
350
351 /* free pmem disk */
352 pmem = dev_get_drvdata(&nd_pfn->dev);
353 pmem_detach_disk(pmem);
354
355 /* release nd_pfn resources */
356 kfree(nd_pfn->pfn_sb);
357 nd_pfn->pfn_sb = NULL;
358
359 return 0;
360}
361
362static int nvdimm_namespace_attach_pfn(struct nd_namespace_common *ndns)
9e853f23 363{
32ab0a3f
DW
364 struct nd_namespace_io *nsio = to_nd_namespace_io(&ndns->dev);
365 struct nd_pfn *nd_pfn = to_nd_pfn(ndns->claim);
366 struct device *dev = &nd_pfn->dev;
32ab0a3f 367 struct nd_region *nd_region;
d2c0f041 368 struct vmem_altmap *altmap;
32ab0a3f
DW
369 struct nd_pfn_sb *pfn_sb;
370 struct pmem_device *pmem;
5c2c2587 371 struct request_queue *q;
32ab0a3f
DW
372 phys_addr_t offset;
373 int rc;
d2c0f041
DW
374 struct vmem_altmap __altmap = {
375 .base_pfn = __phys_to_pfn(nsio->res.start),
376 .reserve = __phys_to_pfn(SZ_8K),
377 };
32ab0a3f
DW
378
379 if (!nd_pfn->uuid || !nd_pfn->ndns)
380 return -ENODEV;
381
382 nd_region = to_nd_region(dev->parent);
383 rc = nd_pfn_init(nd_pfn);
384 if (rc)
385 return rc;
386
32ab0a3f
DW
387 pfn_sb = nd_pfn->pfn_sb;
388 offset = le64_to_cpu(pfn_sb->dataoff);
389 nd_pfn->mode = le32_to_cpu(nd_pfn->pfn_sb->mode);
390 if (nd_pfn->mode == PFN_MODE_RAM) {
315c5625 391 if (offset < SZ_8K)
32ab0a3f
DW
392 return -EINVAL;
393 nd_pfn->npfns = le64_to_cpu(pfn_sb->npfns);
394 altmap = NULL;
d2c0f041
DW
395 } else if (nd_pfn->mode == PFN_MODE_PMEM) {
396 nd_pfn->npfns = (resource_size(&nsio->res) - offset)
397 / PAGE_SIZE;
398 if (le64_to_cpu(nd_pfn->pfn_sb->npfns) > nd_pfn->npfns)
399 dev_info(&nd_pfn->dev,
400 "number of pfns truncated from %lld to %ld\n",
401 le64_to_cpu(nd_pfn->pfn_sb->npfns),
402 nd_pfn->npfns);
403 altmap = & __altmap;
404 altmap->free = __phys_to_pfn(offset - SZ_8K);
405 altmap->alloc = 0;
32ab0a3f
DW
406 } else {
407 rc = -ENXIO;
408 goto err;
409 }
410
411 /* establish pfn range for lookup, and switch to direct map */
412 pmem = dev_get_drvdata(dev);
5c2c2587 413 q = pmem->pmem_queue;
a639315d 414 devm_memunmap(dev, (void __force *) pmem->virt_addr);
4b94ffdc 415 pmem->virt_addr = (void __pmem *) devm_memremap_pages(dev, &nsio->res,
5c2c2587 416 &q->q_usage_counter, altmap);
34c0fd54 417 pmem->pfn_flags |= PFN_MAP;
32ab0a3f
DW
418 if (IS_ERR(pmem->virt_addr)) {
419 rc = PTR_ERR(pmem->virt_addr);
420 goto err;
421 }
422
423 /* attach pmem disk in "pfn-mode" */
424 pmem->data_offset = offset;
425 rc = pmem_attach_disk(dev, ndns, pmem);
426 if (rc)
427 goto err;
428
429 return rc;
430 err:
431 nvdimm_namespace_detach_pfn(ndns);
432 return rc;
9e853f23
RZ
433}
434
9f53f9fa 435static int nd_pmem_probe(struct device *dev)
9e853f23 436{
9f53f9fa 437 struct nd_region *nd_region = to_nd_region(dev->parent);
8c2f7e86
DW
438 struct nd_namespace_common *ndns;
439 struct nd_namespace_io *nsio;
9e853f23 440 struct pmem_device *pmem;
9e853f23 441
8c2f7e86
DW
442 ndns = nvdimm_namespace_common_probe(dev);
443 if (IS_ERR(ndns))
444 return PTR_ERR(ndns);
bf9bccc1 445
8c2f7e86 446 nsio = to_nd_namespace_io(&ndns->dev);
9f53f9fa 447 pmem = pmem_alloc(dev, &nsio->res, nd_region->id);
9e853f23
RZ
448 if (IS_ERR(pmem))
449 return PTR_ERR(pmem);
450
32ab0a3f 451 pmem->ndns = ndns;
9f53f9fa 452 dev_set_drvdata(dev, pmem);
8c2f7e86 453 ndns->rw_bytes = pmem_rw_bytes;
710d69cc
DW
454 if (devm_init_badblocks(dev, &pmem->bb))
455 return -ENOMEM;
456 nvdimm_namespace_add_poison(ndns, &pmem->bb, 0);
708ab62b 457
468ded03
DW
458 if (is_nd_btt(dev)) {
459 /* btt allocates its own request_queue */
460 blk_cleanup_queue(pmem->pmem_queue);
461 pmem->pmem_queue = NULL;
708ab62b 462 return nvdimm_namespace_attach_btt(ndns);
468ded03 463 }
708ab62b 464
32ab0a3f
DW
465 if (is_nd_pfn(dev))
466 return nvdimm_namespace_attach_pfn(ndns);
467
468ded03
DW
468 if (nd_btt_probe(ndns, pmem) == 0 || nd_pfn_probe(ndns, pmem) == 0) {
469 /*
470 * We'll come back as either btt-pmem, or pfn-pmem, so
471 * drop the queue allocation for now.
472 */
473 blk_cleanup_queue(pmem->pmem_queue);
32ab0a3f
DW
474 return -ENXIO;
475 }
476
477 return pmem_attach_disk(dev, ndns, pmem);
9e853f23
RZ
478}
479
9f53f9fa 480static int nd_pmem_remove(struct device *dev)
9e853f23 481{
9f53f9fa 482 struct pmem_device *pmem = dev_get_drvdata(dev);
9e853f23 483
8c2f7e86 484 if (is_nd_btt(dev))
32ab0a3f
DW
485 nvdimm_namespace_detach_btt(pmem->ndns);
486 else if (is_nd_pfn(dev))
487 nvdimm_namespace_detach_pfn(pmem->ndns);
8c2f7e86
DW
488 else
489 pmem_detach_disk(pmem);
8c2f7e86 490
9e853f23
RZ
491 return 0;
492}
493
71999466
DW
494static void nd_pmem_notify(struct device *dev, enum nvdimm_event event)
495{
496 struct pmem_device *pmem = dev_get_drvdata(dev);
497 struct nd_namespace_common *ndns = pmem->ndns;
498
499 if (event != NVDIMM_REVALIDATE_POISON)
500 return;
501
502 if (is_nd_btt(dev))
503 nvdimm_namespace_add_poison(ndns, &pmem->bb, 0);
504 else
505 nvdimm_namespace_add_poison(ndns, &pmem->bb, pmem->data_offset);
506}
507
9f53f9fa
DW
508MODULE_ALIAS("pmem");
509MODULE_ALIAS_ND_DEVICE(ND_DEVICE_NAMESPACE_IO);
bf9bccc1 510MODULE_ALIAS_ND_DEVICE(ND_DEVICE_NAMESPACE_PMEM);
9f53f9fa
DW
511static struct nd_device_driver nd_pmem_driver = {
512 .probe = nd_pmem_probe,
513 .remove = nd_pmem_remove,
71999466 514 .notify = nd_pmem_notify,
9f53f9fa
DW
515 .drv = {
516 .name = "nd_pmem",
9e853f23 517 },
bf9bccc1 518 .type = ND_DRIVER_NAMESPACE_IO | ND_DRIVER_NAMESPACE_PMEM,
9e853f23
RZ
519};
520
521static int __init pmem_init(void)
522{
523 int error;
524
525 pmem_major = register_blkdev(0, "pmem");
526 if (pmem_major < 0)
527 return pmem_major;
528
9f53f9fa
DW
529 error = nd_driver_register(&nd_pmem_driver);
530 if (error) {
9e853f23 531 unregister_blkdev(pmem_major, "pmem");
9f53f9fa
DW
532 return error;
533 }
534
535 return 0;
9e853f23
RZ
536}
537module_init(pmem_init);
538
539static void pmem_exit(void)
540{
9f53f9fa 541 driver_unregister(&nd_pmem_driver.drv);
9e853f23
RZ
542 unregister_blkdev(pmem_major, "pmem");
543}
544module_exit(pmem_exit);
545
546MODULE_AUTHOR("Ross Zwisler <ross.zwisler@linux.intel.com>");
547MODULE_LICENSE("GPL v2");