]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/blame - drivers/phy/phy-rockchip-usb.c
phy: rockchip-usb: fix clock get-put mismatch
[mirror_ubuntu-artful-kernel.git] / drivers / phy / phy-rockchip-usb.c
CommitLineData
64d11406
YL
1/*
2 * Rockchip usb PHY driver
3 *
4 * Copyright (C) 2014 Yunzhi Li <lyz@rock-chips.com>
5 * Copyright (C) 2014 ROCKCHIP, Inc.
6 *
7 * This program is free software; you can redistribute it and/or modify
8 * it under the terms of the GNU General Public License as published by
9 * the Free Software Foundation; either version 2 of the License.
10 *
11 * This program is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 * GNU General Public License for more details.
15 */
16
17#include <linux/clk.h>
18#include <linux/io.h>
19#include <linux/kernel.h>
20#include <linux/module.h>
21#include <linux/mutex.h>
22#include <linux/of.h>
23#include <linux/of_address.h>
24#include <linux/phy/phy.h>
25#include <linux/platform_device.h>
26#include <linux/regulator/consumer.h>
27#include <linux/reset.h>
28#include <linux/regmap.h>
29#include <linux/mfd/syscon.h>
30
31/*
32 * The higher 16-bit of this register is used for write protection
33 * only if BIT(13 + 16) set to 1 the BIT(13) can be written.
34 */
35#define SIDDQ_WRITE_ENA BIT(29)
36#define SIDDQ_ON BIT(13)
37#define SIDDQ_OFF (0 << 13)
38
39struct rockchip_usb_phy {
40 unsigned int reg_offset;
41 struct regmap *reg_base;
42 struct clk *clk;
43 struct phy *phy;
44};
45
46static int rockchip_usb_phy_power(struct rockchip_usb_phy *phy,
47 bool siddq)
48{
49 return regmap_write(phy->reg_base, phy->reg_offset,
50 SIDDQ_WRITE_ENA | (siddq ? SIDDQ_ON : SIDDQ_OFF));
51}
52
53static int rockchip_usb_phy_power_off(struct phy *_phy)
54{
55 struct rockchip_usb_phy *phy = phy_get_drvdata(_phy);
56 int ret = 0;
57
58 /* Power down usb phy analog blocks by set siddq 1 */
59 ret = rockchip_usb_phy_power(phy, 1);
60 if (ret)
61 return ret;
62
63 clk_disable_unprepare(phy->clk);
64d11406
YL
64
65 return 0;
66}
67
68static int rockchip_usb_phy_power_on(struct phy *_phy)
69{
70 struct rockchip_usb_phy *phy = phy_get_drvdata(_phy);
71 int ret = 0;
72
73 ret = clk_prepare_enable(phy->clk);
74 if (ret)
75 return ret;
76
77 /* Power up usb phy analog blocks by set siddq 0 */
78 ret = rockchip_usb_phy_power(phy, 0);
6b08e36b
AL
79 if (ret) {
80 clk_disable_unprepare(phy->clk);
64d11406 81 return ret;
6b08e36b 82 }
64d11406
YL
83
84 return 0;
85}
86
4a9e5ca1 87static const struct phy_ops ops = {
64d11406
YL
88 .power_on = rockchip_usb_phy_power_on,
89 .power_off = rockchip_usb_phy_power_off,
90 .owner = THIS_MODULE,
91};
92
75d390fe
HS
93static void rockchip_usb_phy_action(void *data)
94{
95 struct rockchip_usb_phy *rk_phy = data;
96
97 if (rk_phy->clk)
98 clk_put(rk_phy->clk);
99}
100
64d11406
YL
101static int rockchip_usb_phy_probe(struct platform_device *pdev)
102{
103 struct device *dev = &pdev->dev;
104 struct rockchip_usb_phy *rk_phy;
105 struct phy_provider *phy_provider;
106 struct device_node *child;
107 struct regmap *grf;
108 unsigned int reg_offset;
08db7e5c 109 int err;
64d11406
YL
110
111 grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,grf");
112 if (IS_ERR(grf)) {
113 dev_err(&pdev->dev, "Missing rockchip,grf property\n");
114 return PTR_ERR(grf);
115 }
116
117 for_each_available_child_of_node(dev->of_node, child) {
118 rk_phy = devm_kzalloc(dev, sizeof(*rk_phy), GFP_KERNEL);
f6f31af8
JL
119 if (!rk_phy) {
120 err = -ENOMEM;
121 goto put_child;
122 }
64d11406
YL
123
124 if (of_property_read_u32(child, "reg", &reg_offset)) {
125 dev_err(dev, "missing reg property in node %s\n",
126 child->name);
f6f31af8
JL
127 err = -EINVAL;
128 goto put_child;
64d11406
YL
129 }
130
131 rk_phy->reg_offset = reg_offset;
132 rk_phy->reg_base = grf;
133
75d390fe
HS
134 err = devm_add_action(dev, rockchip_usb_phy_action, rk_phy);
135 if (err)
136 return err;
137
64d11406
YL
138 rk_phy->clk = of_clk_get_by_name(child, "phyclk");
139 if (IS_ERR(rk_phy->clk))
140 rk_phy->clk = NULL;
141
142 rk_phy->phy = devm_phy_create(dev, child, &ops);
143 if (IS_ERR(rk_phy->phy)) {
144 dev_err(dev, "failed to create PHY\n");
f6f31af8
JL
145 err = PTR_ERR(rk_phy->phy);
146 goto put_child;
64d11406
YL
147 }
148 phy_set_drvdata(rk_phy->phy, rk_phy);
08db7e5c 149
150 /* only power up usb phy when it use, so disable it when init*/
151 err = rockchip_usb_phy_power(rk_phy, 1);
152 if (err)
f6f31af8 153 goto put_child;
64d11406
YL
154 }
155
156 phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
157 return PTR_ERR_OR_ZERO(phy_provider);
f6f31af8
JL
158put_child:
159 of_node_put(child);
160 return err;
64d11406
YL
161}
162
163static const struct of_device_id rockchip_usb_phy_dt_ids[] = {
164 { .compatible = "rockchip,rk3288-usb-phy" },
165 {}
166};
167
168MODULE_DEVICE_TABLE(of, rockchip_usb_phy_dt_ids);
169
170static struct platform_driver rockchip_usb_driver = {
171 .probe = rockchip_usb_phy_probe,
172 .driver = {
173 .name = "rockchip-usb-phy",
64d11406
YL
174 .of_match_table = rockchip_usb_phy_dt_ids,
175 },
176};
177
178module_platform_driver(rockchip_usb_driver);
179
180MODULE_AUTHOR("Yunzhi Li <lyz@rock-chips.com>");
181MODULE_DESCRIPTION("Rockchip USB 2.0 PHY driver");
182MODULE_LICENSE("GPL v2");