]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/blame - fs/overlayfs/dir.c
ovl: implement index dir copy up
[mirror_ubuntu-bionic-kernel.git] / fs / overlayfs / dir.c
CommitLineData
e9be9d5e
MS
1/*
2 *
3 * Copyright (C) 2011 Novell Inc.
4 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
8 */
9
10#include <linux/fs.h>
11#include <linux/namei.h>
12#include <linux/xattr.h>
13#include <linux/security.h>
14#include <linux/cred.h>
3ea22a71 15#include <linux/module.h>
38b25697
MS
16#include <linux/posix_acl.h>
17#include <linux/posix_acl_xattr.h>
6a45b362 18#include <linux/atomic.h>
a6c60655 19#include <linux/ratelimit.h>
e9be9d5e
MS
20#include "overlayfs.h"
21
3ea22a71
MS
22static unsigned short ovl_redirect_max = 256;
23module_param_named(redirect_max, ovl_redirect_max, ushort, 0644);
24MODULE_PARM_DESC(ovl_redirect_max,
25 "Maximum length of absolute redirect xattr value");
26
415543d5 27int ovl_cleanup(struct inode *wdir, struct dentry *wdentry)
e9be9d5e
MS
28{
29 int err;
30
31 dget(wdentry);
e36cb0b8 32 if (d_is_dir(wdentry))
e9be9d5e
MS
33 err = ovl_do_rmdir(wdir, wdentry);
34 else
35 err = ovl_do_unlink(wdir, wdentry);
36 dput(wdentry);
37
38 if (err) {
39 pr_err("overlayfs: cleanup of '%pd2' failed (%i)\n",
40 wdentry, err);
41 }
415543d5
AG
42
43 return err;
e9be9d5e
MS
44}
45
3d27573c 46struct dentry *ovl_lookup_temp(struct dentry *workdir)
e9be9d5e
MS
47{
48 struct dentry *temp;
49 char name[20];
6a45b362 50 static atomic_t temp_id = ATOMIC_INIT(0);
e9be9d5e 51
6a45b362
RW
52 /* counter is allowed to wrap, since temp dentries are ephemeral */
53 snprintf(name, sizeof(name), "#%x", atomic_inc_return(&temp_id));
e9be9d5e
MS
54
55 temp = lookup_one_len(name, workdir, strlen(name));
56 if (!IS_ERR(temp) && temp->d_inode) {
57 pr_err("overlayfs: workdir/%s already exists\n", name);
58 dput(temp);
59 temp = ERR_PTR(-EIO);
60 }
61
62 return temp;
63}
64
65/* caller holds i_mutex on workdir */
66static struct dentry *ovl_whiteout(struct dentry *workdir,
67 struct dentry *dentry)
68{
69 int err;
70 struct dentry *whiteout;
71 struct inode *wdir = workdir->d_inode;
72
3d27573c 73 whiteout = ovl_lookup_temp(workdir);
e9be9d5e
MS
74 if (IS_ERR(whiteout))
75 return whiteout;
76
77 err = ovl_do_whiteout(wdir, whiteout);
78 if (err) {
79 dput(whiteout);
80 whiteout = ERR_PTR(err);
81 }
82
83 return whiteout;
84}
85
86int ovl_create_real(struct inode *dir, struct dentry *newdentry,
32a3d848 87 struct cattr *attr, struct dentry *hardlink, bool debug)
e9be9d5e
MS
88{
89 int err;
90
91 if (newdentry->d_inode)
92 return -ESTALE;
93
94 if (hardlink) {
95 err = ovl_do_link(hardlink, dir, newdentry, debug);
96 } else {
32a3d848 97 switch (attr->mode & S_IFMT) {
e9be9d5e 98 case S_IFREG:
32a3d848 99 err = ovl_do_create(dir, newdentry, attr->mode, debug);
e9be9d5e
MS
100 break;
101
102 case S_IFDIR:
32a3d848 103 err = ovl_do_mkdir(dir, newdentry, attr->mode, debug);
e9be9d5e
MS
104 break;
105
106 case S_IFCHR:
107 case S_IFBLK:
108 case S_IFIFO:
109 case S_IFSOCK:
110 err = ovl_do_mknod(dir, newdentry,
32a3d848 111 attr->mode, attr->rdev, debug);
e9be9d5e
MS
112 break;
113
114 case S_IFLNK:
32a3d848 115 err = ovl_do_symlink(dir, newdentry, attr->link, debug);
e9be9d5e
MS
116 break;
117
118 default:
119 err = -EPERM;
120 }
121 }
122 if (!err && WARN_ON(!newdentry->d_inode)) {
123 /*
124 * Not quite sure if non-instantiated dentry is legal or not.
125 * VFS doesn't seem to care so check and warn here.
126 */
127 err = -ENOENT;
128 }
129 return err;
130}
131
21a22878
AG
132static int ovl_set_opaque_xerr(struct dentry *dentry, struct dentry *upper,
133 int xerr)
e9be9d5e 134{
5cf5b477
MS
135 int err;
136
21a22878 137 err = ovl_check_setxattr(dentry, upper, OVL_XATTR_OPAQUE, "y", 1, xerr);
5cf5b477
MS
138 if (!err)
139 ovl_dentry_set_opaque(dentry);
140
141 return err;
e9be9d5e
MS
142}
143
21a22878
AG
144static int ovl_set_opaque(struct dentry *dentry, struct dentry *upperdentry)
145{
146 /*
147 * Fail with -EIO when trying to create opaque dir and upper doesn't
148 * support xattrs. ovl_rename() calls ovl_set_opaque_xerr(-EXDEV) to
149 * return a specific error for noxattr case.
150 */
151 return ovl_set_opaque_xerr(dentry, upperdentry, -EIO);
152}
153
72e48481
VG
154/* Common operations required to be done after creation of file on upper */
155static void ovl_instantiate(struct dentry *dentry, struct inode *inode,
51f7e52d 156 struct dentry *newdentry, bool hardlink)
72e48481
VG
157{
158 ovl_dentry_version_inc(dentry->d_parent);
55acc661 159 ovl_dentry_set_upper_alias(dentry);
51f7e52d 160 if (!hardlink) {
09d8b586 161 ovl_inode_update(inode, newdentry);
51f7e52d
MS
162 ovl_copyattr(newdentry->d_inode, inode);
163 } else {
09d8b586
MS
164 WARN_ON(ovl_inode_real(inode) != d_inode(newdentry));
165 dput(newdentry);
51f7e52d
MS
166 inc_nlink(inode);
167 }
72e48481 168 d_instantiate(dentry, inode);
5b6c9053
AG
169 /* Force lookup of new upper hardlink to find its lower */
170 if (hardlink)
171 d_drop(dentry);
72e48481
VG
172}
173
97c684cc
AG
174static bool ovl_type_merge(struct dentry *dentry)
175{
176 return OVL_TYPE_MERGE(ovl_path_type(dentry));
177}
178
ee1d6d37
AG
179static bool ovl_type_origin(struct dentry *dentry)
180{
181 return OVL_TYPE_ORIGIN(ovl_path_type(dentry));
182}
183
e9be9d5e 184static int ovl_create_upper(struct dentry *dentry, struct inode *inode,
32a3d848 185 struct cattr *attr, struct dentry *hardlink)
e9be9d5e
MS
186{
187 struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
188 struct inode *udir = upperdir->d_inode;
189 struct dentry *newdentry;
190 int err;
191
38b25697 192 if (!hardlink && !IS_POSIXACL(udir))
32a3d848 193 attr->mode &= ~current_umask();
38b25697 194
5955102c 195 inode_lock_nested(udir, I_MUTEX_PARENT);
e9be9d5e
MS
196 newdentry = lookup_one_len(dentry->d_name.name, upperdir,
197 dentry->d_name.len);
198 err = PTR_ERR(newdentry);
199 if (IS_ERR(newdentry))
200 goto out_unlock;
32a3d848 201 err = ovl_create_real(udir, newdentry, attr, hardlink, false);
e9be9d5e
MS
202 if (err)
203 goto out_dput;
204
4a99f3c8 205 if (ovl_type_merge(dentry->d_parent) && d_is_dir(newdentry)) {
97c684cc
AG
206 /* Setting opaque here is just an optimization, allow to fail */
207 ovl_set_opaque(dentry, newdentry);
208 }
209
51f7e52d 210 ovl_instantiate(dentry, inode, newdentry, !!hardlink);
e9be9d5e
MS
211 newdentry = NULL;
212out_dput:
213 dput(newdentry);
214out_unlock:
5955102c 215 inode_unlock(udir);
e9be9d5e
MS
216 return err;
217}
218
219static int ovl_lock_rename_workdir(struct dentry *workdir,
220 struct dentry *upperdir)
221{
222 /* Workdir should not be the same as upperdir */
223 if (workdir == upperdir)
224 goto err;
225
226 /* Workdir should not be subdir of upperdir and vice versa */
227 if (lock_rename(workdir, upperdir) != NULL)
228 goto err_unlock;
229
230 return 0;
231
232err_unlock:
233 unlock_rename(workdir, upperdir);
234err:
235 pr_err("overlayfs: failed to lock workdir+upperdir\n");
236 return -EIO;
237}
238
239static struct dentry *ovl_clear_empty(struct dentry *dentry,
240 struct list_head *list)
241{
242 struct dentry *workdir = ovl_workdir(dentry);
243 struct inode *wdir = workdir->d_inode;
244 struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
245 struct inode *udir = upperdir->d_inode;
246 struct path upperpath;
247 struct dentry *upper;
248 struct dentry *opaquedir;
249 struct kstat stat;
250 int err;
251
cc6f67bc
MS
252 if (WARN_ON(!workdir))
253 return ERR_PTR(-EROFS);
254
e9be9d5e
MS
255 err = ovl_lock_rename_workdir(workdir, upperdir);
256 if (err)
257 goto out;
258
259 ovl_path_upper(dentry, &upperpath);
a528d35e
DH
260 err = vfs_getattr(&upperpath, &stat,
261 STATX_BASIC_STATS, AT_STATX_SYNC_AS_STAT);
e9be9d5e
MS
262 if (err)
263 goto out_unlock;
264
265 err = -ESTALE;
266 if (!S_ISDIR(stat.mode))
267 goto out_unlock;
268 upper = upperpath.dentry;
269 if (upper->d_parent->d_inode != udir)
270 goto out_unlock;
271
3d27573c 272 opaquedir = ovl_lookup_temp(workdir);
e9be9d5e
MS
273 err = PTR_ERR(opaquedir);
274 if (IS_ERR(opaquedir))
275 goto out_unlock;
276
32a3d848
AV
277 err = ovl_create_real(wdir, opaquedir,
278 &(struct cattr){.mode = stat.mode}, NULL, true);
e9be9d5e
MS
279 if (err)
280 goto out_dput;
281
282 err = ovl_copy_xattr(upper, opaquedir);
283 if (err)
284 goto out_cleanup;
285
5cf5b477 286 err = ovl_set_opaque(dentry, opaquedir);
e9be9d5e
MS
287 if (err)
288 goto out_cleanup;
289
5955102c 290 inode_lock(opaquedir->d_inode);
e9be9d5e 291 err = ovl_set_attr(opaquedir, &stat);
5955102c 292 inode_unlock(opaquedir->d_inode);
e9be9d5e
MS
293 if (err)
294 goto out_cleanup;
295
296 err = ovl_do_rename(wdir, opaquedir, udir, upper, RENAME_EXCHANGE);
297 if (err)
298 goto out_cleanup;
299
300 ovl_cleanup_whiteouts(upper, list);
301 ovl_cleanup(wdir, upper);
302 unlock_rename(workdir, upperdir);
303
304 /* dentry's upper doesn't match now, get rid of it */
305 d_drop(dentry);
306
307 return opaquedir;
308
309out_cleanup:
310 ovl_cleanup(wdir, opaquedir);
311out_dput:
312 dput(opaquedir);
313out_unlock:
314 unlock_rename(workdir, upperdir);
315out:
316 return ERR_PTR(err);
317}
318
a105d685 319static struct dentry *ovl_check_empty_and_clear(struct dentry *dentry)
e9be9d5e
MS
320{
321 int err;
322 struct dentry *ret = NULL;
30c17ebf 323 enum ovl_path_type type = ovl_path_type(dentry);
e9be9d5e
MS
324 LIST_HEAD(list);
325
326 err = ovl_check_empty_dir(dentry, &list);
30c17ebf 327 if (err) {
e9be9d5e 328 ret = ERR_PTR(err);
30c17ebf 329 goto out_free;
a105d685 330 }
e9be9d5e 331
30c17ebf
MS
332 /*
333 * When removing an empty opaque directory, then it makes no sense to
334 * replace it with an exact replica of itself.
335 *
336 * If no upperdentry then skip clearing whiteouts.
337 *
338 * Can race with copy-up, since we don't hold the upperdir mutex.
339 * Doesn't matter, since copy-up can't create a non-empty directory
340 * from an empty one.
341 */
342 if (OVL_TYPE_UPPER(type) && OVL_TYPE_MERGE(type))
343 ret = ovl_clear_empty(dentry, &list);
344
345out_free:
e9be9d5e
MS
346 ovl_cache_free(&list);
347
348 return ret;
349}
350
38b25697
MS
351static int ovl_set_upper_acl(struct dentry *upperdentry, const char *name,
352 const struct posix_acl *acl)
353{
354 void *buffer;
355 size_t size;
356 int err;
357
358 if (!IS_ENABLED(CONFIG_FS_POSIX_ACL) || !acl)
359 return 0;
360
361 size = posix_acl_to_xattr(NULL, acl, NULL, 0);
362 buffer = kmalloc(size, GFP_KERNEL);
363 if (!buffer)
364 return -ENOMEM;
365
366 size = posix_acl_to_xattr(&init_user_ns, acl, buffer, size);
367 err = size;
368 if (err < 0)
369 goto out_free;
370
371 err = vfs_setxattr(upperdentry, name, buffer, size, XATTR_CREATE);
372out_free:
373 kfree(buffer);
374 return err;
375}
376
e9be9d5e 377static int ovl_create_over_whiteout(struct dentry *dentry, struct inode *inode,
32a3d848 378 struct cattr *cattr,
e9be9d5e
MS
379 struct dentry *hardlink)
380{
381 struct dentry *workdir = ovl_workdir(dentry);
382 struct inode *wdir = workdir->d_inode;
383 struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
384 struct inode *udir = upperdir->d_inode;
385 struct dentry *upper;
386 struct dentry *newdentry;
387 int err;
38b25697 388 struct posix_acl *acl, *default_acl;
e9be9d5e 389
cc6f67bc
MS
390 if (WARN_ON(!workdir))
391 return -EROFS;
392
38b25697
MS
393 if (!hardlink) {
394 err = posix_acl_create(dentry->d_parent->d_inode,
32a3d848 395 &cattr->mode, &default_acl, &acl);
38b25697
MS
396 if (err)
397 return err;
398 }
399
e9be9d5e
MS
400 err = ovl_lock_rename_workdir(workdir, upperdir);
401 if (err)
402 goto out;
403
3d27573c 404 newdentry = ovl_lookup_temp(workdir);
e9be9d5e
MS
405 err = PTR_ERR(newdentry);
406 if (IS_ERR(newdentry))
407 goto out_unlock;
408
409 upper = lookup_one_len(dentry->d_name.name, upperdir,
410 dentry->d_name.len);
411 err = PTR_ERR(upper);
412 if (IS_ERR(upper))
413 goto out_dput;
414
32a3d848 415 err = ovl_create_real(wdir, newdentry, cattr, hardlink, true);
e9be9d5e
MS
416 if (err)
417 goto out_dput2;
418
bb0d2b8a
MS
419 /*
420 * mode could have been mutilated due to umask (e.g. sgid directory)
421 */
51f7e52d 422 if (!hardlink &&
32a3d848
AV
423 !S_ISLNK(cattr->mode) &&
424 newdentry->d_inode->i_mode != cattr->mode) {
bb0d2b8a
MS
425 struct iattr attr = {
426 .ia_valid = ATTR_MODE,
32a3d848 427 .ia_mode = cattr->mode,
bb0d2b8a
MS
428 };
429 inode_lock(newdentry->d_inode);
430 err = notify_change(newdentry, &attr, NULL);
431 inode_unlock(newdentry->d_inode);
432 if (err)
433 goto out_cleanup;
434 }
38b25697
MS
435 if (!hardlink) {
436 err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_ACCESS,
437 acl);
438 if (err)
439 goto out_cleanup;
440
441 err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_DEFAULT,
442 default_acl);
443 if (err)
444 goto out_cleanup;
445 }
bb0d2b8a 446
32a3d848 447 if (!hardlink && S_ISDIR(cattr->mode)) {
5cf5b477 448 err = ovl_set_opaque(dentry, newdentry);
e9be9d5e
MS
449 if (err)
450 goto out_cleanup;
451
452 err = ovl_do_rename(wdir, newdentry, udir, upper,
453 RENAME_EXCHANGE);
454 if (err)
455 goto out_cleanup;
456
457 ovl_cleanup(wdir, upper);
458 } else {
459 err = ovl_do_rename(wdir, newdentry, udir, upper, 0);
460 if (err)
461 goto out_cleanup;
462 }
51f7e52d 463 ovl_instantiate(dentry, inode, newdentry, !!hardlink);
e9be9d5e
MS
464 newdentry = NULL;
465out_dput2:
466 dput(upper);
467out_dput:
468 dput(newdentry);
469out_unlock:
470 unlock_rename(workdir, upperdir);
471out:
38b25697
MS
472 if (!hardlink) {
473 posix_acl_release(acl);
474 posix_acl_release(default_acl);
475 }
e9be9d5e
MS
476 return err;
477
478out_cleanup:
479 ovl_cleanup(wdir, newdentry);
480 goto out_dput2;
481}
482
51f7e52d 483static int ovl_create_or_link(struct dentry *dentry, struct inode *inode,
32a3d848 484 struct cattr *attr, struct dentry *hardlink)
e9be9d5e
MS
485{
486 int err;
1175b6b8
VG
487 const struct cred *old_cred;
488 struct cred *override_cred;
e9be9d5e
MS
489
490 err = ovl_copy_up(dentry->d_parent);
491 if (err)
51f7e52d 492 return err;
bb0d2b8a 493
1175b6b8
VG
494 old_cred = ovl_override_creds(dentry->d_sb);
495 err = -ENOMEM;
496 override_cred = prepare_creds();
497 if (override_cred) {
bb0d2b8a
MS
498 override_cred->fsuid = inode->i_uid;
499 override_cred->fsgid = inode->i_gid;
2602625b
VG
500 if (!hardlink) {
501 err = security_dentry_create_files_as(dentry,
32a3d848 502 attr->mode, &dentry->d_name, old_cred,
2602625b
VG
503 override_cred);
504 if (err) {
505 put_cred(override_cred);
506 goto out_revert_creds;
507 }
508 }
1175b6b8
VG
509 put_cred(override_creds(override_cred));
510 put_cred(override_cred);
511
c412ce49 512 if (!ovl_dentry_is_whiteout(dentry))
32a3d848 513 err = ovl_create_upper(dentry, inode, attr,
1175b6b8
VG
514 hardlink);
515 else
32a3d848
AV
516 err = ovl_create_over_whiteout(dentry, inode, attr,
517 hardlink);
e9be9d5e 518 }
2602625b 519out_revert_creds:
1175b6b8 520 revert_creds(old_cred);
bb0d2b8a
MS
521 if (!err) {
522 struct inode *realinode = d_inode(ovl_dentry_upper(dentry));
523
524 WARN_ON(inode->i_mode != realinode->i_mode);
525 WARN_ON(!uid_eq(inode->i_uid, realinode->i_uid));
526 WARN_ON(!gid_eq(inode->i_gid, realinode->i_gid));
bb0d2b8a 527 }
e9be9d5e
MS
528 return err;
529}
530
531static int ovl_create_object(struct dentry *dentry, int mode, dev_t rdev,
532 const char *link)
533{
534 int err;
51f7e52d 535 struct inode *inode;
32a3d848 536 struct cattr attr = {
51f7e52d 537 .rdev = rdev,
32a3d848 538 .link = link,
51f7e52d 539 };
e9be9d5e
MS
540
541 err = ovl_want_write(dentry);
51f7e52d
MS
542 if (err)
543 goto out;
544
545 err = -ENOMEM;
ca4c8a3a 546 inode = ovl_new_inode(dentry->d_sb, mode, rdev);
51f7e52d
MS
547 if (!inode)
548 goto out_drop_write;
549
550 inode_init_owner(inode, dentry->d_parent->d_inode, mode);
32a3d848 551 attr.mode = inode->i_mode;
51f7e52d 552
32a3d848 553 err = ovl_create_or_link(dentry, inode, &attr, NULL);
51f7e52d
MS
554 if (err)
555 iput(inode);
e9be9d5e 556
51f7e52d
MS
557out_drop_write:
558 ovl_drop_write(dentry);
559out:
e9be9d5e
MS
560 return err;
561}
562
563static int ovl_create(struct inode *dir, struct dentry *dentry, umode_t mode,
564 bool excl)
565{
566 return ovl_create_object(dentry, (mode & 07777) | S_IFREG, 0, NULL);
567}
568
569static int ovl_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
570{
571 return ovl_create_object(dentry, (mode & 07777) | S_IFDIR, 0, NULL);
572}
573
574static int ovl_mknod(struct inode *dir, struct dentry *dentry, umode_t mode,
575 dev_t rdev)
576{
577 /* Don't allow creation of "whiteout" on overlay */
578 if (S_ISCHR(mode) && rdev == WHITEOUT_DEV)
579 return -EPERM;
580
581 return ovl_create_object(dentry, mode, rdev, NULL);
582}
583
584static int ovl_symlink(struct inode *dir, struct dentry *dentry,
585 const char *link)
586{
587 return ovl_create_object(dentry, S_IFLNK, 0, link);
588}
589
590static int ovl_link(struct dentry *old, struct inode *newdir,
591 struct dentry *new)
592{
593 int err;
51f7e52d 594 struct inode *inode;
e9be9d5e
MS
595
596 err = ovl_want_write(old);
597 if (err)
598 goto out;
599
600 err = ovl_copy_up(old);
601 if (err)
602 goto out_drop_write;
603
51f7e52d
MS
604 inode = d_inode(old);
605 ihold(inode);
606
32a3d848 607 err = ovl_create_or_link(new, inode, NULL, ovl_dentry_upper(old));
51f7e52d
MS
608 if (err)
609 iput(inode);
e9be9d5e
MS
610
611out_drop_write:
612 ovl_drop_write(old);
613out:
614 return err;
615}
616
9020df37
MS
617static bool ovl_matches_upper(struct dentry *dentry, struct dentry *upper)
618{
619 return d_inode(ovl_dentry_upper(dentry)) == d_inode(upper);
620}
621
a105d685 622static int ovl_remove_and_whiteout(struct dentry *dentry, bool is_dir)
e9be9d5e
MS
623{
624 struct dentry *workdir = ovl_workdir(dentry);
625 struct inode *wdir = workdir->d_inode;
626 struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
627 struct inode *udir = upperdir->d_inode;
628 struct dentry *whiteout;
629 struct dentry *upper;
630 struct dentry *opaquedir = NULL;
631 int err;
cfc9fde0 632 int flags = 0;
e9be9d5e 633
cc6f67bc
MS
634 if (WARN_ON(!workdir))
635 return -EROFS;
636
d377c5eb 637 if (is_dir) {
30c17ebf
MS
638 opaquedir = ovl_check_empty_and_clear(dentry);
639 err = PTR_ERR(opaquedir);
640 if (IS_ERR(opaquedir))
641 goto out;
e9be9d5e
MS
642 }
643
644 err = ovl_lock_rename_workdir(workdir, upperdir);
645 if (err)
646 goto out_dput;
647
cfc9fde0
MP
648 upper = lookup_one_len(dentry->d_name.name, upperdir,
649 dentry->d_name.len);
650 err = PTR_ERR(upper);
651 if (IS_ERR(upper))
e9be9d5e
MS
652 goto out_unlock;
653
cfc9fde0
MP
654 err = -ESTALE;
655 if ((opaquedir && upper != opaquedir) ||
656 (!opaquedir && ovl_dentry_upper(dentry) &&
9020df37 657 !ovl_matches_upper(dentry, upper))) {
cfc9fde0
MP
658 goto out_dput_upper;
659 }
e9be9d5e 660
cfc9fde0
MP
661 whiteout = ovl_whiteout(workdir, dentry);
662 err = PTR_ERR(whiteout);
663 if (IS_ERR(whiteout))
664 goto out_dput_upper;
e9be9d5e 665
cfc9fde0
MP
666 if (d_is_dir(upper))
667 flags = RENAME_EXCHANGE;
e9be9d5e 668
cfc9fde0
MP
669 err = ovl_do_rename(wdir, whiteout, udir, upper, flags);
670 if (err)
671 goto kill_whiteout;
672 if (flags)
673 ovl_cleanup(wdir, upper);
e9be9d5e 674
e9be9d5e
MS
675 ovl_dentry_version_inc(dentry->d_parent);
676out_d_drop:
677 d_drop(dentry);
678 dput(whiteout);
cfc9fde0
MP
679out_dput_upper:
680 dput(upper);
e9be9d5e
MS
681out_unlock:
682 unlock_rename(workdir, upperdir);
683out_dput:
684 dput(opaquedir);
685out:
686 return err;
687
688kill_whiteout:
689 ovl_cleanup(wdir, whiteout);
690 goto out_d_drop;
691}
692
693static int ovl_remove_upper(struct dentry *dentry, bool is_dir)
694{
695 struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
696 struct inode *dir = upperdir->d_inode;
11f37104 697 struct dentry *upper;
d1595119 698 struct dentry *opaquedir = NULL;
e9be9d5e
MS
699 int err;
700
d1595119
AG
701 /* Redirect dir can be !ovl_lower_positive && OVL_TYPE_MERGE */
702 if (is_dir && ovl_dentry_get_redirect(dentry)) {
703 opaquedir = ovl_check_empty_and_clear(dentry);
704 err = PTR_ERR(opaquedir);
705 if (IS_ERR(opaquedir))
706 goto out;
707 }
708
5955102c 709 inode_lock_nested(dir, I_MUTEX_PARENT);
11f37104
MS
710 upper = lookup_one_len(dentry->d_name.name, upperdir,
711 dentry->d_name.len);
712 err = PTR_ERR(upper);
713 if (IS_ERR(upper))
714 goto out_unlock;
715
e9be9d5e 716 err = -ESTALE;
d1595119 717 if ((opaquedir && upper != opaquedir) ||
9020df37 718 (!opaquedir && !ovl_matches_upper(dentry, upper)))
d1595119
AG
719 goto out_dput_upper;
720
721 if (is_dir)
722 err = vfs_rmdir(dir, upper);
723 else
724 err = vfs_unlink(dir, upper, NULL);
725 ovl_dentry_version_inc(dentry->d_parent);
e9be9d5e
MS
726
727 /*
728 * Keeping this dentry hashed would mean having to release
729 * upperpath/lowerpath, which could only be done if we are the
730 * sole user of this dentry. Too tricky... Just unhash for
731 * now.
732 */
ce9113bb
RW
733 if (!err)
734 d_drop(dentry);
d1595119
AG
735out_dput_upper:
736 dput(upper);
11f37104 737out_unlock:
5955102c 738 inode_unlock(dir);
d1595119
AG
739 dput(opaquedir);
740out:
e9be9d5e
MS
741 return err;
742}
743
e9be9d5e
MS
744static int ovl_do_remove(struct dentry *dentry, bool is_dir)
745{
746 enum ovl_path_type type;
747 int err;
1175b6b8
VG
748 const struct cred *old_cred;
749
e9be9d5e
MS
750 err = ovl_want_write(dentry);
751 if (err)
752 goto out;
753
754 err = ovl_copy_up(dentry->d_parent);
755 if (err)
756 goto out_drop_write;
757
758 type = ovl_path_type(dentry);
e9be9d5e 759
1175b6b8 760 old_cred = ovl_override_creds(dentry->d_sb);
2aff4534 761 if (!ovl_lower_positive(dentry))
1175b6b8
VG
762 err = ovl_remove_upper(dentry, is_dir);
763 else
a105d685 764 err = ovl_remove_and_whiteout(dentry, is_dir);
1175b6b8 765 revert_creds(old_cred);
dbc816d0
MS
766 if (!err) {
767 if (is_dir)
768 clear_nlink(dentry->d_inode);
769 else
770 drop_nlink(dentry->d_inode);
771 }
e9be9d5e
MS
772out_drop_write:
773 ovl_drop_write(dentry);
774out:
775 return err;
776}
777
778static int ovl_unlink(struct inode *dir, struct dentry *dentry)
779{
780 return ovl_do_remove(dentry, false);
781}
782
783static int ovl_rmdir(struct inode *dir, struct dentry *dentry)
784{
785 return ovl_do_remove(dentry, true);
786}
787
370e55ac
MS
788static bool ovl_type_merge_or_lower(struct dentry *dentry)
789{
790 enum ovl_path_type type = ovl_path_type(dentry);
791
792 return OVL_TYPE_MERGE(type) || !OVL_TYPE_UPPER(type);
793}
794
a6c60655
MS
795static bool ovl_can_move(struct dentry *dentry)
796{
797 return ovl_redirect_dir(dentry->d_sb) ||
798 !d_is_dir(dentry) || !ovl_type_merge_or_lower(dentry);
799}
800
a6c60655
MS
801static char *ovl_get_redirect(struct dentry *dentry, bool samedir)
802{
803 char *buf, *ret;
804 struct dentry *d, *tmp;
3ea22a71 805 int buflen = ovl_redirect_max + 1;
a6c60655
MS
806
807 if (samedir) {
808 ret = kstrndup(dentry->d_name.name, dentry->d_name.len,
809 GFP_KERNEL);
810 goto out;
811 }
812
813 buf = ret = kmalloc(buflen, GFP_TEMPORARY);
814 if (!buf)
815 goto out;
816
817 buflen--;
818 buf[buflen] = '\0';
819 for (d = dget(dentry); !IS_ROOT(d);) {
820 const char *name;
821 int thislen;
822
823 spin_lock(&d->d_lock);
824 name = ovl_dentry_get_redirect(d);
825 if (name) {
826 thislen = strlen(name);
827 } else {
828 name = d->d_name.name;
829 thislen = d->d_name.len;
830 }
831
832 /* If path is too long, fall back to userspace move */
833 if (thislen + (name[0] != '/') > buflen) {
834 ret = ERR_PTR(-EXDEV);
835 spin_unlock(&d->d_lock);
836 goto out_put;
837 }
838
839 buflen -= thislen;
840 memcpy(&buf[buflen], name, thislen);
841 tmp = dget_dlock(d->d_parent);
842 spin_unlock(&d->d_lock);
843
844 dput(d);
845 d = tmp;
846
847 /* Absolute redirect: finished */
848 if (buf[buflen] == '/')
849 break;
850 buflen--;
851 buf[buflen] = '/';
852 }
853 ret = kstrdup(&buf[buflen], GFP_KERNEL);
854out_put:
855 dput(d);
856 kfree(buf);
857out:
858 return ret ? ret : ERR_PTR(-ENOMEM);
859}
860
861static int ovl_set_redirect(struct dentry *dentry, bool samedir)
862{
863 int err;
864 const char *redirect = ovl_dentry_get_redirect(dentry);
865
866 if (redirect && (samedir || redirect[0] == '/'))
867 return 0;
868
869 redirect = ovl_get_redirect(dentry, samedir);
870 if (IS_ERR(redirect))
871 return PTR_ERR(redirect);
872
21a22878
AG
873 err = ovl_check_setxattr(dentry, ovl_dentry_upper(dentry),
874 OVL_XATTR_REDIRECT,
875 redirect, strlen(redirect), -EXDEV);
a6c60655
MS
876 if (!err) {
877 spin_lock(&dentry->d_lock);
878 ovl_dentry_set_redirect(dentry, redirect);
879 spin_unlock(&dentry->d_lock);
880 } else {
881 kfree(redirect);
21a22878 882 pr_warn_ratelimited("overlay: failed to set redirect (%i)\n", err);
a6c60655
MS
883 /* Fall back to userspace copy-up */
884 err = -EXDEV;
885 }
886 return err;
887}
888
6c02cb59
MS
889static int ovl_rename(struct inode *olddir, struct dentry *old,
890 struct inode *newdir, struct dentry *new,
891 unsigned int flags)
e9be9d5e
MS
892{
893 int err;
e9be9d5e
MS
894 struct dentry *old_upperdir;
895 struct dentry *new_upperdir;
896 struct dentry *olddentry;
897 struct dentry *newdentry;
898 struct dentry *trap;
899 bool old_opaque;
900 bool new_opaque;
e9be9d5e
MS
901 bool cleanup_whiteout = false;
902 bool overwrite = !(flags & RENAME_EXCHANGE);
e36cb0b8 903 bool is_dir = d_is_dir(old);
370e55ac 904 bool new_is_dir = d_is_dir(new);
a6c60655 905 bool samedir = olddir == newdir;
e9be9d5e
MS
906 struct dentry *opaquedir = NULL;
907 const struct cred *old_cred = NULL;
e9be9d5e
MS
908
909 err = -EINVAL;
910 if (flags & ~(RENAME_EXCHANGE | RENAME_NOREPLACE))
911 goto out;
912
913 flags &= ~RENAME_NOREPLACE;
914
e9be9d5e 915 /* Don't copy up directory trees */
e9be9d5e 916 err = -EXDEV;
a6c60655 917 if (!ovl_can_move(old))
370e55ac 918 goto out;
a6c60655 919 if (!overwrite && !ovl_can_move(new))
e9be9d5e 920 goto out;
e9be9d5e
MS
921
922 err = ovl_want_write(old);
923 if (err)
924 goto out;
925
926 err = ovl_copy_up(old);
927 if (err)
928 goto out_drop_write;
929
930 err = ovl_copy_up(new->d_parent);
931 if (err)
932 goto out_drop_write;
933 if (!overwrite) {
934 err = ovl_copy_up(new);
935 if (err)
936 goto out_drop_write;
937 }
938
1175b6b8 939 old_cred = ovl_override_creds(old->d_sb);
e9be9d5e 940
370e55ac 941 if (overwrite && new_is_dir && ovl_type_merge_or_lower(new)) {
a105d685 942 opaquedir = ovl_check_empty_and_clear(new);
e9be9d5e
MS
943 err = PTR_ERR(opaquedir);
944 if (IS_ERR(opaquedir)) {
945 opaquedir = NULL;
946 goto out_revert_creds;
947 }
948 }
949
950 if (overwrite) {
2aff4534 951 if (ovl_lower_positive(old)) {
c412ce49 952 if (!ovl_dentry_is_whiteout(new)) {
e9be9d5e
MS
953 /* Whiteout source */
954 flags |= RENAME_WHITEOUT;
955 } else {
956 /* Switch whiteouts */
957 flags |= RENAME_EXCHANGE;
958 }
c412ce49 959 } else if (is_dir && ovl_dentry_is_whiteout(new)) {
e9be9d5e
MS
960 flags |= RENAME_EXCHANGE;
961 cleanup_whiteout = true;
962 }
963 }
964
965 old_upperdir = ovl_dentry_upper(old->d_parent);
966 new_upperdir = ovl_dentry_upper(new->d_parent);
967
ee1d6d37
AG
968 if (!samedir) {
969 /*
970 * When moving a merge dir or non-dir with copy up origin into
f3a15685
AG
971 * a new parent, we are marking the new parent dir "impure".
972 * When ovl_iterate() iterates an "impure" upper dir, it will
973 * lookup the origin inodes of the entries to fill d_ino.
ee1d6d37 974 */
f3a15685 975 if (ovl_type_origin(old)) {
ee1d6d37
AG
976 err = ovl_set_impure(new->d_parent, new_upperdir);
977 if (err)
978 goto out_revert_creds;
979 }
f3a15685 980 if (!overwrite && ovl_type_origin(new)) {
ee1d6d37
AG
981 err = ovl_set_impure(old->d_parent, old_upperdir);
982 if (err)
983 goto out_revert_creds;
984 }
985 }
986
e9be9d5e
MS
987 trap = lock_rename(new_upperdir, old_upperdir);
988
11f37104
MS
989 olddentry = lookup_one_len(old->d_name.name, old_upperdir,
990 old->d_name.len);
991 err = PTR_ERR(olddentry);
992 if (IS_ERR(olddentry))
993 goto out_unlock;
994
995 err = -ESTALE;
9020df37 996 if (!ovl_matches_upper(old, olddentry))
11f37104
MS
997 goto out_dput_old;
998
999 newdentry = lookup_one_len(new->d_name.name, new_upperdir,
1000 new->d_name.len);
1001 err = PTR_ERR(newdentry);
1002 if (IS_ERR(newdentry))
1003 goto out_dput_old;
1004
3ee23ff1
MS
1005 old_opaque = ovl_dentry_is_opaque(old);
1006 new_opaque = ovl_dentry_is_opaque(new);
1007
11f37104 1008 err = -ESTALE;
09d8b586 1009 if (d_inode(new) && ovl_dentry_upper(new)) {
e9be9d5e 1010 if (opaquedir) {
11f37104
MS
1011 if (newdentry != opaquedir)
1012 goto out_dput;
e9be9d5e 1013 } else {
9020df37 1014 if (!ovl_matches_upper(new, newdentry))
11f37104 1015 goto out_dput;
e9be9d5e
MS
1016 }
1017 } else {
11f37104
MS
1018 if (!d_is_negative(newdentry) &&
1019 (!new_opaque || !ovl_is_whiteout(newdentry)))
1020 goto out_dput;
e9be9d5e
MS
1021 }
1022
e9be9d5e
MS
1023 if (olddentry == trap)
1024 goto out_dput;
1025 if (newdentry == trap)
1026 goto out_dput;
1027
804032fa
MS
1028 if (WARN_ON(olddentry->d_inode == newdentry->d_inode))
1029 goto out_dput;
1030
5cf5b477 1031 err = 0;
a6c60655 1032 if (is_dir) {
5cf5b477 1033 if (ovl_type_merge_or_lower(old))
a6c60655 1034 err = ovl_set_redirect(old, samedir);
97c684cc 1035 else if (!old_opaque && ovl_type_merge(new->d_parent))
21a22878 1036 err = ovl_set_opaque_xerr(old, olddentry, -EXDEV);
5cf5b477
MS
1037 if (err)
1038 goto out_dput;
e9be9d5e 1039 }
a6c60655 1040 if (!overwrite && new_is_dir) {
5cf5b477 1041 if (ovl_type_merge_or_lower(new))
a6c60655 1042 err = ovl_set_redirect(new, samedir);
97c684cc 1043 else if (!new_opaque && ovl_type_merge(old->d_parent))
21a22878 1044 err = ovl_set_opaque_xerr(new, newdentry, -EXDEV);
5cf5b477
MS
1045 if (err)
1046 goto out_dput;
e9be9d5e
MS
1047 }
1048
3ee23ff1
MS
1049 err = ovl_do_rename(old_upperdir->d_inode, olddentry,
1050 new_upperdir->d_inode, newdentry, flags);
1051 if (err)
e9be9d5e 1052 goto out_dput;
e9be9d5e
MS
1053
1054 if (cleanup_whiteout)
1055 ovl_cleanup(old_upperdir->d_inode, newdentry);
1056
f681eb1d
AG
1057 if (overwrite && d_inode(new)) {
1058 if (new_is_dir)
1059 clear_nlink(d_inode(new));
1060 else
1061 drop_nlink(d_inode(new));
1062 }
1063
e9be9d5e
MS
1064 ovl_dentry_version_inc(old->d_parent);
1065 ovl_dentry_version_inc(new->d_parent);
1066
1067out_dput:
1068 dput(newdentry);
11f37104
MS
1069out_dput_old:
1070 dput(olddentry);
e9be9d5e
MS
1071out_unlock:
1072 unlock_rename(new_upperdir, old_upperdir);
1073out_revert_creds:
1175b6b8 1074 revert_creds(old_cred);
e9be9d5e
MS
1075out_drop_write:
1076 ovl_drop_write(old);
1077out:
1078 dput(opaquedir);
1079 return err;
1080}
1081
1082const struct inode_operations ovl_dir_inode_operations = {
1083 .lookup = ovl_lookup,
1084 .mkdir = ovl_mkdir,
1085 .symlink = ovl_symlink,
1086 .unlink = ovl_unlink,
1087 .rmdir = ovl_rmdir,
6c02cb59 1088 .rename = ovl_rename,
e9be9d5e
MS
1089 .link = ovl_link,
1090 .setattr = ovl_setattr,
1091 .create = ovl_create,
1092 .mknod = ovl_mknod,
1093 .permission = ovl_permission,
5b712091 1094 .getattr = ovl_getattr,
e9be9d5e 1095 .listxattr = ovl_listxattr,
39a25b2b 1096 .get_acl = ovl_get_acl,
d719e8f2 1097 .update_time = ovl_update_time,
e9be9d5e 1098};